[GitHub] carbondata pull request #2168: [CARBONDATA-2343][DataMap]Improper filter res...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/carbondata/pull/2168


---

[GitHub] carbondata pull request #2168: [CARBONDATA-2343][DataMap]Improper filter res...

[xuchuanyin]

GitHub user xuchuanyin opened a pull request:

https://github.com/apache/carbondata/pull/2168

[CARBONDATA-2343][DataMap]Improper filter resolver cause more filter scan 
on data that could be skipped

Currently DataMapChooser will choose and combine datamap for
expressions and it will wrap the expression in a
`TrueConditionalResolverImpl`. However the executor `TrueFilterExecutor`
will always cause scanning the blocklet which could be skipped.

Be sure to do all of the following checklist to help us incorporate 
your contribution quickly and easily:

 - [x] Any interfaces changed?
 `NO, only internal interface has been changed`
 - [x] Any backward compatibility impacted?
 `NO`
 - [x] Document update required?
`NO`
 - [x] Testing done
Please provide details on 
- Whether new unit test cases have been added or why no new tests 
are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance 
test report.
- Any additional information to help reviewers in testing this 
change.
   
 - [ ] For large changes, please consider breaking it into sub-tasks under 
an umbrella JIRA. 



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/xuchuanyin/carbondata 0413_bug_dm

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/carbondata/pull/2168.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2168


commit 2e2c0683f867a7ecda7a4e7f80b2c7030220cd4a
Author: xuchuanyin 
Date:   2018-04-13T07:14:25Z

Fix bugs in datamap chooser

Currently DataMapChooser will choose and combine datamap for
expressions and it will wrap the expression in a
`TrueConditionalResolverImpl`. However the executor `TrueFilterExecutor`
will always cause scanning the blocklet which could be skipped.




---