[GitHub] carbondata pull request #2170: [CARBONDATA-2346] Added fix for NULL error wh...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/carbondata/pull/2170


---

[GitHub] carbondata pull request #2170: [CARBONDATA-2346] Added fix for NULL error wh...

[kumarvishal09]

Github user kumarvishal09 commented on a diff in the pull request:

https://github.com/apache/carbondata/pull/2170#discussion_r181758974
  
--- Diff: 
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/preaaggregate/PreAggregateTableHelper.scala
 ---
@@ -76,7 +76,8 @@ case class PreAggregateTableHelper(
 val partitionerFields = fieldRelationMap.collect {
   case (field, dataMapField) if parentPartitionColumns
 .exists(parentCol =>
-  
parentCol.equals(dataMapField.columnTableRelationList.get.head.parentColumnName)
 &&
+  dataMapField.columnTableRelationList.getOrElse(Seq()).nonEmpty &&
--- End diff --

Please add comment 


---

[GitHub] carbondata pull request #2170: [CARBONDATA-2346] Added fix for NULL error wh...

[praveenmeenakshi56]

GitHub user praveenmeenakshi56 opened a pull request:

https://github.com/apache/carbondata/pull/2170

[CARBONDATA-2346] Added fix for NULL error while dropping partition with 
multiple Pre-Aggregate tables

Fixed null value issue for childcolumn

 - [ ] Any interfaces changed?
 NA
 - [ ] Any backward compatibility impacted?
 NA
 - [ ] Document update required?
NA
 - [ ] Testing done
Please provide details on 
- Whether new unit test cases have been added or why no new tests 
are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance 
test report.
- Any additional information to help reviewers in testing this 
change.
NA  
 - [ ] For large changes, please consider breaking it into sub-tasks under 
an umbrella JIRA. 
NA


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/praveenmeenakshi56/carbondata defect_part

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/carbondata/pull/2170.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2170


commit dd3d3d1181847a1930048144740bfa053c878dd8
Author: praveenmeenakshi56 
Date:   2018-04-13T10:31:35Z

Added fix for error while dropping partition with multiple Pre-Aggregate 
tables




---