Github user asfgit closed the pull request at:
https://github.com/apache/carbondata/pull/2433
---
Github user BJangir commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2433#discussion_r201340590
--- Diff:
integration/spark-common-test/src/test/scala/org/apache/carbondata/spark/testsuite/createTable/TestNonTransactionalCarbonTable.scala
---
@@
Github user BJangir commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2433#discussion_r201340518
--- Diff:
store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonWriterBuilder.java
---
@@ -284,6 +286,29 @@ public CarbonWriterBuilder
Github user kumarvishal09 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2433#discussion_r200999110
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/parser/CarbonSparkSqlParser.scala
---
@@ -293,6 +296,29 @@ class
Github user ajantha-bhat commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2433#discussion_r201273392
--- Diff:
integration/spark-common-test/src/test/scala/org/apache/carbondata/spark/testsuite/createTable/TestNonTransactionalCarbonTable.scala
---
Github user ajantha-bhat commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2433#discussion_r201272195
--- Diff:
store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonWriterBuilder.java
---
@@ -284,6 +286,29 @@ public CarbonWriterBuilder
Github user ajantha-bhat commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2433#discussion_r201266791
--- Diff:
integration/spark-common-test/src/test/scala/org/apache/carbondata/spark/testsuite/createTable/TestNonTransactionalCarbonTable.scala
---
Github user ajantha-bhat commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2433#discussion_r201266849
--- Diff:
integration/spark-common-test/src/test/scala/org/apache/carbondata/spark/testsuite/createTable/TestNonTransactionalCarbonTable.scala
---
Github user ajantha-bhat commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2433#discussion_r201266103
--- Diff: docs/sdk-guide.md ---
@@ -251,6 +251,23 @@ public CarbonWriterBuilder withBlockSize(int
blockSize);
public CarbonWriterBuilder
Github user kumarvishal09 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2433#discussion_r200998411
--- Diff:
core/src/main/java/org/apache/carbondata/core/metadata/schema/table/TableSchemaBuilder.java
---
@@ -108,6 +122,20 @@ public
Github user BJangir commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2433#discussion_r200820929
--- Diff:
store/sdk/src/test/java/org/apache/carbondata/sdk/file/CSVNonTransactionalCarbonWriterTest.java
---
@@ -284,4 +284,137 @@ public void
Github user BJangir commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2433#discussion_r200820921
--- Diff:
store/sdk/src/test/java/org/apache/carbondata/sdk/file/CSVNonTransactionalCarbonWriterTest.java
---
@@ -284,4 +284,137 @@ public void
Github user BJangir commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2433#discussion_r200820912
--- Diff:
store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonWriterBuilder.java
---
@@ -284,6 +286,28 @@ public CarbonWriterBuilder
Github user BJangir commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2433#discussion_r200820916
--- Diff:
store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonWriterBuilder.java
---
@@ -284,6 +286,28 @@ public CarbonWriterBuilder
Github user BJangir commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2433#discussion_r200820906
--- Diff:
core/src/main/java/org/apache/carbondata/core/metadata/schema/table/TableSchemaBuilder.java
---
@@ -108,6 +122,20 @@ public TableSchema
Github user BJangir commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2433#discussion_r200820900
--- Diff:
core/src/main/java/org/apache/carbondata/core/metadata/schema/table/TableSchemaBuilder.java
---
@@ -108,6 +122,20 @@ public TableSchema
Github user BJangir commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2433#discussion_r200820897
--- Diff:
core/src/main/java/org/apache/carbondata/core/metadata/schema/table/TableSchemaBuilder.java
---
@@ -76,6 +78,18 @@ public TableSchemaBuilder
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2433#discussion_r199382674
--- Diff:
store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonWriterBuilder.java
---
@@ -284,6 +286,28 @@ public CarbonWriterBuilder
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2433#discussion_r199384025
--- Diff:
store/sdk/src/test/java/org/apache/carbondata/sdk/file/CSVNonTransactionalCarbonWriterTest.java
---
@@ -284,4 +284,137 @@ public void
Github user ajantha-bhat commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2433#discussion_r199371244
--- Diff:
store/sdk/src/test/java/org/apache/carbondata/sdk/file/CSVNonTransactionalCarbonWriterTest.java
---
@@ -284,4 +284,137 @@ public void
Github user ajantha-bhat commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2433#discussion_r199370611
--- Diff:
core/src/main/java/org/apache/carbondata/core/metadata/schema/table/TableSchemaBuilder.java
---
@@ -76,6 +78,18 @@ public
Github user ajantha-bhat commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2433#discussion_r199370539
--- Diff:
core/src/main/java/org/apache/carbondata/core/metadata/schema/table/TableSchemaBuilder.java
---
@@ -76,6 +78,18 @@ public
Github user ajantha-bhat commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2433#discussion_r199370410
--- Diff:
core/src/main/java/org/apache/carbondata/core/metadata/schema/table/TableSchemaBuilder.java
---
@@ -108,6 +122,20 @@ public TableSchema
Github user ajantha-bhat commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2433#discussion_r199370319
--- Diff:
core/src/main/java/org/apache/carbondata/core/metadata/schema/table/TableSchemaBuilder.java
---
@@ -108,6 +122,20 @@ public TableSchema
Github user ajantha-bhat commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2433#discussion_r199370193
--- Diff:
store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonWriterBuilder.java
---
@@ -284,6 +286,28 @@ public CarbonWriterBuilder
25 matches
Mail list logo
