[GitHub] carbondata pull request #2694: [CARBONDATA-2876]AVRO datatype support throug...

2018-09-06 Thread asfgit 
Github user asfgit closed the pull request at:

https://github.com/apache/carbondata/pull/2694


---

[GitHub] carbondata pull request #2694: [CARBONDATA-2876]AVRO datatype support throug...

2018-09-05 Thread Indhumathi27 
Github user Indhumathi27 commented on a diff in the pull request:

https://github.com/apache/carbondata/pull/2694#discussion_r215500532
  
--- Diff: 
store/sdk/src/main/java/org/apache/carbondata/sdk/file/AvroCarbonWriter.java ---
@@ -445,17 +445,13 @@ private static Field prepareFields(Schema.Field 
avroField) {
 if (logicalType instanceof LogicalTypes.Date) {
--- End diff --

Added a comment


---

[GitHub] carbondata pull request #2694: [CARBONDATA-2876]AVRO datatype support throug...

2018-09-05 Thread KanakaKumar 
Github user KanakaKumar commented on a diff in the pull request:

https://github.com/apache/carbondata/pull/2694#discussion_r215499485
  
--- Diff: 
store/sdk/src/main/java/org/apache/carbondata/sdk/file/AvroCarbonWriter.java ---
@@ -445,17 +445,13 @@ private static Field prepareFields(Schema.Field 
avroField) {
 if (logicalType instanceof LogicalTypes.Date) {
--- End diff --

Int can have "Time (millisecond precision)" logical type annotation. So, 
please leave a comment here about logical type  handling in carbon. I think we 
just leave int as it is.

Same way, add remarks for time-micros also.  
It would be good if we can summarize the logical types vs carbon data types 
mapping in the converter class it will beusefull for future reference and 
reviews.


---

[GitHub] carbondata pull request #2694: [CARBONDATA-2876]AVRO datatype support throug...

2018-09-05 Thread Indhumathi27 
GitHub user Indhumathi27 opened a pull request:

https://github.com/apache/carbondata/pull/2694

[CARBONDATA-2876]AVRO datatype support through SDK

This PR supports following Avro DataTypes to carbon format through SDK. 
Avro datatypes include,

  1.  Avro Logical type TimeMillis
  2.  Avro Logical type TimeMicros

 - [ ] Any interfaces changed?
 
 - [ ] Any backward compatibility impacted?
 
 - [ ] Document update required?

 - [ ] Testing done
test cases added
 - [ ] For large changes, please consider breaking it into sub-tasks under 
an umbrella JIRA. 



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/Indhumathi27/carbondata avro_support_sdk1

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/carbondata/pull/2694.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2694


commit 2738b29b4cb3439fec40b80da0ec31776c5944a6
Author: Indhumathi27 
Date:   2018-09-03T04:47:20Z

[CARBONDATA-2876]AVRO datatype support through SDK




---