[jira] [Commented] (CARBONDATA-239) Failure of one compaction in queue should not affect the others.
[ https://issues.apache.org/jira/browse/CARBONDATA-239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15594628#comment-15594628 ] ASF GitHub Bot commented on CARBONDATA-239: --- Github user asfgit closed the pull request at: https://github.com/apache/incubator-carbondata/pull/224 > Failure of one compaction in queue should not affect the others. > > > Key: CARBONDATA-239 > URL: https://issues.apache.org/jira/browse/CARBONDATA-239 > Project: CarbonData > Issue Type: Bug >Reporter: ravikiran >Assignee: ravikiran > Fix For: 0.2.0-incubating > > > Failure of one compaction in queue should not affect the others. > If a compaction is triggered by the user on table1 , and other requests will > go to queue. and if the compaction is failed for table1 then the requests in > queue should continue and at the end the beeline will show the failure > message to the user. > if any compaction gets failed for a table which is other than the user > requested table then the error in the beeline should not appear. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CARBONDATA-239) Failure of one compaction in queue should not affect the others.
[
https://issues.apache.org/jira/browse/CARBONDATA-239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15568425#comment-15568425
]
ASF GitHub Bot commented on CARBONDATA-239:
---
Github user sujith71955 commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/224#discussion_r82983904
--- Diff:
core/src/main/java/org/apache/carbondata/scan/scanner/impl/FilterScanner.java
---
@@ -78,10 +80,11 @@ public FilterScanner(BlockExecutionInfo
blockExecutionInfo) {
* @throws QueryExecutionException
* @throws FilterUnsupportedException
*/
- @Override public AbstractScannedResult scanBlocklet(BlocksChunkHolder
blocksChunkHolder)
+ @Override public AbstractScannedResult scanBlocklet(BlocksChunkHolder
blocksChunkHolder,
+ QueryStatisticsModel
queryStatisticsModel)
throws QueryExecutionException {
try {
- fillScannedResult(blocksChunkHolder);
+ fillScannedResult(blocksChunkHolder, queryStatisticsModel);
--- End diff --
Pass the model in constructor so that no need to change in all API
> Failure of one compaction in queue should not affect the others.
>
>
> Key: CARBONDATA-239
> URL: https://issues.apache.org/jira/browse/CARBONDATA-239
> Project: CarbonData
> Issue Type: Bug
>Reporter: ravikiran
>Assignee: ravikiran
> Fix For: 0.2.0-incubating
>
>
> Failure of one compaction in queue should not affect the others.
> If a compaction is triggered by the user on table1 , and other requests will
> go to queue. and if the compaction is failed for table1 then the requests in
> queue should continue and at the end the beeline will show the failure
> message to the user.
> if any compaction gets failed for a table which is other than the user
> requested table then the error in the beeline should not appear.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CARBONDATA-239) Failure of one compaction in queue should not affect the others.
[
https://issues.apache.org/jira/browse/CARBONDATA-239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15568046#comment-15568046
]
ASF GitHub Bot commented on CARBONDATA-239:
---
Github user Zhangshunyu commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/224#discussion_r82958230
--- Diff:
core/src/main/java/org/apache/carbondata/scan/processor/AbstractDataBlockIterator.java
---
@@ -127,11 +133,15 @@ protected boolean updateScanner() {
}
}
- private AbstractScannedResult getNextScannedResult() throws
QueryExecutionException {
+ private AbstractScannedResult
getNextScannedResult(QueryStatisticsRecorder recorder,
--- End diff --
@sujith71955 OK, i will use a statistics model, thanks!
> Failure of one compaction in queue should not affect the others.
>
>
> Key: CARBONDATA-239
> URL: https://issues.apache.org/jira/browse/CARBONDATA-239
> Project: CarbonData
> Issue Type: Bug
>Reporter: ravikiran
>Assignee: ravikiran
> Fix For: 0.2.0-incubating
>
>
> Failure of one compaction in queue should not affect the others.
> If a compaction is triggered by the user on table1 , and other requests will
> go to queue. and if the compaction is failed for table1 then the requests in
> queue should continue and at the end the beeline will show the failure
> message to the user.
> if any compaction gets failed for a table which is other than the user
> requested table then the error in the beeline should not appear.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CARBONDATA-239) Failure of one compaction in queue should not affect the others.
[
https://issues.apache.org/jira/browse/CARBONDATA-239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15564600#comment-15564600
]
ASF GitHub Bot commented on CARBONDATA-239:
---
Github user sujith71955 commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/224#discussion_r82729006
--- Diff:
core/src/main/java/org/apache/carbondata/scan/processor/AbstractDataBlockIterator.java
---
@@ -127,11 +133,15 @@ protected boolean updateScanner() {
}
}
- private AbstractScannedResult getNextScannedResult() throws
QueryExecutionException {
+ private AbstractScannedResult
getNextScannedResult(QueryStatisticsRecorder recorder,
--- End diff --
Why we need to change this getNextScannedResult() method parameters. if
required please pass a statistics model, this will make sure that our method
parameters wont grow
> Failure of one compaction in queue should not affect the others.
>
>
> Key: CARBONDATA-239
> URL: https://issues.apache.org/jira/browse/CARBONDATA-239
> Project: CarbonData
> Issue Type: Bug
>Reporter: ravikiran
>Assignee: ravikiran
> Fix For: 0.2.0-incubating
>
>
> Failure of one compaction in queue should not affect the others.
> If a compaction is triggered by the user on table1 , and other requests will
> go to queue. and if the compaction is failed for table1 then the requests in
> queue should continue and at the end the beeline will show the failure
> message to the user.
> if any compaction gets failed for a table which is other than the user
> requested table then the error in the beeline should not appear.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CARBONDATA-239) Failure of one compaction in queue should not affect the others.
[ https://issues.apache.org/jira/browse/CARBONDATA-239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15499655#comment-15499655 ] ASF GitHub Bot commented on CARBONDATA-239: --- Github user asfgit closed the pull request at: https://github.com/apache/incubator-carbondata/pull/155 > Failure of one compaction in queue should not affect the others. > > > Key: CARBONDATA-239 > URL: https://issues.apache.org/jira/browse/CARBONDATA-239 > Project: CarbonData > Issue Type: Bug >Reporter: ravikiran > > Failure of one compaction in queue should not affect the others. > If a compaction is triggered by the user on table1 , and other requests will > go to queue. and if the compaction is failed for table1 then the requests in > queue should continue and at the end the beeline will show the failure > message to the user. > if any compaction gets failed for a table which is other than the user > requested table then the error in the beeline should not appear. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CARBONDATA-239) Failure of one compaction in queue should not affect the others.
[
https://issues.apache.org/jira/browse/CARBONDATA-239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15499019#comment-15499019
]
ASF GitHub Bot commented on CARBONDATA-239:
---
Github user ravikiran23 commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/155#discussion_r79283801
--- Diff:
integration/spark/src/main/scala/org/apache/carbondata/spark/rdd/CarbonDataRDDFactory.scala
---
@@ -590,16 +605,25 @@ object CarbonDataRDDFactory extends Logging {
executor, sqlContext, kettleHomePath, storeLocation
)
}
+catch {
+ case e: Exception =>
+logger.error("Exception in compaction thread for table
" + tableForCompaction
+ .carbonTable.getDatabaseName + "." +
+ tableForCompaction.carbonTableIdentifier
+ .getTableName)
+ // not handling the exception. only logging as this is
not the table triggered
+ // by user.
+}
finally {
- // delete the compaction required file
+ // delete the compaction required file in case of
failure or success also.
--- End diff --
fixed
> Failure of one compaction in queue should not affect the others.
>
>
> Key: CARBONDATA-239
> URL: https://issues.apache.org/jira/browse/CARBONDATA-239
> Project: CarbonData
> Issue Type: Bug
>Reporter: ravikiran
>
> Failure of one compaction in queue should not affect the others.
> If a compaction is triggered by the user on table1 , and other requests will
> go to queue. and if the compaction is failed for table1 then the requests in
> queue should continue and at the end the beeline will show the failure
> message to the user.
> if any compaction gets failed for a table which is other than the user
> requested table then the error in the beeline should not appear.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CARBONDATA-239) Failure of one compaction in queue should not affect the others.
[
https://issues.apache.org/jira/browse/CARBONDATA-239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15496804#comment-15496804
]
ASF GitHub Bot commented on CARBONDATA-239:
---
Github user gvramana commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/155#discussion_r79208835
--- Diff:
integration/spark/src/main/scala/org/apache/carbondata/spark/rdd/CarbonDataRDDFactory.scala
---
@@ -590,16 +605,25 @@ object CarbonDataRDDFactory extends Logging {
executor, sqlContext, kettleHomePath, storeLocation
)
}
+catch {
+ case e: Exception =>
+logger.error("Exception in compaction thread for table
" + tableForCompaction
+ .carbonTable.getDatabaseName + "." +
+ tableForCompaction.carbonTableIdentifier
+ .getTableName)
+ // not handling the exception. only logging as this is
not the table triggered
+ // by user.
+}
finally {
- // delete the compaction required file
+ // delete the compaction required file in case of
failure or success also.
--- End diff --
If compact file deletion fails, add failed table to skipped list.
> Failure of one compaction in queue should not affect the others.
>
>
> Key: CARBONDATA-239
> URL: https://issues.apache.org/jira/browse/CARBONDATA-239
> Project: CarbonData
> Issue Type: Bug
>Reporter: ravikiran
>
> Failure of one compaction in queue should not affect the others.
> If a compaction is triggered by the user on table1 , and other requests will
> go to queue. and if the compaction is failed for table1 then the requests in
> queue should continue and at the end the beeline will show the failure
> message to the user.
> if any compaction gets failed for a table which is other than the user
> requested table then the error in the beeline should not appear.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CARBONDATA-239) Failure of one compaction in queue should not affect the others.
[ https://issues.apache.org/jira/browse/CARBONDATA-239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15490770#comment-15490770 ] ASF GitHub Bot commented on CARBONDATA-239: --- GitHub user ravikiran23 opened a pull request: https://github.com/apache/incubator-carbondata/pull/155 [CARBONDATA-239] Handling the exception cases in compaction. Why raise this pr? If a compaction is triggered by the user on table1 , and other requests will go to queue. and if the compaction is failed for table1 then the requests in queue is not getting completed. How to resolve? If the compaction is failed then the requests in queue should continue the compaction. if compaction is failed for table, requested by user then need to show error message in the beeline. You can merge this pull request into a Git repository by running: $ git pull https://github.com/ravikiran23/incubator-carbondata ExceptionHandlingInCompaction Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-carbondata/pull/155.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #155 commit 03964c4c0b900d3e6e7fc5c62e507328836269a8 Author: ravikiran Date: 2016-09-14T12:39:54Z handling the exception cases in compaction. if compaction is failed for table requested by user then need to show error message in the beeline. and if any exception occurs then need to continue compaction for the queued compactions. > Failure of one compaction in queue should not affect the others. > > > Key: CARBONDATA-239 > URL: https://issues.apache.org/jira/browse/CARBONDATA-239 > Project: CarbonData > Issue Type: Bug >Reporter: ravikiran > > Failure of one compaction in queue should not affect the others. > If a compaction is triggered by the user on table1 , and other requests will > go to queue. and if the compaction is failed for table1 then the requests in > queue should continue and at the end the beeline will show the failure > message to the user. > if any compaction gets failed for a table which is other than the user > requested table then the error in the beeline should not appear. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
