[jira] [Commented] (CARBONDATA-245) Actual Exception is getting lost in case of data dictionary file generation.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CARBONDATA-245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15499701#comment-15499701
 ] 

ASF GitHub Bot commented on CARBONDATA-245:
---

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-carbondata/pull/160


> Actual Exception is getting lost in case of data dictionary file generation.
> 
>
> Key: CARBONDATA-245
> URL: https://issues.apache.org/jira/browse/CARBONDATA-245
> Project: CarbonData
>  Issue Type: Bug
>  Components: data-load
>Reporter: ravikiran
>Priority: Minor
>
> Actual Exception is getting lost in case of data dictionary file 
> generation.getting the null pointer exception as in the finally block we are 
> trying to write data to a null stream.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CARBONDATA-245) Actual Exception is getting lost in case of data dictionary file generation.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CARBONDATA-245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15499118#comment-15499118
 ] 

ASF GitHub Bot commented on CARBONDATA-245:
---

Github user ravikiran23 commented on a diff in the pull request:

https://github.com/apache/incubator-carbondata/pull/160#discussion_r79284972
  
--- Diff: 
core/src/main/java/org/apache/carbondata/core/writer/ThriftWriter.java ---
@@ -80,6 +80,17 @@ public void open() throws IOException {
   }
 
   /**
+   * This will check whether stream and binary out is open or not.
+   * @return
+   */
+  public boolean isOpen() {
+if (null != binaryOut && null != dataOutputStream) {
--- End diff --

in close  we are using util to close the stream so i think no need to set 
null explicitly.


> Actual Exception is getting lost in case of data dictionary file generation.
> 
>
> Key: CARBONDATA-245
> URL: https://issues.apache.org/jira/browse/CARBONDATA-245
> Project: CarbonData
>  Issue Type: Bug
>  Components: data-load
>Reporter: ravikiran
>Priority: Minor
>
> Actual Exception is getting lost in case of data dictionary file 
> generation.getting the null pointer exception as in the finally block we are 
> trying to write data to a null stream.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CARBONDATA-245) Actual Exception is getting lost in case of data dictionary file generation.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CARBONDATA-245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15498891#comment-15498891
 ] 

ASF GitHub Bot commented on CARBONDATA-245:
---

Github user vinodkc commented on a diff in the pull request:

https://github.com/apache/incubator-carbondata/pull/160#discussion_r79282603
  
--- Diff: 
core/src/main/java/org/apache/carbondata/core/writer/ThriftWriter.java ---
@@ -80,6 +80,17 @@ public void open() throws IOException {
   }
 
   /**
+   * This will check whether stream and binary out is open or not.
+   * @return
+   */
+  public boolean isOpen() {
+if (null != binaryOut && null != dataOutputStream) {
--- End diff --

need to set  binaryOut  and dataOutputStream to null in close() method


> Actual Exception is getting lost in case of data dictionary file generation.
> 
>
> Key: CARBONDATA-245
> URL: https://issues.apache.org/jira/browse/CARBONDATA-245
> Project: CarbonData
>  Issue Type: Bug
>  Components: data-load
>Reporter: ravikiran
>Priority: Minor
>
> Actual Exception is getting lost in case of data dictionary file 
> generation.getting the null pointer exception as in the finally block we are 
> trying to write data to a null stream.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CARBONDATA-245) Actual Exception is getting lost in case of data dictionary file generation.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CARBONDATA-245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15498890#comment-15498890
 ] 

ASF GitHub Bot commented on CARBONDATA-245:
---

Github user vinodkc commented on a diff in the pull request:

https://github.com/apache/incubator-carbondata/pull/160#discussion_r79282613
  
--- Diff: 
core/src/main/java/org/apache/carbondata/core/writer/CarbonDictionaryWriterImpl.java
 ---
@@ -199,7 +199,10 @@ public CarbonDictionaryWriterImpl(String hdfsStorePath,
*/
   @Override public void close() throws IOException {
 if (null != dictionaryThriftWriter) {
-  writeDictionaryFile();
+  // if stream is open then only need to write dictionary file.
+  if(dictionaryThriftWriter.isOpen()){
--- End diff --

Combine both if conditions 


> Actual Exception is getting lost in case of data dictionary file generation.
> 
>
> Key: CARBONDATA-245
> URL: https://issues.apache.org/jira/browse/CARBONDATA-245
> Project: CarbonData
>  Issue Type: Bug
>  Components: data-load
>Reporter: ravikiran
>Priority: Minor
>
> Actual Exception is getting lost in case of data dictionary file 
> generation.getting the null pointer exception as in the finally block we are 
> trying to write data to a null stream.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)