Re: [PR] [CELEBORN-1746] Reduce the size of aws dependencies [celeborn]

2024-11-28 Thread via GitHub


FMX closed pull request #2944: [CELEBORN-1746] Reduce the size of aws 
dependencies
URL: https://github.com/apache/celeborn/pull/2944


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] [CELEBORN-1746] Reduce the size of aws dependencies [celeborn]

2024-11-28 Thread via GitHub


FMX commented on PR #2944:
URL: https://github.com/apache/celeborn/pull/2944#issuecomment-2505615468

   This PR reduced the binary package with AWS from 481M to 194M. I'll merge it 
after the tests are done.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] [CELEBORN-1746] Reduce the size of aws dependencies [celeborn]

2024-11-27 Thread via GitHub


zhaohehuhu commented on code in PR #2944:
URL: https://github.com/apache/celeborn/pull/2944#discussion_r1860699772


##
dev/dependencies.sh:
##
@@ -32,13 +32,14 @@ SBT_ENABLED="false"
 REPLACE="false"
 CHECK="false"
 MODULE=""
+PROFILE="aws"

Review Comment:
   > In default, we won't enable aws profile.
   
   Fixed. Thanks 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] [CELEBORN-1746] Reduce the size of aws dependencies [celeborn]

2024-11-26 Thread via GitHub


FMX commented on code in PR #2944:
URL: https://github.com/apache/celeborn/pull/2944#discussion_r1860009057


##
dev/dependencies.sh:
##
@@ -32,13 +32,14 @@ SBT_ENABLED="false"
 REPLACE="false"
 CHECK="false"
 MODULE=""
+PROFILE="aws"

Review Comment:
   In default, we won't enable aws profile.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] [CELEBORN-1746] Reduce the size of aws dependencies [celeborn]

2024-11-25 Thread via GitHub


FMX commented on PR #2944:
URL: https://github.com/apache/celeborn/pull/2944#issuecomment-2499519874

   Look like there are dependency check failures, plz fix them.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org