[jira] [Commented] (CLOUDSTACK-10293) Single view network ACL rules listing
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16373594#comment-16373594 ] ASF subversion and git services commented on CLOUDSTACK-10293: -- Commit e9da30b24e8d4df4b22451488e459361435da80c in cloudstack's branch refs/heads/master from [~rafaelweingartner] [ https://gitbox.apache.org/repos/asf?p=cloudstack.git;h=e9da30b ] Merge pull request #2456 from rafaelweingartner/CLOUDSTACK-10293 [CLOUDSTACK-10293] Single view network ACL rules listing > Single view network ACL rules listing > - > > Key: CLOUDSTACK-10293 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10293 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Rafael Weingärtner >Assignee: Rafael Weingärtner >Priority: Major > Fix For: 4.12 > > > The ACL rules editing/addition page is not user-friendly. Users are not able > to see in a single view all of the detail of the ACL rule (they need to use a > scroll bar on the horizontal). The problem becomes worse when there are a > considerable number of rules. Therefore, we are proposing the following > changes: > # Instead of using the table to create new ACL, we can create a button like > the one presented in attached pictures, where users can click, and then a > modal popup would appear and users would be able to create the new ACL there. > This is similar to the workings of the ACL edit button. > # Remove the ability to add new ACL via table where they are presented. All > ACLs should be entered via the “New ACL” button. Therefore, the section “Add > ACL” would be removed as well; > # Move the action section of the list ACL table to the most left position; > > These changes would reduce the information in the table and facilitate users > to add new rules and easily edit them as well. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10293) Single view network ACL rules listing
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16373593#comment-16373593 ] ASF subversion and git services commented on CLOUDSTACK-10293: -- Commit e9da30b24e8d4df4b22451488e459361435da80c in cloudstack's branch refs/heads/master from [~rafaelweingartner] [ https://gitbox.apache.org/repos/asf?p=cloudstack.git;h=e9da30b ] Merge pull request #2456 from rafaelweingartner/CLOUDSTACK-10293 [CLOUDSTACK-10293] Single view network ACL rules listing > Single view network ACL rules listing > - > > Key: CLOUDSTACK-10293 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10293 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Rafael Weingärtner >Assignee: Rafael Weingärtner >Priority: Major > Fix For: 4.12 > > > The ACL rules editing/addition page is not user-friendly. Users are not able > to see in a single view all of the detail of the ACL rule (they need to use a > scroll bar on the horizontal). The problem becomes worse when there are a > considerable number of rules. Therefore, we are proposing the following > changes: > # Instead of using the table to create new ACL, we can create a button like > the one presented in attached pictures, where users can click, and then a > modal popup would appear and users would be able to create the new ACL there. > This is similar to the workings of the ACL edit button. > # Remove the ability to add new ACL via table where they are presented. All > ACLs should be entered via the “New ACL” button. Therefore, the section “Add > ACL” would be removed as well; > # Move the action section of the list ACL table to the most left position; > > These changes would reduce the information in the table and facilitate users > to add new rules and easily edit them as well. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10293) Single view network ACL rules listing
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16373592#comment-16373592 ] ASF subversion and git services commented on CLOUDSTACK-10293: -- Commit 689715504c84dce65e3f9d5f834cd01e5284bad6 in cloudstack's branch refs/heads/master from [~rafaelweingartner] [ https://gitbox.apache.org/repos/asf?p=cloudstack.git;h=6897155 ] [CLOUDSTACK-10293] Single view network ACL rules listing The ACL rules editing/addition page is not user-friendly. Users are not able to see in a single view all of the detail of the ACL rule (they need to use a scroll bar on the horizontal). The problem becomes worse when there are a considerable number of rules. Therefore, we are proposing the following changes: 1- Instead of using the table to create new ACL, we can create a button like the one presented in attached pictures, where users can click, and then a modal popup would appear and users would be able to create the new ACL there. This is similar to the workings of the ACL edit button. 2 - Remove the ability to add new ACL via table where they are presented. All ACLs should be entered via the “New ACL” button. Therefore, the section “Add ACL” would be removed as well; 3 - Move the action section of the list ACL table to the most left position; These changes would reduce the information in the table and facilitate users to add new rules and easily edit them as well. > Single view network ACL rules listing > - > > Key: CLOUDSTACK-10293 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10293 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Rafael Weingärtner >Assignee: Rafael Weingärtner >Priority: Major > Fix For: 4.12 > > > The ACL rules editing/addition page is not user-friendly. Users are not able > to see in a single view all of the detail of the ACL rule (they need to use a > scroll bar on the horizontal). The problem becomes worse when there are a > considerable number of rules. Therefore, we are proposing the following > changes: > # Instead of using the table to create new ACL, we can create a button like > the one presented in attached pictures, where users can click, and then a > modal popup would appear and users would be able to create the new ACL there. > This is similar to the workings of the ACL edit button. > # Remove the ability to add new ACL via table where they are presented. All > ACLs should be entered via the “New ACL” button. Therefore, the section “Add > ACL” would be removed as well; > # Move the action section of the list ACL table to the most left position; > > These changes would reduce the information in the table and facilitate users > to add new rules and easily edit them as well. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10293) Single view network ACL rules listing
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16373591#comment-16373591 ] ASF GitHub Bot commented on CLOUDSTACK-10293: - rafaelweingartner commented on issue #2456: [CLOUDSTACK-10293] Single view network ACL rules listing URL: https://github.com/apache/cloudstack/pull/2456#issuecomment-367846443 Two LGTMs, and as it is only a change in JavaScript there is no need for the integration tests. I will merge this one then. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Single view network ACL rules listing > - > > Key: CLOUDSTACK-10293 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10293 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Rafael Weingärtner >Assignee: Rafael Weingärtner >Priority: Major > Fix For: 4.12 > > > The ACL rules editing/addition page is not user-friendly. Users are not able > to see in a single view all of the detail of the ACL rule (they need to use a > scroll bar on the horizontal). The problem becomes worse when there are a > considerable number of rules. Therefore, we are proposing the following > changes: > # Instead of using the table to create new ACL, we can create a button like > the one presented in attached pictures, where users can click, and then a > modal popup would appear and users would be able to create the new ACL there. > This is similar to the workings of the ACL edit button. > # Remove the ability to add new ACL via table where they are presented. All > ACLs should be entered via the “New ACL” button. Therefore, the section “Add > ACL” would be removed as well; > # Move the action section of the list ACL table to the most left position; > > These changes would reduce the information in the table and facilitate users > to add new rules and easily edit them as well. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10293) Single view network ACL rules listing
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16373566#comment-16373566 ] ASF GitHub Bot commented on CLOUDSTACK-10293: - GabrielBrascher commented on issue #2456: [CLOUDSTACK-10293] Single view network ACL rules listing URL: https://github.com/apache/cloudstack/pull/2456#issuecomment-367841826 Thanks, @rafaelweingartner! Code and Screenshots LGTM. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Single view network ACL rules listing > - > > Key: CLOUDSTACK-10293 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10293 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Rafael Weingärtner >Assignee: Rafael Weingärtner >Priority: Major > Fix For: 4.12 > > > The ACL rules editing/addition page is not user-friendly. Users are not able > to see in a single view all of the detail of the ACL rule (they need to use a > scroll bar on the horizontal). The problem becomes worse when there are a > considerable number of rules. Therefore, we are proposing the following > changes: > # Instead of using the table to create new ACL, we can create a button like > the one presented in attached pictures, where users can click, and then a > modal popup would appear and users would be able to create the new ACL there. > This is similar to the workings of the ACL edit button. > # Remove the ability to add new ACL via table where they are presented. All > ACLs should be entered via the “New ACL” button. Therefore, the section “Add > ACL” would be removed as well; > # Move the action section of the list ACL table to the most left position; > > These changes would reduce the information in the table and facilitate users > to add new rules and easily edit them as well. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10293) Single view network ACL rules listing
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16369074#comment-16369074 ] ASF GitHub Bot commented on CLOUDSTACK-10293: - nvazquez commented on issue #2456: [CLOUDSTACK-10293] Single view network ACL rules listing URL: https://github.com/apache/cloudstack/pull/2456#issuecomment-366678807 Thanks @rafaelweingartner! Now code LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Single view network ACL rules listing > - > > Key: CLOUDSTACK-10293 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10293 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Rafael Weingärtner >Assignee: Rafael Weingärtner >Priority: Major > Fix For: 4.12 > > > The ACL rules editing/addition page is not user-friendly. Users are not able > to see in a single view all of the detail of the ACL rule (they need to use a > scroll bar on the horizontal). The problem becomes worse when there are a > considerable number of rules. Therefore, we are proposing the following > changes: > # Instead of using the table to create new ACL, we can create a button like > the one presented in attached pictures, where users can click, and then a > modal popup would appear and users would be able to create the new ACL there. > This is similar to the workings of the ACL edit button. > # Remove the ability to add new ACL via table where they are presented. All > ACLs should be entered via the “New ACL” button. Therefore, the section “Add > ACL” would be removed as well; > # Move the action section of the list ACL table to the most left position; > > These changes would reduce the information in the table and facilitate users > to add new rules and easily edit them as well. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10293) Single view network ACL rules listing
[
https://issues.apache.org/jira/browse/CLOUDSTACK-10293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16369069#comment-16369069
]
ASF GitHub Bot commented on CLOUDSTACK-10293:
-
nvazquez commented on a change in pull request #2456: [CLOUDSTACK-10293] Single
view network ACL rules listing
URL: https://github.com/apache/cloudstack/pull/2456#discussion_r169060895
##
File path: ui/scripts/vpc.js
##
@@ -1333,35 +1321,65 @@
$.ajax({
url:
createURL('listNetworkACLs&aclid=' + args.context.aclLists[0].id),
success: function(json) {
-var items =
json.listnetworkaclsresponse.networkacl.sort(function(a, b) {
-return a.number >=
b.number;
-}).map(function(acl) {
-if
(parseInt(acl.protocol)) { // protocol number
-acl.protocolnumber
= acl.protocol;
-acl.protocol =
"protocolnumber";
-}
-
-return acl;
-});
+var items =
json.listnetworkaclsresponse.networkacl;
+
+if(items){
+items.sort(function(a,
b) {
+return a.number >=
b.number;
+}).map(function(acl) {
+if
(parseInt(acl.protocol)) { // protocol number
+
acl.protocolnumber = acl.protocol;
+acl.protocol =
"protocolnumber";
+}
+
+return acl;
+});
+}
args.response.success({
data: items
-/* {
- cidrlist: '10.1.1.0/24',
- protocol: 'TCP',
- startport: 22, endport: 22,
- networkid: 0,
- traffictype: 'Egress'
- },
- {
- cidrlist: '10.2.1.0/24',
- protocol: 'UDP',
- startport: 56, endport: 72,
- networkid: 0,
- trafficType: 'Ingress'
- }
- ]*/
});
+
if(jQuery('#details-tab-aclRules').siblings('div.toolbar').children('div.add').size()
=== 0){
+var
$addAclRuleDivButton = jQuery('').addClass('button add');
+var
$spanAddAclRuleButtonMessage = jQuery('').html(_l('label.add.ACL'));
+
+
$addAclRuleDivButton.html($spanAddAclRuleButtonMessage);
+
$addAclRuleDivButton.click(function(){
+
cloudStack.dialog.createForm({
+form: {
+ title:
'label.add.rule',
+ desc:
'Create a new ACL rule',
+ fields:
aclRuleFields
+ },
+ after:
function(argsLocal) {
+var
data = argsLocal.data;
+
data.aclid
[jira] [Commented] (CLOUDSTACK-10293) Single view network ACL rules listing
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16368997#comment-16368997 ] ASF GitHub Bot commented on CLOUDSTACK-10293: - rafaelweingartner commented on issue #2456: [CLOUDSTACK-10293] Single view network ACL rules listing URL: https://github.com/apache/cloudstack/pull/2456#issuecomment-366658774 Thanks for your review @nvazquez ! I have made the changes you suggested. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Single view network ACL rules listing > - > > Key: CLOUDSTACK-10293 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10293 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Rafael Weingärtner >Assignee: Rafael Weingärtner >Priority: Major > Fix For: 4.12 > > > The ACL rules editing/addition page is not user-friendly. Users are not able > to see in a single view all of the detail of the ACL rule (they need to use a > scroll bar on the horizontal). The problem becomes worse when there are a > considerable number of rules. Therefore, we are proposing the following > changes: > # Instead of using the table to create new ACL, we can create a button like > the one presented in attached pictures, where users can click, and then a > modal popup would appear and users would be able to create the new ACL there. > This is similar to the workings of the ACL edit button. > # Remove the ability to add new ACL via table where they are presented. All > ACLs should be entered via the “New ACL” button. Therefore, the section “Add > ACL” would be removed as well; > # Move the action section of the list ACL table to the most left position; > > These changes would reduce the information in the table and facilitate users > to add new rules and easily edit them as well. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10293) Single view network ACL rules listing
[
https://issues.apache.org/jira/browse/CLOUDSTACK-10293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16368993#comment-16368993
]
ASF GitHub Bot commented on CLOUDSTACK-10293:
-
rafaelweingartner commented on a change in pull request #2456:
[CLOUDSTACK-10293] Single view network ACL rules listing
URL: https://github.com/apache/cloudstack/pull/2456#discussion_r169045024
##
File path: ui/scripts/vpc.js
##
@@ -436,6 +401,38 @@
isOptional: true,
isEditable: true
},
+'icmptype': {
+edit: true,
+label: 'ICMP.type',
+desc: 'Please specify -1 if you want to allow all ICMP types',
Review comment:
Done
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Single view network ACL rules listing
> -
>
> Key: CLOUDSTACK-10293
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10293
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
>Reporter: Rafael Weingärtner
>Assignee: Rafael Weingärtner
>Priority: Major
> Fix For: 4.12
>
>
> The ACL rules editing/addition page is not user-friendly. Users are not able
> to see in a single view all of the detail of the ACL rule (they need to use a
> scroll bar on the horizontal). The problem becomes worse when there are a
> considerable number of rules. Therefore, we are proposing the following
> changes:
> # Instead of using the table to create new ACL, we can create a button like
> the one presented in attached pictures, where users can click, and then a
> modal popup would appear and users would be able to create the new ACL there.
> This is similar to the workings of the ACL edit button.
> # Remove the ability to add new ACL via table where they are presented. All
> ACLs should be entered via the “New ACL” button. Therefore, the section “Add
> ACL” would be removed as well;
> # Move the action section of the list ACL table to the most left position;
>
> These changes would reduce the information in the table and facilitate users
> to add new rules and easily edit them as well.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10293) Single view network ACL rules listing
[
https://issues.apache.org/jira/browse/CLOUDSTACK-10293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16368990#comment-16368990
]
ASF GitHub Bot commented on CLOUDSTACK-10293:
-
rafaelweingartner commented on a change in pull request #2456:
[CLOUDSTACK-10293] Single view network ACL rules listing
URL: https://github.com/apache/cloudstack/pull/2456#discussion_r169043241
##
File path: ui/scripts/vpc.js
##
@@ -1333,35 +1321,65 @@
$.ajax({
url:
createURL('listNetworkACLs&aclid=' + args.context.aclLists[0].id),
success: function(json) {
-var items =
json.listnetworkaclsresponse.networkacl.sort(function(a, b) {
-return a.number >=
b.number;
-}).map(function(acl) {
-if
(parseInt(acl.protocol)) { // protocol number
-acl.protocolnumber
= acl.protocol;
-acl.protocol =
"protocolnumber";
-}
-
-return acl;
-});
+var items =
json.listnetworkaclsresponse.networkacl;
+
+if(items){
+items.sort(function(a,
b) {
+return a.number >=
b.number;
+}).map(function(acl) {
+if
(parseInt(acl.protocol)) { // protocol number
+
acl.protocolnumber = acl.protocol;
+acl.protocol =
"protocolnumber";
+}
+
+return acl;
+});
+}
args.response.success({
data: items
-/* {
- cidrlist: '10.1.1.0/24',
- protocol: 'TCP',
- startport: 22, endport: 22,
- networkid: 0,
- traffictype: 'Egress'
- },
- {
- cidrlist: '10.2.1.0/24',
- protocol: 'UDP',
- startport: 56, endport: 72,
- networkid: 0,
- trafficType: 'Ingress'
- }
- ]*/
});
+
if(jQuery('#details-tab-aclRules').siblings('div.toolbar').children('div.add').size()
=== 0){
+var
$addAclRuleDivButton = jQuery('').addClass('button add');
+var
$spanAddAclRuleButtonMessage = jQuery('').html(_l('label.add.ACL'));
+
+
$addAclRuleDivButton.html($spanAddAclRuleButtonMessage);
+
$addAclRuleDivButton.click(function(){
+
cloudStack.dialog.createForm({
+form: {
+ title:
'label.add.rule',
+ desc:
'Create a new ACL rule',
Review comment:
Sure, I was maintaining everything as before, but why not improve this one
as well.
I will do that in a sec.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@i
[jira] [Commented] (CLOUDSTACK-10293) Single view network ACL rules listing
[
https://issues.apache.org/jira/browse/CLOUDSTACK-10293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16368988#comment-16368988
]
ASF GitHub Bot commented on CLOUDSTACK-10293:
-
rafaelweingartner commented on a change in pull request #2456:
[CLOUDSTACK-10293] Single view network ACL rules listing
URL: https://github.com/apache/cloudstack/pull/2456#discussion_r169043024
##
File path: ui/scripts/vpc.js
##
@@ -1333,35 +1321,65 @@
$.ajax({
url:
createURL('listNetworkACLs&aclid=' + args.context.aclLists[0].id),
success: function(json) {
-var items =
json.listnetworkaclsresponse.networkacl.sort(function(a, b) {
-return a.number >=
b.number;
-}).map(function(acl) {
-if
(parseInt(acl.protocol)) { // protocol number
-acl.protocolnumber
= acl.protocol;
-acl.protocol =
"protocolnumber";
-}
-
-return acl;
-});
+var items =
json.listnetworkaclsresponse.networkacl;
+
+if(items){
+items.sort(function(a,
b) {
+return a.number >=
b.number;
+}).map(function(acl) {
+if
(parseInt(acl.protocol)) { // protocol number
+
acl.protocolnumber = acl.protocol;
+acl.protocol =
"protocolnumber";
+}
+
+return acl;
+});
+}
args.response.success({
data: items
-/* {
- cidrlist: '10.1.1.0/24',
- protocol: 'TCP',
- startport: 22, endport: 22,
- networkid: 0,
- traffictype: 'Egress'
- },
- {
- cidrlist: '10.2.1.0/24',
- protocol: 'UDP',
- startport: 56, endport: 72,
- networkid: 0,
- trafficType: 'Ingress'
- }
- ]*/
});
+
if(jQuery('#details-tab-aclRules').siblings('div.toolbar').children('div.add').size()
=== 0){
+var
$addAclRuleDivButton = jQuery('').addClass('button add');
+var
$spanAddAclRuleButtonMessage = jQuery('').html(_l('label.add.ACL'));
+
+
$addAclRuleDivButton.html($spanAddAclRuleButtonMessage);
+
$addAclRuleDivButton.click(function(){
+
cloudStack.dialog.createForm({
+form: {
+ title:
'label.add.rule',
+ desc:
'Create a new ACL rule',
+ fields:
aclRuleFields
+ },
+ after:
function(argsLocal) {
+var
data = argsLocal.data;
+
da
[jira] [Commented] (CLOUDSTACK-10293) Single view network ACL rules listing
[
https://issues.apache.org/jira/browse/CLOUDSTACK-10293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16368775#comment-16368775
]
ASF GitHub Bot commented on CLOUDSTACK-10293:
-
nvazquez commented on a change in pull request #2456: [CLOUDSTACK-10293] Single
view network ACL rules listing
URL: https://github.com/apache/cloudstack/pull/2456#discussion_r168984710
##
File path: ui/scripts/vpc.js
##
@@ -1333,35 +1321,65 @@
$.ajax({
url:
createURL('listNetworkACLs&aclid=' + args.context.aclLists[0].id),
success: function(json) {
-var items =
json.listnetworkaclsresponse.networkacl.sort(function(a, b) {
-return a.number >=
b.number;
-}).map(function(acl) {
-if
(parseInt(acl.protocol)) { // protocol number
-acl.protocolnumber
= acl.protocol;
-acl.protocol =
"protocolnumber";
-}
-
-return acl;
-});
+var items =
json.listnetworkaclsresponse.networkacl;
+
+if(items){
+items.sort(function(a,
b) {
+return a.number >=
b.number;
+}).map(function(acl) {
+if
(parseInt(acl.protocol)) { // protocol number
+
acl.protocolnumber = acl.protocol;
+acl.protocol =
"protocolnumber";
+}
+
+return acl;
+});
+}
args.response.success({
data: items
-/* {
- cidrlist: '10.1.1.0/24',
- protocol: 'TCP',
- startport: 22, endport: 22,
- networkid: 0,
- traffictype: 'Egress'
- },
- {
- cidrlist: '10.2.1.0/24',
- protocol: 'UDP',
- startport: 56, endport: 72,
- networkid: 0,
- trafficType: 'Ingress'
- }
- ]*/
});
+
if(jQuery('#details-tab-aclRules').siblings('div.toolbar').children('div.add').size()
=== 0){
+var
$addAclRuleDivButton = jQuery('').addClass('button add');
+var
$spanAddAclRuleButtonMessage = jQuery('').html(_l('label.add.ACL'));
+
+
$addAclRuleDivButton.html($spanAddAclRuleButtonMessage);
+
$addAclRuleDivButton.click(function(){
+
cloudStack.dialog.createForm({
+form: {
+ title:
'label.add.rule',
+ desc:
'Create a new ACL rule',
+ fields:
aclRuleFields
+ },
+ after:
function(argsLocal) {
+var
data = argsLocal.data;
+
data.aclid
[jira] [Commented] (CLOUDSTACK-10293) Single view network ACL rules listing
[
https://issues.apache.org/jira/browse/CLOUDSTACK-10293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16368767#comment-16368767
]
ASF GitHub Bot commented on CLOUDSTACK-10293:
-
nvazquez commented on a change in pull request #2456: [CLOUDSTACK-10293] Single
view network ACL rules listing
URL: https://github.com/apache/cloudstack/pull/2456#discussion_r168983742
##
File path: ui/scripts/vpc.js
##
@@ -1333,35 +1321,65 @@
$.ajax({
url:
createURL('listNetworkACLs&aclid=' + args.context.aclLists[0].id),
success: function(json) {
-var items =
json.listnetworkaclsresponse.networkacl.sort(function(a, b) {
-return a.number >=
b.number;
-}).map(function(acl) {
-if
(parseInt(acl.protocol)) { // protocol number
-acl.protocolnumber
= acl.protocol;
-acl.protocol =
"protocolnumber";
-}
-
-return acl;
-});
+var items =
json.listnetworkaclsresponse.networkacl;
+
+if(items){
+items.sort(function(a,
b) {
+return a.number >=
b.number;
+}).map(function(acl) {
+if
(parseInt(acl.protocol)) { // protocol number
+
acl.protocolnumber = acl.protocol;
+acl.protocol =
"protocolnumber";
+}
+
+return acl;
+});
+}
args.response.success({
data: items
-/* {
- cidrlist: '10.1.1.0/24',
- protocol: 'TCP',
- startport: 22, endport: 22,
- networkid: 0,
- traffictype: 'Egress'
- },
- {
- cidrlist: '10.2.1.0/24',
- protocol: 'UDP',
- startport: 56, endport: 72,
- networkid: 0,
- trafficType: 'Ingress'
- }
- ]*/
});
+
if(jQuery('#details-tab-aclRules').siblings('div.toolbar').children('div.add').size()
=== 0){
+var
$addAclRuleDivButton = jQuery('').addClass('button add');
+var
$spanAddAclRuleButtonMessage = jQuery('').html(_l('label.add.ACL'));
+
+
$addAclRuleDivButton.html($spanAddAclRuleButtonMessage);
+
$addAclRuleDivButton.click(function(){
+
cloudStack.dialog.createForm({
+form: {
+ title:
'label.add.rule',
+ desc:
'Create a new ACL rule',
Review comment:
How about using internationalization here as well?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Single view network ACL rules listing
> ---
[jira] [Commented] (CLOUDSTACK-10293) Single view network ACL rules listing
[
https://issues.apache.org/jira/browse/CLOUDSTACK-10293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16368763#comment-16368763
]
ASF GitHub Bot commented on CLOUDSTACK-10293:
-
nvazquez commented on a change in pull request #2456: [CLOUDSTACK-10293] Single
view network ACL rules listing
URL: https://github.com/apache/cloudstack/pull/2456#discussion_r168983543
##
File path: ui/scripts/vpc.js
##
@@ -436,6 +401,38 @@
isOptional: true,
isEditable: true
},
+'icmptype': {
+edit: true,
+label: 'ICMP.type',
+desc: 'Please specify -1 if you want to allow all ICMP types',
Review comment:
How about adding internationalization to desc field? (the same for icmpcode
below)
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Single view network ACL rules listing
> -
>
> Key: CLOUDSTACK-10293
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10293
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
>Reporter: Rafael Weingärtner
>Assignee: Rafael Weingärtner
>Priority: Major
> Fix For: 4.12
>
>
> The ACL rules editing/addition page is not user-friendly. Users are not able
> to see in a single view all of the detail of the ACL rule (they need to use a
> scroll bar on the horizontal). The problem becomes worse when there are a
> considerable number of rules. Therefore, we are proposing the following
> changes:
> # Instead of using the table to create new ACL, we can create a button like
> the one presented in attached pictures, where users can click, and then a
> modal popup would appear and users would be able to create the new ACL there.
> This is similar to the workings of the ACL edit button.
> # Remove the ability to add new ACL via table where they are presented. All
> ACLs should be entered via the “New ACL” button. Therefore, the section “Add
> ACL” would be removed as well;
> # Move the action section of the list ACL table to the most left position;
>
> These changes would reduce the information in the table and facilitate users
> to add new rules and easily edit them as well.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10293) Single view network ACL rules listing
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16368739#comment-16368739 ] ASF GitHub Bot commented on CLOUDSTACK-10293: - rafaelweingartner commented on issue #2456: [CLOUDSTACK-10293] Single view network ACL rules listing URL: https://github.com/apache/cloudstack/pull/2456#issuecomment-366570188 How do we proceed with this one? Will reviewers feedback be enough? No code was changed in the server side. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Single view network ACL rules listing > - > > Key: CLOUDSTACK-10293 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10293 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Rafael Weingärtner >Assignee: Rafael Weingärtner >Priority: Major > Fix For: 4.12 > > > The ACL rules editing/addition page is not user-friendly. Users are not able > to see in a single view all of the detail of the ACL rule (they need to use a > scroll bar on the horizontal). The problem becomes worse when there are a > considerable number of rules. Therefore, we are proposing the following > changes: > # Instead of using the table to create new ACL, we can create a button like > the one presented in attached pictures, where users can click, and then a > modal popup would appear and users would be able to create the new ACL there. > This is similar to the workings of the ACL edit button. > # Remove the ability to add new ACL via table where they are presented. All > ACLs should be entered via the “New ACL” button. Therefore, the section “Add > ACL” would be removed as well; > # Move the action section of the list ACL table to the most left position; > > These changes would reduce the information in the table and facilitate users > to add new rules and easily edit them as well. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10293) Single view network ACL rules listing
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16366079#comment-16366079 ] ASF GitHub Bot commented on CLOUDSTACK-10293: - rafaelweingartner commented on issue #2456: [CLOUDSTACK-10293] Single view network ACL rules listing URL: https://github.com/apache/cloudstack/pull/2456#issuecomment-365949680 Yes, it is a screen shot. I just put it there to show people how the page will look like.. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Single view network ACL rules listing > - > > Key: CLOUDSTACK-10293 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10293 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Rafael Weingärtner >Assignee: Rafael Weingärtner >Priority: Major > Fix For: 4.12 > > > The ACL rules editing/addition page is not user-friendly. Users are not able > to see in a single view all of the detail of the ACL rule (they need to use a > scroll bar on the horizontal). The problem becomes worse when there are a > considerable number of rules. Therefore, we are proposing the following > changes: > # Instead of using the table to create new ACL, we can create a button like > the one presented in attached pictures, where users can click, and then a > modal popup would appear and users would be able to create the new ACL there. > This is similar to the workings of the ACL edit button. > # Remove the ability to add new ACL via table where they are presented. All > ACLs should be entered via the “New ACL” button. Therefore, the section “Add > ACL” would be removed as well; > # Move the action section of the list ACL table to the most left position; > > These changes would reduce the information in the table and facilitate users > to add new rules and easily edit them as well. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10293) Single view network ACL rules listing
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16366074#comment-16366074 ] ASF GitHub Bot commented on CLOUDSTACK-10293: - rafaelweingartner commented on issue #2456: [CLOUDSTACK-10293] Single view network ACL rules listing URL: https://github.com/apache/cloudstack/pull/2456#issuecomment-365949680 Yes, it is a screen shot. I just put it there to show people how the page will become. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Single view network ACL rules listing > - > > Key: CLOUDSTACK-10293 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10293 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Rafael Weingärtner >Assignee: Rafael Weingärtner >Priority: Major > Fix For: 4.12 > > > The ACL rules editing/addition page is not user-friendly. Users are not able > to see in a single view all of the detail of the ACL rule (they need to use a > scroll bar on the horizontal). The problem becomes worse when there are a > considerable number of rules. Therefore, we are proposing the following > changes: > # Instead of using the table to create new ACL, we can create a button like > the one presented in attached pictures, where users can click, and then a > modal popup would appear and users would be able to create the new ACL there. > This is similar to the workings of the ACL edit button. > # Remove the ability to add new ACL via table where they are presented. All > ACLs should be entered via the “New ACL” button. Therefore, the section “Add > ACL” would be removed as well; > # Move the action section of the list ACL table to the most left position; > > These changes would reduce the information in the table and facilitate users > to add new rules and easily edit them as well. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10293) Single view network ACL rules listing
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16365668#comment-16365668 ] ASF GitHub Bot commented on CLOUDSTACK-10293: - rafaelweingartner commented on issue #2456: [CLOUDSTACK-10293] Single view network ACL rules listing URL: https://github.com/apache/cloudstack/pull/2456#issuecomment-365949680 Yes, it is a screen shot. I just put there it to show people how the page will become. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Single view network ACL rules listing > - > > Key: CLOUDSTACK-10293 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10293 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Rafael Weingärtner >Assignee: Rafael Weingärtner >Priority: Major > Fix For: 4.12 > > > The ACL rules editing/addition page is not user-friendly. Users are not able > to see in a single view all of the detail of the ACL rule (they need to use a > scroll bar on the horizontal). The problem becomes worse when there are a > considerable number of rules. Therefore, we are proposing the following > changes: > # Instead of using the table to create new ACL, we can create a button like > the one presented in attached pictures, where users can click, and then a > modal popup would appear and users would be able to create the new ACL there. > This is similar to the workings of the ACL edit button. > # Remove the ability to add new ACL via table where they are presented. All > ACLs should be entered via the “New ACL” button. Therefore, the section “Add > ACL” would be removed as well; > # Move the action section of the list ACL table to the most left position; > > These changes would reduce the information in the table and facilitate users > to add new rules and easily edit them as well. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10293) Single view network ACL rules listing
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16365665#comment-16365665 ] ASF GitHub Bot commented on CLOUDSTACK-10293: - rafaelweingartner commented on issue #2456: [CLOUDSTACK-10293] Single view network ACL rules listing URL: https://github.com/apache/cloudstack/pull/2456#issuecomment-365949680 Yes, it is a screen shot. I just put it to show people how the page will become. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Single view network ACL rules listing > - > > Key: CLOUDSTACK-10293 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10293 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Rafael Weingärtner >Assignee: Rafael Weingärtner >Priority: Major > Fix For: 4.12 > > > The ACL rules editing/addition page is not user-friendly. Users are not able > to see in a single view all of the detail of the ACL rule (they need to use a > scroll bar on the horizontal). The problem becomes worse when there are a > considerable number of rules. Therefore, we are proposing the following > changes: > # Instead of using the table to create new ACL, we can create a button like > the one presented in attached pictures, where users can click, and then a > modal popup would appear and users would be able to create the new ACL there. > This is similar to the workings of the ACL edit button. > # Remove the ability to add new ACL via table where they are presented. All > ACLs should be entered via the “New ACL” button. Therefore, the section “Add > ACL” would be removed as well; > # Move the action section of the list ACL table to the most left position; > > These changes would reduce the information in the table and facilitate users > to add new rules and easily edit them as well. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10293) Single view network ACL rules listing
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16365519#comment-16365519 ] ASF GitHub Bot commented on CLOUDSTACK-10293: - rhtyd commented on issue #2456: [CLOUDSTACK-10293] Single view network ACL rules listing URL: https://github.com/apache/cloudstack/pull/2456#issuecomment-365927051 Screenshots? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Single view network ACL rules listing > - > > Key: CLOUDSTACK-10293 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10293 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Rafael Weingärtner >Assignee: Rafael Weingärtner >Priority: Major > Fix For: 4.12 > > > The ACL rules editing/addition page is not user-friendly. Users are not able > to see in a single view all of the detail of the ACL rule (they need to use a > scroll bar on the horizontal). The problem becomes worse when there are a > considerable number of rules. Therefore, we are proposing the following > changes: > # Instead of using the table to create new ACL, we can create a button like > the one presented in attached pictures, where users can click, and then a > modal popup would appear and users would be able to create the new ACL there. > This is similar to the workings of the ACL edit button. > # Remove the ability to add new ACL via table where they are presented. All > ACLs should be entered via the “New ACL” button. Therefore, the section “Add > ACL” would be removed as well; > # Move the action section of the list ACL table to the most left position; > > These changes would reduce the information in the table and facilitate users > to add new rules and easily edit them as well. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10293) Single view network ACL rules listing
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16365418#comment-16365418 ] ASF GitHub Bot commented on CLOUDSTACK-10293: - rafaelweingartner opened a new pull request #2456: [CLOUDSTACK-10293] Single view network ACL rules listing URL: https://github.com/apache/cloudstack/pull/2456 The ACL rules editing/addition page is not user-friendly. Users are not able to see in a single view all of the detail of the ACL rule (they need to use a scroll bar on the horizontal). The problem becomes worse when there are a considerable number of rules. Therefore, we are proposing the following changes: 1- Instead of using the table to create new ACL, we can create a button like the one presented in attached pictures, where users can click, and then a modal popup would appear and users would be able to create the new ACL there. This is similar to the workings of the ACL edit button. 2 - Remove the ability to add new ACL via table where they are presented. All ACLs should be entered via the “New ACL” button. Therefore, the section “Add ACL” would be removed as well; 3 - Move the action section of the list ACL table to the most left position; These changes would reduce the information in the table and facilitate users to add new rules and easily edit them as well. The previous described changes will create a page similar to the following:  This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Single view network ACL rules listing > - > > Key: CLOUDSTACK-10293 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10293 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Rafael Weingärtner >Assignee: Rafael Weingärtner >Priority: Major > Fix For: 4.12 > > > The ACL rules editing/addition page is not user-friendly. Users are not able > to see in a single view all of the detail of the ACL rule (they need to use a > scroll bar on the horizontal). The problem becomes worse when there are a > considerable number of rules. Therefore, we are proposing the following > changes: > # Instead of using the table to create new ACL, we can create a button like > the one presented in attached pictures, where users can click, and then a > modal popup would appear and users would be able to create the new ACL there. > This is similar to the workings of the ACL edit button. > # Remove the ability to add new ACL via table where they are presented. All > ACLs should be entered via the “New ACL” button. Therefore, the section “Add > ACL” would be removed as well; > # Move the action section of the list ACL table to the most left position; > > These changes would reduce the information in the table and facilitate users > to add new rules and easily edit them as well. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
