[jira] [Commented] (CLOUDSTACK-8849) Usage job should stop usage generation in case of any exception

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15964201#comment-15964201
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8849:


Github user yvsubhash commented on the issue:

https://github.com/apache/cloudstack/pull/827
  
Closing this PR


> Usage job should stop usage generation in case of any exception
> ---
>
> Key: CLOUDSTACK-8849
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8849
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Usage
>Affects Versions: 4.5.2
>Reporter: subhash yedugundla
>
> usage server should stop completely after getting an exception. When it 
> continues it can result in wrong usage data



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (CLOUDSTACK-8849) Usage job should stop usage generation in case of any exception

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15964202#comment-15964202
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8849:


Github user yvsubhash closed the pull request at:

https://github.com/apache/cloudstack/pull/827


> Usage job should stop usage generation in case of any exception
> ---
>
> Key: CLOUDSTACK-8849
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8849
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Usage
>Affects Versions: 4.5.2
>Reporter: subhash yedugundla
>
> usage server should stop completely after getting an exception. When it 
> continues it can result in wrong usage data



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (CLOUDSTACK-8849) Usage job should stop usage generation in case of any exception

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15901313#comment-15901313
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8849:


Github user ustcweizhou commented on the issue:

https://github.com/apache/cloudstack/pull/827
  
@yvsubhash Sorry I still disagree with it.



> Usage job should stop usage generation in case of any exception
> ---
>
> Key: CLOUDSTACK-8849
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8849
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Usage
>Affects Versions: 4.5.2
>Reporter: subhash yedugundla
>
> usage server should stop completely after getting an exception. When it 
> continues it can result in wrong usage data



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (CLOUDSTACK-8849) Usage job should stop usage generation in case of any exception

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15901118#comment-15901118
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8849:


Github user yvsubhash commented on the issue:

https://github.com/apache/cloudstack/pull/827
  
@ustcweizhou Do you still have some queries on it?


> Usage job should stop usage generation in case of any exception
> ---
>
> Key: CLOUDSTACK-8849
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8849
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Usage
>Affects Versions: 4.5.2
>Reporter: subhash yedugundla
>
> usage server should stop completely after getting an exception. When it 
> continues it can result in wrong usage data



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (CLOUDSTACK-8849) Usage job should stop usage generation in case of any exception

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15734245#comment-15734245
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8849:


Github user yvsubhash commented on the issue:

https://github.com/apache/cloudstack/pull/827
  
@ustcweizhou By stopping the usage server, we can fix the records and 
continue in the next run. If we simply skip we wont come to know abt the 
records with errors. 


> Usage job should stop usage generation in case of any exception
> ---
>
> Key: CLOUDSTACK-8849
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8849
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Usage
>Affects Versions: 4.5.2
>Reporter: subhash yedugundla
>
> usage server should stop completely after getting an exception. When it 
> continues it can result in wrong usage data



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-8849) Usage job should stop usage generation in case of any exception

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15695050#comment-15695050
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8849:


Github user ustcweizhou commented on the issue:

https://github.com/apache/cloudstack/pull/827
  
@yvsubhash yes, we will miss some records if we skip the exception, but we 
will miss all others records if we stop the usage server. For me, it is 
important that usage server will still be running in case of exception.


> Usage job should stop usage generation in case of any exception
> ---
>
> Key: CLOUDSTACK-8849
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8849
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Usage
>Affects Versions: 4.5.2
>Reporter: subhash yedugundla
>
> usage server should stop completely after getting an exception. When it 
> continues it can result in wrong usage data



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-8849) Usage job should stop usage generation in case of any exception

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15694860#comment-15694860
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8849:


Github user yvsubhash commented on the issue:

https://github.com/apache/cloudstack/pull/827
  
@ustcweizhou  In case we continue with usage generation, we may miss out 
some of the records which actually resulted in exception and would in turn lead 
to wrong usage numbers. stopping after the exception can help in running the 
usage server once the errors are fixed can result in proper usage generation. 
May I know the reason for you to think usage generation should not be stopped


> Usage job should stop usage generation in case of any exception
> ---
>
> Key: CLOUDSTACK-8849
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8849
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Usage
>Affects Versions: 4.5.2
>Reporter: subhash yedugundla
>
> usage server should stop completely after getting an exception. When it 
> continues it can result in wrong usage data



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-8849) Usage job should stop usage generation in case of any exception

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15666734#comment-15666734
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8849:


Github user ustcweizhou commented on the issue:

https://github.com/apache/cloudstack/pull/827
  
@yvsubhash  Sorry, I disagree with you. The usage server should not stop 
even an exception is raised.


> Usage job should stop usage generation in case of any exception
> ---
>
> Key: CLOUDSTACK-8849
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8849
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Usage
>Affects Versions: 4.5.2
>Reporter: subhash yedugundla
>
> usage server should stop completely after getting an exception. When it 
> continues it can result in wrong usage data



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-8849) Usage job should stop usage generation in case of any exception

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1571#comment-1571
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8849:


Github user yvsubhash commented on the issue:

https://github.com/apache/cloudstack/pull/827
  
@rodrigo93 
Exception in this part of code should stop further usage generation. 
Catching it here is suppressing the exception. The fix is tested manually by 
simulating the scenario
@rhtyd 
it is rebased to 4.8


> Usage job should stop usage generation in case of any exception
> ---
>
> Key: CLOUDSTACK-8849
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8849
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Usage
>Affects Versions: 4.5.2
>Reporter: subhash yedugundla
>
> usage server should stop completely after getting an exception. When it 
> continues it can result in wrong usage data



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-8849) Usage job should stop usage generation in case of any exception

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15324438#comment-15324438
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8849:


Github user bvbharatk commented on the issue:

https://github.com/apache/cloudstack/pull/827
  
### ACS CI BVT Run
 **Sumarry:**
 Build Number 176
 Hypervisor xenserver
 NetworkType Advanced
 Passed=73
 Failed=0
 Skipped=3

_Link to logs Folder (search by build_no):_ 
https://www.dropbox.com/sh/yj3wnzbceo9uef2/AAB6u-Iap-xztdm6jHX9SjPja?dl=0


**Failed tests:**

**Skipped tests:**
test_vm_nic_adapter_vmxnet3
test_static_role_account_acls
test_deploy_vgpu_enabled_vm

**Passed test suits:**
test_deploy_vm_with_userdata.py
test_affinity_groups_projects.py
test_portable_publicip.py
test_vpc_vpn.py
test_over_provisioning.py
test_global_settings.py
test_scale_vm.py
test_service_offerings.py
test_routers_iptables_default_policy.py
test_routers.py
test_reset_vm_on_reboot.py
test_snapshots.py
test_deploy_vms_with_varied_deploymentplanners.py
test_login.py
test_list_ids_parameter.py
test_public_ip_range.py
test_multipleips_per_nic.py
test_regions.py
test_affinity_groups.py
test_network_acl.py
test_pvlan.py
test_volumes.py
test_nic.py
test_deploy_vm_root_resize.py
test_resource_detail.py
test_secondary_storage.py
test_vm_life_cycle.py
test_disk_offerings.py


> Usage job should stop usage generation in case of any exception
> ---
>
> Key: CLOUDSTACK-8849
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8849
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Usage
>Affects Versions: 4.5.2
>Reporter: subhash yedugundla
>
> usage server should stop completely after getting an exception. When it 
> continues it can result in wrong usage data



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-8849) Usage job should stop usage generation in case of any exception

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15314767#comment-15314767
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8849:


Github user bvbharatk commented on the issue:

https://github.com/apache/cloudstack/pull/827
  
### ACS CI BVT Run
 **Sumarry:**
 Build Number 123
 Hypervisor xenserver
 NetworkType Advanced
 Passed=73
 Failed=0
 Skipped=3

_Link to logs Folder (search by build_no):_ 
https://www.dropbox.com/sh/yj3wnzbceo9uef2/AAB6u-Iap-xztdm6jHX9SjPja?dl=0


**Failed tests:**

**Skipped tests:**
test_vm_nic_adapter_vmxnet3
test_static_role_account_acls
test_deploy_vgpu_enabled_vm

**Passed test suits:**
test_deploy_vm_with_userdata.py
test_affinity_groups_projects.py
test_portable_publicip.py
test_vpc_vpn.py
test_over_provisioning.py
test_global_settings.py
test_scale_vm.py
test_service_offerings.py
test_routers_iptables_default_policy.py
test_routers.py
test_reset_vm_on_reboot.py
test_snapshots.py
test_deploy_vms_with_varied_deploymentplanners.py
test_login.py
test_list_ids_parameter.py
test_public_ip_range.py
test_multipleips_per_nic.py
test_regions.py
test_affinity_groups.py
test_network_acl.py
test_pvlan.py
test_volumes.py
test_nic.py
test_deploy_vm_root_resize.py
test_resource_detail.py
test_secondary_storage.py
test_vm_life_cycle.py
test_disk_offerings.py


> Usage job should stop usage generation in case of any exception
> ---
>
> Key: CLOUDSTACK-8849
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8849
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Usage
>Affects Versions: 4.5.2
>Reporter: subhash yedugundla
>
> usage server should stop completely after getting an exception. When it 
> continues it can result in wrong usage data



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-8849) Usage job should stop usage generation in case of any exception

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15266338#comment-15266338
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8849:


Github user rhtyd commented on the pull request:

https://github.com/apache/cloudstack/pull/827#issuecomment-216189896
  
@yvsubhash please rebase against latest master and push -f, update on 
status of your PR

We'll need more information on why we should ignore/stop usage generation, 
in case we don't handle exception this will not generate usage for other kinds 
of resources


> Usage job should stop usage generation in case of any exception
> ---
>
> Key: CLOUDSTACK-8849
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8849
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Usage
>Affects Versions: 4.5.2
>Reporter: subhash yedugundla
>
> usage server should stop completely after getting an exception. When it 
> continues it can result in wrong usage data



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-8849) Usage job should stop usage generation in case of any exception

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15103967#comment-15103967
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8849:


Github user rodrigo93 commented on the pull request:

https://github.com/apache/cloudstack/pull/827#issuecomment-172394161
  
Hi @yvsubhash, could you make a Jira?
Sorry to ask you, but, why did you remove the tries and catches? It should 
throw exceptions if that part of the code can be executed, should it not? How 
did you test it?


> Usage job should stop usage generation in case of any exception
> ---
>
> Key: CLOUDSTACK-8849
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8849
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Usage
>Affects Versions: 4.5.2
>Reporter: subhash yedugundla
>
> usage server should stop completely after getting an exception. When it 
> continues it can result in wrong usage data



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-8849) Usage job should stop usage generation in case of any exception

[subhash yedugundla (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14745169#comment-14745169
 ] 

subhash yedugundla commented on CLOUDSTACK-8849:


Fixed in the following pull request
https://github.com/apache/cloudstack/pull/827

> Usage job should stop usage generation in case of any exception
> ---
>
> Key: CLOUDSTACK-8849
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8849
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Usage
>Affects Versions: 4.5.2
>Reporter: subhash yedugundla
>
> usage server should stop completely after getting an exception. When it 
> continues it can result in wrong usage data



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-8849) Usage job should stop usage generation in case of any exception

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14745165#comment-14745165
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8849:


GitHub user yvsubhash opened a pull request:

https://github.com/apache/cloudstack/pull/827

BUG-ID: CLOUDSTACK-8849: Usage job should stop usage generation in ca…

…se of any exception

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/yvsubhash/cloudstack CLOUDSTACK-8849

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/827.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #827


commit 2818bd4f82eb1e9517fa13935cef6159fdd22cf9
Author: Sudhansu 
Date:   2015-08-25T11:43:56Z

BUG-ID: CLOUDSTACK-8849: Usage job should stop usage generation in case of 
any exception




> Usage job should stop usage generation in case of any exception
> ---
>
> Key: CLOUDSTACK-8849
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8849
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Usage
>Affects Versions: 4.5.2
>Reporter: subhash yedugundla
>
> usage server should stop completely after getting an exception. When it 
> continues it can result in wrong usage data



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)