[jira] [Commented] (CLOUDSTACK-9535) [API] listVMSnapshots improvement

2016-10-13 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15572349#comment-15572349
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9535:


Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1702
  
Trillian test result (tid-141)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 26960 seconds
Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr1702-t141-kvm-centos7.zip
Test completed. 40 look ok, 8 have error(s)


Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_02_VPC_default_routes | `Failure` | 125.66 | test_vpc_router_nics.py
test_02_redundant_VPC_default_routes | `Failure` | 222.13 | 
test_vpc_redundant.py
test_router_dhcphosts | `Failure` | 85.83 | test_router_dhcphosts.py
test_04_rvpc_privategw_static_routes | `Failure` | 323.59 | 
test_privategw_acl.py
test_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 218.02 | 
test_privategw_acl.py
test_02_vpc_privategw_static_routes | `Failure` | 132.39 | 
test_privategw_acl.py
test_isolate_network_password_server | `Failure` | 55.85 | 
test_password_server.py
test_oobm_zchange_password | `Failure` | 20.33 | test_outofbandmanagement.py
ContextSuite context=TestVpcSite2SiteVpn>:setup | `Error` | 0.00 | 
test_vpc_vpn.py
ContextSuite context=TestVpcRemoteAccessVpn>:setup | `Error` | 0.00 | 
test_vpc_vpn.py
ContextSuite context=TestRVPCSite2SiteVpn>:setup | `Error` | 0.00 | 
test_vpc_vpn.py
ContextSuite context=TestRouterDHCPHosts>:teardown | `Error` | 136.12 | 
test_router_dhcphosts.py
test_extendPhysicalNetworkVlan | `Error` | 0.03 | test_non_contigiousvlan.py
test_network_rules_acquired_public_ip_3_Load_Balancer_Rule | `Error` | 
733.79 | test_network.py
test_network_rules_acquired_public_ip_2_nat_rule | `Error` | 736.44 | 
test_network.py
test_network_rules_acquired_public_ip_1_static_nat_rule | `Error` | 735.33 
| test_network.py
test_01_VPC_nics_after_destroy | Success | 516.60 | test_vpc_router_nics.py
test_05_rvpc_multi_tiers | Success | 423.15 | test_vpc_redundant.py
test_04_rvpc_network_garbage_collector_nics | Success | 1528.48 | 
test_vpc_redundant.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | 
Success | 474.12 | test_vpc_redundant.py
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | Success | 1025.30 | 
test_vpc_redundant.py
test_09_delete_detached_volume | Success | 15.31 | test_volumes.py
test_08_resize_volume | Success | 15.27 | test_volumes.py
test_07_resize_fail | Success | 20.31 | test_volumes.py
test_06_download_detached_volume | Success | 15.21 | test_volumes.py
test_05_detach_volume | Success | 100.23 | test_volumes.py
test_04_delete_attached_volume | Success | 10.14 | test_volumes.py
test_03_download_attached_volume | Success | 15.20 | test_volumes.py
test_02_attach_volume | Success | 73.71 | test_volumes.py
test_01_create_volume | Success | 718.07 | test_volumes.py
test_deploy_vm_multiple | Success | 242.33 | test_vm_life_cycle.py
test_deploy_vm | Success | 0.02 | test_vm_life_cycle.py
test_advZoneVirtualRouter | Success | 0.01 | test_vm_life_cycle.py
test_10_attachAndDetach_iso | Success | 71.56 | test_vm_life_cycle.py
test_09_expunge_vm | Success | 125.17 | test_vm_life_cycle.py
test_08_migrate_vm | Success | 40.59 | test_vm_life_cycle.py
test_07_restore_vm | Success | 0.09 | test_vm_life_cycle.py
test_06_destroy_vm | Success | 125.56 | test_vm_life_cycle.py
test_03_reboot_vm | Success | 125.60 | test_vm_life_cycle.py
test_02_start_vm | Success | 10.11 | test_vm_life_cycle.py
test_01_stop_vm | Success | 40.23 | test_vm_life_cycle.py
test_CreateTemplateWithDuplicateName | Success | 70.93 | test_templates.py
test_08_list_system_templates | Success | 0.02 | test_templates.py
test_07_list_public_templates | Success | 0.03 | test_templates.py
test_05_template_permissions | Success | 0.03 | test_templates.py
test_04_extract_template | Success | 5.14 | test_templates.py
test_03_delete_template | Success | 5.07 | test_templates.py
test_02_edit_template | Success | 90.15 | test_templates.py
test_01_create_template | Success | 25.22 | test_templates.py
test_10_destroy_cpvm | Success | 131.48 | test_ssvm.py
test_09_destroy_ssvm | Success | 164.47 | test_ssvm.py
test_08_reboot_cpvm | Success | 131.52 | test_ssvm.py
test_07_reboot_ssvm | Success | 133.55 | test_ssvm.py
test_06_stop_cpvm | Success | 136.67 | test_ssvm.py
test_05_stop_ssvm | Success | 133.61 | test_ssvm.py
test_04_cpvm_internals | Success | 1.20 | test_ssvm.py
test_03_ssvm_internals | Success | 3.72 | test_ssvm.py
test_02_list_cpvm

[jira] [Commented] (CLOUDSTACK-9535) [API] listVMSnapshots improvement

2016-10-13 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15571284#comment-15571284
 ] 

ASF subversion and git services commented on CLOUDSTACK-9535:
-

Commit 1b5342b24e6f9cd6cb15af6f7ff44d563d28516d in cloudstack's branch 
refs/heads/master from [~rajanik]
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=1b5342b ]

Merge release branch 4.9 to master

* 4.9:
  CLOUDSTACK-9535: [API] listVMSnapshots improvement


> [API] listVMSnapshots improvement
> -
>
> Key: CLOUDSTACK-9535
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9535
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
>
> * Include missing fields in response: {{account}}, {{domain}}, {{domainid}}, 
> {{zoneid}}
> * Display total count of snapshots, not depending on page size



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9535) [API] listVMSnapshots improvement

2016-10-13 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15571282#comment-15571282
 ] 

ASF subversion and git services commented on CLOUDSTACK-9535:
-

Commit 2ebf9492858f70588dccf26042ff053d94d2fc6d in cloudstack's branch 
refs/heads/master from [~rajanik]
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=2ebf949 ]

Merge pull request #1702 from nvazquez/listvmsnapshotsissues

CLOUDSTACK-9535: [API] listVMSnapshots improvement### Improvements
- Include missing fields in response: `account`, `domain`, `domainid`, `zoneid`
- Display total count of snapshots, not depending on page size

### Example
After creating 2 vm snapshots for a given vm, and making this API call: 
`command=listVMSnapshot&listAll=true&virtualmachineid=c8531ef8-8502-4b42-b1c5-c52ace0e7801&_=1475516598524&pagesize=1&page=1`
 we get this response:

```

2

88f7416a-8799-4245-99c6-c707cfbe6f47
i-2-10482-VM_VS_20161003174340
Ready
2
testsnap2
0d074f25-ed31-482f-8bc5-44c9314fc417
c8531ef8-8502-4b42-b1c5-c52ace0e7801
24e44fe5-5f2e-4d35-a8f8-109b644a04e0
testsnap
true
Disk
2016-10-03T10:43:40-0700
admin
5a7ffa07-3fca-11e5-9c45-005056ad45b7
ROOT


```

**NOTES:** As in `listVirtualMachines`, despite `pagesize=1`, `count` field 
shows total snapshots count for given vm. Also, `account`, `domain`, 
`domainid`, `zoneid` fields are listed

* pr/1702:
  CLOUDSTACK-9535: [API] listVMSnapshots improvement

Signed-off-by: Rajani Karuturi 


> [API] listVMSnapshots improvement
> -
>
> Key: CLOUDSTACK-9535
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9535
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
>
> * Include missing fields in response: {{account}}, {{domain}}, {{domainid}}, 
> {{zoneid}}
> * Display total count of snapshots, not depending on page size



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9535) [API] listVMSnapshots improvement

2016-10-13 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15571283#comment-15571283
 ] 

ASF subversion and git services commented on CLOUDSTACK-9535:
-

Commit 2ebf9492858f70588dccf26042ff053d94d2fc6d in cloudstack's branch 
refs/heads/master from [~rajanik]
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=2ebf949 ]

Merge pull request #1702 from nvazquez/listvmsnapshotsissues

CLOUDSTACK-9535: [API] listVMSnapshots improvement### Improvements
- Include missing fields in response: `account`, `domain`, `domainid`, `zoneid`
- Display total count of snapshots, not depending on page size

### Example
After creating 2 vm snapshots for a given vm, and making this API call: 
`command=listVMSnapshot&listAll=true&virtualmachineid=c8531ef8-8502-4b42-b1c5-c52ace0e7801&_=1475516598524&pagesize=1&page=1`
 we get this response:

```

2

88f7416a-8799-4245-99c6-c707cfbe6f47
i-2-10482-VM_VS_20161003174340
Ready
2
testsnap2
0d074f25-ed31-482f-8bc5-44c9314fc417
c8531ef8-8502-4b42-b1c5-c52ace0e7801
24e44fe5-5f2e-4d35-a8f8-109b644a04e0
testsnap
true
Disk
2016-10-03T10:43:40-0700
admin
5a7ffa07-3fca-11e5-9c45-005056ad45b7
ROOT


```

**NOTES:** As in `listVirtualMachines`, despite `pagesize=1`, `count` field 
shows total snapshots count for given vm. Also, `account`, `domain`, 
`domainid`, `zoneid` fields are listed

* pr/1702:
  CLOUDSTACK-9535: [API] listVMSnapshots improvement

Signed-off-by: Rajani Karuturi 


> [API] listVMSnapshots improvement
> -
>
> Key: CLOUDSTACK-9535
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9535
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
>
> * Include missing fields in response: {{account}}, {{domain}}, {{domainid}}, 
> {{zoneid}}
> * Display total count of snapshots, not depending on page size



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9535) [API] listVMSnapshots improvement

2016-10-13 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15571281#comment-15571281
 ] 

ASF subversion and git services commented on CLOUDSTACK-9535:
-

Commit f4a42ab0d7aa559e007e263b54e67d4ce9a0e2ad in cloudstack's branch 
refs/heads/master from [~nvazquez]
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=f4a42ab ]

CLOUDSTACK-9535: [API] listVMSnapshots improvement


> [API] listVMSnapshots improvement
> -
>
> Key: CLOUDSTACK-9535
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9535
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
>
> * Include missing fields in response: {{account}}, {{domain}}, {{domainid}}, 
> {{zoneid}}
> * Display total count of snapshots, not depending on page size



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9535) [API] listVMSnapshots improvement

2016-10-13 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15571278#comment-15571278
 ] 

ASF subversion and git services commented on CLOUDSTACK-9535:
-

Commit 2ebf9492858f70588dccf26042ff053d94d2fc6d in cloudstack's branch 
refs/heads/4.9 from [~rajanik]
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=2ebf949 ]

Merge pull request #1702 from nvazquez/listvmsnapshotsissues

CLOUDSTACK-9535: [API] listVMSnapshots improvement### Improvements
- Include missing fields in response: `account`, `domain`, `domainid`, `zoneid`
- Display total count of snapshots, not depending on page size

### Example
After creating 2 vm snapshots for a given vm, and making this API call: 
`command=listVMSnapshot&listAll=true&virtualmachineid=c8531ef8-8502-4b42-b1c5-c52ace0e7801&_=1475516598524&pagesize=1&page=1`
 we get this response:

```

2

88f7416a-8799-4245-99c6-c707cfbe6f47
i-2-10482-VM_VS_20161003174340
Ready
2
testsnap2
0d074f25-ed31-482f-8bc5-44c9314fc417
c8531ef8-8502-4b42-b1c5-c52ace0e7801
24e44fe5-5f2e-4d35-a8f8-109b644a04e0
testsnap
true
Disk
2016-10-03T10:43:40-0700
admin
5a7ffa07-3fca-11e5-9c45-005056ad45b7
ROOT


```

**NOTES:** As in `listVirtualMachines`, despite `pagesize=1`, `count` field 
shows total snapshots count for given vm. Also, `account`, `domain`, 
`domainid`, `zoneid` fields are listed

* pr/1702:
  CLOUDSTACK-9535: [API] listVMSnapshots improvement

Signed-off-by: Rajani Karuturi 


> [API] listVMSnapshots improvement
> -
>
> Key: CLOUDSTACK-9535
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9535
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
>
> * Include missing fields in response: {{account}}, {{domain}}, {{domainid}}, 
> {{zoneid}}
> * Display total count of snapshots, not depending on page size



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9535) [API] listVMSnapshots improvement

2016-10-13 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15571280#comment-15571280
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9535:


Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/1702


> [API] listVMSnapshots improvement
> -
>
> Key: CLOUDSTACK-9535
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9535
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
>
> * Include missing fields in response: {{account}}, {{domain}}, {{domainid}}, 
> {{zoneid}}
> * Display total count of snapshots, not depending on page size



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9535) [API] listVMSnapshots improvement

2016-10-13 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15571277#comment-15571277
 ] 

ASF subversion and git services commented on CLOUDSTACK-9535:
-

Commit f4a42ab0d7aa559e007e263b54e67d4ce9a0e2ad in cloudstack's branch 
refs/heads/4.9 from [~nvazquez]
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=f4a42ab ]

CLOUDSTACK-9535: [API] listVMSnapshots improvement


> [API] listVMSnapshots improvement
> -
>
> Key: CLOUDSTACK-9535
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9535
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
>
> * Include missing fields in response: {{account}}, {{domain}}, {{domainid}}, 
> {{zoneid}}
> * Display total count of snapshots, not depending on page size



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9535) [API] listVMSnapshots improvement

2016-10-13 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15571279#comment-15571279
 ] 

ASF subversion and git services commented on CLOUDSTACK-9535:
-

Commit 2ebf9492858f70588dccf26042ff053d94d2fc6d in cloudstack's branch 
refs/heads/4.9 from [~rajanik]
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=2ebf949 ]

Merge pull request #1702 from nvazquez/listvmsnapshotsissues

CLOUDSTACK-9535: [API] listVMSnapshots improvement### Improvements
- Include missing fields in response: `account`, `domain`, `domainid`, `zoneid`
- Display total count of snapshots, not depending on page size

### Example
After creating 2 vm snapshots for a given vm, and making this API call: 
`command=listVMSnapshot&listAll=true&virtualmachineid=c8531ef8-8502-4b42-b1c5-c52ace0e7801&_=1475516598524&pagesize=1&page=1`
 we get this response:

```

2

88f7416a-8799-4245-99c6-c707cfbe6f47
i-2-10482-VM_VS_20161003174340
Ready
2
testsnap2
0d074f25-ed31-482f-8bc5-44c9314fc417
c8531ef8-8502-4b42-b1c5-c52ace0e7801
24e44fe5-5f2e-4d35-a8f8-109b644a04e0
testsnap
true
Disk
2016-10-03T10:43:40-0700
admin
5a7ffa07-3fca-11e5-9c45-005056ad45b7
ROOT


```

**NOTES:** As in `listVirtualMachines`, despite `pagesize=1`, `count` field 
shows total snapshots count for given vm. Also, `account`, `domain`, 
`domainid`, `zoneid` fields are listed

* pr/1702:
  CLOUDSTACK-9535: [API] listVMSnapshots improvement

Signed-off-by: Rajani Karuturi 


> [API] listVMSnapshots improvement
> -
>
> Key: CLOUDSTACK-9535
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9535
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
>
> * Include missing fields in response: {{account}}, {{domain}}, {{domainid}}, 
> {{zoneid}}
> * Display total count of snapshots, not depending on page size



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9535) [API] listVMSnapshots improvement

2016-10-13 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15571272#comment-15571272
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9535:


Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1702
  
@blueorangutan test


> [API] listVMSnapshots improvement
> -
>
> Key: CLOUDSTACK-9535
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9535
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
>
> * Include missing fields in response: {{account}}, {{domain}}, {{domainid}}, 
> {{zoneid}}
> * Display total count of snapshots, not depending on page size



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9535) [API] listVMSnapshots improvement

2016-10-13 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15571274#comment-15571274
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9535:


Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1702
  
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been 
kicked to run smoke tests


> [API] listVMSnapshots improvement
> -
>
> Key: CLOUDSTACK-9535
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9535
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
>
> * Include missing fields in response: {{account}}, {{domain}}, {{domainid}}, 
> {{zoneid}}
> * Display total count of snapshots, not depending on page size



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9535) [API] listVMSnapshots improvement

2016-10-13 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15571268#comment-15571268
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9535:


Github user karuturi commented on the issue:

https://github.com/apache/cloudstack/pull/1702
  
đź‘Ťmerging this now


> [API] listVMSnapshots improvement
> -
>
> Key: CLOUDSTACK-9535
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9535
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
>
> * Include missing fields in response: {{account}}, {{domain}}, {{domainid}}, 
> {{zoneid}}
> * Display total count of snapshots, not depending on page size



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9535) [API] listVMSnapshots improvement

2016-10-12 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15569019#comment-15569019
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9535:


Github user nvazquez commented on the issue:

https://github.com/apache/cloudstack/pull/1702
  
@rhtyd @jburwell that would be great, thanks!


> [API] listVMSnapshots improvement
> -
>
> Key: CLOUDSTACK-9535
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9535
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
>
> * Include missing fields in response: {{account}}, {{domain}}, {{domainid}}, 
> {{zoneid}}
> * Display total count of snapshots, not depending on page size



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9535) [API] listVMSnapshots improvement

2016-10-07 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1717#comment-1717
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9535:


Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1702
  
LGTM. Since, the changes to the api response are additive (no response keys 
were removed), we can accept this change. /cc @jburwell 


> [API] listVMSnapshots improvement
> -
>
> Key: CLOUDSTACK-9535
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9535
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
>
> * Include missing fields in response: {{account}}, {{domain}}, {{domainid}}, 
> {{zoneid}}
> * Display total count of snapshots, not depending on page size



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9535) [API] listVMSnapshots improvement

2016-10-07 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1039#comment-1039
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9535:


Github user serg38 commented on the issue:

https://github.com/apache/cloudstack/pull/1702
  
Testing LGTM. Vmware 5.5. and 6.0 , advanced networking, RHEL 6 management 
servers
```
test DeployVM in anti-affinity groups for project ... === TestName: 
test_DeployVmAntiAffinityGroup_in_project | Status : SUCCESS ===
test DeployVM in anti-affinity groups ... === TestName: 
test_DeployVmAntiAffinityGroup | Status : SUCCESS ===
Test Deploy Virtual Machine ... SKIP: Skipping test because suitable 
hypervisor/host notpresent
Test Deploy Virtual Machine from ISO ... === TestName: 
test_deploy_vm_from_iso | Status : SUCCESS ===
Test deploy virtual machine with root resize ... === TestName: 
test_00_deploy_vm_root_resize | Status : SUCCESS ===
Test proper failure to deploy virtual machine with rootdisksize of 0 ... 
=== TestName: test_01_deploy_vm_root_resize | Status : SUCCESS ===
Test proper failure to deploy virtual machine with rootdisksize less than 
template size ... === TestName: test_02_deploy_vm_root_resize | Status : 
SUCCESS ===
Test to deploy vm with a first fit offering ... === TestName: 
test_deployvm_firstfit | Status : SUCCESS ===
Test deploy VMs using user concentrated planner ... === TestName: 
test_deployvm_userconcentrated | Status : SUCCESS ===
Test deploy VMs using user dispersion planner ... === TestName: 
test_deployvm_userdispersing | Status : SUCCESS ===
Test userdata as GET, size > 2k ... === TestName: test_deployvm_userdata | 
Status : SUCCESS ===
Test userdata as POST, size > 2k ... === TestName: 
test_deployvm_userdata_post | Status : SUCCESS ===
Test to create disk offering ... === TestName: test_01_create_disk_offering 
| Status : SUCCESS ===
Test to create  a sparse type disk offering ... === TestName: 
test_02_create_sparse_type_disk_offering | Status : SUCCESS ===
Test to create  a sparse type disk offering ... === TestName: 
test_04_create_fat_type_disk_offering | Status : SUCCESS ===
Test to update existing disk offering ... === TestName: 
test_02_edit_disk_offering | Status : SUCCESS ===
Test to delete disk offering ... === TestName: test_03_delete_disk_offering 
| Status : SUCCESS ===
Test to ensure 4 default roles cannot be deleted ... SKIP: Dynamic 
Role-Based API checker not enabled, skipping test
Test to check role, role permissions and account life cycles ... SKIP: 
Dynamic Role-Based API checker not enabled, skipping test
Test for role-rule enforcement in case of multiple mgmt servers ... SKIP: 
Dynamic Role-Based API checker not enabled, skipping test
Test to ensure role in use cannot be deleted ... SKIP: Dynamic Role-Based 
API checker not enabled, skipping test
Tests normal lifecycle operations for roles ... SKIP: Dynamic Role-Based 
API checker not enabled, skipping test
Tests role update ... SKIP: Dynamic Role-Based API checker not enabled, 
skipping test
Tests that default four roles exist ... SKIP: Dynamic Role-Based API 
checker not enabled, skipping test
Tests role update ... SKIP: Dynamic Role-Based API checker not enabled, 
skipping test
Tests role update when role is in use by an account ... SKIP: Dynamic 
Role-Based API checker not enabled, skipping test
Tests concurrent order updation of role permission ... SKIP: Dynamic 
Role-Based API checker not enabled, skipping test
Tests creation of role permission ... SKIP: Dynamic Role-Based API checker 
not enabled, skipping test
Tests deletion of role permission ... SKIP: Dynamic Role-Based API checker 
not enabled, skipping test
Tests listing of default role's permission ... SKIP: Dynamic Role-Based API 
checker not enabled, skipping test
Tests order updation of role permission ... SKIP: Dynamic Role-Based API 
checker not enabled, skipping test
test update configuration setting at zone level scope ... === TestName: 
test_UpdateConfigParamWithScope | Status : SUCCESS ===
Test guest vlan range dedication ... === TestName: 
test_dedicateGuestVlanRange | Status : SUCCESS ===
Test create public & private ISO ... === TestName: test_01_create_iso | 
Status : SUCCESS ===
Test Edit ISO ... === TestName: test_02_edit_iso | Status : SUCCESS ===
Test delete ISO ... === TestName: test_03_delete_iso | Status : SUCCESS ===
Test for extract ISO ... === TestName: test_04_extract_Iso | Status : 
SUCCESS ===
Update & Test for ISO permissions ... === TestName: test_05_iso_permissions 
| Status : SUCCESS ===
Test for copy ISO from one zone to another ... SKIP: Not enough zones 
available to perform copy template
Test delete ISO ... === TestName: test_07_list_default_iso | Status

[jira] [Commented] (CLOUDSTACK-9535) [API] listVMSnapshots improvement

2016-10-06 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15554318#comment-15554318
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9535:


Github user koushik-das commented on the issue:

https://github.com/apache/cloudstack/pull/1702
  
Code changes LGTM


> [API] listVMSnapshots improvement
> -
>
> Key: CLOUDSTACK-9535
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9535
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
>
> * Include missing fields in response: {{account}}, {{domain}}, {{domainid}}, 
> {{zoneid}}
> * Display total count of snapshots, not depending on page size



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9535) [API] listVMSnapshots improvement

2016-10-06 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15551215#comment-15551215
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9535:


Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1702
  
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-54


> [API] listVMSnapshots improvement
> -
>
> Key: CLOUDSTACK-9535
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9535
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
>
> * Include missing fields in response: {{account}}, {{domain}}, {{domainid}}, 
> {{zoneid}}
> * Display total count of snapshots, not depending on page size



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9535) [API] listVMSnapshots improvement

2016-10-06 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15551137#comment-15551137
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9535:


Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1702
  
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you 
posted as I make progress.


> [API] listVMSnapshots improvement
> -
>
> Key: CLOUDSTACK-9535
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9535
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
>
> * Include missing fields in response: {{account}}, {{domain}}, {{domainid}}, 
> {{zoneid}}
> * Display total count of snapshots, not depending on page size



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9535) [API] listVMSnapshots improvement

2016-10-06 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15551135#comment-15551135
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9535:


Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1702
  
@blueorangutan package


> [API] listVMSnapshots improvement
> -
>
> Key: CLOUDSTACK-9535
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9535
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
>
> * Include missing fields in response: {{account}}, {{domain}}, {{domainid}}, 
> {{zoneid}}
> * Display total count of snapshots, not depending on page size



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9535) [API] listVMSnapshots improvement

2016-10-05 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15549327#comment-15549327
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9535:


GitHub user nvazquez opened a pull request:

https://github.com/apache/cloudstack/pull/1702

CLOUDSTACK-9535: [API] listVMSnapshots improvement

### Improvements
- Include missing fields in response: `account`, `domain`, `domainid`, 
`zoneid`
- Display total count of snapshots, not depending on page size

### Example
After creating 2 vm snapshots for a given vm, and making this API call: 
`command=listVMSnapshot&listAll=true&virtualmachineid=c8531ef8-8502-4b42-b1c5-c52ace0e7801&_=1475516598524&pagesize=1&page=1`
 we get this response:

```

2

88f7416a-8799-4245-99c6-c707cfbe6f47
i-2-10482-VM_VS_20161003174340
Ready
2
testsnap2
0d074f25-ed31-482f-8bc5-44c9314fc417
c8531ef8-8502-4b42-b1c5-c52ace0e7801
24e44fe5-5f2e-4d35-a8f8-109b644a04e0
testsnap
true
Disk
2016-10-03T10:43:40-0700
admin
5a7ffa07-3fca-11e5-9c45-005056ad45b7
ROOT


```

**NOTES:** As in `listVirtualMachines`, despite `pagesize=1`, `count` field 
shows total snapshots count for given vm. Also, `account`, `domain`, 
`domainid`, `zoneid` fields are listed

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nvazquez/cloudstack listvmsnapshotsissues

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1702.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1702


commit ce0338e106d43f06b1afb9a2c4a5fce68fde
Author: nvazquez 
Date:   2016-10-03T18:56:32Z

CLOUDSTACK-9535: [API] listVMSnapshots improvement




> [API] listVMSnapshots improvement
> -
>
> Key: CLOUDSTACK-9535
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9535
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
>
> * Include missing fields in response: {{account}}, {{domain}}, {{domainid}}, 
> {{zoneid}}
> * Display total count of snapshots, not depending on page size



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)