[jira] [Commented] (CLOUDSTACK-9677) Swift Storage Policy support for Secondary Storage

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16454417#comment-16454417
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9677:


pdube commented on issue #2412: CLOUDSTACK-9677: Adding storage policy support 
for swift as secondary…
URL: https://github.com/apache/cloudstack/pull/2412#issuecomment-384691609
 
 
   Thanks @khos2ow 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Swift Storage Policy support for Secondary Storage
> --
>
> Key: CLOUDSTACK-9677
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9677
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Patrick D.
>Assignee: Patrick D.
>Priority: Major
> Fix For: 4.11.1.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-9677) Swift Storage Policy support for Secondary Storage

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16454023#comment-16454023
 ] 

ASF subversion and git services commented on CLOUDSTACK-9677:
-

Commit b3c22df71d0ec3c29fbe37dc3c9812353c1685d9 in cloudstack's branch 
refs/heads/master from [~rafaelweingartner]
[ https://gitbox.apache.org/repos/asf?p=cloudstack.git;h=b3c22df ]

Forward merge branch '4.11' to master

ConfigDrive fixes: CLOUDSTACK-10288, CLOUDSTACK-10289 (#2566)
CLOUDSTACK-9677: Adding storage policy support for swift as secondary
storage (#2412)


> Swift Storage Policy support for Secondary Storage
> --
>
> Key: CLOUDSTACK-9677
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9677
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Patrick D.
>Assignee: Patrick D.
>Priority: Major
> Fix For: 4.11.1.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-9677) Swift Storage Policy support for Secondary Storage

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16454014#comment-16454014
 ] 

ASF subversion and git services commented on CLOUDSTACK-9677:
-

Commit b6d420bec3b4cb02651cffd43502ed880f100bef in cloudstack's branch 
refs/heads/master from [~kmoossavi]
[ https://gitbox.apache.org/repos/asf?p=cloudstack.git;h=b6d420b ]

CLOUDSTACK-9677: Adding storage policy support for swift as secondary storage 
(#2412)

Original-Author: @pdube on PR Fixes #1830.

> Swift Storage Policy support for Secondary Storage
> --
>
> Key: CLOUDSTACK-9677
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9677
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Patrick D.
>Assignee: Patrick D.
>Priority: Major
> Fix For: 4.11.1.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-9677) Swift Storage Policy support for Secondary Storage

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16453203#comment-16453203
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9677:


rhtyd closed pull request #2412: CLOUDSTACK-9677: Adding storage policy support 
for swift as secondary…
URL: https://github.com/apache/cloudstack/pull/2412
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/api/src/com/cloud/agent/api/to/SwiftTO.java 
b/api/src/com/cloud/agent/api/to/SwiftTO.java
index c7a98660302..b89dfea40e0 100644
--- a/api/src/com/cloud/agent/api/to/SwiftTO.java
+++ b/api/src/com/cloud/agent/api/to/SwiftTO.java
@@ -26,17 +26,19 @@
 
 String userName;
 String key;
+String storagePolicy;
 private static final String pathSeparator = "/";
 
 public SwiftTO() {
 }
 
-public SwiftTO(Long id, String url, String account, String userName, 
String key) {
+public SwiftTO(Long id, String url, String account, String userName, 
String key, String storagePolicy) {
 this.id = id;
 this.url = url;
 this.account = account;
 this.userName = userName;
 this.key = key;
+this.storagePolicy = storagePolicy;
 }
 
 public Long getId() {
@@ -63,6 +65,11 @@ public String getKey() {
 return key;
 }
 
+@Override
+public String getStoragePolicy() {
+return this.storagePolicy;
+}
+
 @Override
 public DataStoreRole getRole() {
 return DataStoreRole.Image;
diff --git a/api/src/org/apache/cloudstack/api/ApiConstants.java 
b/api/src/org/apache/cloudstack/api/ApiConstants.java
index d9090b89217..dfe9b30f306 100644
--- a/api/src/org/apache/cloudstack/api/ApiConstants.java
+++ b/api/src/org/apache/cloudstack/api/ApiConstants.java
@@ -287,6 +287,7 @@
 public static final String STATE = "state";
 public static final String STATUS = "status";
 public static final String STORAGE_TYPE = "storagetype";
+public static final String STORAGE_POLICY = "storagepolicy";
 public static final String STORAGE_MOTION_ENABLED = "storagemotionenabled";
 public static final String STORAGE_CAPABILITIES = "storagecapabilities";
 public static final String SYSTEM_VM_TYPE = "systemvmtype";
diff --git 
a/plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/XenServerStorageProcessor.java
 
b/plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/XenServerStorageProcessor.java
index 257c6a23e41..336c32ce159 100644
--- 
a/plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/XenServerStorageProcessor.java
+++ 
b/plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/XenServerStorageProcessor.java
@@ -18,23 +18,24 @@
  */
 package com.cloud.hypervisor.xenserver.resource;
 
-import com.cloud.agent.api.Answer;
-import com.cloud.agent.api.to.DataObjectType;
-import com.cloud.agent.api.to.DataStoreTO;
-import com.cloud.agent.api.to.DataTO;
-import com.cloud.agent.api.to.DiskTO;
-import com.cloud.agent.api.to.NfsTO;
-import com.cloud.agent.api.to.S3TO;
-import com.cloud.agent.api.to.SwiftTO;
-import com.cloud.exception.InternalErrorException;
-import com.cloud.hypervisor.Hypervisor.HypervisorType;
-import com.cloud.hypervisor.xenserver.resource.CitrixResourceBase.SRType;
-import com.cloud.storage.DataStoreRole;
-import com.cloud.storage.Storage;
-import com.cloud.storage.Storage.ImageFormat;
-import com.cloud.storage.resource.StorageProcessor;
-import com.cloud.utils.exception.CloudRuntimeException;
-import com.cloud.utils.storage.S3.ClientOptions;
+import static com.cloud.utils.ReflectUtil.flattenProperties;
+import static com.google.common.collect.Lists.newArrayList;
+
+import java.io.File;
+import java.net.URI;
+import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;
+import java.util.Set;
+import java.util.UUID;
+
+import org.apache.commons.lang3.BooleanUtils;
+import org.apache.log4j.Logger;
+import org.apache.xmlrpc.XmlRpcException;
+
+import com.google.common.annotations.VisibleForTesting;
 import com.xensource.xenapi.Connection;
 import com.xensource.xenapi.SR;
 import com.xensource.xenapi.Types;
@@ -44,6 +45,7 @@
 import com.xensource.xenapi.VBD;
 import com.xensource.xenapi.VDI;
 import com.xensource.xenapi.VM;
+
 import org.apache.cloudstack.agent.directdownload.DirectDownloadCommand;
 import org.apache.cloudstack.storage.command.AttachAnswer;
 import org.apache.cloudstack.storage.command.AttachCommand;
@@ -65,20 +67,24 @@
 import org.apache.cloudstack.storage.to.SnapshotObjectTO;
 import org.apache.cloudstack.storage.to.TemplateObjectTO;
 import 

[jira] [Commented] (CLOUDSTACK-9677) Swift Storage Policy support for Secondary Storage

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16453204#comment-16453204
 ] 

ASF subversion and git services commented on CLOUDSTACK-9677:
-

Commit b6d420bec3b4cb02651cffd43502ed880f100bef in cloudstack's branch 
refs/heads/4.11 from [~kmoossavi]
[ https://gitbox.apache.org/repos/asf?p=cloudstack.git;h=b6d420b ]

CLOUDSTACK-9677: Adding storage policy support for swift as secondary storage 
(#2412)

Original-Author: @pdube on PR Fixes #1830.

> Swift Storage Policy support for Secondary Storage
> --
>
> Key: CLOUDSTACK-9677
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9677
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Patrick D.
>Assignee: Patrick D.
>Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-9677) Swift Storage Policy support for Secondary Storage

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16453202#comment-16453202
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9677:


rhtyd commented on issue #2412: CLOUDSTACK-9677: Adding storage policy support 
for swift as secondary…
URL: https://github.com/apache/cloudstack/pull/2412#issuecomment-384456645
 
 
   LGTM @khos2ow @rafaelweingartner. Since I don't any infra to test swift, 
I'll merge this based on reviews and previous automated regression tests and 
manual tests around swift shared by @khos2ow . Thanks for the effort.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Swift Storage Policy support for Secondary Storage
> --
>
> Key: CLOUDSTACK-9677
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9677
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Patrick D.
>Assignee: Patrick D.
>Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-9677) Swift Storage Policy support for Secondary Storage

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16452869#comment-16452869
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9677:


rafaelweingartner commented on issue #2412: CLOUDSTACK-9677: Adding storage 
policy support for swift as secondary…
URL: https://github.com/apache/cloudstack/pull/2412#issuecomment-384394346
 
 
   Thanks for the replies @khos2ow. Is that what you wanted @rhtyd?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Swift Storage Policy support for Secondary Storage
> --
>
> Key: CLOUDSTACK-9677
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9677
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Patrick D.
>Assignee: Patrick D.
>Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-9677) Swift Storage Policy support for Secondary Storage

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16452833#comment-16452833
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9677:


khos2ow commented on issue #2412: CLOUDSTACK-9677: Adding storage policy 
support for swift as secondary…
URL: https://github.com/apache/cloudstack/pull/2412#issuecomment-384388108
 
 
   @rhtyd @rafaelweingartner ping.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Swift Storage Policy support for Secondary Storage
> --
>
> Key: CLOUDSTACK-9677
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9677
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Patrick D.
>Assignee: Patrick D.
>Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-9677) Swift Storage Policy support for Secondary Storage

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16448554#comment-16448554
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9677:


khos2ow commented on issue #2412: CLOUDSTACK-9677: Adding storage policy 
support for swift as secondary…
URL: https://github.com/apache/cloudstack/pull/2412#issuecomment-383660557
 
 
   Finally I managed some time to test this! (sorry for delay). I did couple 
round of manual tests as follow:
   - created a secondary storage of type Swift with storage policy: `region-1`
   - created a VM: `vm-1`
   - created a volume (`vm-1-vol-1`) and attached to it
   - created a snapshot of that volume and validated it ended up in `region-1`
   - deleted secondary storage `region-1`
   - created a secondary storage of type Swift with storage policy: `region-2`
   - created a VM: `vm-2`
   - created a volume (`vm-2-vol-1`) and attached to it
   - created a snapshot of that volume and validated it ended up in `region-2`


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Swift Storage Policy support for Secondary Storage
> --
>
> Key: CLOUDSTACK-9677
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9677
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Patrick D.
>Assignee: Patrick D.
>Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-9677) Swift Storage Policy support for Secondary Storage

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16448553#comment-16448553
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9677:


khos2ow commented on issue #2412: CLOUDSTACK-9677: Adding storage policy 
support for swift as secondary…
URL: https://github.com/apache/cloudstack/pull/2412#issuecomment-383660557
 
 
   Finally I managed some time to test this! (sorry for delay). I did couple 
round of manual tests as follow:
   - created a secondary storage of type Swift with storage policy: `region-1`
   - created a VM: `vm-1`
   - created a volume (`vm-1-vol-1`) and attached to it
   - created a snapshot of that volume and checked to see validated it ended up 
in `region-1`
   - deleted secondary storage `region-1`
   - created a secondary storage of type Swift with storage policy: `region-2`
   - created a VM: `vm-2`
   - created a volume (`vm-2-vol-1`) and attached to it
   - created a snapshot of that volume and checked to see validated it ended up 
in `region-2`


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Swift Storage Policy support for Secondary Storage
> --
>
> Key: CLOUDSTACK-9677
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9677
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Patrick D.
>Assignee: Patrick D.
>Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-9677) Swift Storage Policy support for Secondary Storage

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16417172#comment-16417172
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9677:


rhtyd commented on issue #2412: CLOUDSTACK-9677: Adding storage policy support 
for swift as secondary…
URL: https://github.com/apache/cloudstack/pull/2412#issuecomment-376848209
 
 
   Ping @khos2ow can you advise on testing of this PR against swift? This is 
ready to merge based on 2+lgtms and smoke test results.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Swift Storage Policy support for Secondary Storage
> --
>
> Key: CLOUDSTACK-9677
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9677
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Patrick D.
>Assignee: Patrick D.
>Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-9677) Swift Storage Policy support for Secondary Storage

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16382544#comment-16382544
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9677:


khos2ow commented on issue #2412: CLOUDSTACK-9677: Adding storage policy 
support for swift as secondary…
URL: https://github.com/apache/cloudstack/pull/2412#issuecomment-369710850
 
 
   Yes @rafaelweingartner , I will, soon.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Swift Storage Policy support for Secondary Storage
> --
>
> Key: CLOUDSTACK-9677
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9677
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Patrick D.
>Assignee: Patrick D.
>Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-9677) Swift Storage Policy support for Secondary Storage

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16373643#comment-16373643
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9677:


rafaelweingartner commented on issue #2412: CLOUDSTACK-9677: Adding storage 
policy support for swift as secondary…
URL: https://github.com/apache/cloudstack/pull/2412#issuecomment-367853242
 
 
   @khos2ow can you provide some inputs regarding @rhtyd inquiry? 
   This one is ready to go.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Swift Storage Policy support for Secondary Storage
> --
>
> Key: CLOUDSTACK-9677
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9677
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Patrick D.
>Assignee: Patrick D.
>Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-9677) Swift Storage Policy support for Secondary Storage

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16365269#comment-16365269
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9677:


rhtyd commented on issue #2412: CLOUDSTACK-9677: Adding storage policy support 
for swift as secondary…
URL: https://github.com/apache/cloudstack/pull/2412#issuecomment-365866150
 
 
   Regression test LGTM, can you share your test results with swift @khos2ow 
and @pdube ?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Swift Storage Policy support for Secondary Storage
> --
>
> Key: CLOUDSTACK-9677
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9677
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Patrick D.
>Assignee: Patrick D.
>Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-9677) Swift Storage Policy support for Secondary Storage

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16365185#comment-16365185
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9677:


blueorangutan commented on issue #2412: CLOUDSTACK-9677: Adding storage policy 
support for swift as secondary…
URL: https://github.com/apache/cloudstack/pull/2412#issuecomment-365842733
 
 
   Trillian test result (tid-2261)
   Environment: xenserver-65sp1 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 31922 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2412-t2261-xenserver-65sp1.zip
   Smoke tests completed. 67 look OK, 0 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Swift Storage Policy support for Secondary Storage
> --
>
> Key: CLOUDSTACK-9677
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9677
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Patrick D.
>Assignee: Patrick D.
>Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-9677) Swift Storage Policy support for Secondary Storage

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16364812#comment-16364812
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9677:


blueorangutan commented on issue #2412: CLOUDSTACK-9677: Adding storage policy 
support for swift as secondary…
URL: https://github.com/apache/cloudstack/pull/2412#issuecomment-365752809
 
 
   @rhtyd a Trillian-Jenkins test job (centos7 mgmt + xenserver-65sp1) has been 
kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Swift Storage Policy support for Secondary Storage
> --
>
> Key: CLOUDSTACK-9677
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9677
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Patrick D.
>Assignee: Patrick D.
>Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-9677) Swift Storage Policy support for Secondary Storage

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16364809#comment-16364809
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9677:


rhtyd commented on issue #2412: CLOUDSTACK-9677: Adding storage policy support 
for swift as secondary…
URL: https://github.com/apache/cloudstack/pull/2412#issuecomment-365752655
 
 
   @blueorangutan test centos7 xenserver-65sp1


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Swift Storage Policy support for Secondary Storage
> --
>
> Key: CLOUDSTACK-9677
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9677
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Patrick D.
>Assignee: Patrick D.
>Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-9677) Swift Storage Policy support for Secondary Storage

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16364776#comment-16364776
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9677:


khos2ow commented on issue #2412: CLOUDSTACK-9677: Adding storage policy 
support for swift as secondary…
URL: https://github.com/apache/cloudstack/pull/2412#issuecomment-365745432
 
 
   @DaanHoogland @rhtyd Can we get a round of test on this PR please?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Swift Storage Policy support for Secondary Storage
> --
>
> Key: CLOUDSTACK-9677
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9677
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Patrick D.
>Assignee: Patrick D.
>Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-9677) Swift Storage Policy support for Secondary Storage

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16356808#comment-16356808
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9677:


blueorangutan commented on issue #2412: CLOUDSTACK-9677: Adding storage policy 
support for swift as secondary…
URL: https://github.com/apache/cloudstack/pull/2412#issuecomment-364078295
 
 
   Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1695


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Swift Storage Policy support for Secondary Storage
> --
>
> Key: CLOUDSTACK-9677
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9677
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Patrick D.
>Assignee: Patrick D.
>Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-9677) Swift Storage Policy support for Secondary Storage

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16356779#comment-16356779
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9677:


blueorangutan commented on issue #2412: CLOUDSTACK-9677: Adding storage policy 
support for swift as secondary…
URL: https://github.com/apache/cloudstack/pull/2412#issuecomment-364072006
 
 
   @DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you 
posted as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Swift Storage Policy support for Secondary Storage
> --
>
> Key: CLOUDSTACK-9677
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9677
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Patrick D.
>Assignee: Patrick D.
>Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-9677) Swift Storage Policy support for Secondary Storage

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16356777#comment-16356777
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9677:


DaanHoogland commented on issue #2412: CLOUDSTACK-9677: Adding storage policy 
support for swift as secondary…
URL: https://github.com/apache/cloudstack/pull/2412#issuecomment-364071766
 
 
   @khos2ow no, it seems to never have started, retrying
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Swift Storage Policy support for Secondary Storage
> --
>
> Key: CLOUDSTACK-9677
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9677
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Patrick D.
>Assignee: Patrick D.
>Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-9677) Swift Storage Policy support for Secondary Storage

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16356109#comment-16356109
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9677:


khos2ow commented on issue #2412: CLOUDSTACK-9677: Adding storage policy 
support for swift as secondary…
URL: https://github.com/apache/cloudstack/pull/2412#issuecomment-363918686
 
 
   @rhtyd @DaanHoogland do you have any idea why packaging is not finished yet? 
Is it normal?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Swift Storage Policy support for Secondary Storage
> --
>
> Key: CLOUDSTACK-9677
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9677
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Patrick D.
>Assignee: Patrick D.
>Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-9677) Swift Storage Policy support for Secondary Storage

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16354496#comment-16354496
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9677:


blueorangutan commented on issue #2412: CLOUDSTACK-9677: Adding storage policy 
support for swift as secondary…
URL: https://github.com/apache/cloudstack/pull/2412#issuecomment-363553653
 
 
   @DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you 
posted as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Swift Storage Policy support for Secondary Storage
> --
>
> Key: CLOUDSTACK-9677
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9677
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Patrick D.
>Assignee: Patrick D.
>Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-9677) Swift Storage Policy support for Secondary Storage

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16354494#comment-16354494
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9677:


DaanHoogland commented on issue #2412: CLOUDSTACK-9677: Adding storage policy 
support for swift as secondary…
URL: https://github.com/apache/cloudstack/pull/2412#issuecomment-363553405
 
 
   not sure why mine didn't work, retrying
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Swift Storage Policy support for Secondary Storage
> --
>
> Key: CLOUDSTACK-9677
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9677
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Patrick D.
>Assignee: Patrick D.
>Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-9677) Swift Storage Policy support for Secondary Storage

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16354419#comment-16354419
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9677:


khos2ow commented on issue #2412: CLOUDSTACK-9677: Adding storage policy 
support for swift as secondary…
URL: https://github.com/apache/cloudstack/pull/2412#issuecomment-363535283
 
 
   damn! typo!!


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Swift Storage Policy support for Secondary Storage
> --
>
> Key: CLOUDSTACK-9677
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9677
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Patrick D.
>Assignee: Patrick D.
>Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-9677) Swift Storage Policy support for Secondary Storage

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16354392#comment-16354392
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9677:


khos2ow opened a new pull request #2412: CLOUDSTACK-9677: Adding storage policy 
support for swift as secondary…
URL: https://github.com/apache/cloudstack/pull/2412
 
 
   … storage
   
   This is to bring PR #1830 back to life (since it was lost in time). We 
already have this fix in our prod well over a year now.
   
   It's based on branch `4.11` and I guess it will be fine to go into `4.11.1` 
milestone.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Swift Storage Policy support for Secondary Storage
> --
>
> Key: CLOUDSTACK-9677
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9677
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Patrick D.
>Assignee: Patrick D.
>Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-9677) Swift Storage Policy support for Secondary Storage

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16354387#comment-16354387
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9677:


DaanHoogland commented on issue #2412: CLOUDSTACK-9677: Adding storage policy 
support for swift as secondary…
URL: https://github.com/apache/cloudstack/pull/2412#issuecomment-363531865
 
 
   unfortunatlelily blueorangutanisn't human and kan'd ried throe spelletjes
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Swift Storage Policy support for Secondary Storage
> --
>
> Key: CLOUDSTACK-9677
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9677
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Patrick D.
>Assignee: Patrick D.
>Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-9677) Swift Storage Policy support for Secondary Storage

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16354338#comment-16354338
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9677:


khos2ow commented on issue #2412: CLOUDSTACK-9677: Adding storage policy 
support for swift as secondary…
URL: https://github.com/apache/cloudstack/pull/2412#issuecomment-363526152
 
 
   @rafaelweingartner oh yes. In the meantime I'm gonna do the package until 
someone runs the test. @blueorangutan pacakge


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Swift Storage Policy support for Secondary Storage
> --
>
> Key: CLOUDSTACK-9677
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9677
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Patrick D.
>Assignee: Patrick D.
>Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-9677) Swift Storage Policy support for Secondary Storage

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16354310#comment-16354310
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9677:


rafaelweingartner commented on issue #2412: CLOUDSTACK-9677: Adding storage 
policy support for swift as secondary…
URL: https://github.com/apache/cloudstack/pull/2412#issuecomment-363520439
 
 
   I believe this one is still missing the automated testes to be executed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Swift Storage Policy support for Secondary Storage
> --
>
> Key: CLOUDSTACK-9677
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9677
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Patrick D.
>Assignee: Patrick D.
>Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-9677) Swift Storage Policy support for Secondary Storage

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16354247#comment-16354247
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9677:


khos2ow commented on issue #2412: CLOUDSTACK-9677: Adding storage policy 
support for swift as secondary…
URL: https://github.com/apache/cloudstack/pull/2412#issuecomment-363510322
 
 
   @rhtyd @rafaelweingartner @wido @DaanHoogland Since 4.11 is out can we get 
this PR going again?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Swift Storage Policy support for Secondary Storage
> --
>
> Key: CLOUDSTACK-9677
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9677
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Patrick D.
>Assignee: Patrick D.
>Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-9677) Swift Storage Policy support for Secondary Storage

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16354244#comment-16354244
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9677:


khos2ow commented on issue #2412: CLOUDSTACK-9677: Adding storage policy 
support for swift as secondary…
URL: https://github.com/apache/cloudstack/pull/2412#issuecomment-363510322
 
 
   @rhtyd @rafaelweingartner @wido @DaanHoogland Since 4.11 is out can we get 
these PR going again?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Swift Storage Policy support for Secondary Storage
> --
>
> Key: CLOUDSTACK-9677
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9677
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Patrick D.
>Assignee: Patrick D.
>Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-9677) Swift Storage Policy support for Secondary Storage

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16343692#comment-16343692
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9677:


khos2ow commented on a change in pull request #2412: CLOUDSTACK-9677: Adding 
storage policy support for swift as secondary…
URL: https://github.com/apache/cloudstack/pull/2412#discussion_r164463356
 
 

 ##
 File path: utils/src/test/java/com/cloud/utils/SwiftUtilTest.java
 ##
 @@ -90,4 +96,134 @@ public void testGetContainerName(){
 
 assertEquals(expected, output);
 }
+
+@Test
 
 Review comment:
   I totally agree, but all the credit for this PR should go to @pdube. I only 
revived and rebased his PR.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Swift Storage Policy support for Secondary Storage
> --
>
> Key: CLOUDSTACK-9677
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9677
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Patrick D.
>Assignee: Patrick D.
>Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-9677) Swift Storage Policy support for Secondary Storage

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16343487#comment-16343487
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9677:


khos2ow commented on a change in pull request #2412: CLOUDSTACK-9677: Adding 
storage policy support for swift as secondary…
URL: https://github.com/apache/cloudstack/pull/2412#discussion_r164463704
 
 

 ##
 File path: 
plugins/hypervisors/xenserver/test/com/cloud/hypervisor/xenserver/resource/XenServerStorageProcessorTest.java
 ##
 @@ -0,0 +1,72 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package com.cloud.hypervisor.xenserver.resource;
+
+import java.util.List;
+
+import org.junit.Assert;
+import org.junit.Test;
+import org.mockito.Mockito;
+
+import com.cloud.agent.api.to.SwiftTO;
+
+public class XenServerStorageProcessorTest {
+@Test
+public void testOrderOfSwiftUplodScriptParams() {
+CitrixResourceBase resource = Mockito.mock(CitrixResourceBase.class);
+XenServerStorageProcessor mock = new 
XenServerStorageProcessor(resource);
+
+SwiftTO swift = Mockito.mock(SwiftTO.class);
+String container = "sample-container-name";
+String ldir = "sample-ldir";
+String lfilename = "sample-lfilename";
+Boolean isISCSI = true;
+
+List params = mock.getSwiftParams(swift, container, ldir, 
lfilename, isISCSI);
+
+// make sure the params not null and has correct number of items in it
+Assert.assertNotNull("params is null", params);
+Assert.assertTrue("Expected param list size is either 18 or 20 but it 
was" + params.size(), params.size() == 18 || params.size() == 20);
+
+// check the order of params
+Assert.assertEquals("unexpected param.", "op", params.get(0));
+Assert.assertEquals("unexpected param.", "upload", params.get(1));
+Assert.assertEquals("unexpected param.", "url", params.get(2));
+Assert.assertEquals("unexpected param.", swift.getUrl(), 
params.get(3));
+Assert.assertEquals("unexpected param.", "account", params.get(4));
+Assert.assertEquals("unexpected param.", swift.getAccount(), 
params.get(5));
+Assert.assertEquals("unexpected param.", "username", params.get(6));
+Assert.assertEquals("unexpected param.", swift.getUserName(), 
params.get(7));
+Assert.assertEquals("unexpected param.", "key", params.get(8));
+Assert.assertEquals("unexpected param.", swift.getKey(), 
params.get(9));
+Assert.assertEquals("unexpected param.", "container", params.get(10));
+Assert.assertEquals("unexpected param.", container, params.get(11));
+Assert.assertEquals("unexpected param.", "ldir", params.get(12));
+Assert.assertEquals("unexpected param.", ldir, params.get(13));
+Assert.assertEquals("unexpected param.", "lfilename", params.get(14));
+Assert.assertEquals("unexpected param.", lfilename, params.get(15));
+Assert.assertEquals("unexpected param.", "isISCSI", params.get(16));
+Assert.assertEquals("unexpected param.", isISCSI.toString(), 
params.get(17));
+
+if (swift.getStoragePolicy() != null) {
 
 Review comment:
   The flow is the basically test the exact order or params, and I actually do 
agree about two different tests for with and without storage policy.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Swift Storage Policy support for Secondary Storage
> --
>
> Key: CLOUDSTACK-9677
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9677
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Patrick D.
>Assignee: Patrick D.
>Priority: 

[jira] [Commented] (CLOUDSTACK-9677) Swift Storage Policy support for Secondary Storage

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16343485#comment-16343485
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9677:


khos2ow commented on a change in pull request #2412: CLOUDSTACK-9677: Adding 
storage policy support for swift as secondary…
URL: https://github.com/apache/cloudstack/pull/2412#discussion_r164463356
 
 

 ##
 File path: utils/src/test/java/com/cloud/utils/SwiftUtilTest.java
 ##
 @@ -90,4 +96,134 @@ public void testGetContainerName(){
 
 assertEquals(expected, output);
 }
+
+@Test
 
 Review comment:
   I totally agree, but all the credit for this PS should go to @pdube. I only 
revived and rebased his PR.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Swift Storage Policy support for Secondary Storage
> --
>
> Key: CLOUDSTACK-9677
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9677
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Patrick D.
>Assignee: Patrick D.
>Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-9677) Swift Storage Policy support for Secondary Storage

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16343482#comment-16343482
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9677:


khos2ow commented on a change in pull request #2412: CLOUDSTACK-9677: Adding 
storage policy support for swift as secondary…
URL: https://github.com/apache/cloudstack/pull/2412#discussion_r164462626
 
 

 ##
 File path: utils/src/main/java/com/cloud/utils/SwiftUtil.java
 ##
 @@ -294,12 +238,80 @@ public static String calculateRFC2104HMAC(String data, 
String key)
 
 }
 
-public static String toHexString(byte[] bytes) {
+static String toHexString(byte[] bytes) {
 
 Review comment:
   sure.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Swift Storage Policy support for Secondary Storage
> --
>
> Key: CLOUDSTACK-9677
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9677
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Patrick D.
>Assignee: Patrick D.
>Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-9677) Swift Storage Policy support for Secondary Storage

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16342051#comment-16342051
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9677:


rafaelweingartner commented on a change in pull request #2412: CLOUDSTACK-9677: 
Adding storage policy support for swift as secondary…
URL: https://github.com/apache/cloudstack/pull/2412#discussion_r164267922
 
 

 ##
 File path: utils/src/test/java/com/cloud/utils/SwiftUtilTest.java
 ##
 @@ -90,4 +96,134 @@ public void testGetContainerName(){
 
 assertEquals(expected, output);
 }
+
+@Test
 
 Review comment:
   Unit Tests! That is awesome!!
   Thank you very much for these. We need to create a culture of writing them.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Swift Storage Policy support for Secondary Storage
> --
>
> Key: CLOUDSTACK-9677
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9677
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Patrick D.
>Assignee: Patrick D.
>Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-9677) Swift Storage Policy support for Secondary Storage

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16342049#comment-16342049
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9677:


rafaelweingartner commented on a change in pull request #2412: CLOUDSTACK-9677: 
Adding storage policy support for swift as secondary…
URL: https://github.com/apache/cloudstack/pull/2412#discussion_r164267865
 
 

 ##
 File path: utils/src/main/java/com/cloud/utils/SwiftUtil.java
 ##
 @@ -294,12 +238,80 @@ public static String calculateRFC2104HMAC(String data, 
String key)
 
 }
 
-public static String toHexString(byte[] bytes) {
+static String toHexString(byte[] bytes) {
 
 Review comment:
   What about using a commons to convert the string to Hexadecimal?
   Something like: org.apache.commons.codec.binary.Hex.encode(byte[])


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Swift Storage Policy support for Secondary Storage
> --
>
> Key: CLOUDSTACK-9677
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9677
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Patrick D.
>Assignee: Patrick D.
>Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-9677) Swift Storage Policy support for Secondary Storage

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16342048#comment-16342048
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9677:


rafaelweingartner commented on a change in pull request #2412: CLOUDSTACK-9677: 
Adding storage policy support for swift as secondary…
URL: https://github.com/apache/cloudstack/pull/2412#discussion_r164267825
 
 

 ##
 File path: 
plugins/hypervisors/xenserver/test/com/cloud/hypervisor/xenserver/resource/XenServerStorageProcessorTest.java
 ##
 @@ -0,0 +1,72 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package com.cloud.hypervisor.xenserver.resource;
+
+import java.util.List;
+
+import org.junit.Assert;
+import org.junit.Test;
+import org.mockito.Mockito;
+
+import com.cloud.agent.api.to.SwiftTO;
+
+public class XenServerStorageProcessorTest {
+@Test
+public void testOrderOfSwiftUplodScriptParams() {
+CitrixResourceBase resource = Mockito.mock(CitrixResourceBase.class);
+XenServerStorageProcessor mock = new 
XenServerStorageProcessor(resource);
+
+SwiftTO swift = Mockito.mock(SwiftTO.class);
+String container = "sample-container-name";
+String ldir = "sample-ldir";
+String lfilename = "sample-lfilename";
+Boolean isISCSI = true;
+
+List params = mock.getSwiftParams(swift, container, ldir, 
lfilename, isISCSI);
+
+// make sure the params not null and has correct number of items in it
+Assert.assertNotNull("params is null", params);
+Assert.assertTrue("Expected param list size is either 18 or 20 but it 
was" + params.size(), params.size() == 18 || params.size() == 20);
+
+// check the order of params
+Assert.assertEquals("unexpected param.", "op", params.get(0));
+Assert.assertEquals("unexpected param.", "upload", params.get(1));
+Assert.assertEquals("unexpected param.", "url", params.get(2));
+Assert.assertEquals("unexpected param.", swift.getUrl(), 
params.get(3));
+Assert.assertEquals("unexpected param.", "account", params.get(4));
+Assert.assertEquals("unexpected param.", swift.getAccount(), 
params.get(5));
+Assert.assertEquals("unexpected param.", "username", params.get(6));
+Assert.assertEquals("unexpected param.", swift.getUserName(), 
params.get(7));
+Assert.assertEquals("unexpected param.", "key", params.get(8));
+Assert.assertEquals("unexpected param.", swift.getKey(), 
params.get(9));
+Assert.assertEquals("unexpected param.", "container", params.get(10));
+Assert.assertEquals("unexpected param.", container, params.get(11));
+Assert.assertEquals("unexpected param.", "ldir", params.get(12));
+Assert.assertEquals("unexpected param.", ldir, params.get(13));
+Assert.assertEquals("unexpected param.", "lfilename", params.get(14));
+Assert.assertEquals("unexpected param.", lfilename, params.get(15));
+Assert.assertEquals("unexpected param.", "isISCSI", params.get(16));
+Assert.assertEquals("unexpected param.", isISCSI.toString(), 
params.get(17));
+
+if (swift.getStoragePolicy() != null) {
 
 Review comment:
   @khos2ow thanks for creating the unit test case.
   I have a doubt here. What is the execution flow you are testing? the one 
with storage policy or without it?
   Also, what do you think about two distinct tests? One to execute the test 
with a storagePolicy and other without. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Swift Storage Policy support for Secondary Storage
> --
>
> Key: CLOUDSTACK-9677
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9677
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: 

[jira] [Commented] (CLOUDSTACK-9677) Swift Storage Policy support for Secondary Storage

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16341601#comment-16341601
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9677:


khos2ow commented on issue #2412: CLOUDSTACK-9677: Adding storage policy 
support for swift as secondary…
URL: https://github.com/apache/cloudstack/pull/2412#issuecomment-360904418
 
 
   @rafaelweingartner can you please review again?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Swift Storage Policy support for Secondary Storage
> --
>
> Key: CLOUDSTACK-9677
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9677
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Patrick D.
>Assignee: Patrick D.
>Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-9677) Swift Storage Policy support for Secondary Storage

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16332227#comment-16332227
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9677:


rafaelweingartner commented on a change in pull request #2412: CLOUDSTACK-9677: 
Adding storage policy support for swift as secondary…
URL: https://github.com/apache/cloudstack/pull/2412#discussion_r162616231
 
 

 ##
 File path: 
plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/XenServerStorageProcessor.java
 ##
 @@ -914,20 +917,45 @@ public Answer copyVolumeFromPrimaryToSecondary(final 
CopyCommand cmd) {
 
 private boolean swiftUpload(final Connection conn, final SwiftTO swift, 
final String container, final String ldir, final String lfilename, final 
Boolean isISCSI,
 final int wait) {
-String result = null;
+
+List params = getSwiftParams(swift, container, ldir, 
lfilename, isISCSI);
+
 try {
-result =
-hypervisorResource.callHostPluginAsync(conn, 
"swiftxenserver", "swift", wait, "op", "upload", "url", swift.getUrl(), 
"account", swift.getAccount(), "username",
-swift.getUserName(), "key", swift.getKey(), 
"container", container, "ldir", ldir, "lfilename", lfilename, "isISCSI", 
isISCSI.toString());
-if (result != null && result.equals("true")) {
-return true;
-}
+String result = hypervisorResource.callHostPluginAsync(conn, 
"swiftxenserver", "swift", wait, params.toArray(new String[params.size()]));
+return "true".equals(result);
 } catch (final Exception e) {
 s_logger.warn("swift upload failed due to " + e.toString(), e);
 }
 return false;
 }
 
+private List getSwiftParams(SwiftTO swift, String container, 
String ldir, String lfilename, Boolean isISCSI) {
 
 Review comment:
   This method could really benefit from unit tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Swift Storage Policy support for Secondary Storage
> --
>
> Key: CLOUDSTACK-9677
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9677
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Patrick D.
>Assignee: Patrick D.
>Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-9677) Swift Storage Policy support for Secondary Storage

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16332226#comment-16332226
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9677:


rafaelweingartner commented on a change in pull request #2412: CLOUDSTACK-9677: 
Adding storage policy support for swift as secondary…
URL: https://github.com/apache/cloudstack/pull/2412#discussion_r162615113
 
 

 ##
 File path: 
plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/XenServerStorageProcessor.java
 ##
 @@ -914,20 +917,45 @@ public Answer copyVolumeFromPrimaryToSecondary(final 
CopyCommand cmd) {
 
 private boolean swiftUpload(final Connection conn, final SwiftTO swift, 
final String container, final String ldir, final String lfilename, final 
Boolean isISCSI,
 final int wait) {
-String result = null;
+
+List params = getSwiftParams(swift, container, ldir, 
lfilename, isISCSI);
+
 try {
-result =
-hypervisorResource.callHostPluginAsync(conn, 
"swiftxenserver", "swift", wait, "op", "upload", "url", swift.getUrl(), 
"account", swift.getAccount(), "username",
-swift.getUserName(), "key", swift.getKey(), 
"container", container, "ldir", ldir, "lfilename", lfilename, "isISCSI", 
isISCSI.toString());
-if (result != null && result.equals("true")) {
-return true;
-}
+String result = hypervisorResource.callHostPluginAsync(conn, 
"swiftxenserver", "swift", wait, params.toArray(new String[params.size()]));
+return "true".equals(result);
 
 Review comment:
   what about using `org.apache.commons.lang3.BooleanUtils.toBoolean(String)` 
here?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Swift Storage Policy support for Secondary Storage
> --
>
> Key: CLOUDSTACK-9677
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9677
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Patrick D.
>Assignee: Patrick D.
>Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-9677) Swift Storage Policy support for Secondary Storage

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16331012#comment-16331012
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9677:


khos2ow opened a new pull request #2412: CLOUDSTACK-9677: Adding storage policy 
support for swift as secondary…
URL: https://github.com/apache/cloudstack/pull/2412
 
 
   … storage
   
   This is to bring PR #1830 back to life (since it was lost in time). We 
already have this fix in our prod well over a year now.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Swift Storage Policy support for Secondary Storage
> --
>
> Key: CLOUDSTACK-9677
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9677
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Patrick D.
>Assignee: Patrick D.
>Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-9677) Swift Storage Policy support for Secondary Storage

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16331013#comment-16331013
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9677:


khos2ow commented on issue #2412: CLOUDSTACK-9677: Adding storage policy 
support for swift as secondary…
URL: https://github.com/apache/cloudstack/pull/2412#issuecomment-358753304
 
 
   @rhtyd @syed @rafaelweingartner Can you please take a look at this?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Swift Storage Policy support for Secondary Storage
> --
>
> Key: CLOUDSTACK-9677
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9677
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Patrick D.
>Assignee: Patrick D.
>Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-9677) Swift Storage Policy support for Secondary Storage

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16330652#comment-16330652
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9677:


pdube commented on issue #1830: CLOUDSTACK-9677: Adding storage policy support 
for swift as secondary…
URL: https://github.com/apache/cloudstack/pull/1830#issuecomment-358686022
 
 
   @khos2ow will be opening up a followup PR shortly


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Swift Storage Policy support for Secondary Storage
> --
>
> Key: CLOUDSTACK-9677
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9677
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Patrick D.
>Assignee: Patrick D.
>Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-9677) Swift Storage Policy support for Secondary Storage

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15798511#comment-15798511
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9677:


Github user pdube closed the pull request at:

https://github.com/apache/cloudstack/pull/1830


> Swift Storage Policy support for Secondary Storage
> --
>
> Key: CLOUDSTACK-9677
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9677
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Patrick D.
>Assignee: Patrick D.
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9677) Swift Storage Policy support for Secondary Storage

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15798514#comment-15798514
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9677:


Github user pdube commented on the issue:

https://github.com/apache/cloudstack/pull/1830
  
Oops, closed by accident


> Swift Storage Policy support for Secondary Storage
> --
>
> Key: CLOUDSTACK-9677
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9677
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Patrick D.
>Assignee: Patrick D.
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9677) Swift Storage Policy support for Secondary Storage

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15798512#comment-15798512
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9677:


GitHub user pdube reopened a pull request:

https://github.com/apache/cloudstack/pull/1830

CLOUDSTACK-9677: Adding storage policy support for swift as secondary…

… storage

Added support to use storage policies with swift

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/pdube/cloudstack swift-storagepolicies

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1830.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1830


commit b157381b9933e17bd2f0583ecf519c58faeffcb7
Author: Patrick Dube 
Date:   2016-12-14T18:57:20Z

CLOUDSTACK-9677: Adding storage policy support for swift as secondary 
storage




> Swift Storage Policy support for Secondary Storage
> --
>
> Key: CLOUDSTACK-9677
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9677
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Patrick D.
>Assignee: Patrick D.
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9677) Swift Storage Policy support for Secondary Storage

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15798510#comment-15798510
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9677:


Github user pdube commented on the issue:

https://github.com/apache/cloudstack/pull/1830
  
@syed Think you could take a look? Thanks


> Swift Storage Policy support for Secondary Storage
> --
>
> Key: CLOUDSTACK-9677
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9677
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Patrick D.
>Assignee: Patrick D.
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9677) Swift Storage Policy support for Secondary Storage

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15749153#comment-15749153
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9677:


GitHub user pdube opened a pull request:

https://github.com/apache/cloudstack/pull/1830

CLOUDSTACK-9677: Adding storage policy support for swift as secondary…

… storage

Added support to use storage policies with swift

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/pdube/cloudstack swift-storagepolicies

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1830.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1830


commit b157381b9933e17bd2f0583ecf519c58faeffcb7
Author: Patrick Dube 
Date:   2016-12-14T18:57:20Z

CLOUDSTACK-9677: Adding storage policy support for swift as secondary 
storage




> Swift Storage Policy support for Secondary Storage
> --
>
> Key: CLOUDSTACK-9677
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9677
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Patrick D.
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)