[
https://issues.apache.org/jira/browse/LANG-1373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16375623#comment-16375623
]
Otto Fowler commented on LANG-1373:
---
OK,
I have addressed the feedback with one exception, I kept the
[
https://issues.apache.org/jira/browse/LANG-1373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16375599#comment-16375599
]
Gilles commented on LANG-1373:
--
bq. why getChildren() should be public?
I thought that it was intended to be
[
https://issues.apache.org/jira/browse/LANG-1373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16375658#comment-16375658
]
Gilles edited comment on LANG-1373 at 2/24/18 4:41 PM:
---
{quote}I have addressed the
[
https://issues.apache.org/jira/browse/LANG-1373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16375658#comment-16375658
]
Gilles commented on LANG-1373:
--
{quote}I have addressed the feedback with one exception
{quote}
Thanks!
[
https://issues.apache.org/jira/browse/LANG-1373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16375667#comment-16375667
]
Otto Fowler commented on LANG-1373:
---
have you tried that when there are generics? give it a try.
[
https://issues.apache.org/jira/browse/LANG-1373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16375668#comment-16375668
]
Otto Fowler commented on LANG-1373:
---
I'll try the private thing again, and if I can't get 100% coverage
[
https://issues.apache.org/jira/browse/LANG-1373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16375740#comment-16375740
]
Gilles commented on LANG-1373:
--
bq. what is the output you get?
{noformat}
Visit level 0 timing:
[
https://issues.apache.org/jira/browse/LANG-1373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16375476#comment-16375476
]
Gilles commented on LANG-1373:
--
* {{T[] getTags()}} -> {{List getTags()}}
> Stopwatch based capability for
[
https://issues.apache.org/jira/browse/LANG-1380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16375470#comment-16375470
]
Gilles commented on LANG-1380:
--
A quick look at the code reveals all sorts of "strategies" (a.o.
[
https://issues.apache.org/jira/browse/LANG-1373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16375585#comment-16375585
]
Otto Fowler commented on LANG-1373:
---
Can I ask why getChildren() should be public? I assume you mean add
[
https://issues.apache.org/jira/browse/VFS-614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16375569#comment-16375569
]
Boris Petrov commented on VFS-614:
--
I think [https://issues.apache.org/jira/projects/VFS/issues/VFS-301]
[
https://issues.apache.org/jira/browse/VFS-119?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Otto Fowler updated VFS-119:
Assignee: Otto Fowler
> Stream closed by the monitor
>
>
> Key:
[
https://issues.apache.org/jira/browse/VFS-119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16375577#comment-16375577
]
Otto Fowler commented on VFS-119:
-
There is a PR for VFS-614
> Stream closed by the monitor
>
[
https://issues.apache.org/jira/browse/VFS-301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16375578#comment-16375578
]
Otto Fowler commented on VFS-301:
-
VFS-614 has a PR
> MonitorInputStream doesn't correctly support 'mark'
>
[
https://issues.apache.org/jira/browse/VFS-614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16375580#comment-16375580
]
Otto Fowler commented on VFS-614:
-
I marked the others duplicates, to link them up
I also commented that
[
https://issues.apache.org/jira/browse/VFS-301?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Otto Fowler updated VFS-301:
Assignee: Otto Fowler
> MonitorInputStream doesn't correctly support 'mark'
>
[
https://issues.apache.org/jira/browse/LANG-1373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16375923#comment-16375923
]
Otto Fowler commented on LANG-1373:
---
I have fixed the visit issue, and done the javadoc using the hybrid
[
https://issues.apache.org/jira/browse/LANG-1373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16375956#comment-16375956
]
Otto Fowler commented on LANG-1373:
---
Maybe we are both watching the ODI cricket? [~kinow]!
Hopefully we
[
https://issues.apache.org/jira/browse/LANG-1373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16375955#comment-16375955
]
Bruno P. Kinoshita commented on LANG-1373:
--
Was lurking here during the comments, reading
[
https://issues.apache.org/jira/browse/LANG-1373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16375954#comment-16375954
]
Otto Fowler commented on LANG-1373:
---
Ok, I think all feedback ( short the autogeneration of names ) has
[
https://issues.apache.org/jira/browse/LANG-1373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16375963#comment-16375963
]
Bruno P. Kinoshita commented on LANG-1373:
--
Digressing a bit from the code in Commons Lang; should
21 matches
Mail list logo
