[
https://issues.apache.org/jira/browse/MATH-1458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16467179#comment-16467179
]
Alex D Herbert commented on MATH-1458:
--
Changes submitted via the pull request:
[
https://issues.apache.org/jira/browse/MATH-1458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16467179#comment-16467179
]
Alex D Herbert edited comment on MATH-1458 at 5/8/18 9:57 AM:
--
Changes
[
https://issues.apache.org/jira/browse/MATH-1458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16467179#comment-16467179
]
Alex D Herbert edited comment on MATH-1458 at 5/8/18 9:56 AM:
--
Changes
[
https://issues.apache.org/jira/browse/MATH-1458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16467352#comment-16467352
]
Alex D Herbert commented on MATH-1458:
--
Found 1 checkstyle error for trailing whitespace.
I was
[
https://issues.apache.org/jira/browse/MATH-1458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16467352#comment-16467352
]
Alex D Herbert edited comment on MATH-1458 at 5/8/18 2:24 PM:
--
Found 1
[
https://issues.apache.org/jira/browse/MATH-1458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16460916#comment-16460916
]
Alex D Herbert edited comment on MATH-1458 at 5/2/18 11:44 AM:
---
The comment
[
https://issues.apache.org/jira/browse/MATH-1458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16460916#comment-16460916
]
Alex D Herbert commented on MATH-1458:
--
The comment about the Incrementor is for the new
[
https://issues.apache.org/jira/browse/MATH-1458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alex D Herbert updated MATH-1458:
-
Description:
org.apache.commons.math3.analysis.integration.SimpsonIntergrator
When used with
Alex D Herbert created MATH-1458:
Summary: Simpson Integrator computes incorrect value at minimum
iterations=1 and wastes an iteration
Key: MATH-1458
URL: https://issues.apache.org/jira/browse/MATH-1458
[
https://issues.apache.org/jira/browse/MATH-1458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16462262#comment-16462262
]
Alex D Herbert commented on MATH-1458:
--
I've branched the git repo and will create tests that the
[
https://issues.apache.org/jira/browse/RNG-50?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16565413#comment-16565413
]
Alex D Herbert commented on RNG-50:
---
Sorry about the link. I've updated it.
{quote}If so,
[
https://issues.apache.org/jira/browse/RNG-50?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16565413#comment-16565413
]
Alex D Herbert edited comment on RNG-50 at 8/1/18 2:38 PM:
---
Sorry about the link.
[
https://issues.apache.org/jira/browse/RNG-50?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16568231#comment-16568231
]
Alex D Herbert edited comment on RNG-50 at 8/3/18 2:25 PM:
---
*Note: I've edited this
[
https://issues.apache.org/jira/browse/RNG-50?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16568231#comment-16568231
]
Alex D Herbert commented on RNG-50:
---
I've created a benchmark for a cache for the state of the
[
https://issues.apache.org/jira/browse/RNG-50?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16568231#comment-16568231
]
Alex D Herbert edited comment on RNG-50 at 8/3/18 1:58 PM:
---
I've created a
[
https://issues.apache.org/jira/browse/RNG-50?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16562006#comment-16562006
]
Alex D Herbert commented on RNG-50:
---
I've made a simple Maven project that tests the use of the {{log(n!}}
[
https://issues.apache.org/jira/browse/RNG-50?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16560761#comment-16560761
]
Alex D Herbert edited comment on RNG-50 at 7/28/18 2:25 PM:
{quote}I've missed
[
https://issues.apache.org/jira/browse/RNG-50?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16560761#comment-16560761
]
Alex D Herbert commented on RNG-50:
---
{quote}I've missed something: If the factorials are precomputed with a
[
https://issues.apache.org/jira/browse/RNG-50?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16562407#comment-16562407
]
Alex D Herbert commented on RNG-50:
---
{quote}I'm a bit lost with layout of the tables
{quote}
I just pasted
[
https://issues.apache.org/jira/browse/RNG-50?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16560761#comment-16560761
]
Alex D Herbert edited comment on RNG-50 at 7/28/18 2:29 PM:
{quote}I've missed
[
https://issues.apache.org/jira/browse/RNG-50?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16558843#comment-16558843
]
Alex D Herbert commented on RNG-50:
---
OK. The PoissonSampler does check the input mean parameter. It doesn't
[
https://issues.apache.org/jira/browse/RNG-50?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16559674#comment-16559674
]
Alex D Herbert commented on RNG-50:
---
{quote}I'd be inclined to introduce sanity checks. Do you think that
[
https://issues.apache.org/jira/browse/RNG-50?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16562006#comment-16562006
]
Alex D Herbert edited comment on RNG-50 at 7/31/18 11:54 AM:
-
I've made a simple
[
https://issues.apache.org/jira/browse/RNG-50?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16562006#comment-16562006
]
Alex D Herbert edited comment on RNG-50 at 7/31/18 11:40 AM:
-
I've made a simple
[
https://issues.apache.org/jira/browse/RNG-50?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16563557#comment-16563557
]
Alex D Herbert commented on RNG-50:
---
I've updated the post to actually use tables.
I'll build some
[
https://issues.apache.org/jira/browse/RNG-50?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16563557#comment-16563557
]
Alex D Herbert edited comment on RNG-50 at 7/31/18 5:22 PM:
I've updated the post
[
https://issues.apache.org/jira/browse/RNG-50?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16564006#comment-16564006
]
Alex D Herbert commented on RNG-50:
---
I've built a simple test using JHM based on
[
https://issues.apache.org/jira/browse/RNG-50?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16565098#comment-16565098
]
Alex D Herbert commented on RNG-50:
---
{quote}We keep the name PoissonSampler and change the implementation.
[
https://issues.apache.org/jira/browse/RNG-50?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alex D Herbert updated RNG-50:
--
Attachment: jmh-result.csv
> PoissonSampler single use speed improvements
>
[
https://issues.apache.org/jira/browse/RNG-50?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16565098#comment-16565098
]
Alex D Herbert edited comment on RNG-50 at 8/1/18 10:19 AM:
{quote}We keep the
[
https://issues.apache.org/jira/browse/RNG-50?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16565206#comment-16565206
]
Alex D Herbert commented on RNG-50:
---
{quote}However what to do with your use-case (large mean single use)?
[
https://issues.apache.org/jira/browse/RNG-50?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16565209#comment-16565209
]
Alex D Herbert commented on RNG-50:
---
Initial modifications without a cache for the LargeMeanPoissonSampler
[
https://issues.apache.org/jira/browse/RNG-50?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16568839#comment-16568839
]
Alex D Herbert commented on RNG-50:
---
{quote}I do not follow: Do you mean that the rest of the previous
[
https://issues.apache.org/jira/browse/RNG-50?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16569589#comment-16569589
]
Alex D Herbert commented on RNG-50:
---
{quote}With JMH?
{quote}
All benchmark data is from JMH.
{quote}You
[
https://issues.apache.org/jira/browse/RNG-50?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16569593#comment-16569593
]
Alex D Herbert commented on RNG-50:
---
PS.
I've just noticed that the
[
https://issues.apache.org/jira/browse/RNG-50?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16565209#comment-16565209
]
Alex D Herbert edited comment on RNG-50 at 8/1/18 1:56 PM:
---
Initial modifications
[
https://issues.apache.org/jira/browse/RNG-50?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16566020#comment-16566020
]
Alex D Herbert commented on RNG-50:
---
{quote}looks like it will silently recompute everything all the time
[
https://issues.apache.org/jira/browse/RNG-50?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16565872#comment-16565872
]
Alex D Herbert commented on RNG-50:
---
I don't see why you have to precompute everything. The cache helps in
[
https://issues.apache.org/jira/browse/RNG-50?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16565206#comment-16565206
]
Alex D Herbert edited comment on RNG-50 at 8/1/18 12:35 PM:
{quote}However what
[
https://issues.apache.org/jira/browse/RNG-50?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16565206#comment-16565206
]
Alex D Herbert edited comment on RNG-50 at 8/1/18 12:37 PM:
{quote}However what
[
https://issues.apache.org/jira/browse/RNG-50?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16560319#comment-16560319
]
Alex D Herbert commented on RNG-50:
---
{quote}Would it be good enough for your use-case?{quote}
Yes. That is
Alex D Herbert created RNG-50:
-
Summary: PoissonSampler single use speed improvements
Key: RNG-50
URL: https://issues.apache.org/jira/browse/RNG-50
Project: Commons RNG
Issue Type: Improvement
[
https://issues.apache.org/jira/browse/RNG-50?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alex D Herbert updated RNG-50:
--
Description:
The Sampler architecture of {{org.apache.commons.rng.sampling.distribution}} is
nicely
[
https://issues.apache.org/jira/browse/RNG-50?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16569803#comment-16569803
]
Alex D Herbert commented on RNG-50:
---
{quote}But... looking again at the table, I now see that the
[
https://issues.apache.org/jira/browse/RNG-50?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16570919#comment-16570919
]
Alex D Herbert commented on RNG-50:
---
[PR for the
[
https://issues.apache.org/jira/browse/RNG-50?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16568231#comment-16568231
]
Alex D Herbert edited comment on RNG-50 at 8/3/18 9:55 PM:
---
*Note: I've edited this
[
https://issues.apache.org/jira/browse/RNG-50?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16572287#comment-16572287
]
Alex D Herbert commented on RNG-50:
---
FYI. Somehow git was broken. A new clone of the same forked repo then
Alex D Herbert created RNG-52:
-
Summary: PoissonSampler allows mean above Integer.MAX_VALUE
Key: RNG-52
URL: https://issues.apache.org/jira/browse/RNG-52
Project: Commons RNG
Issue Type: Bug
Alex D Herbert created RNG-51:
-
Summary: PoissonSampler single use speed improvements using a cache
Key: RNG-51
URL: https://issues.apache.org/jira/browse/RNG-51
Project: Commons RNG
Issue Type:
Alex D Herbert created RNG-54:
-
Summary: StringSampler
Key: RNG-54
URL: https://issues.apache.org/jira/browse/RNG-54
Project: Commons RNG
Issue Type: Improvement
Components: sampling
Alex D Herbert created RNG-55:
-
Summary: UnitSphereSampler
Key: RNG-55
URL: https://issues.apache.org/jira/browse/RNG-55
Project: Commons RNG
Issue Type: Bug
Components: sampling
[
https://issues.apache.org/jira/browse/RNG-55?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16582361#comment-16582361
]
Alex D Herbert commented on RNG-55:
---
{quote}No, because zero size is allowed.{quote}
My typo. I should
[
https://issues.apache.org/jira/browse/RNG-54?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16582795#comment-16582795
]
Alex D Herbert commented on RNG-54:
---
I just had a look at commons Text and that currently has no
[
https://issues.apache.org/jira/browse/RNG-55?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16582863#comment-16582863
]
Alex D Herbert commented on RNG-55:
---
{quote}There is also the case where normSq would be
[
https://issues.apache.org/jira/browse/RNG-50?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16569977#comment-16569977
]
Alex D Herbert commented on RNG-50:
---
bq. Thanks. There was a question for you on the "dev" ML.
Oh. I'm not
[
https://issues.apache.org/jira/browse/RNG-50?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16570624#comment-16570624
]
Alex D Herbert commented on RNG-50:
---
Here are the relative performance figures for the
[
https://issues.apache.org/jira/browse/RNG-54?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16584272#comment-16584272
]
Alex D Herbert commented on RNG-54:
---
{quote}You should post to the ML.
{quote}
OK. I've been really busy
[
https://issues.apache.org/jira/browse/RNG-57?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16630299#comment-16630299
]
Alex D Herbert commented on RNG-57:
---
{quote}So I'm going to test a version that uses int bit masking for
[
https://issues.apache.org/jira/browse/RNG-57?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16639951#comment-16639951
]
Alex D Herbert edited comment on RNG-57 at 10/5/18 4:13 PM:
{quote}No need to
[
https://issues.apache.org/jira/browse/RNG-57?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16639951#comment-16639951
]
Alex D Herbert commented on RNG-57:
---
{quote}No need to insert paragraph formatting tags (...) in the
[
https://issues.apache.org/jira/browse/RNG-57?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1663#comment-1663
]
Alex D Herbert commented on RNG-57:
---
{quote}Please review the changes made for RNG-58.
{quote}
Nice
[
https://issues.apache.org/jira/browse/RNG-57?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16641616#comment-16641616
]
Alex D Herbert commented on RNG-57:
---
bq. Why should the number of expected failures be different for each
[
https://issues.apache.org/jira/browse/RNG-57?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16640363#comment-16640363
]
Alex D Herbert commented on RNG-57:
---
I also noticed that {{BaseProvider}} returns an empty array in
[
https://issues.apache.org/jira/browse/RNG-57?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16640375#comment-16640375
]
Alex D Herbert commented on RNG-57:
---
bq. IIRC, I did this to avoid a circular dependency between
[
https://issues.apache.org/jira/browse/RNG-57?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16640379#comment-16640379
]
Alex D Herbert commented on RNG-57:
---
bq. Please rebase your changes on the current "master" (sorry).
Done.
[
https://issues.apache.org/jira/browse/RNG-57?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16641910#comment-16641910
]
Alex D Herbert commented on RNG-57:
---
Apologies in advance for the long post. This stems from the desire to
[
https://issues.apache.org/jira/browse/RNG-57?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16688792#comment-16688792
]
Alex D Herbert commented on RNG-57:
---
A post to the commons developers list mentioned a release for v1.2
Alex D Herbert created RNG-61:
-
Summary: PermutationSampler shuffle contains unnecessary
conditional
Key: RNG-61
URL: https://issues.apache.org/jira/browse/RNG-61
Project: Commons RNG
Issue
Alex D Herbert created RNG-62:
-
Summary: CombinationSampler
Key: RNG-62
URL: https://issues.apache.org/jira/browse/RNG-62
Project: Commons RNG
Issue Type: New Feature
Reporter: Alex
[
https://issues.apache.org/jira/browse/RNG-60?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16689408#comment-16689408
]
Alex D Herbert commented on RNG-60:
---
A simpler approach would be to split them into hardcoded methods:
[
https://issues.apache.org/jira/browse/RNG-57?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16689433#comment-16689433
]
Alex D Herbert commented on RNG-57:
---
Using RNG-60 I have made the same changes that previously failed and
[
https://issues.apache.org/jira/browse/RNG-60?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16689333#comment-16689333
]
Alex D Herbert commented on RNG-60:
---
This commit changes the tests to have a rerun count of 2.
Most of the
[
https://issues.apache.org/jira/browse/RNG-57?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16689499#comment-16689499
]
Alex D Herbert commented on RNG-57:
---
BigCrush
I manged to get this to work using:
{code:java}
> sudo
[
https://issues.apache.org/jira/browse/RNG-57?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16636813#comment-16636813
]
Alex D Herbert commented on RNG-57:
---
The changes to implement the cache in {{IntProvider}} and
[
https://issues.apache.org/jira/browse/RNG-57?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16637066#comment-16637066
]
Alex D Herbert commented on RNG-57:
---
{quote}Or let me the chance to implement the latter.{quote}
I was
[
https://issues.apache.org/jira/browse/RNG-57?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16643062#comment-16643062
]
Alex D Herbert commented on RNG-57:
---
bq. Did I understand correctly that you propose to
Yes.
The test
[
https://issues.apache.org/jira/browse/RNG-57?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16643229#comment-16643229
]
Alex D Herbert edited comment on RNG-57 at 10/9/18 12:11 PM:
-
bq. How would a
[
https://issues.apache.org/jira/browse/RNG-57?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16643229#comment-16643229
]
Alex D Herbert commented on RNG-57:
---
bq. How would a single test detect which of the NumberFactory methods
[
https://issues.apache.org/jira/browse/RNG-57?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16635714#comment-16635714
]
Alex D Herbert commented on RNG-57:
---
{quote}Perhaps add a table for "nextBoolean()"{quote}
Updating the
[
https://issues.apache.org/jira/browse/RNG-57?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16634698#comment-16634698
]
Alex D Herbert commented on RNG-57:
---
{quote}The benchmarking code is in class GenerationPerformance in
[
https://issues.apache.org/jira/browse/RNG-57?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16633915#comment-16633915
]
Alex D Herbert commented on RNG-57:
---
{quote}I'm not sure whether it is your intended contribution to the
[
https://issues.apache.org/jira/browse/RNG-57?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16636686#comment-16636686
]
Alex D Herbert commented on RNG-57:
---
After some more benchmarking I cannot categorically state that one
[
https://issues.apache.org/jira/browse/RNG-57?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16636686#comment-16636686
]
Alex D Herbert edited comment on RNG-57 at 10/3/18 9:46 AM:
After some more
[
https://issues.apache.org/jira/browse/RNG-57?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16640722#comment-16640722
]
Alex D Herbert commented on RNG-57:
---
Wow that test is hard to get to pass.
I just tried this using a 1024
[
https://issues.apache.org/jira/browse/RNG-57?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16640712#comment-16640712
]
Alex D Herbert commented on RNG-57:
---
I've closed the PR and repeated the changes in a new branch.
Do you
[
https://issues.apache.org/jira/browse/RNG-57?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16640891#comment-16640891
]
Alex D Herbert commented on RNG-57:
---
Having though about this the simulation can be modelled as a Binomial
[
https://issues.apache.org/jira/browse/RNG-57?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16640855#comment-16640855
]
Alex D Herbert commented on RNG-57:
---
I've had a look at {{ProvidersCommonParametricTest}} and why this
[
https://issues.apache.org/jira/browse/RNG-51?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16623697#comment-16623697
]
Alex D Herbert commented on RNG-51:
---
I've created a PR with the modifications for review:
[PR
[
https://issues.apache.org/jira/browse/RNG-51?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16624069#comment-16624069
]
Alex D Herbert commented on RNG-51:
---
A more comprehensive speed test using 5 different samplers and 30
[
https://issues.apache.org/jira/browse/RNG-54?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16625675#comment-16625675
]
Alex D Herbert edited comment on RNG-54 at 9/24/18 11:26 AM:
-
Side note follow
[
https://issues.apache.org/jira/browse/RNG-52?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16625626#comment-16625626
]
Alex D Herbert commented on RNG-52:
---
In short, I agree.
Here're my thoughts:
The fix RNG-51 added a check
[
https://issues.apache.org/jira/browse/RNG-54?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16625796#comment-16625796
]
Alex D Herbert commented on RNG-54:
---
I read the code for {{long next()}} in most of the {{LongProviders}}
[
https://issues.apache.org/jira/browse/RNG-52?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16625654#comment-16625654
]
Alex D Herbert commented on RNG-52:
---
OK. I'll add it to my TODO list for this week.
> PoissonSampler
[
https://issues.apache.org/jira/browse/RNG-54?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16625651#comment-16625651
]
Alex D Herbert commented on RNG-54:
---
{quote}But do not bother making a PR for CM: I'll simply delete the
[
https://issues.apache.org/jira/browse/RNG-54?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16625675#comment-16625675
]
Alex D Herbert commented on RNG-54:
---
Side note follow up:
Also wrapper classes to cache values could be
[
https://issues.apache.org/jira/browse/RNG-54?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16625817#comment-16625817
]
Alex D Herbert commented on RNG-54:
---
{code:java}
/**
* Generate a random string of the given length using
Alex D Herbert created RNG-57:
-
Summary: CachedUniformRandomProvider for nextBoolean() and
nextInt()
Key: RNG-57
URL: https://issues.apache.org/jira/browse/RNG-57
Project: Commons RNG
Issue
[
https://issues.apache.org/jira/browse/RNG-54?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16625841#comment-16625841
]
Alex D Herbert commented on RNG-54:
---
{quote}Is it necessary to return a String from the core
[
https://issues.apache.org/jira/browse/RNG-54?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16625913#comment-16625913
]
Alex D Herbert commented on RNG-54:
---
{quote}I meant "core implementation of the generation of bytes that
[
https://issues.apache.org/jira/browse/RNG-57?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16627255#comment-16627255
]
Alex D Herbert commented on RNG-57:
---
For reference this is what I tried:
{code:java}
/**
* Wrap an
1 - 100 of 425 matches
Mail list logo
