[GitHub] coveralls edited a comment on issue #396: Travis: "openjdk-ea" now means Java 13, so add Java 12 to JDKs to bui…

2019-01-05 Thread GitBox
coveralls edited a comment on issue #396: Travis: "openjdk-ea" now means Java 13, so add Java 12 to JDKs to bui… URL: https://github.com/apache/commons-lang/pull/396#issuecomment-451688667 [![Coverage

[GitHub] asfgit closed pull request #396: Travis: "openjdk-ea" now means Java 13, so add Java 12 to JDKs to bui…

2019-01-05 Thread GitBox
asfgit closed pull request #396: Travis: "openjdk-ea" now means Java 13, so add Java 12 to JDKs to bui… URL: https://github.com/apache/commons-lang/pull/396 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] PascalSchumacher opened a new pull request #396: Travis: "openjdk-ea" now means Java 13, so add Java 12 to JDKs to bui…

2019-01-05 Thread GitBox
PascalSchumacher opened a new pull request #396: Travis: "openjdk-ea" now means Java 13, so add Java 12 to JDKs to bui… URL: https://github.com/apache/commons-lang/pull/396 …ld on. This is an automated message from the

[GitHub] coveralls commented on issue #396: Travis: "openjdk-ea" now means Java 13, so add Java 12 to JDKs to bui…

2019-01-05 Thread GitBox
coveralls commented on issue #396: Travis: "openjdk-ea" now means Java 13, so add Java 12 to JDKs to bui… URL: https://github.com/apache/commons-lang/pull/396#issuecomment-451688667 [![Coverage Status](https://coveralls.io/builds/20921921/badge)](https://coveralls.io/builds/20921921)

[GitHub] JiangYongKang closed pull request #318: clean code

2019-01-16 Thread GitBox
JiangYongKang closed pull request #318: clean code URL: https://github.com/apache/commons-lang/pull/318 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the

[GitHub] Yash-777 commented on a change in pull request #395: Replaces the given String, with the String which is nested in between two Strings.

2019-01-15 Thread GitBox
Yash-777 commented on a change in pull request #395: Replaces the given String, with the String which is nested in between two Strings. URL: https://github.com/apache/commons-lang/pull/395#discussion_r247473007 ## File path: src/main/java/org/apache/commons/lang3/StringUtils.java

[GitHub] kinow commented on issue #395: Replaces the given String, with the String which is nested in between two Strings.

2019-01-15 Thread GitBox
kinow commented on issue #395: Replaces the given String, with the String which is nested in between two Strings. URL: https://github.com/apache/commons-lang/pull/395#issuecomment-454675700 I am not sure if this belongs to commons-lang. It has a practical use, and I can see you put some

[GitHub] Yash-777 commented on a change in pull request #395: Replaces the given String, with the String which is nested in between two Strings.

2019-01-15 Thread GitBox
Yash-777 commented on a change in pull request #395: Replaces the given String, with the String which is nested in between two Strings. URL: https://github.com/apache/commons-lang/pull/395#discussion_r247473007 ## File path: src/main/java/org/apache/commons/lang3/StringUtils.java

[GitHub] Yash-777 closed pull request #395: Replaces the given String, with the String which is nested in between two Strings.

2019-01-15 Thread GitBox
Yash-777 closed pull request #395: Replaces the given String, with the String which is nested in between two Strings. URL: https://github.com/apache/commons-lang/pull/395 As this is a foreign pull request (from a fork), the diff has been sent to your commit mailing list,

[GitHub] Yash-777 opened a new pull request #395: Replaces the given String, with the String which is nested in between two Strings.

2019-01-15 Thread GitBox
Yash-777 opened a new pull request #395: Replaces the given String, with the String which is nested in between two Strings. URL: https://github.com/apache/commons-lang/pull/395 Replace String with the String which is nested in between two Strings. I have used this Method in order to

[GitHub] Yash-777 closed pull request #395: Replaces the given String, with the String which is nested in between two Strings.

2019-01-15 Thread GitBox
Yash-777 closed pull request #395: Replaces the given String, with the String which is nested in between two Strings. URL: https://github.com/apache/commons-lang/pull/395 As this is a foreign pull request (from a fork), the diff has been sent to your commit mailing list,

[GitHub] Yash-777 commented on issue #395: Replaces the given String, with the String which is nested in between two Strings.

2019-01-15 Thread GitBox
Yash-777 commented on issue #395: Replaces the given String, with the String which is nested in between two Strings. URL: https://github.com/apache/commons-lang/pull/395#issuecomment-454680834 creating new pull request. This

[GitHub] coveralls edited a comment on issue #395: Replaces the given String, with the String which is nested in between two Strings.

2019-01-15 Thread GitBox
coveralls edited a comment on issue #395: Replaces the given String, with the String which is nested in between two Strings. URL: https://github.com/apache/commons-lang/pull/395#issuecomment-451407579 [![Coverage

[GitHub] MarkDacek commented on a change in pull request #395: Replaces the given String, with the String which is nested in between two Strings.

2019-01-15 Thread GitBox
MarkDacek commented on a change in pull request #395: Replaces the given String, with the String which is nested in between two Strings. URL: https://github.com/apache/commons-lang/pull/395#discussion_r248161742 ## File path: src/main/java/org/apache/commons/lang3/StringUtils.java

[GitHub] kinow commented on issue #395: Replaces the given String, with the String which is nested in between two Strings.

2019-01-15 Thread GitBox
kinow commented on issue #395: Replaces the given String, with the String which is nested in between two Strings. URL: https://github.com/apache/commons-lang/pull/395#issuecomment-454682674 @Yash-777 I think it would be easier if you used the same pull request. This makes it a lot harder

[GitHub] coveralls commented on issue #400: Close/flush the `OutputStream` before calling `toByteArray()` on underlying `ByteArrayOutputStream`

2019-01-23 Thread GitBox
coveralls commented on issue #400: Close/flush the `OutputStream` before calling `toByteArray()` on underlying `ByteArrayOutputStream` URL: https://github.com/apache/commons-lang/pull/400#issuecomment-456718148 [![Coverage

[GitHub] emopers opened a new pull request #399: Synchronize before looping over synchronized collection

2019-01-23 Thread GitBox
emopers opened a new pull request #399: Synchronize before looping over synchronized collection URL: https://github.com/apache/commons-lang/pull/399 In `CharSet.java`, `set = Collections.synchronizedSet(new HashSet<>())` is iterated over without synchronization. According to [Java API]

[GitHub] emopers opened a new pull request #400: Close/flush the `OutputStream` before calling `toByteArray()` on underlying `ByteArrayOutputStream`

2019-01-23 Thread GitBox
emopers opened a new pull request #400: Close/flush the `OutputStream` before calling `toByteArray()` on underlying `ByteArrayOutputStream` URL: https://github.com/apache/commons-lang/pull/400 When an `OutputStream` instance wraps an underlying `ByteArrayOutputStream` instance, it is

[GitHub] coveralls commented on issue #399: Synchronize before looping over synchronized collection

2019-01-23 Thread GitBox
coveralls commented on issue #399: Synchronize before looping over synchronized collection URL: https://github.com/apache/commons-lang/pull/399#issuecomment-456717202 [![Coverage Status](https://coveralls.io/builds/21225943/badge)](https://coveralls.io/builds/21225943) Coverage

[GitHub] Sam-Kruglov opened a new pull request #398: Add ComparableUtils

2019-01-17 Thread GitBox
Sam-Kruglov opened a new pull request #398: Add ComparableUtils URL: https://github.com/apache/commons-lang/pull/398 I have turned `feeAmount.compareTo(BigDecimal.ZERO) > 0` into `is(feeAmount).greaterThan(BigDecimal.ZERO)` and decided to share.

[GitHub] Yash-777 opened a new pull request #397: Replaces the given String, with the String which is nested in between two Strings.

2019-01-15 Thread GitBox
Yash-777 opened a new pull request #397: Replaces the given String, with the String which is nested in between two Strings. URL: https://github.com/apache/commons-lang/pull/397 This method returns the input String on the below conditions: * If the input String is null * if

[GitHub] coveralls commented on issue #397: Replaces the given String, with the String which is nested in between two Strings.

2019-01-16 Thread GitBox
coveralls commented on issue #397: Replaces the given String, with the String which is nested in between two Strings. URL: https://github.com/apache/commons-lang/pull/397#issuecomment-454686192 [![Coverage

[GitHub] coveralls commented on issue #398: Add ComparableUtils

2019-01-17 Thread GitBox
coveralls commented on issue #398: Add ComparableUtils URL: https://github.com/apache/commons-lang/pull/398#issuecomment-455218326 [![Coverage Status](https://coveralls.io/builds/21131417/badge)](https://coveralls.io/builds/21131417) Coverage decreased (-0.003%) to 95.27% when

[GitHub] MarkDacek commented on issue #398: Add ComparableUtils

2019-01-17 Thread GitBox
MarkDacek commented on issue #398: Add ComparableUtils URL: https://github.com/apache/commons-lang/pull/398#issuecomment-455432213 I think you'd have to add in null-safety to make this worthwhile. Without that, it's just overhead on top of `a.compareTo(b)`.

[GitHub] Sam-Kruglov commented on issue #398: Add ComparableUtils

2019-01-18 Thread GitBox
Sam-Kruglov commented on issue #398: Add ComparableUtils URL: https://github.com/apache/commons-lang/pull/398#issuecomment-455475212 @MarkDacek @GedMarc actually that's correct, compareTo is null safe, here is a piece of its javadoc: `@throws NullPointerException if the specified object

[GitHub] GedMarc commented on issue #398: Add ComparableUtils

2019-01-18 Thread GitBox
GedMarc commented on issue #398: Add ComparableUtils URL: https://github.com/apache/commons-lang/pull/398#issuecomment-455463754 @MarkDacek compareTo() is null safe by default, that's the difference vs compare(T a1,T a2)? So adding in null checks into compareTo() seems likes a waste of

[GitHub] Sam-Kruglov commented on issue #398: Add ComparableUtils

2019-01-17 Thread GitBox
Sam-Kruglov commented on issue #398: Add ComparableUtils URL: https://github.com/apache/commons-lang/pull/398#issuecomment-455448673 Good idea will add. But following that logic, the whole commons is just an overhead then.

[GitHub] MarkDacek commented on issue #362: Add a check to StringUtils.repeat() for large length repeat value

2018-12-17 Thread GitBox
MarkDacek commented on issue #362: Add a check to StringUtils.repeat() for large length repeat value URL: https://github.com/apache/commons-lang/pull/362#issuecomment-448013754 Can you think of any kind of use-case where a String over two-billion characters long is created, such that all

[GitHub] MarkDacek commented on issue #391: Adding junits for JsonToStringStyle

2018-12-17 Thread GitBox
MarkDacek commented on issue #391: Adding junits for JsonToStringStyle URL: https://github.com/apache/commons-lang/pull/391#issuecomment-448004147 Can you make your arrays in the new test cases final? Also perhaps avoid using the **new** keyword when you don't need memory allocated at that

[GitHub] Turan91 commented on issue #362: Add a check to StringUtils.repeat() for large length repeat value

2018-12-17 Thread GitBox
Turan91 commented on issue #362: Add a check to StringUtils.repeat() for large length repeat value URL: https://github.com/apache/commons-lang/pull/362#issuecomment-448012492 It is convention for exception messages to provide the user with information on the cause of failure. In the same

[GitHub] MarkDacek commented on a change in pull request #392: LANG-1410: eliminate one unnecessary local int variable and add more tests

2018-12-17 Thread GitBox
MarkDacek commented on a change in pull request #392: LANG-1410: eliminate one unnecessary local int variable and add more tests URL: https://github.com/apache/commons-lang/pull/392#discussion_r242326099 ## File path: src/main/java/org/apache/commons/lang3/StringUtils.java

[GitHub] MarkDacek commented on issue #362: Add a check to StringUtils.repeat() for large length repeat value

2018-12-17 Thread GitBox
MarkDacek commented on issue #362: Add a check to StringUtils.repeat() for large length repeat value URL: https://github.com/apache/commons-lang/pull/362#issuecomment-448005772 Other thing of note: I don't think that providing the length in the exception is terribly useful, as the

[GitHub] MarkDacek commented on a change in pull request #392: LANG-1410: eliminate one unnecessary local int variable and add more tests

2018-12-17 Thread GitBox
MarkDacek commented on a change in pull request #392: LANG-1410: eliminate one unnecessary local int variable and add more tests URL: https://github.com/apache/commons-lang/pull/392#discussion_r242326701 ## File path:

[GitHub] rosti-il commented on a change in pull request #392: LANG-1410: eliminate one unnecessary local int variable and add more tests

2018-12-17 Thread GitBox
rosti-il commented on a change in pull request #392: LANG-1410: eliminate one unnecessary local int variable and add more tests URL: https://github.com/apache/commons-lang/pull/392#discussion_r242420905 ## File path:

[GitHub] rosti-il commented on a change in pull request #392: LANG-1410: eliminate one unnecessary local int variable and add more tests

2018-12-17 Thread GitBox
rosti-il commented on a change in pull request #392: LANG-1410: eliminate one unnecessary local int variable and add more tests URL: https://github.com/apache/commons-lang/pull/392#discussion_r242423165 ## File path: src/main/java/org/apache/commons/lang3/StringUtils.java

[GitHub] chtompki commented on issue #391: Adding junits for JsonToStringStyle

2018-12-18 Thread GitBox
chtompki commented on issue #391: Adding junits for JsonToStringStyle URL: https://github.com/apache/commons-lang/pull/391#issuecomment-448218634 I'm fairly indifferent about how the strings are declared as they are tests. The concatenation is a tad odd to me because it seems to be

[GitHub] chtompki commented on issue #391: Adding junits for JsonToStringStyle

2018-12-18 Thread GitBox
chtompki commented on issue #391: Adding junits for JsonToStringStyle URL: https://github.com/apache/commons-lang/pull/391#issuecomment-448221818 I'll try to get to this today. This is an automated message from the Apache Git

[GitHub] MarkDacek commented on a change in pull request #392: LANG-1410: eliminate one unnecessary local int variable and add more tests

2018-12-18 Thread GitBox
MarkDacek commented on a change in pull request #392: LANG-1410: eliminate one unnecessary local int variable and add more tests URL: https://github.com/apache/commons-lang/pull/392#discussion_r242667471 ## File path:

[GitHub] RahulNagekar commented on issue #391: Adding junits for JsonToStringStyle

2018-12-20 Thread GitBox
RahulNagekar commented on issue #391: Adding junits for JsonToStringStyle URL: https://github.com/apache/commons-lang/pull/391#issuecomment-449103250 Will post 1 more commit improving this. I am all agree with all comnents , its best to follow best practices.

[GitHub] rosti-il commented on a change in pull request #392: LANG-1410: eliminate one unnecessary local int variable and add more tests

2018-12-20 Thread GitBox
rosti-il commented on a change in pull request #392: LANG-1410: eliminate one unnecessary local int variable and add more tests URL: https://github.com/apache/commons-lang/pull/392#discussion_r243349505 ## File path: src/main/java/org/apache/commons/lang3/StringUtils.java

[GitHub] eceejcr commented on a change in pull request #392: LANG-1410: eliminate one unnecessary local int variable and add more tests

2018-12-20 Thread GitBox
eceejcr commented on a change in pull request #392: LANG-1410: eliminate one unnecessary local int variable and add more tests URL: https://github.com/apache/commons-lang/pull/392#discussion_r243382598 ## File path: src/main/java/org/apache/commons/lang3/StringUtils.java

[GitHub] MarkDacek edited a comment on issue #362: Add a check to StringUtils.repeat() for large length repeat value

2018-12-16 Thread GitBox
MarkDacek edited a comment on issue #362: Add a check to StringUtils.repeat() for large length repeat value URL: https://github.com/apache/commons-lang/pull/362#issuecomment-447725344 > > I'm somewhat wary of simply comparing the values, as it's not always intuitive and doesn't save us

[GitHub] MarkDacek commented on issue #362: Add a check to StringUtils.repeat() for large length repeat value

2018-12-16 Thread GitBox
MarkDacek commented on issue #362: Add a check to StringUtils.repeat() for large length repeat value URL: https://github.com/apache/commons-lang/pull/362#issuecomment-447725344 > > I'm somewhat wary of simply comparing the values, as it's not always intuitive and doesn't save us much in

[GitHub] Turan91 commented on issue #362: Add a check to StringUtils.repeat() for large length repeat value

2018-12-22 Thread GitBox
Turan91 commented on issue #362: Add a check to StringUtils.repeat() for large length repeat value URL: https://github.com/apache/commons-lang/pull/362#issuecomment-449603524 Validation checks are validation checks, we can't begin using occurrence to dictate their place. As with any

[GitHub] rosti-il commented on a change in pull request #392: LANG-1410: eliminate one unnecessary local int variable and add more tests

2018-12-18 Thread GitBox
rosti-il commented on a change in pull request #392: LANG-1410: eliminate one unnecessary local int variable and add more tests URL: https://github.com/apache/commons-lang/pull/392#discussion_r242720230 ## File path:

[GitHub] rosti-il commented on a change in pull request #392: LANG-1410: eliminate one unnecessary local int variable and add more tests

2018-12-18 Thread GitBox
rosti-il commented on a change in pull request #392: LANG-1410: eliminate one unnecessary local int variable and add more tests URL: https://github.com/apache/commons-lang/pull/392#discussion_r242720230 ## File path:

[GitHub] eceejcr commented on a change in pull request #392: LANG-1410: eliminate one unnecessary local int variable and add more tests

2018-12-19 Thread GitBox
eceejcr commented on a change in pull request #392: LANG-1410: eliminate one unnecessary local int variable and add more tests URL: https://github.com/apache/commons-lang/pull/392#discussion_r243179720 ## File path: src/main/java/org/apache/commons/lang3/StringUtils.java

[GitHub] Yash-777 edited a comment on issue #395: Replaces the given String, with the String which is nested in between two Strings.

2019-01-09 Thread GitBox
Yash-777 edited a comment on issue #395: Replaces the given String, with the String which is nested in between two Strings. URL: https://github.com/apache/commons-lang/pull/395#issuecomment-452188188 Already i have closed `393, 394` pull requests.

[GitHub] JiangYongKang removed a comment on issue #318: clean code

2019-01-09 Thread GitBox
JiangYongKang removed a comment on issue #318: clean code URL: https://github.com/apache/commons-lang/pull/318#issuecomment-399720458 @stokito thinks This is an automated message from the Apache Git Service. To respond to the

[GitHub] Yash-777 edited a comment on issue #395: Replaces the given String, with the String which is nested in between two Strings.

2019-01-07 Thread GitBox
Yash-777 edited a comment on issue #395: Replaces the given String, with the String which is nested in between two Strings. URL: https://github.com/apache/commons-lang/pull/395#issuecomment-451852546 Can any one explain that, Is the build fails because of an extra added function

[GitHub] ecki commented on issue #395: Replaces the given String, with the String which is nested in between two Strings.

2019-01-07 Thread GitBox
ecki commented on issue #395: Replaces the given String, with the String which is nested in between two Strings. URL: https://github.com/apache/commons-lang/pull/395#issuecomment-452019406 The test States `will fail about 1 in 1000 times`

[GitHub] ecki commented on issue #395: Replaces the given String, with the String which is nested in between two Strings.

2019-01-07 Thread GitBox
ecki commented on issue #395: Replaces the given String, with the String which is nested in between two Strings. URL: https://github.com/apache/commons-lang/pull/395#issuecomment-452019913 Can you please merge your commits to a single one, so it is easier to review and apply.

[GitHub] Yash-777 commented on issue #395: Replaces the given String, with the String which is nested in between two Strings.

2019-01-07 Thread GitBox
Yash-777 commented on issue #395: Replaces the given String, with the String which is nested in between two Strings. URL: https://github.com/apache/commons-lang/pull/395#issuecomment-452188188 Already i have closed the pull requests `393, 394`

[GitHub] kinow commented on issue #379: add tests for use ImmutableTriple as key in java.util.HashMap and java.util.TreeMap

2019-01-07 Thread GitBox
kinow commented on issue #379: add tests for use ImmutableTriple as key in java.util.HashMap and java.util.TreeMap URL: https://github.com/apache/commons-lang/pull/379#issuecomment-452194089 Merged in https://github.com/apache/commons-lang/commit/bf7767867378d9d33551ad54687b48c8fbecf424

[GitHub] kinow closed pull request #379: add tests for use ImmutableTriple as key in java.util.HashMap and java.util.TreeMap

2019-01-07 Thread GitBox
kinow closed pull request #379: add tests for use ImmutableTriple as key in java.util.HashMap and java.util.TreeMap URL: https://github.com/apache/commons-lang/pull/379 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the

[GitHub] kinow commented on issue #379: add tests for use ImmutableTriple as key in java.util.HashMap and java.util.TreeMap

2019-01-07 Thread GitBox
kinow commented on issue #379: add tests for use ImmutableTriple as key in java.util.HashMap and java.util.TreeMap URL: https://github.com/apache/commons-lang/pull/379#issuecomment-452193708 Generated site from `master` branch with `-Pjacoco`. Then stored the site elsewhere.

[GitHub] Yash-777 commented on issue #395: Replaces the given String, with the String which is nested in between two Strings.

2019-01-07 Thread GitBox
Yash-777 commented on issue #395: Replaces the given String, with the String which is nested in between two Strings. URL: https://github.com/apache/commons-lang/pull/395#issuecomment-451852546 Can any one explain that, the build is fail because of extra added function

[GitHub] Yash-777 edited a comment on issue #395: Replaces the given String, with the String which is nested in between two Strings.

2019-01-07 Thread GitBox
Yash-777 edited a comment on issue #395: Replaces the given String, with the String which is nested in between two Strings. URL: https://github.com/apache/commons-lang/pull/395#issuecomment-451852546 Can any one explain that, the build is fail because of extra added function

[GitHub] Yash-777 closed pull request #394: Replace String for reports

2019-01-04 Thread GitBox
Yash-777 closed pull request #394: Replace String for reports URL: https://github.com/apache/commons-lang/pull/394 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request

[GitHub] Yash-777 opened a new pull request #395: Replaces the given String, with the String which is nested in between two Strings.

2019-01-04 Thread GitBox
Yash-777 opened a new pull request #395: Replaces the given String, with the String which is nested in between two Strings. URL: https://github.com/apache/commons-lang/pull/395 Replace String with the String which is nested in between two Strings. I have used this Method in order to

[GitHub] coveralls commented on issue #395: Replaces the given String, with the String which is nested in between two Strings.

2019-01-04 Thread GitBox
coveralls commented on issue #395: Replaces the given String, with the String which is nested in between two Strings. URL: https://github.com/apache/commons-lang/pull/395#issuecomment-451407579 [![Coverage

[GitHub] Yash-777 closed pull request #393: Replace String

2019-01-04 Thread GitBox
Yash-777 closed pull request #393: Replace String URL: https://github.com/apache/commons-lang/pull/393 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a

[GitHub] Yash-777 commented on issue #393: Replace String

2019-01-04 Thread GitBox
Yash-777 commented on issue #393: Replace String URL: https://github.com/apache/commons-lang/pull/393#issuecomment-451380562 I will create new pull request after solving the 7 Checkstyle violations. This is an automated

[GitHub] Yash-777 opened a new pull request #393: Replace String

2019-01-03 Thread GitBox
Yash-777 opened a new pull request #393: Replace String URL: https://github.com/apache/commons-lang/pull/393 Replace String with the String which is nested in between two Strings. I have used this Method in order to generate dynamic HTML reports to send a mail. ```java

[GitHub] Yash-777 opened a new pull request #394: Replace String for reports

2019-01-04 Thread GitBox
Yash-777 opened a new pull request #394: Replace String for reports URL: https://github.com/apache/commons-lang/pull/394 Replace String with the String which is nested in between two Strings. I have used this Method in order to generate dynamic HTML reports to send a mail.

[GitHub] MarkDacek commented on a change in pull request #395: Replaces the given String, with the String which is nested in between two Strings.

2019-01-13 Thread GitBox
MarkDacek commented on a change in pull request #395: Replaces the given String, with the String which is nested in between two Strings. URL: https://github.com/apache/commons-lang/pull/395#discussion_r247361985 ## File path: src/main/java/org/apache/commons/lang3/StringUtils.java

[GitHub] MarkDacek commented on a change in pull request #395: Replaces the given String, with the String which is nested in between two Strings.

2019-01-13 Thread GitBox
MarkDacek commented on a change in pull request #395: Replaces the given String, with the String which is nested in between two Strings. URL: https://github.com/apache/commons-lang/pull/395#discussion_r247361985 ## File path: src/main/java/org/apache/commons/lang3/StringUtils.java

[GitHub] MarkDacek commented on a change in pull request #395: Replaces the given String, with the String which is nested in between two Strings.

2019-01-13 Thread GitBox
MarkDacek commented on a change in pull request #395: Replaces the given String, with the String which is nested in between two Strings. URL: https://github.com/apache/commons-lang/pull/395#discussion_r247361944 ## File path: src/main/java/org/apache/commons/lang3/StringUtils.java

[GitHub] MarkDacek commented on a change in pull request #395: Replaces the given String, with the String which is nested in between two Strings.

2019-01-13 Thread GitBox
MarkDacek commented on a change in pull request #395: Replaces the given String, with the String which is nested in between two Strings. URL: https://github.com/apache/commons-lang/pull/395#discussion_r247362123 ## File path: src/main/java/org/apache/commons/lang3/StringUtils.java

[GitHub] MarkDacek commented on issue #395: Replaces the given String, with the String which is nested in between two Strings.

2019-01-13 Thread GitBox
MarkDacek commented on issue #395: Replaces the given String, with the String which is nested in between two Strings. URL: https://github.com/apache/commons-lang/pull/395#issuecomment-453863749 For one, the default return value should be the original `str`, not null. That way, it would be

[GitHub] MarkDacek commented on a change in pull request #395: Replaces the given String, with the String which is nested in between two Strings.

2019-01-13 Thread GitBox
MarkDacek commented on a change in pull request #395: Replaces the given String, with the String which is nested in between two Strings. URL: https://github.com/apache/commons-lang/pull/395#discussion_r247362069 ## File path: src/main/java/org/apache/commons/lang3/StringUtils.java

[GitHub] MarkDacek commented on a change in pull request #395: Replaces the given String, with the String which is nested in between two Strings.

2019-01-13 Thread GitBox
MarkDacek commented on a change in pull request #395: Replaces the given String, with the String which is nested in between two Strings. URL: https://github.com/apache/commons-lang/pull/395#discussion_r247362055 ## File path: src/main/java/org/apache/commons/lang3/StringUtils.java

[GitHub] MarkDacek commented on a change in pull request #395: Replaces the given String, with the String which is nested in between two Strings.

2019-01-13 Thread GitBox
MarkDacek commented on a change in pull request #395: Replaces the given String, with the String which is nested in between two Strings. URL: https://github.com/apache/commons-lang/pull/395#discussion_r247362048 ## File path: src/main/java/org/apache/commons/lang3/StringUtils.java

[GitHub] zmacomber commented on issue #358: ClassUtils.getBaseClasses(desiredBase, packageName)

2018-12-28 Thread GitBox
zmacomber commented on issue #358: ClassUtils.getBaseClasses(desiredBase, packageName) URL: https://github.com/apache/commons-lang/pull/358#issuecomment-450391993 Have not heard anything on this PR for 2 months. Should I just close this PR? This doesn't seem like the way open source

[GitHub] ecki commented on a change in pull request #358: ClassUtils.getBaseClasses(desiredBase, packageName)

2018-12-28 Thread GitBox
ecki commented on a change in pull request #358: ClassUtils.getBaseClasses(desiredBase, packageName) URL: https://github.com/apache/commons-lang/pull/358#discussion_r244365437 ## File path: src/main/java/org/apache/commons/lang3/ClassUtils.java ## @@ -1059,6 +1067,62 @@

[GitHub] ecki commented on a change in pull request #358: ClassUtils.getBaseClasses(desiredBase, packageName)

2018-12-28 Thread GitBox
ecki commented on a change in pull request #358: ClassUtils.getBaseClasses(desiredBase, packageName) URL: https://github.com/apache/commons-lang/pull/358#discussion_r244365537 ## File path: src/main/java/org/apache/commons/lang3/ClassUtils.java ## @@ -1059,6 +1067,85 @@

[GitHub] zmacomber commented on a change in pull request #358: ClassUtils.getBaseClasses(desiredBase, packageName)

2018-12-28 Thread GitBox
zmacomber commented on a change in pull request #358: ClassUtils.getBaseClasses(desiredBase, packageName) URL: https://github.com/apache/commons-lang/pull/358#discussion_r244380194 ## File path: src/main/java/org/apache/commons/lang3/ClassUtils.java ## @@ -1059,6 +1067,62

[GitHub] zmacomber commented on a change in pull request #358: ClassUtils.getBaseClasses(desiredBase, packageName)

2018-12-28 Thread GitBox
zmacomber commented on a change in pull request #358: ClassUtils.getBaseClasses(desiredBase, packageName) URL: https://github.com/apache/commons-lang/pull/358#discussion_r244380396 ## File path: src/main/java/org/apache/commons/lang3/ClassUtils.java ## @@ -1059,6 +1067,85

[GitHub] zmacomber commented on a change in pull request #358: ClassUtils.getBaseClasses(desiredBase, packageName)

2018-12-28 Thread GitBox
zmacomber commented on a change in pull request #358: ClassUtils.getBaseClasses(desiredBase, packageName) URL: https://github.com/apache/commons-lang/pull/358#discussion_r244380396 ## File path: src/main/java/org/apache/commons/lang3/ClassUtils.java ## @@ -1059,6 +1067,85

[GitHub] Yash-777 commented on a change in pull request #395: Replaces the given String, with the String which is nested in between two Strings.

2019-01-14 Thread GitBox
Yash-777 commented on a change in pull request #395: Replaces the given String, with the String which is nested in between two Strings. URL: https://github.com/apache/commons-lang/pull/395#discussion_r247473007 ## File path: src/main/java/org/apache/commons/lang3/StringUtils.java

[GitHub] asciborek commented on a change in pull request #392: LANG-1410: eliminate one unnecessary local int variable and add more tests

2018-12-19 Thread GitBox
asciborek commented on a change in pull request #392: LANG-1410: eliminate one unnecessary local int variable and add more tests URL: https://github.com/apache/commons-lang/pull/392#discussion_r243089452 ## File path: src/main/java/org/apache/commons/lang3/StringUtils.java

[GitHub] rosti-il commented on a change in pull request #392: LANG-1410: eliminate one unnecessary local int variable and add more tests

2018-12-19 Thread GitBox
rosti-il commented on a change in pull request #392: LANG-1410: eliminate one unnecessary local int variable and add more tests URL: https://github.com/apache/commons-lang/pull/392#discussion_r243110330 ## File path: src/main/java/org/apache/commons/lang3/StringUtils.java

[GitHub] rosti-il commented on issue #392: LANG-1410: eliminate one unnecessary local int variable and add more tests

2018-12-18 Thread GitBox
rosti-il commented on issue #392: LANG-1410: eliminate one unnecessary local int variable and add more tests URL: https://github.com/apache/commons-lang/pull/392#issuecomment-448407328 Force-pushed twice from 27b1742 to 9d8ac06 and then back from 9d8ac06 to 27b1742 because of a confusion

[GitHub] MarkDacek commented on a change in pull request #392: LANG-1410: eliminate one unnecessary local int variable and add more tests

2018-12-19 Thread GitBox
MarkDacek commented on a change in pull request #392: LANG-1410: eliminate one unnecessary local int variable and add more tests URL: https://github.com/apache/commons-lang/pull/392#discussion_r243150110 ## File path: src/main/java/org/apache/commons/lang3/StringUtils.java

[GitHub] [commons-rng] asfgit merged pull request #33: RNG-87: Advance MultiplyWithCarry256 state one index per nextInt() call.

2019-04-02 Thread GitBox
asfgit merged pull request #33: RNG-87: Advance MultiplyWithCarry256 state one index per nextInt() call. URL: https://github.com/apache/commons-rng/pull/33 This is an automated message from the Apache Git Service. To

[GitHub] [commons-vfs] garydgregory commented on issue #28: fixed for AbstractFileObject#toString leak password!

2019-04-02 Thread GitBox
garydgregory commented on issue #28: fixed for AbstractFileObject#toString leak password! URL: https://github.com/apache/commons-vfs/pull/28#issuecomment-478961351 Any thoughts on the likelihood of this breaking existing apps?

[GitHub] [commons-vfs] garydgregory commented on issue #52: VFS-686: webdav4 provider based on the latest Jackrabbit 2.x

2019-04-02 Thread GitBox
garydgregory commented on issue #52: VFS-686: webdav4 provider based on the latest Jackrabbit 2.x URL: https://github.com/apache/commons-vfs/pull/52#issuecomment-478964021 Hi @woonsan , To be clear, the tests are still failing :-( Gary

[GitHub] [commons-vfs] boris-petrov opened a new pull request #57: Simplify adding files to DefaultFileMonitor

2019-04-02 Thread GitBox
boris-petrov opened a new pull request #57: Simplify adding files to DefaultFileMonitor URL: https://github.com/apache/commons-vfs/pull/57 The original code tried adding recursively the children twice - once in `doAddFile` and then again in `addFile` itself. This is now simplified.

[GitHub] [commons-vfs] woonsan commented on issue #52: VFS-686: webdav4 provider based on the latest Jackrabbit 2.x

2019-04-02 Thread GitBox
woonsan commented on issue #52: VFS-686: webdav4 provider based on the latest Jackrabbit 2.x URL: https://github.com/apache/commons-vfs/pull/52#issuecomment-479276504 @garydgregory , just fyi, I'm trying to figure out how to reproduce this locally. Strangely, my local tests were

[GitHub] [commons-vfs] woonsan commented on issue #52: VFS-686: webdav4 provider based on the latest Jackrabbit 2.x

2019-04-02 Thread GitBox
woonsan commented on issue #52: VFS-686: webdav4 provider based on the latest Jackrabbit 2.x URL: https://github.com/apache/commons-vfs/pull/52#issuecomment-479279513 Hi @garydgregory , I think I found the cause. It's all my bad. For some reason -- probably due to my git env setting, some

[GitHub] [commons-geometry] darkma773r commented on a change in pull request #31: Geometry 29 2 sven

2019-04-02 Thread GitBox
darkma773r commented on a change in pull request #31: Geometry 29 2 sven URL: https://github.com/apache/commons-geometry/pull/31#discussion_r271548014 ## File path: commons-geometry-euclidean/src/main/java/org/apache/commons/geometry/euclidean/threed/Plane.java ## @@

[GitHub] [commons-geometry] darkma773r commented on a change in pull request #31: Geometry 29 2 sven

2019-04-02 Thread GitBox
darkma773r commented on a change in pull request #31: Geometry 29 2 sven URL: https://github.com/apache/commons-geometry/pull/31#discussion_r271548380 ## File path: commons-geometry-euclidean/src/main/java/org/apache/commons/geometry/euclidean/threed/Line.java ## @@

[GitHub] [commons-vfs] garydgregory commented on issue #52: VFS-686: webdav4 provider based on the latest Jackrabbit 2.x

2019-04-02 Thread GitBox
garydgregory commented on issue #52: VFS-686: webdav4 provider based on the latest Jackrabbit 2.x URL: https://github.com/apache/commons-vfs/pull/52#issuecomment-479299314 Hi @woonsan, What is the status of this PR? Is it still "Not ready for merge"? Gary

[GitHub] [commons-vfs] woonsan commented on issue #52: VFS-686: webdav4 provider based on the latest Jackrabbit 2.x

2019-04-02 Thread GitBox
woonsan commented on issue #52: VFS-686: webdav4 provider based on the latest Jackrabbit 2.x URL: https://github.com/apache/commons-vfs/pull/52#issuecomment-479304944 Hi @garydgregory , Yet not ready status because jackrabbit3 submodule depends on the following (in root pom): >

[GitHub] [commons-vfs] woonsan commented on issue #52: [Not to merge - JR snapshot dep] VFS-686: webdav4 provider based on the latest Jackrabbit 2.x

2019-04-03 Thread GitBox
woonsan commented on issue #52: [Not to merge - JR snapshot dep] VFS-686: webdav4 provider based on the latest Jackrabbit 2.x URL: https://github.com/apache/commons-vfs/pull/52#issuecomment-479416774 Hi @garydgregory , I figured out how to make this PR reviewable and mergeable right now:

[GitHub] [commons-io] col-panic opened a new pull request #76: Refactor io.monitor to support alternativ file entities

2019-03-27 Thread GitBox
col-panic opened a new pull request #76: Refactor io.monitor to support alternativ file entities URL: https://github.com/apache/commons-io/pull/76 I want to combine the io.monitor with the https://github.com/hierynomus/smbj project, to realize a SMB capable io monitor. In order to achieve

[GitHub] [commons-geometry] darkma773r commented on a change in pull request #31: Geometry 29 2 sven

2019-03-25 Thread GitBox
darkma773r commented on a change in pull request #31: Geometry 29 2 sven URL: https://github.com/apache/commons-geometry/pull/31#discussion_r268941832 ## File path: commons-geometry-euclidean/src/main/java/org/apache/commons/geometry/euclidean/threed/Plane.java ## @@

[GitHub] [commons-geometry] darkma773r commented on a change in pull request #31: Geometry 29 2 sven

2019-03-25 Thread GitBox
darkma773r commented on a change in pull request #31: Geometry 29 2 sven URL: https://github.com/apache/commons-geometry/pull/31#discussion_r268946414 ## File path: commons-geometry-euclidean/src/main/java/org/apache/commons/geometry/euclidean/threed/Plane.java ## @@

[GitHub] [commons-geometry] darkma773r commented on a change in pull request #31: Geometry 29 2 sven

2019-03-25 Thread GitBox
darkma773r commented on a change in pull request #31: Geometry 29 2 sven URL: https://github.com/apache/commons-geometry/pull/31#discussion_r268943199 ## File path: commons-geometry-euclidean/src/main/java/org/apache/commons/geometry/euclidean/threed/Plane.java ## @@

[GitHub] [commons-geometry] darkma773r commented on a change in pull request #31: Geometry 29 2 sven

2019-03-25 Thread GitBox
darkma773r commented on a change in pull request #31: Geometry 29 2 sven URL: https://github.com/apache/commons-geometry/pull/31#discussion_r268945594 ## File path: commons-geometry-euclidean/src/main/java/org/apache/commons/geometry/euclidean/threed/Plane.java ## @@

  1   2   3   4   5   6   7   8   9   10   >