GitHub user jodastephen opened a pull request:
https://github.com/apache/commons-lang/pull/299
Add module-info for Java 9
Add the module-info.java file
Make the appropriate changes to pom.xml
You can merge this pull request into a Git repository by running:
$ git pull
Github user jodastephen commented on a diff in the pull request:
https://github.com/apache/commons-lang/pull/299#discussion_r144119796
--- Diff: .travis.yml ---
@@ -17,12 +17,10 @@ language: java
sudo: false
jdk:
- - openjdk7
--- End diff
Github user jodastephen commented on a diff in the pull request:
https://github.com/apache/commons-lang/pull/299#discussion_r147859782
--- Diff: .travis.yml ---
@@ -21,8 +21,19 @@ jdk:
- oraclejdk8
- oraclejdk9
+cache:
+ directories:
+- "
Github user jodastephen commented on the issue:
https://github.com/apache/commons-lang/pull/299
`mvn install` works fine on each JDK version AFAICT. `mvn site` still
breaks on cobertura on Java 9 and I'm not sure I can work around it without
removing it from the parent pom.
---
Github user jodastephen commented on the issue:
https://github.com/apache/commons-lang/pull/299
@namannigam You need to check it out and run `mvn clean install site` on
Java 9.
---
Github user jodastephen commented on the issue:
https://github.com/apache/commons-lang/pull/275
Thanks @kinow , this seems like the right solution. Now the module-info can
just use `require static` to avoid creating a full dependency on the awkward
three classes and users have
Github user jodastephen commented on the issue:
https://github.com/apache/commons-lang/pull/275
The PR is indeed backwards incompatible.
My suggestion would be to add two new classes with the fixed code
(different class names), and deprecated the old classes. That way
Github user jodastephen commented on the issue:
https://github.com/apache/commons-lang/pull/299
@michaelsavich , this PR does not create a full dependency on
`java.desktop`. The dependency is expressed as `requires static`, which means
that it will not be pulled in by default. Users
GitHub user jodastephen opened a pull request:
https://github.com/apache/commons-lang/pull/304
Fix DateUtilsTest to work reliably on Java 9
Fixes failures due to MST time-zone not being formatted as "MST"
Also sets and unsets time-zones in finally blocks
to avoid
Github user jodastephen commented on the issue:
https://github.com/apache/commons-lang/pull/304
Test failure looks like a timing issue unrelated to this PR
---
Github user jodastephen commented on a diff in the pull request:
https://github.com/apache/commons-lang/pull/299#discussion_r147424665
--- Diff: src/main/java/module-info.java ---
@@ -0,0 +1,41 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
Github user jodastephen commented on the issue:
https://github.com/apache/commons-lang/pull/299
Adding `module-info` causes some older/Android projects to fail as they
can't handle the class format. So, projects are left with the choice of moving
forwards or breaking these older
Github user jodastephen commented on the issue:
https://github.com/apache/commons-lang/pull/299
Its not just compiling, there are issues at runtime still AFAIK, especially
with Java EE and older bytecode libraries.
---
Github user jodastephen commented on the issue:
https://github.com/apache/commons-lang/pull/299
There is a lot of complexity in commons-parent and commons generally.
Getting a build to work for Joda was hard enough, and there I am willing to
insist on releases being done on Java 9
14 matches
Mail list logo
