[GitHub] commons-lang issue #282: SwappedPair constructed as Pair.of(rhs,lhs)

2017-08-13 Thread namannigam
Github user namannigam commented on the issue: https://github.com/apache/commons-lang/pull/282 @kinow @garydgregory Sure would try to come back soon with a unit test for the use-case. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] commons-lang pull request #282: SwappedPair constructed as Pair.of(rhs,lhs)

2017-08-09 Thread namannigam
GitHub user namannigam opened a pull request: https://github.com/apache/commons-lang/pull/282 SwappedPair constructed as Pair.of(rhs,lhs) There seems to be a bug in the current implementation of the `isRegistered` implementation, where the `swappedPair` is constructed similarly

[GitHub] commons-lang issue #299: Add module-info for Java 9

2017-10-30 Thread namannigam
Github user namannigam commented on the issue: https://github.com/apache/commons-lang/pull/299 @jodastephen What's the error that you get with site? Any links to the build? ---

[GitHub] commons-lang pull request #299: Add module-info for Java 9

2017-10-27 Thread namannigam
Github user namannigam commented on a diff in the pull request: https://github.com/apache/commons-lang/pull/299#discussion_r147422522 --- Diff: src/main/java/module-info.java --- @@ -0,0 +1,41 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more