Github user ottobackwards closed the pull request at:
https://github.com/apache/commons-lang/pull/311
---
Github user ottobackwards commented on the issue:
https://github.com/apache/commons-lang/pull/311
giving up: https://github.com/palindromicity/stackwatch
---
Github user ottobackwards commented on the issue:
https://github.com/apache/commons-lang/pull/311
bump
---
Github user ottobackwards commented on the issue:
https://github.com/apache/commons-lang/pull/311
You bet, thanks. If there is any guide that I should be following let me
know.
---
Github user ottobackwards commented on the issue:
https://github.com/apache/commons-lang/pull/311
Thanks, I did try to follow that, I use travis so the different java builds
worked. I used the local checkstyle xml, and through I had caught everything.
---
Github user ottobackwards commented on the issue:
https://github.com/apache/commons-lang/pull/311
Do I have to do something to get my stuff added to the reports in the local
site? I see my tests run in the cli, but they are not in the reports, or the
java doc etc
---
Github user ottobackwards commented on the issue:
https://github.com/apache/commons-lang/pull/311
maybe i didn't run clean, i'll try again
---
Github user ottobackwards commented on the issue:
https://github.com/apache/commons-lang/pull/311
The reports actually look good for my stuff, except the coverage stuff, if
I am reading this correctly
---
Github user ottobackwards commented on the issue:
https://github.com/apache/commons-lang/pull/311
OK, I wasn't looking in target, I have the reports. smh.
---
Github user ottobackwards commented on the issue:
https://github.com/apache/commons-lang/pull/311
I will take care of it :)
---
Github user ottobackwards commented on the issue:
https://github.com/apache/commons-lang/pull/311
Close and re-open to kick travis. My travis built fine, not sure why
apache failed
---
GitHub user ottobackwards reopened a pull request:
https://github.com/apache/commons-lang/pull/311
LANG-1373 Stopwatch based capability for nested, named, timings
There are times when you want to do a number or related timings across a
sequence of calls or operations
Github user ottobackwards closed the pull request at:
https://github.com/apache/commons-lang/pull/311
---
Github user ottobackwards commented on the issue:
https://github.com/apache/commons-lang/pull/311
I am so sorry, I'll take care of it.
---
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/commons-lang/pull/311#discussion_r164283889
--- Diff: src/main/java/org/apache/commons/lang3/time/TimingRecordNode.java
---
@@ -0,0 +1,222 @@
+/*
+ * Licensed to the Apache
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/commons-lang/pull/311#discussion_r164283887
--- Diff: src/main/java/org/apache/commons/lang3/time/TimingRecordNode.java
---
@@ -0,0 +1,222 @@
+/*
+ * Licensed to the Apache
Github user ottobackwards commented on the issue:
https://github.com/apache/commons-lang/pull/311
bump
---
Github user ottobackwards commented on the issue:
https://github.com/apache/commons-lang/pull/311
would a rebase -i with FIXUP work? What git command would *you* run? Do
we have to worry about authorship?
---
Github user ottobackwards commented on the issue:
https://github.com/apache/commons-lang/pull/311
yes, i'm interested on your take on the jira stuff from today @kinow
---
Github user ottobackwards commented on the issue:
https://github.com/apache/commons-lang/pull/311
Just a note, discussion of this issue has been split between here and the
jira issue.
---
GitHub user ottobackwards opened a pull request:
https://github.com/apache/commons-lang/pull/311
LANG-1373 Stopwatch based capability for nested, named, timings
There are times when you want to do a number or related timings across a
sequence of calls or operations
Github user ottobackwards commented on the issue:
https://github.com/apache/commons-lang/pull/311
```java
Optional watchOptional = state.context.getWatch();
watchOptional.ifPresent((sw) -> sw.startTiming("lambda", "LAMBDA"));
Object re
Github user ottobackwards commented on the issue:
https://github.com/apache/commons-lang/pull/311
Try on the overall watch would have to behave differently, as it would both
close the watch and stop the root timing...
---
Github user ottobackwards commented on the issue:
https://github.com/apache/commons-lang/pull/311
To do try with resources we would have to have do nothing default returns
right?
---
Github user ottobackwards commented on the issue:
https://github.com/apache/commons-lang/pull/311
Maybe there should be a commons-examples project with the src for examples?
The java doc examples could come from there
---
Github user ottobackwards commented on the issue:
https://github.com/apache/commons-lang/pull/311
Sorry @garydgregory I understood you to mean it would be optional.
So, the context of the creation of this idea is I did it for an environment
where we have optional available
Github user ottobackwards commented on the issue:
https://github.com/apache/commons-lang/pull/311
That doesn't mean I don't want to re-visit the idea
---
Github user ottobackwards commented on the issue:
https://github.com/apache/commons-lang/pull/311
I did think of that at the start. There were two issues for me:
1. I didn't want to expose the internal node to the caller and complicate
the interface
2. In my scenario
Github user ottobackwards commented on the issue:
https://github.com/apache/commons-lang/pull/311
bump?
---
Github user ottobackwards commented on the issue:
https://github.com/apache/commons-lang/pull/311
@garydgregory, since we are getting out of code review / pr and into bigger
issues, can we move your comments to jira? Gilles doesn't have github and the
conversation will make more
Github user ottobackwards commented on the issue:
https://github.com/apache/commons-lang/pull/311
@garydgregory @kinow I added the static method. I did not squash/rebase
though. I will if you need me to but I want the review.
---
Github user ottobackwards commented on the issue:
https://github.com/apache/commons-lang/pull/311
the static factory, is pretty straight forward.
The try with resources, less so. What ends up happening is you cannot stop
the watch before visiting the nodes.
For example
Github user ottobackwards commented on the issue:
https://github.com/apache/commons-lang/pull/311
same with the static factory:
```java
@Test
public void testTryWithResourcesStaticFactory() {
final StopWatch stopWatch = new StopWatch
33 matches
Mail list logo
