[GitHub] [commons-collections] Claudenw commented on issue #83: Initial bloom filter code contribution

2020-01-22 Thread GitBox
Claudenw commented on issue #83: Initial bloom filter code contribution URL: https://github.com/apache/commons-collections/pull/83#issuecomment-577295181 Hello @kinow A `HashFunctionIdentity` without the a `HashFunction` would be used where ever there is a remote system that is

[GitHub] [commons-collections] Claudenw commented on issue #83: Initial bloom filter code contribution

2020-01-21 Thread GitBox
Claudenw commented on issue #83: Initial bloom filter code contribution URL: https://github.com/apache/commons-collections/pull/83#issuecomment-577048235 What are the next steps? On Sun, Jan 19, 2020 at 12:34 AM Gary Gregory wrote: > *@garydgregory* approved this pull

[GitHub] [commons-collections] Claudenw commented on issue #83: Initial bloom filter code contribution

2020-01-12 Thread GitBox
Claudenw commented on issue #83: Initial bloom filter code contribution URL: https://github.com/apache/commons-collections/pull/83#issuecomment-573396667 > ## HashFunctionIdentity > > I thought it was an identity as seen in some functional programming libs/ > code. As when

[GitHub] [commons-collections] Claudenw commented on issue #83: Initial bloom filter code contribution

2020-01-05 Thread GitBox
Claudenw commented on issue #83: Initial bloom filter code contribution URL: https://github.com/apache/commons-collections/pull/83#issuecomment-570903095 Done On Sat, Jan 4, 2020 at 4:35 PM Gary Gregory wrote: > *@garydgregory* requested changes on this pull request. >

[GitHub] [commons-collections] Claudenw commented on issue #83: Initial bloom filter code contribution

2019-12-15 Thread GitBox
Claudenw commented on issue #83: Initial bloom filter code contribution URL: https://github.com/apache/commons-collections/pull/83#issuecomment-565797418 HashFunctionIdentity was added to replace the HashFunction name. The identity contains the function name, Signedness, and ProcessType

[GitHub] [commons-collections] Claudenw commented on issue #83: Initial bloom filter code contribution

2019-11-29 Thread GitBox
Claudenw commented on issue #83: Initial bloom filter code contribution URL: https://github.com/apache/commons-collections/pull/83#issuecomment-559850739 Will someone please comment on this pull request or approve it? This

[GitHub] [commons-collections] Claudenw commented on issue #83: Initial bloom filter code contribution

2019-11-24 Thread GitBox
Claudenw commented on issue #83: Initial bloom filter code contribution URL: https://github.com/apache/commons-collections/pull/83#issuecomment-557871331 Are there any open issues against this pull request. The latest change places a dependency on commons-codec 1.14-SNAPSHOT so that

[GitHub] [commons-collections] Claudenw commented on issue #83: Initial bloom filter code contribution

2019-11-09 Thread GitBox
Claudenw commented on issue #83: Initial bloom filter code contribution URL: https://github.com/apache/commons-collections/pull/83#issuecomment-552110051 Changed from WIP This is an automated message from the Apache Git