[GitHub] commons-lang pull request #163: LANG-1197: Prepare Java 9 detection
Github user asfgit closed the pull request at: https://github.com/apache/commons-lang/pull/163 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] commons-lang pull request #163: LANG-1197: Prepare Java 9 detection (unfinis...
GitHub user PascalSchumacher reopened a pull request: https://github.com/apache/commons-lang/pull/163 LANG-1197: Prepare Java 9 detection (unfinished) Not complete: `JavaVersion` expects the `java.version` system property to return `1.x` but for java 9 it will return `9*`. Not sure how to handle this. You can merge this pull request into a Git repository by running: $ git pull https://github.com/PascalSchumacher/commons-lang java_9 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/commons-lang/pull/163.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #163 commit 96dc0638d5220b7835093d08fdead7d46bee1120 Author: pascalschumacher Date: 2016-05-20T17:29:20Z LANG-1197: Prepare Java 9 detection (unfinished) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] commons-lang pull request #163: LANG-1197: Prepare Java 9 detection (unfinis...
Github user PascalSchumacher closed the pull request at: https://github.com/apache/commons-lang/pull/163 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] commons-lang pull request #163: LANG-1197: Prepare Java 9 detection (unfinis...
Github user britter commented on a diff in the pull request:
https://github.com/apache/commons-lang/pull/163#discussion_r78301302
--- Diff: src/main/java/org/apache/commons/lang3/JavaVersion.java ---
@@ -72,8 +72,15 @@
/**
* Java 1.9.
+ *
+ * @deprecated As of release 3.5, replaced by {@link #JAVA_9}
+ */
+JAVA_1_9(1.9f, "9"),
+
+/**
+ * Java 9
*/
-JAVA_1_9(1.9f, "1.9"),
+JAVA_9(1.9f, "9"),
--- End diff --
I agree with Michael
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] commons-lang pull request #163: LANG-1197: Prepare Java 9 detection (unfinis...
Github user michael-o commented on a diff in the pull request:
https://github.com/apache/commons-lang/pull/163#discussion_r65946021
--- Diff: src/main/java/org/apache/commons/lang3/JavaVersion.java ---
@@ -72,8 +72,15 @@
/**
* Java 1.9.
+ *
+ * @deprecated As of release 3.5, replaced by {@link #JAVA_9}
+ */
+JAVA_1_9(1.9f, "9"),
+
+/**
+ * Java 9
*/
-JAVA_1_9(1.9f, "1.9"),
+JAVA_9(1.9f, "9"),
--- End diff --
`1.9f`? This should rather be `9.0f`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] commons-lang pull request #163: LANG-1197: Prepare Java 9 detection (unfinis...
GitHub user PascalSchumacher opened a pull request: https://github.com/apache/commons-lang/pull/163 LANG-1197: Prepare Java 9 detection (unfinished) Not complete: `JavaVersion` expects the `java.version` system property to return `1.x` but for java 9 it will return `9*`. Not sure how to handle this. You can merge this pull request into a Git repository by running: $ git pull https://github.com/PascalSchumacher/commons-lang java_9 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/commons-lang/pull/163.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #163 commit 96dc0638d5220b7835093d08fdead7d46bee1120 Author: pascalschumacher Date: 2016-05-20T17:29:20Z LANG-1197: Prepare Java 9 detection (unfinished) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
