[jira] [Commented] (COLLECTIONS-685) IterableUtils has public constructor
[ https://issues.apache.org/jira/browse/COLLECTIONS-685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16510262#comment-16510262 ] ASF GitHub Bot commented on COLLECTIONS-685: Github user sfuhrm commented on the issue: https://github.com/apache/commons-collections/pull/40 Closing because of breaking the API. May be interesting for commons-cli 5.0. > IterableUtils has public constructor > > > Key: COLLECTIONS-685 > URL: https://issues.apache.org/jira/browse/COLLECTIONS-685 > Project: Commons Collections > Issue Type: Bug > Components: Collection >Reporter: Stephan Fuhrmann >Priority: Trivial > Fix For: 5.0 > > > IterableUtils has public constructor. All other Utils classes have their > constructor made private to prohibit instantiation. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (COLLECTIONS-685) IterableUtils has public constructor
[ https://issues.apache.org/jira/browse/COLLECTIONS-685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16510263#comment-16510263 ] ASF GitHub Bot commented on COLLECTIONS-685: Github user sfuhrm closed the pull request at: https://github.com/apache/commons-collections/pull/40 > IterableUtils has public constructor > > > Key: COLLECTIONS-685 > URL: https://issues.apache.org/jira/browse/COLLECTIONS-685 > Project: Commons Collections > Issue Type: Bug > Components: Collection >Reporter: Stephan Fuhrmann >Priority: Trivial > Fix For: 5.0 > > > IterableUtils has public constructor. All other Utils classes have their > constructor made private to prohibit instantiation. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (COLLECTIONS-685) IterableUtils has public constructor
[ https://issues.apache.org/jira/browse/COLLECTIONS-685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16510264#comment-16510264 ] ASF GitHub Bot commented on COLLECTIONS-685: Github user sfuhrm closed the pull request at: https://github.com/apache/commons-collections/pull/40 > IterableUtils has public constructor > > > Key: COLLECTIONS-685 > URL: https://issues.apache.org/jira/browse/COLLECTIONS-685 > Project: Commons Collections > Issue Type: Bug > Components: Collection >Reporter: Stephan Fuhrmann >Priority: Trivial > Fix For: 5.0 > > > IterableUtils has public constructor. All other Utils classes have their > constructor made private to prohibit instantiation. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (COLLECTIONS-685) IterableUtils has public constructor
[ https://issues.apache.org/jira/browse/COLLECTIONS-685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16510261#comment-16510261 ] Stephan Fuhrmann commented on COLLECTIONS-685: -- [~garydgregory] thanks for your review! I undestand your view of the situation. I'll close the PR so no one needs to bother about this. This ticket can stay open as a reminder. > IterableUtils has public constructor > > > Key: COLLECTIONS-685 > URL: https://issues.apache.org/jira/browse/COLLECTIONS-685 > Project: Commons Collections > Issue Type: Bug > Components: Collection >Reporter: Stephan Fuhrmann >Priority: Trivial > Fix For: 5.0 > > > IterableUtils has public constructor. All other Utils classes have their > constructor made private to prohibit instantiation. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (COLLECTIONS-685) IterableUtils has public constructor
[ https://issues.apache.org/jira/browse/COLLECTIONS-685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16509946#comment-16509946 ] Gary Gregory commented on COLLECTIONS-685: -- You cannot make a public API private without breaking binary compatiblity, so this is a no go in 4.x but would be OK for 5.0. > IterableUtils has public constructor > > > Key: COLLECTIONS-685 > URL: https://issues.apache.org/jira/browse/COLLECTIONS-685 > Project: Commons Collections > Issue Type: Bug > Components: Collection >Reporter: Stephan Fuhrmann >Priority: Trivial > > IterableUtils has public constructor. All other Utils classes have their > constructor made private to prohibit instantiation. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (COLLECTIONS-685) IterableUtils has public constructor
[ https://issues.apache.org/jira/browse/COLLECTIONS-685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16509230#comment-16509230 ] ASF GitHub Bot commented on COLLECTIONS-685: Github user sfuhrm commented on the issue: https://github.com/apache/commons-collections/pull/40 BTW, TravisCI is right, technically this is an API change, but I suggest that all API uses are neither useful nor make sense. > IterableUtils has public constructor > > > Key: COLLECTIONS-685 > URL: https://issues.apache.org/jira/browse/COLLECTIONS-685 > Project: Commons Collections > Issue Type: Bug > Components: Collection >Reporter: Stephan Fuhrmann >Priority: Trivial > > IterableUtils has public constructor. All other Utils classes have their > constructor made private to prohibit instantiation. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (COLLECTIONS-685) IterableUtils has public constructor
[ https://issues.apache.org/jira/browse/COLLECTIONS-685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16509227#comment-16509227 ] ASF GitHub Bot commented on COLLECTIONS-685: GitHub user sfuhrm opened a pull request: https://github.com/apache/commons-collections/pull/40 COLLECTIONS-685: IterableUtils has public constructor Constructor for Utils class was not private. This was obviously not intended as all other Utils classes have private constructors. You can merge this pull request into a Git repository by running: $ git pull https://github.com/sfuhrm/commons-collections COLLECTIONS-685 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/commons-collections/pull/40.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #40 commit 49bc94faccddc2f81ce8af1db2bce8ccbede82d9 Author: Stephan Fuhrmann Date: 2018-06-12T06:02:06Z Constructor for Utils class was not private. This was obviously not intended as all other Utils classes have private constructors. > IterableUtils has public constructor > > > Key: COLLECTIONS-685 > URL: https://issues.apache.org/jira/browse/COLLECTIONS-685 > Project: Commons Collections > Issue Type: Bug > Components: Collection >Reporter: Stephan Fuhrmann >Priority: Trivial > > IterableUtils has public constructor. All other Utils classes have their > constructor made private to prohibit instantiation. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (COLLECTIONS-685) IterableUtils has public constructor
[ https://issues.apache.org/jira/browse/COLLECTIONS-685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16509226#comment-16509226 ] ASF GitHub Bot commented on COLLECTIONS-685: GitHub user sfuhrm opened a pull request: https://github.com/apache/commons-collections/pull/40 COLLECTIONS-685: IterableUtils has public constructor Constructor for Utils class was not private. This was obviously not intended as all other Utils classes have private constructors. You can merge this pull request into a Git repository by running: $ git pull https://github.com/sfuhrm/commons-collections COLLECTIONS-685 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/commons-collections/pull/40.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #40 commit 49bc94faccddc2f81ce8af1db2bce8ccbede82d9 Author: Stephan Fuhrmann Date: 2018-06-12T06:02:06Z Constructor for Utils class was not private. This was obviously not intended as all other Utils classes have private constructors. > IterableUtils has public constructor > > > Key: COLLECTIONS-685 > URL: https://issues.apache.org/jira/browse/COLLECTIONS-685 > Project: Commons Collections > Issue Type: Bug > Components: Collection >Reporter: Stephan Fuhrmann >Priority: Trivial > > IterableUtils has public constructor. All other Utils classes have their > constructor made private to prohibit instantiation. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
