[jira] [Commented] (IO-572) Refactor duplicate code in org.apache.commons.io.FileUtils
[ https://issues.apache.org/jira/browse/IO-572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16506255#comment-16506255 ] ASF GitHub Bot commented on IO-572: --- Github user asfgit closed the pull request at: https://github.com/apache/commons-io/pull/57 > Refactor duplicate code in org.apache.commons.io.FileUtils > -- > > Key: IO-572 > URL: https://issues.apache.org/jira/browse/IO-572 > Project: Commons IO > Issue Type: Improvement >Affects Versions: 2.6 >Reporter: Pranet Verma >Assignee: Gary Gregory >Priority: Minor > Labels: refactor > Fix For: 2.7 > > > There is some duplicate code in the moveFile / moveDirectory methods as well > as in the listFiles and listFilesAndDirectoriesMethod -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IO-572) Refactor duplicate code in org.apache.commons.io.FileUtils
[ https://issues.apache.org/jira/browse/IO-572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16394310#comment-16394310 ] Pranet Verma commented on IO-572: - Makes sense. Thanks a lot for the clarification! > Refactor duplicate code in org.apache.commons.io.FileUtils > -- > > Key: IO-572 > URL: https://issues.apache.org/jira/browse/IO-572 > Project: Commons IO > Issue Type: Improvement >Affects Versions: 2.6 >Reporter: Pranet Verma >Assignee: Gary Gregory >Priority: Minor > Labels: refactor > Fix For: 2.7 > > > There is some duplicate code in the moveFile / moveDirectory methods as well > as in the listFiles and listFilesAndDirectoriesMethod -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IO-572) Refactor duplicate code in org.apache.commons.io.FileUtils
[ https://issues.apache.org/jira/browse/IO-572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16394308#comment-16394308 ] Gary Gregory commented on IO-572: - GitHub is a mirror of the Apache GitHub repo, so we cannot merge directly with GitHub. I just took the patch file for your PR and applied it to my local Apache Git repo. > Refactor duplicate code in org.apache.commons.io.FileUtils > -- > > Key: IO-572 > URL: https://issues.apache.org/jira/browse/IO-572 > Project: Commons IO > Issue Type: Improvement >Affects Versions: 2.6 >Reporter: Pranet Verma >Assignee: Gary Gregory >Priority: Minor > Labels: refactor > Fix For: 2.7 > > > There is some duplicate code in the moveFile / moveDirectory methods as well > as in the listFiles and listFilesAndDirectoriesMethod -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IO-572) Refactor duplicate code in org.apache.commons.io.FileUtils
[ https://issues.apache.org/jira/browse/IO-572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16394301#comment-16394301 ] Pranet Verma commented on IO-572: - Great. Just one question. Did I make some mistake in the PR? I noticed that it wasn't merged directly, and another one was merged in it's place with the same content (and the appropriate changes in [src/changes/changes.xml|https://github.com/apache/commons-io/commit/f0751b65cf680456557aa1bf5c56b12f5c1a0fe0#diff-de211ef1fe8b98f5c0f34a40201f732f]) > Refactor duplicate code in org.apache.commons.io.FileUtils > -- > > Key: IO-572 > URL: https://issues.apache.org/jira/browse/IO-572 > Project: Commons IO > Issue Type: Improvement >Affects Versions: 2.6 >Reporter: Pranet Verma >Assignee: Gary Gregory >Priority: Minor > Labels: refactor > Fix For: 2.7 > > > There is some duplicate code in the moveFile / moveDirectory methods as well > as in the listFiles and listFilesAndDirectoriesMethod -- This message was sent by Atlassian JIRA (v7.6.3#76005)
