[jira] [Commented] (LANG-1160) StringUtils.abbreviate() to support "custom ellipses" parameter

2016-10-28 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/LANG-1160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15616030#comment-15616030
 ] 

ASF GitHub Bot commented on LANG-1160:
--

Github user asfgit closed the pull request at:

https://github.com/apache/commons-lang/pull/195


> StringUtils.abbreviate() to support "custom ellipses" parameter
> ---
>
> Key: LANG-1160
> URL: https://issues.apache.org/jira/browse/LANG-1160
> Project: Commons Lang
>  Issue Type: Improvement
>  Components: lang.*
>Affects Versions: 3.4
>Reporter: Hendy Irawan
>Priority: Trivial
>
> {{abbreviateMiddle()}} supports custom replacement string.
> {{abbreviate()}} needs to also support this, for example to to use "…" 
> Unicode character instead of three "..."



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LANG-1160) StringUtils.abbreviate() to support "custom ellipses" parameter

2016-10-19 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/LANG-1160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15590975#comment-15590975
 ] 

ASF GitHub Bot commented on LANG-1160:
--

Github user PascalSchumacher commented on the issue:

https://github.com/apache/commons-lang/pull/195
  
+1


> StringUtils.abbreviate() to support "custom ellipses" parameter
> ---
>
> Key: LANG-1160
> URL: https://issues.apache.org/jira/browse/LANG-1160
> Project: Commons Lang
>  Issue Type: Improvement
>  Components: lang.*
>Affects Versions: 3.4
>Reporter: Hendy Irawan
>Priority: Trivial
>
> {{abbreviateMiddle()}} supports custom replacement string.
> {{abbreviate()}} needs to also support this, for example to to use "…" 
> Unicode character instead of three "..."



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LANG-1160) StringUtils.abbreviate() to support "custom ellipses" parameter

2016-10-13 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/LANG-1160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15571542#comment-15571542
 ] 

ASF GitHub Bot commented on LANG-1160:
--

Github user coveralls commented on the issue:

https://github.com/apache/commons-lang/pull/195
  

[![Coverage 
Status](https://coveralls.io/builds/8317240/badge)](https://coveralls.io/builds/8317240)

Coverage decreased (-0.004%) to 93.545% when pulling 
**a7b552208acb7d4eb6d79bddb60cb358ae1ce5bd on kinow:fix-LANG-1160** into 
**78134f6b3f1facd019e604d2cd000c4ce7cf9a0a on apache:master**.



> StringUtils.abbreviate() to support "custom ellipses" parameter
> ---
>
> Key: LANG-1160
> URL: https://issues.apache.org/jira/browse/LANG-1160
> Project: Commons Lang
>  Issue Type: Improvement
>  Components: lang.*
>Affects Versions: 3.4
>Reporter: Hendy Irawan
>Priority: Trivial
>
> {{abbreviateMiddle()}} supports custom replacement string.
> {{abbreviate()}} needs to also support this, for example to to use "…" 
> Unicode character instead of three "..."



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LANG-1160) StringUtils.abbreviate() to support "custom ellipses" parameter

2016-10-13 Thread Bruno P. Kinoshita (JIRA) 

[ 
https://issues.apache.org/jira/browse/LANG-1160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15571473#comment-15571473
 ] 

Bruno P. Kinoshita commented on LANG-1160:
--

Pull request submitted https://github.com/apache/commons-lang/pull/195

> StringUtils.abbreviate() to support "custom ellipses" parameter
> ---
>
> Key: LANG-1160
> URL: https://issues.apache.org/jira/browse/LANG-1160
> Project: Commons Lang
>  Issue Type: Improvement
>  Components: lang.*
>Affects Versions: 3.4
>Reporter: Hendy Irawan
>Priority: Trivial
>
> {{abbreviateMiddle()}} supports custom replacement string.
> {{abbreviate()}} needs to also support this, for example to to use "…" 
> Unicode character instead of three "..."



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LANG-1160) StringUtils.abbreviate() to support "custom ellipses" parameter

2016-10-13 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/LANG-1160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15571472#comment-15571472
 ] 

ASF GitHub Bot commented on LANG-1160:
--

GitHub user kinow opened a pull request:

https://github.com/apache/commons-lang/pull/195

LANG-1160 StringUtils.abbreviate() to support 'custom ellipses' parameter

From [LANG-1160](https://issues.apache.org/jira/browse/LANG-1160).

Before this pull request the code contained only two abbreviate methods. 
One abbreviate(String, int) that would call the other one abbreviate(String, 
int, int) with a default value for one of the int parameters.

This pull request adds two other methods with the same name, but that 
receive a custom abbreviation marker. The existing methods were update to call 
the new complete method with a default abbreviation marker of "...", which 
guarantees backward compatibility (we are keeping binary compatibility, and 
also feature backward compatibility).

Tests were update, test coverage is the same as before. No issues found 
building the site locally and from looking at CPD, PMD, FindBugs, CheckStyle 
and Surefire reports; all tests passing locally, with additional two tests in 
this PR.

Cheers
Bruno

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/kinow/commons-lang fix-LANG-1160

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/commons-lang/pull/195.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #195


commit a7b552208acb7d4eb6d79bddb60cb358ae1ce5bd
Author: Bruno P. Kinoshita 
Date:   2016-10-13T09:55:17Z

LANG-1160 StringUtils.abbreviate() to support 'custom ellipses' parameter




> StringUtils.abbreviate() to support "custom ellipses" parameter
> ---
>
> Key: LANG-1160
> URL: https://issues.apache.org/jira/browse/LANG-1160
> Project: Commons Lang
>  Issue Type: Improvement
>  Components: lang.*
>Affects Versions: 3.4
>Reporter: Hendy Irawan
>Priority: Trivial
>
> {{abbreviateMiddle()}} supports custom replacement string.
> {{abbreviate()}} needs to also support this, for example to to use "…" 
> Unicode character instead of three "..."



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LANG-1160) StringUtils.abbreviate() to support "custom ellipses" parameter

2016-10-12 Thread Bruno P. Kinoshita (JIRA) 

[ 
https://issues.apache.org/jira/browse/LANG-1160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15571066#comment-15571066
 ] 

Bruno P. Kinoshita commented on LANG-1160:
--

Good point [~britter]! Let's wait, and in the mean time I will prepare a pull 
request for this issue as it seems like an interesting improvement to the 
abbreviate method.

Thanks!

> StringUtils.abbreviate() to support "custom ellipses" parameter
> ---
>
> Key: LANG-1160
> URL: https://issues.apache.org/jira/browse/LANG-1160
> Project: Commons Lang
>  Issue Type: Improvement
>  Components: lang.*
>Affects Versions: 3.4
>Reporter: Hendy Irawan
>Priority: Trivial
>
> {{abbreviateMiddle()}} supports custom replacement string.
> {{abbreviate()}} needs to also support this, for example to to use "…" 
> Unicode character instead of three "..."



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LANG-1160) StringUtils.abbreviate() to support "custom ellipses" parameter

2016-10-12 Thread Benedikt Ritter (JIRA) 

[ 
https://issues.apache.org/jira/browse/LANG-1160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15571022#comment-15571022
 ] 

Benedikt Ritter commented on LANG-1160:
---

[~kinow] the problem I see is, that we don't have a [text] release yet. IMHO we 
need to push out [text] before we can really start to deprecate methods in 
string utils.

> StringUtils.abbreviate() to support "custom ellipses" parameter
> ---
>
> Key: LANG-1160
> URL: https://issues.apache.org/jira/browse/LANG-1160
> Project: Commons Lang
>  Issue Type: Improvement
>  Components: lang.*
>Affects Versions: 3.4
>Reporter: Hendy Irawan
>Priority: Trivial
>
> {{abbreviateMiddle()}} supports custom replacement string.
> {{abbreviate()}} needs to also support this, for example to to use "…" 
> Unicode character instead of three "..."



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LANG-1160) StringUtils.abbreviate() to support "custom ellipses" parameter

2016-10-12 Thread Bruno P. Kinoshita (JIRA) 

[ 
https://issues.apache.org/jira/browse/LANG-1160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15567880#comment-15567880
 ] 

Bruno P. Kinoshita commented on LANG-1160:
--

Looks easy to be implemented. I can submit a pull request for this this 
weekend. 

[~britter] abbreviations will probably be included in [text] too. StringUtils 
has 8822 LOC at the moment. Do you reckon it is all right to add this new 
method on [lang], or would methods like this on StringUtils be good candidates 
to be moved to [text]? I'd be inclined to not add any more features to 
StringUtils if [text] is going to have similart code. Or should I drop an 
e-mail to the mailing list about it?

> StringUtils.abbreviate() to support "custom ellipses" parameter
> ---
>
> Key: LANG-1160
> URL: https://issues.apache.org/jira/browse/LANG-1160
> Project: Commons Lang
>  Issue Type: Improvement
>  Components: lang.*
>Affects Versions: 3.4
>Reporter: Hendy Irawan
>Priority: Trivial
>
> {{abbreviateMiddle()}} supports custom replacement string.
> {{abbreviate()}} needs to also support this, for example to to use "…" 
> Unicode character instead of three "..."



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)