[jira] [Commented] (LANG-1197) Prepare Java 9 detection

2016-09-17 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/LANG-1197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15499134#comment-15499134
 ] 

ASF GitHub Bot commented on LANG-1197:
--

Github user asfgit closed the pull request at:

https://github.com/apache/commons-lang/pull/163


> Prepare Java 9 detection
> 
>
> Key: LANG-1197
> URL: https://issues.apache.org/jira/browse/LANG-1197
> Project: Commons Lang
>  Issue Type: Task
>  Components: lang.*
>Affects Versions: 3.4
>Reporter: Michael Osipov
> Fix For: 3.5
>
>
> In anticipation of Java 9 and [JEP 223|http://openjdk.java.net/jeps/223], the 
> versioning scheme will change completely. We need to reflect that in 
> {{SystemUtils}}, {{JavaVersion}}, etc.:
> * {{SystemUtils}}: Deprecate {{IS_JAVA_1_9}} and replace with {{IS_JAVA_9}}
> * {{JavaVersion}}: Deprecate {{JAVA_1_9}} in {{JavaVersion}} and replace with 
> {{JAVA_9}}
> and other places in the library.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (LANG-1197) Prepare Java 9 detection

2016-09-15 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/LANG-1197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15494038#comment-15494038
 ] 

ASF GitHub Bot commented on LANG-1197:
--

Github user coveralls commented on the issue:

https://github.com/apache/commons-lang/pull/163
  

[![Coverage 
Status](https://coveralls.io/builds/7906006/badge)](https://coveralls.io/builds/7906006)

Coverage decreased (-0.01%) to 93.563% when pulling 
**b9f04d9be3e7ff300520da194fe29ed5c1861787 on PascalSchumacher:java_9** into 
**9c506279188a90dbbe124386cc52016682d17b5c on apache:master**.



> Prepare Java 9 detection
> 
>
> Key: LANG-1197
> URL: https://issues.apache.org/jira/browse/LANG-1197
> Project: Commons Lang
>  Issue Type: Task
>  Components: lang.*
>Affects Versions: 3.4
>Reporter: Michael Osipov
>
> In anticipation of Java 9 and [JEP 223|http://openjdk.java.net/jeps/223], the 
> versioning scheme will change completely. We need to reflect that in 
> {{SystemUtils}}, {{JavaVersion}}, etc.:
> * {{SystemUtils}}: Deprecate {{IS_JAVA_1_9}} and replace with {{IS_JAVA_9}}
> * {{JavaVersion}}: Deprecate {{JAVA_1_9}} in {{JavaVersion}} and replace with 
> {{JAVA_9}}
> and other places in the library.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (LANG-1197) Prepare Java 9 detection

2016-09-15 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/LANG-1197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15494036#comment-15494036
 ] 

ASF GitHub Bot commented on LANG-1197:
--

Github user coveralls commented on the issue:

https://github.com/apache/commons-lang/pull/163
  

[![Coverage 
Status](https://coveralls.io/builds/7905919/badge)](https://coveralls.io/builds/7905919)

Coverage decreased (-0.01%) to 93.563% when pulling 
**b9f04d9be3e7ff300520da194fe29ed5c1861787 on PascalSchumacher:java_9** into 
**9c506279188a90dbbe124386cc52016682d17b5c on apache:master**.



> Prepare Java 9 detection
> 
>
> Key: LANG-1197
> URL: https://issues.apache.org/jira/browse/LANG-1197
> Project: Commons Lang
>  Issue Type: Task
>  Components: lang.*
>Affects Versions: 3.4
>Reporter: Michael Osipov
>
> In anticipation of Java 9 and [JEP 223|http://openjdk.java.net/jeps/223], the 
> versioning scheme will change completely. We need to reflect that in 
> {{SystemUtils}}, {{JavaVersion}}, etc.:
> * {{SystemUtils}}: Deprecate {{IS_JAVA_1_9}} and replace with {{IS_JAVA_9}}
> * {{JavaVersion}}: Deprecate {{JAVA_1_9}} in {{JavaVersion}} and replace with 
> {{JAVA_9}}
> and other places in the library.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (LANG-1197) Prepare Java 9 detection

2016-09-15 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/LANG-1197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15493997#comment-15493997
 ] 

ASF GitHub Bot commented on LANG-1197:
--

Github user coveralls commented on the issue:

https://github.com/apache/commons-lang/pull/163
  

[![Coverage 
Status](https://coveralls.io/builds/7905583/badge)](https://coveralls.io/builds/7905583)

Coverage decreased (-0.01%) to 93.563% when pulling 
**83d4fce93647b096ce07d4b57489608a7c8a0043 on PascalSchumacher:java_9** into 
**9c506279188a90dbbe124386cc52016682d17b5c on apache:master**.



> Prepare Java 9 detection
> 
>
> Key: LANG-1197
> URL: https://issues.apache.org/jira/browse/LANG-1197
> Project: Commons Lang
>  Issue Type: Task
>  Components: lang.*
>Affects Versions: 3.4
>Reporter: Michael Osipov
>
> In anticipation of Java 9 and [JEP 223|http://openjdk.java.net/jeps/223], the 
> versioning scheme will change completely. We need to reflect that in 
> {{SystemUtils}}, {{JavaVersion}}, etc.:
> * {{SystemUtils}}: Deprecate {{IS_JAVA_1_9}} and replace with {{IS_JAVA_9}}
> * {{JavaVersion}}: Deprecate {{JAVA_1_9}} in {{JavaVersion}} and replace with 
> {{JAVA_9}}
> and other places in the library.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (LANG-1197) Prepare Java 9 detection

2016-09-12 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/LANG-1197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15484639#comment-15484639
 ] 

ASF GitHub Bot commented on LANG-1197:
--

Github user coveralls commented on the issue:

https://github.com/apache/commons-lang/pull/163
  

[![Coverage 
Status](https://coveralls.io/builds/7848269/badge)](https://coveralls.io/builds/7848269)

Coverage increased (+0.2%) to 93.582% when pulling 
**96dc0638d5220b7835093d08fdead7d46bee1120 on PascalSchumacher:java_9** into 
**078e512e6cc5ba49eb3c5a3a63a0ddb657324fd9 on apache:master**.



> Prepare Java 9 detection
> 
>
> Key: LANG-1197
> URL: https://issues.apache.org/jira/browse/LANG-1197
> Project: Commons Lang
>  Issue Type: Task
>  Components: lang.*
>Affects Versions: 3.4
>Reporter: Michael Osipov
>
> In anticipation of Java 9 and [JEP 223|http://openjdk.java.net/jeps/223], the 
> versioning scheme will change completely. We need to reflect that in 
> {{SystemUtils}}, {{JavaVersion}}, etc.:
> * {{SystemUtils}}: Deprecate {{IS_JAVA_1_9}} and replace with {{IS_JAVA_9}}
> * {{JavaVersion}}: Deprecate {{JAVA_1_9}} in {{JavaVersion}} and replace with 
> {{JAVA_9}}
> and other places in the library.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (LANG-1197) Prepare Java 9 detection

2016-09-12 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/LANG-1197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15484626#comment-15484626
 ] 

ASF GitHub Bot commented on LANG-1197:
--

GitHub user PascalSchumacher reopened a pull request:

https://github.com/apache/commons-lang/pull/163

LANG-1197: Prepare Java 9 detection (unfinished)

Not complete: `JavaVersion` expects the `java.version` system property to 
return `1.x` but for java 9 it will return `9*`. Not sure how to handle this.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/PascalSchumacher/commons-lang java_9

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/commons-lang/pull/163.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #163


commit 96dc0638d5220b7835093d08fdead7d46bee1120
Author: pascalschumacher 
Date:   2016-05-20T17:29:20Z

LANG-1197: Prepare Java 9 detection (unfinished)




> Prepare Java 9 detection
> 
>
> Key: LANG-1197
> URL: https://issues.apache.org/jira/browse/LANG-1197
> Project: Commons Lang
>  Issue Type: Task
>  Components: lang.*
>Affects Versions: 3.4
>Reporter: Michael Osipov
>
> In anticipation of Java 9 and [JEP 223|http://openjdk.java.net/jeps/223], the 
> versioning scheme will change completely. We need to reflect that in 
> {{SystemUtils}}, {{JavaVersion}}, etc.:
> * {{SystemUtils}}: Deprecate {{IS_JAVA_1_9}} and replace with {{IS_JAVA_9}}
> * {{JavaVersion}}: Deprecate {{JAVA_1_9}} in {{JavaVersion}} and replace with 
> {{JAVA_9}}
> and other places in the library.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (LANG-1197) Prepare Java 9 detection

2016-09-12 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/LANG-1197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15484625#comment-15484625
 ] 

ASF GitHub Bot commented on LANG-1197:
--

Github user PascalSchumacher commented on the issue:

https://github.com/apache/commons-lang/pull/163
  
O.k. I will finish this in a few days. This can be merged into the next 
version.


> Prepare Java 9 detection
> 
>
> Key: LANG-1197
> URL: https://issues.apache.org/jira/browse/LANG-1197
> Project: Commons Lang
>  Issue Type: Task
>  Components: lang.*
>Affects Versions: 3.4
>Reporter: Michael Osipov
>
> In anticipation of Java 9 and [JEP 223|http://openjdk.java.net/jeps/223], the 
> versioning scheme will change completely. We need to reflect that in 
> {{SystemUtils}}, {{JavaVersion}}, etc.:
> * {{SystemUtils}}: Deprecate {{IS_JAVA_1_9}} and replace with {{IS_JAVA_9}}
> * {{JavaVersion}}: Deprecate {{JAVA_1_9}} in {{JavaVersion}} and replace with 
> {{JAVA_9}}
> and other places in the library.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (LANG-1197) Prepare Java 9 detection

2016-09-12 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/LANG-1197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15484021#comment-15484021
 ] 

ASF GitHub Bot commented on LANG-1197:
--

Github user britter commented on the issue:

https://github.com/apache/commons-lang/pull/163
  
No, it contains no fix for Java 9 at all :-)


> Prepare Java 9 detection
> 
>
> Key: LANG-1197
> URL: https://issues.apache.org/jira/browse/LANG-1197
> Project: Commons Lang
>  Issue Type: Task
>  Components: lang.*
>Affects Versions: 3.4
>Reporter: Michael Osipov
>
> In anticipation of Java 9 and [JEP 223|http://openjdk.java.net/jeps/223], the 
> versioning scheme will change completely. We need to reflect that in 
> {{SystemUtils}}, {{JavaVersion}}, etc.:
> * {{SystemUtils}}: Deprecate {{IS_JAVA_1_9}} and replace with {{IS_JAVA_9}}
> * {{JavaVersion}}: Deprecate {{JAVA_1_9}} in {{JavaVersion}} and replace with 
> {{JAVA_9}}
> and other places in the library.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (LANG-1197) Prepare Java 9 detection

2016-09-12 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/LANG-1197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15483841#comment-15483841
 ] 

ASF GitHub Bot commented on LANG-1197:
--

Github user PascalSchumacher commented on the issue:

https://github.com/apache/commons-lang/pull/163
  
For the next few days I will probably not have time to finish this and I do 
not want to hold up the release. Doesn't 
https://github.com/apache/commons-lang/pull/187/files pull request contain most 
the code of this pull request anyway?


> Prepare Java 9 detection
> 
>
> Key: LANG-1197
> URL: https://issues.apache.org/jira/browse/LANG-1197
> Project: Commons Lang
>  Issue Type: Task
>  Components: lang.*
>Affects Versions: 3.4
>Reporter: Michael Osipov
>
> In anticipation of Java 9 and [JEP 223|http://openjdk.java.net/jeps/223], the 
> versioning scheme will change completely. We need to reflect that in 
> {{SystemUtils}}, {{JavaVersion}}, etc.:
> * {{SystemUtils}}: Deprecate {{IS_JAVA_1_9}} and replace with {{IS_JAVA_9}}
> * {{JavaVersion}}: Deprecate {{JAVA_1_9}} in {{JavaVersion}} and replace with 
> {{JAVA_9}}
> and other places in the library.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (LANG-1197) Prepare Java 9 detection

2016-09-12 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/LANG-1197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15483551#comment-15483551
 ] 

ASF GitHub Bot commented on LANG-1197:
--

Github user britter commented on the issue:

https://github.com/apache/commons-lang/pull/163
  
@PascalSchumacher but why? This was going in the right direction!


> Prepare Java 9 detection
> 
>
> Key: LANG-1197
> URL: https://issues.apache.org/jira/browse/LANG-1197
> Project: Commons Lang
>  Issue Type: Task
>  Components: lang.*
>Affects Versions: 3.4
>Reporter: Michael Osipov
>
> In anticipation of Java 9 and [JEP 223|http://openjdk.java.net/jeps/223], the 
> versioning scheme will change completely. We need to reflect that in 
> {{SystemUtils}}, {{JavaVersion}}, etc.:
> * {{SystemUtils}}: Deprecate {{IS_JAVA_1_9}} and replace with {{IS_JAVA_9}}
> * {{JavaVersion}}: Deprecate {{JAVA_1_9}} in {{JavaVersion}} and replace with 
> {{JAVA_9}}
> and other places in the library.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (LANG-1197) Prepare Java 9 detection

2016-09-11 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/LANG-1197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15482377#comment-15482377
 ] 

ASF GitHub Bot commented on LANG-1197:
--

Github user PascalSchumacher closed the pull request at:

https://github.com/apache/commons-lang/pull/163


> Prepare Java 9 detection
> 
>
> Key: LANG-1197
> URL: https://issues.apache.org/jira/browse/LANG-1197
> Project: Commons Lang
>  Issue Type: Task
>  Components: lang.*
>Affects Versions: 3.4
>Reporter: Michael Osipov
>
> In anticipation of Java 9 and [JEP 223|http://openjdk.java.net/jeps/223], the 
> versioning scheme will change completely. We need to reflect that in 
> {{SystemUtils}}, {{JavaVersion}}, etc.:
> * {{SystemUtils}}: Deprecate {{IS_JAVA_1_9}} and replace with {{IS_JAVA_9}}
> * {{JavaVersion}}: Deprecate {{JAVA_1_9}} in {{JavaVersion}} and replace with 
> {{JAVA_9}}
> and other places in the library.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (LANG-1197) Prepare Java 9 detection

2016-09-11 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/LANG-1197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15482378#comment-15482378
 ] 

ASF GitHub Bot commented on LANG-1197:
--

Github user PascalSchumacher commented on the issue:

https://github.com/apache/commons-lang/pull/163
  
@britter I closing this and let you handle the complete java 9 issue(s).


> Prepare Java 9 detection
> 
>
> Key: LANG-1197
> URL: https://issues.apache.org/jira/browse/LANG-1197
> Project: Commons Lang
>  Issue Type: Task
>  Components: lang.*
>Affects Versions: 3.4
>Reporter: Michael Osipov
>
> In anticipation of Java 9 and [JEP 223|http://openjdk.java.net/jeps/223], the 
> versioning scheme will change completely. We need to reflect that in 
> {{SystemUtils}}, {{JavaVersion}}, etc.:
> * {{SystemUtils}}: Deprecate {{IS_JAVA_1_9}} and replace with {{IS_JAVA_9}}
> * {{JavaVersion}}: Deprecate {{JAVA_1_9}} in {{JavaVersion}} and replace with 
> {{JAVA_9}}
> and other places in the library.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (LANG-1197) Prepare Java 9 detection

2016-09-11 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/LANG-1197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15482302#comment-15482302
 ] 

ASF GitHub Bot commented on LANG-1197:
--

Github user britter commented on the issue:

https://github.com/apache/commons-lang/pull/163
  
> Not complete: JavaVersion expects the java.version system property to 
return 1.x but for java 9 it will return 9*. Not sure how to handle this.

I think we should better work with `java.specification.version` here


> Prepare Java 9 detection
> 
>
> Key: LANG-1197
> URL: https://issues.apache.org/jira/browse/LANG-1197
> Project: Commons Lang
>  Issue Type: Task
>  Components: lang.*
>Affects Versions: 3.4
>Reporter: Michael Osipov
>
> In anticipation of Java 9 and [JEP 223|http://openjdk.java.net/jeps/223], the 
> versioning scheme will change completely. We need to reflect that in 
> {{SystemUtils}}, {{JavaVersion}}, etc.:
> * {{SystemUtils}}: Deprecate {{IS_JAVA_1_9}} and replace with {{IS_JAVA_9}}
> * {{JavaVersion}}: Deprecate {{JAVA_1_9}} in {{JavaVersion}} and replace with 
> {{JAVA_9}}
> and other places in the library.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (LANG-1197) Prepare Java 9 detection

2016-09-11 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/LANG-1197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15482300#comment-15482300
 ] 

ASF GitHub Bot commented on LANG-1197:
--

Github user britter commented on a diff in the pull request:

https://github.com/apache/commons-lang/pull/163#discussion_r78301302
  
--- Diff: src/main/java/org/apache/commons/lang3/JavaVersion.java ---
@@ -72,8 +72,15 @@
 
 /**
  * Java 1.9.
+ * 
+ * @deprecated As of release 3.5, replaced by {@link #JAVA_9}
+ */
+JAVA_1_9(1.9f, "9"),
+
+/**
+ * Java 9
  */
-JAVA_1_9(1.9f, "1.9"),
+JAVA_9(1.9f, "9"),
--- End diff --

I agree with Michael


> Prepare Java 9 detection
> 
>
> Key: LANG-1197
> URL: https://issues.apache.org/jira/browse/LANG-1197
> Project: Commons Lang
>  Issue Type: Task
>  Components: lang.*
>Affects Versions: 3.4
>Reporter: Michael Osipov
>
> In anticipation of Java 9 and [JEP 223|http://openjdk.java.net/jeps/223], the 
> versioning scheme will change completely. We need to reflect that in 
> {{SystemUtils}}, {{JavaVersion}}, etc.:
> * {{SystemUtils}}: Deprecate {{IS_JAVA_1_9}} and replace with {{IS_JAVA_9}}
> * {{JavaVersion}}: Deprecate {{JAVA_1_9}} in {{JavaVersion}} and replace with 
> {{JAVA_9}}
> and other places in the library.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (LANG-1197) Prepare Java 9 detection

2016-06-06 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/LANG-1197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15316969#comment-15316969
 ] 

ASF GitHub Bot commented on LANG-1197:
--

Github user michael-o commented on a diff in the pull request:

https://github.com/apache/commons-lang/pull/163#discussion_r65946021
  
--- Diff: src/main/java/org/apache/commons/lang3/JavaVersion.java ---
@@ -72,8 +72,15 @@
 
 /**
  * Java 1.9.
+ * 
+ * @deprecated As of release 3.5, replaced by {@link #JAVA_9}
+ */
+JAVA_1_9(1.9f, "9"),
+
+/**
+ * Java 9
  */
-JAVA_1_9(1.9f, "1.9"),
+JAVA_9(1.9f, "9"),
--- End diff --

`1.9f`? This should rather be `9.0f`.


> Prepare Java 9 detection
> 
>
> Key: LANG-1197
> URL: https://issues.apache.org/jira/browse/LANG-1197
> Project: Commons Lang
>  Issue Type: Task
>  Components: lang.*
>Affects Versions: 3.4
>Reporter: Michael Osipov
>
> In anticipation of Java 9 and [JEP 223|http://openjdk.java.net/jeps/223], the 
> versioning scheme will change completely. We need to reflect that in 
> {{SystemUtils}}, {{JavaVersion}}, etc.:
> * {{SystemUtils}}: Deprecate {{IS_JAVA_1_9}} and replace with {{IS_JAVA_9}}
> * {{JavaVersion}}: Deprecate {{JAVA_1_9}} in {{JavaVersion}} and replace with 
> {{JAVA_9}}
> and other places in the library.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (LANG-1197) Prepare Java 9 detection

2016-06-05 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/LANG-1197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15315975#comment-15315975
 ] 

ASF GitHub Bot commented on LANG-1197:
--

Github user coveralls commented on the issue:

https://github.com/apache/commons-lang/pull/163
  

[![Coverage 
Status](https://coveralls.io/builds/6469522/badge)](https://coveralls.io/builds/6469522)

Coverage increased (+0.04%) to 93.45% when pulling 
**96dc0638d5220b7835093d08fdead7d46bee1120 on PascalSchumacher:java_9** into 
**078e512e6cc5ba49eb3c5a3a63a0ddb657324fd9 on apache:master**.



> Prepare Java 9 detection
> 
>
> Key: LANG-1197
> URL: https://issues.apache.org/jira/browse/LANG-1197
> Project: Commons Lang
>  Issue Type: Task
>  Components: lang.*
>Affects Versions: 3.4
>Reporter: Michael Osipov
>
> In anticipation of Java 9 and [JEP 223|http://openjdk.java.net/jeps/223], the 
> versioning scheme will change completely. We need to reflect that in 
> {{SystemUtils}}, {{JavaVersion}}, etc.:
> * {{SystemUtils}}: Deprecate {{IS_JAVA_1_9}} and replace with {{IS_JAVA_9}}
> * {{JavaVersion}}: Deprecate {{JAVA_1_9}} in {{JavaVersion}} and replace with 
> {{JAVA_9}}
> and other places in the library.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (LANG-1197) Prepare Java 9 detection

2016-06-05 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/LANG-1197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15315974#comment-15315974
 ] 

ASF GitHub Bot commented on LANG-1197:
--

GitHub user PascalSchumacher opened a pull request:

https://github.com/apache/commons-lang/pull/163

LANG-1197: Prepare Java 9 detection (unfinished)

Not complete: `JavaVersion` expects the `java.version` system property to 
return `1.x` but for java 9 it will return `9*`. Not sure how to handle this.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/PascalSchumacher/commons-lang java_9

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/commons-lang/pull/163.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #163


commit 96dc0638d5220b7835093d08fdead7d46bee1120
Author: pascalschumacher 
Date:   2016-05-20T17:29:20Z

LANG-1197: Prepare Java 9 detection (unfinished)




> Prepare Java 9 detection
> 
>
> Key: LANG-1197
> URL: https://issues.apache.org/jira/browse/LANG-1197
> Project: Commons Lang
>  Issue Type: Task
>  Components: lang.*
>Affects Versions: 3.4
>Reporter: Michael Osipov
>
> In anticipation of Java 9 and [JEP 223|http://openjdk.java.net/jeps/223], the 
> versioning scheme will change completely. We need to reflect that in 
> {{SystemUtils}}, {{JavaVersion}}, etc.:
> * {{SystemUtils}}: Deprecate {{IS_JAVA_1_9}} and replace with {{IS_JAVA_9}}
> * {{JavaVersion}}: Deprecate {{JAVA_1_9}} in {{JavaVersion}} and replace with 
> {{JAVA_9}}
> and other places in the library.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)