[jira] [Commented] (NUMBERS-60) Check Javadoc with respect to NaN

2018-03-01 Thread Eric Barnhill (JIRA)
[ https://issues.apache.org/jira/browse/NUMBERS-60?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16381932#comment-16381932 ] Eric Barnhill commented on NUMBERS-60: -- I noticed there was some checkstyle code around the NAN

[jira] [Commented] (NUMBERS-60) Check Javadoc with respect to NaN

2018-02-16 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/NUMBERS-60?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16367494#comment-16367494 ] Gilles commented on NUMBERS-60: --- I've linked to the old issue(s). Please open a new report as you see fit

[jira] [Commented] (NUMBERS-60) Check Javadoc with respect to NaN

2018-02-16 Thread Eric Barnhill (JIRA)
[ https://issues.apache.org/jira/browse/NUMBERS-60?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16367453#comment-16367453 ] Eric Barnhill commented on NUMBERS-60: -- You are right, I tended to the trigonometry, but not to the

[jira] [Commented] (NUMBERS-60) Check Javadoc with respect to NaN

2018-02-14 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/NUMBERS-60?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16363750#comment-16363750 ] Gilles commented on NUMBERS-60: --- I've just look back into history, to figure out that I raised the same

[jira] [Commented] (NUMBERS-60) Check Javadoc with respect to NaN

2018-02-14 Thread Eric Barnhill (JIRA)
[ https://issues.apache.org/jira/browse/NUMBERS-60?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16363665#comment-16363665 ] Eric Barnhill commented on NUMBERS-60: -- {code:java} if (c == 0 && d == 0) { return NAN; } {code}  

[jira] [Commented] (NUMBERS-60) Check Javadoc with respect to NaN

2018-02-13 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/NUMBERS-60?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16362389#comment-16362389 ] Gilles commented on NUMBERS-60: --- Eric, The latest change break the build on Jenkins:

[jira] [Commented] (NUMBERS-60) Check Javadoc with respect to NaN

2018-02-12 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/NUMBERS-60?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16360852#comment-16360852 ] Gilles commented on NUMBERS-60: --- I agree {{Complex.ONE}} and {{Complex.ZERO}} but I worry that

[jira] [Commented] (NUMBERS-60) Check Javadoc with respect to NaN

2018-02-12 Thread Eric Barnhill (JIRA)
[ https://issues.apache.org/jira/browse/NUMBERS-60?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16360647#comment-16360647 ] Eric Barnhill commented on NUMBERS-60: -- I think the reason NAN is public is because Complex.ZERO and

[jira] [Commented] (NUMBERS-60) Check Javadoc with respect to NaN

2018-02-12 Thread Eric Barnhill (JIRA)
[ https://issues.apache.org/jira/browse/NUMBERS-60?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16360583#comment-16360583 ] Eric Barnhill commented on NUMBERS-60: -- This is actually a broader issue, there are multiple