[jira] [Commented] (RNG-140) nextLong(long lo, long hi)

2021-07-16 Thread Alex Herbert (Jira)
[ https://issues.apache.org/jira/browse/RNG-140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17382236#comment-17382236 ] Alex Herbert commented on RNG-140: -- I adapted this from the same sampler for int values. However this

[jira] [Commented] (RNG-140) nextLong(long lo, long hi)

2021-07-16 Thread Gilles Sadowski (Jira)
[ https://issues.apache.org/jira/browse/RNG-140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17382213#comment-17382213 ] Gilles Sadowski commented on RNG-140: - {quote}[...] if you want. {quote} No. ;) You've just confirmed

[jira] [Commented] (RNG-140) nextLong(long lo, long hi)

2021-07-16 Thread Alex Herbert (Jira)
[ https://issues.apache.org/jira/browse/RNG-140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17382202#comment-17382202 ] Alex Herbert commented on RNG-140: -- bq. IIUC, you were meaning that with this one, it is not necessary to

[jira] [Commented] (RNG-140) nextLong(long lo, long hi)

2021-07-16 Thread Gilles Sadowski (Jira)
[ https://issues.apache.org/jira/browse/RNG-140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17382119#comment-17382119 ] Gilles Sadowski commented on RNG-140: - bq. testSamplesWithLargeNonPowerOf2RangeIsRejectionMethod : Tests

[jira] [Commented] (RNG-140) nextLong(long lo, long hi)

2021-07-16 Thread Alex Herbert (Jira)
[ https://issues.apache.org/jira/browse/RNG-140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17382089#comment-17382089 ] Alex Herbert commented on RNG-140: -- bq. Which is the test that does that? testSamplesWithFullRange : Tests

[jira] [Commented] (RNG-140) nextLong(long lo, long hi)

2021-07-16 Thread Gilles Sadowski (Jira)
[ https://issues.apache.org/jira/browse/RNG-140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17382072#comment-17382072 ] Gilles Sadowski commented on RNG-140: - bq. PR with the initial interfaces/classes Thanks! bq. [...]

[jira] [Commented] (RNG-140) nextLong(long lo, long hi)

2021-07-16 Thread Alex Herbert (Jira)
[ https://issues.apache.org/jira/browse/RNG-140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17382058#comment-17382058 ] Alex Herbert commented on RNG-140: -- I've opened a PR with the initial interfaces/classes: * LongSampler *

[jira] [Commented] (RNG-140) nextLong(long lo, long hi)

2021-06-14 Thread Gilles Sadowski (Jira)
[ https://issues.apache.org/jira/browse/RNG-140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17363024#comment-17363024 ] Gilles Sadowski commented on RNG-140: - bq. return an instance of the class from the factory constructor

[jira] [Commented] (RNG-140) nextLong(long lo, long hi)

2021-06-14 Thread Alex Herbert (Jira)
[ https://issues.apache.org/jira/browse/RNG-140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17363018#comment-17363018 ] Alex Herbert commented on RNG-140: -- I can put the LongSampler and the implementation of UniformLongSampler

[jira] [Commented] (RNG-140) nextLong(long lo, long hi)

2021-06-14 Thread Gilles Sadowski (Jira)
[ https://issues.apache.org/jira/browse/RNG-140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17363000#comment-17363000 ] Gilles Sadowski commented on RNG-140: - bq. I suggest [...] {{LongSampler}} I'd have favoured

[jira] [Commented] (RNG-140) nextLong(long lo, long hi)

2021-06-14 Thread Alex Herbert (Jira)
[ https://issues.apache.org/jira/browse/RNG-140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17362965#comment-17362965 ] Alex Herbert commented on RNG-140: -- It could. But for the {{int}} case we have a sampler in the sampling

[jira] [Commented] (RNG-140) nextLong(long lo, long hi)

2021-06-14 Thread Gilles Sadowski (Jira)
[ https://issues.apache.org/jira/browse/RNG-140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17362947#comment-17362947 ] Gilles Sadowski commented on RNG-140: - Could the method be added to the {{UniformRandomProvider}}