[jira] [Comment Edited] (CB-13589) Cordova fetch updates too aggressively and breaks itself
[ https://issues.apache.org/jira/browse/CB-13589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16510458#comment-16510458 ] Raphael edited comment on CB-13589 at 6/13/18 3:50 PM: --- Resolved by [https://github.com/apache/cordova-fetch/pull/18] You can test this using cordova@8.0.1-nightly.2018.6.13.f567c26f was (Author: raphinesse): Resolved by [https://github.com/apache/cordova-fetch/pull/18] You can test this [using cordova@8.0.1-nightly.2018.6.13.f567c26f|mailto:using%C2%A0cordova@8.0.1-nightly.2018.6.13.f567c26f] > Cordova fetch updates too aggressively and breaks itself > > > Key: CB-13589 > URL: https://issues.apache.org/jira/browse/CB-13589 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-fetch >Reporter: Andrew Crites >Priority: Blocker > > Related: CB-11252 CB-12262 -- these issues say they are fixed, but I can > still reproduce them. > Running {{cordova platform add}} with plugins directly from github or a file > system path will update {{package.json}} in a way that subsequently breaks > the plugin installation. To get around this, you must currently use {{cordova > platform add $PLATFORM --nofetch}}. > For example: > {code} > spec="https://github.com/pushandplay/cordova-plugin-apprate#0cc8b3b424491d35b1e571a69b21d2ae7cb9cff9; > /> > spec="./src/local-plugins/phonegap-plugin-push"> > > > {code} > On an initial {{cordova platform add}} this will work fine. However, this > updates {{package.json}} to add these plugins as dependencies: > {code} > +"cordova-plugin-apprate": > "git+https://github.com/pushandplay/cordova-plugin-apprate.git#0cc8b3b424491d35b1e571a69b21d2ae7cb9cff9;, > +"phonegap-plugin-push": "file:src/local-plugins/phonegap-plugin-push", > {code} > Now try: > {code} > rm -rf node_modules platforms plugins > npx npm@5.4.2 install > npx cordova@7.1.0 platform add ios > {code} > for example. Plugin installation will be unsuccessful: > {code} > Failed to restore plugin "phonegap-plugin-push" from config.xml. You might > need to try adding it again. Error: Failed to fetch plugin > file:src/local-plugins/phonegap-plugin-push via registry. > Failed to restore plugin "cordova-plugin-apprate" from config.xml. You might > need to try adding it again. Error: Failed to fetch plugin > git+https://github.com/pushandplay/cordova-plugin-apprate.git#0cc8b3b424491d35b1e571a69b21d2ae7cb9cff9 > via registry. > {code} > Manually removing the {{package.json}} update ({{\--nosave}} is broken > CB-13463) or using {{\--nofetch}} will work. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Comment Edited] (CB-13589) Cordova fetch updates too aggressively and breaks itself
[ https://issues.apache.org/jira/browse/CB-13589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16510458#comment-16510458 ] Raphael edited comment on CB-13589 at 6/13/18 3:49 PM: --- Resolved by [https://github.com/apache/cordova-fetch/pull/18] You can test this [using cordova@8.0.1-nightly.2018.6.13.f567c26f|mailto:using%C2%A0cordova@8.0.1-nightly.2018.6.13.f567c26f] was (Author: raphinesse): Resolved by https://github.com/apache/cordova-fetch/pull/18 > Cordova fetch updates too aggressively and breaks itself > > > Key: CB-13589 > URL: https://issues.apache.org/jira/browse/CB-13589 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-fetch >Reporter: Andrew Crites >Priority: Blocker > > Related: CB-11252 CB-12262 -- these issues say they are fixed, but I can > still reproduce them. > Running {{cordova platform add}} with plugins directly from github or a file > system path will update {{package.json}} in a way that subsequently breaks > the plugin installation. To get around this, you must currently use {{cordova > platform add $PLATFORM --nofetch}}. > For example: > {code} > spec="https://github.com/pushandplay/cordova-plugin-apprate#0cc8b3b424491d35b1e571a69b21d2ae7cb9cff9; > /> > spec="./src/local-plugins/phonegap-plugin-push"> > > > {code} > On an initial {{cordova platform add}} this will work fine. However, this > updates {{package.json}} to add these plugins as dependencies: > {code} > +"cordova-plugin-apprate": > "git+https://github.com/pushandplay/cordova-plugin-apprate.git#0cc8b3b424491d35b1e571a69b21d2ae7cb9cff9;, > +"phonegap-plugin-push": "file:src/local-plugins/phonegap-plugin-push", > {code} > Now try: > {code} > rm -rf node_modules platforms plugins > npx npm@5.4.2 install > npx cordova@7.1.0 platform add ios > {code} > for example. Plugin installation will be unsuccessful: > {code} > Failed to restore plugin "phonegap-plugin-push" from config.xml. You might > need to try adding it again. Error: Failed to fetch plugin > file:src/local-plugins/phonegap-plugin-push via registry. > Failed to restore plugin "cordova-plugin-apprate" from config.xml. You might > need to try adding it again. Error: Failed to fetch plugin > git+https://github.com/pushandplay/cordova-plugin-apprate.git#0cc8b3b424491d35b1e571a69b21d2ae7cb9cff9 > via registry. > {code} > Manually removing the {{package.json}} update ({{\--nosave}} is broken > CB-13463) or using {{\--nofetch}} will work. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org