[jira] [Commented] (CB-12479) InAppBrowser: Add Loading Spinner for Android
[ https://issues.apache.org/jira/browse/CB-12479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16636037#comment-16636037 ] ASF GitHub Bot commented on CB-12479: - janpio commented on issue #88: CB-12479: Add loading spinner for android URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/88#issuecomment-426409145 (After final changes on our test environment the tests are now passing. Thanks for your help) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > InAppBrowser: Add Loading Spinner for Android > - > > Key: CB-12479 > URL: https://issues.apache.org/jira/browse/CB-12479 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-inappbrowser >Affects Versions: 2.5.0, 2.6.0, 2.7.0, 2.8.0 > Environment: Android (at least) >Reporter: jcesarmobile >Priority: Trivial > Labels: Triaged > > In CB-3750 a loader spinner was added for iOS. There was another PR for > Android but it was never merged, so I'm creating this new issue for Android. > PR https://github.com/apache/cordova-plugin-inappbrowser/pull/88 -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12479) InAppBrowser: Add Loading Spinner for Android
[ https://issues.apache.org/jira/browse/CB-12479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16634146#comment-16634146 ] ASF GitHub Bot commented on CB-12479: - cjpearson commented on issue #88: CB-12479: Add loading spinner for android URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/88#issuecomment-425937808 @janpio No problem, I had to make another change anyway. The latest commit replaces the deprecated ProgressDialog with a ProgressBar. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > InAppBrowser: Add Loading Spinner for Android > - > > Key: CB-12479 > URL: https://issues.apache.org/jira/browse/CB-12479 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-inappbrowser >Affects Versions: 2.5.0, 2.6.0, 2.7.0, 2.8.0 > Environment: Android (at least) >Reporter: jcesarmobile >Priority: Trivial > Labels: Triaged > > In CB-3750 a loader spinner was added for iOS. There was another PR for > Android but it was never merged, so I'm creating this new issue for Android. > PR https://github.com/apache/cordova-plugin-inappbrowser/pull/88 -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12479) InAppBrowser: Add Loading Spinner for Android
[ https://issues.apache.org/jira/browse/CB-12479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16634115#comment-16634115 ] ASF GitHub Bot commented on CB-12479: - janpio commented on issue #88: CB-12479: Add loading spinner for android URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/88#issuecomment-425935160 Thanks for the rebase, and sorry I didn't check what repo this PR was in before writing this: `cordova-plugin-inappbrowser` has another test problem. You can follow my progress understanding it here: https://github.com/apache/cordova-plugin-inappbrowser/issues/307 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > InAppBrowser: Add Loading Spinner for Android > - > > Key: CB-12479 > URL: https://issues.apache.org/jira/browse/CB-12479 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-inappbrowser >Affects Versions: 2.5.0, 2.6.0, 2.7.0, 2.8.0 > Environment: Android (at least) >Reporter: jcesarmobile >Priority: Trivial > Labels: Triaged > > In CB-3750 a loader spinner was added for iOS. There was another PR for > Android but it was never merged, so I'm creating this new issue for Android. > PR https://github.com/apache/cordova-plugin-inappbrowser/pull/88 -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12479) InAppBrowser: Add Loading Spinner for Android
[ https://issues.apache.org/jira/browse/CB-12479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16634051#comment-16634051 ] ASF GitHub Bot commented on CB-12479: - janpio commented on issue #88: CB-12479: Add loading spinner for android URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/88#issuecomment-425913364 Awesome. Unfortunately I have some more "work" for you: I just fixed the problem that caused Android tests to fail in `master`. Could you rebase this PR please? This should get rid of the Android failures and possibly fix all test failures for this PR. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > InAppBrowser: Add Loading Spinner for Android > - > > Key: CB-12479 > URL: https://issues.apache.org/jira/browse/CB-12479 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-inappbrowser >Affects Versions: 2.5.0, 2.6.0, 2.7.0, 2.8.0 > Environment: Android (at least) >Reporter: jcesarmobile >Priority: Trivial > Labels: Triaged > > In CB-3750 a loader spinner was added for iOS. There was another PR for > Android but it was never merged, so I'm creating this new issue for Android. > PR https://github.com/apache/cordova-plugin-inappbrowser/pull/88 -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12479) InAppBrowser: Add Loading Spinner for Android
[ https://issues.apache.org/jira/browse/CB-12479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16631905#comment-16631905 ] ASF GitHub Bot commented on CB-12479: - cjpearson commented on issue #88: CB-12479: Add loading spinner for android URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/88#issuecomment-425448179 @janpio Done. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > InAppBrowser: Add Loading Spinner for Android > - > > Key: CB-12479 > URL: https://issues.apache.org/jira/browse/CB-12479 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-inappbrowser >Affects Versions: 2.5.0, 2.6.0, 2.7.0, 2.8.0 > Environment: Android (at least) >Reporter: jcesarmobile >Priority: Trivial > Labels: Triaged > > In CB-3750 a loader spinner was added for iOS. There was another PR for > Android but it was never merged, so I'm creating this new issue for Android. > PR https://github.com/apache/cordova-plugin-inappbrowser/pull/88 -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12479) InAppBrowser: Add Loading Spinner for Android
[ https://issues.apache.org/jira/browse/CB-12479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16616827#comment-16616827 ] ASF GitHub Bot commented on CB-12479: - janpio commented on issue #88: CB-12479: Add loading spinner for android URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/88#issuecomment-421804792 Hey @cjpearson , there seems to be a merge conflict now. Could you maybe fix this? Thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > InAppBrowser: Add Loading Spinner for Android > - > > Key: CB-12479 > URL: https://issues.apache.org/jira/browse/CB-12479 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-inappbrowser >Affects Versions: 2.5.0, 2.6.0, 2.7.0, 2.8.0 > Environment: Android (at least) >Reporter: jcesarmobile >Priority: Trivial > Labels: Triaged > > In CB-3750 a loader spinner was added for iOS. There was another PR for > Android but it was never merged, so I'm creating this new issue for Android. > PR https://github.com/apache/cordova-plugin-inappbrowser/pull/88 -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
