[jira] [Commented] (CB-12875) iOS Magnifying glass is showing wrong content in iFrame
[ https://issues.apache.org/jira/browse/CB-12875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16587149#comment-16587149 ] ASF subversion and git services commented on CB-12875: -- Commit dc5329d15757cca1c327e87a309fddbb58e554ed in cordova-plugin-inappbrowser's branch refs/heads/master from Malte Norström [ https://gitbox.apache.org/repos/asf?p=cordova-plugin-inappbrowser.git;h=dc5329d ] CB-12875: (iOS) Pushes the inappbrowser window to a higher ui level than the existing apps window. (#284) > iOS Magnifying glass is showing wrong content in iFrame > --- > > Key: CB-12875 > URL: https://issues.apache.org/jira/browse/CB-12875 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-inappbrowser >Affects Versions: cordova@7.0.0 >Reporter: Thom Eijken >Priority: Major > Attachments: IMG_5791.jpg, IMG_5792.jpg > > > Our app is opening certain third party web pages using the inAppbrowser and > some of those pages (unfortunately) contain content in iFrames. > The issue occurs on iOS when you push and hold the screen to select text or > use the magnifying glass to set the cursor in an input/textarea field. What > happens is that the magnifying glass doesn't actually show the content within > the iFrame, but it shows the content underneath the in-appbrowser (the page > that launched the in-appbrowser). > I've created a very simple example to reproduce this. Just load test.html in > the in-appbrowser and use the magnifying glass inside the iframe. > File: test.html > > > > > > File: iframe.html > > > vhutriwbhrobh jbiortjtboirtw j bjrowijb iorwtj boirjgwobj org brw > jborjgiobj rojb org iob roi jboirtjwbiojrtowbj orjw bojrtobj rtj borjwiob > jrwio biorw b > vhreiuvhuierf hviu ehv oueh vo qv > o > > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12875) iOS Magnifying glass is showing wrong content in iFrame
[ https://issues.apache.org/jira/browse/CB-12875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16587151#comment-16587151 ] ASF GitHub Bot commented on CB-12875: - janpio closed pull request #251: CB-12875: (ios) Magnifiying glass is showing wrong content with inappbrowser window URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/251 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/src/ios/CDVInAppBrowser.m b/src/ios/CDVInAppBrowser.m index f5d05f013..588e8e065 100644 --- a/src/ios/CDVInAppBrowser.m +++ b/src/ios/CDVInAppBrowser.m @@ -243,7 +243,7 @@ - (void)show:(CDVInvokedUrlCommand*)command UIWindow *tmpWindow = [[UIWindow alloc] initWithFrame:frame]; UIViewController *tmpController = [[UIViewController alloc] init]; [tmpWindow setRootViewController:tmpController]; -[tmpWindow setWindowLevel:UIWindowLevelNormal]; +[tmpWindow setWindowLevel:UIWindowLevelNormal + 1]; [tmpWindow makeKeyAndVisible]; [tmpController presentViewController:nav animated:YES completion:nil]; This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > iOS Magnifying glass is showing wrong content in iFrame > --- > > Key: CB-12875 > URL: https://issues.apache.org/jira/browse/CB-12875 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-inappbrowser >Affects Versions: cordova@7.0.0 >Reporter: Thom Eijken >Priority: Major > Attachments: IMG_5791.jpg, IMG_5792.jpg > > > Our app is opening certain third party web pages using the inAppbrowser and > some of those pages (unfortunately) contain content in iFrames. > The issue occurs on iOS when you push and hold the screen to select text or > use the magnifying glass to set the cursor in an input/textarea field. What > happens is that the magnifying glass doesn't actually show the content within > the iFrame, but it shows the content underneath the in-appbrowser (the page > that launched the in-appbrowser). > I've created a very simple example to reproduce this. Just load test.html in > the in-appbrowser and use the magnifying glass inside the iframe. > File: test.html > > > > > > File: iframe.html > > > vhutriwbhrobh jbiortjtboirtw j bjrowijb iorwtj boirjgwobj org brw > jborjgiobj rojb org iob roi jboirtjwbiojrtowbj orjw bojrtobj rtj borjwiob > jrwio biorw b > vhreiuvhuierf hviu ehv oueh vo qv > o > > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12875) iOS Magnifying glass is showing wrong content in iFrame
[ https://issues.apache.org/jira/browse/CB-12875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16587153#comment-16587153 ] ASF GitHub Bot commented on CB-12875: - janpio commented on issue #284: CB-12875: (iOS) Pushes the inappbrowser window to a higher UI level then the existing… URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/284#issuecomment-414594672 🥇 Thanks for your first merged PR @maltenorstroem! 💯 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > iOS Magnifying glass is showing wrong content in iFrame > --- > > Key: CB-12875 > URL: https://issues.apache.org/jira/browse/CB-12875 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-inappbrowser >Affects Versions: cordova@7.0.0 >Reporter: Thom Eijken >Priority: Major > Attachments: IMG_5791.jpg, IMG_5792.jpg > > > Our app is opening certain third party web pages using the inAppbrowser and > some of those pages (unfortunately) contain content in iFrames. > The issue occurs on iOS when you push and hold the screen to select text or > use the magnifying glass to set the cursor in an input/textarea field. What > happens is that the magnifying glass doesn't actually show the content within > the iFrame, but it shows the content underneath the in-appbrowser (the page > that launched the in-appbrowser). > I've created a very simple example to reproduce this. Just load test.html in > the in-appbrowser and use the magnifying glass inside the iframe. > File: test.html > > > > > > File: iframe.html > > > vhutriwbhrobh jbiortjtboirtw j bjrowijb iorwtj boirjgwobj org brw > jborjgiobj rojb org iob roi jboirtjwbiojrtowbj orjw bojrtobj rtj borjwiob > jrwio biorw b > vhreiuvhuierf hviu ehv oueh vo qv > o > > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12875) iOS Magnifying glass is showing wrong content in iFrame
[ https://issues.apache.org/jira/browse/CB-12875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16587150#comment-16587150 ] ASF GitHub Bot commented on CB-12875: - janpio commented on issue #251: CB-12875: (ios) Magnifiying glass is showing wrong content with inappbrowser window URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/251#issuecomment-414594514 https://github.com/apache/cordova-plugin-inappbrowser/pull/284 has been merged as an improved version of this. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > iOS Magnifying glass is showing wrong content in iFrame > --- > > Key: CB-12875 > URL: https://issues.apache.org/jira/browse/CB-12875 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-inappbrowser >Affects Versions: cordova@7.0.0 >Reporter: Thom Eijken >Priority: Major > Attachments: IMG_5791.jpg, IMG_5792.jpg > > > Our app is opening certain third party web pages using the inAppbrowser and > some of those pages (unfortunately) contain content in iFrames. > The issue occurs on iOS when you push and hold the screen to select text or > use the magnifying glass to set the cursor in an input/textarea field. What > happens is that the magnifying glass doesn't actually show the content within > the iFrame, but it shows the content underneath the in-appbrowser (the page > that launched the in-appbrowser). > I've created a very simple example to reproduce this. Just load test.html in > the in-appbrowser and use the magnifying glass inside the iframe. > File: test.html > > > > > > File: iframe.html > > > vhutriwbhrobh jbiortjtboirtw j bjrowijb iorwtj boirjgwobj org brw > jborjgiobj rojb org iob roi jboirtjwbiojrtowbj orjw bojrtobj rtj borjwiob > jrwio biorw b > vhreiuvhuierf hviu ehv oueh vo qv > o > > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12875) iOS Magnifying glass is showing wrong content in iFrame
[ https://issues.apache.org/jira/browse/CB-12875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16587148#comment-16587148 ] ASF GitHub Bot commented on CB-12875: - janpio closed pull request #284: CB-12875: (iOS) Pushes the inappbrowser window to a higher UI level then the existing… URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/284 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/.gitignore b/.gitignore index 4474e73b4..f63dbbf71 100644 --- a/.gitignore +++ b/.gitignore @@ -11,6 +11,7 @@ Thumbs.db *.log *.swp *.user +*.idea node_modules diff --git a/src/ios/CDVInAppBrowser.m b/src/ios/CDVInAppBrowser.m index 5bdb3e1eb..fcd8d984e 100644 --- a/src/ios/CDVInAppBrowser.m +++ b/src/ios/CDVInAppBrowser.m @@ -244,8 +244,9 @@ - (void)show:(CDVInvokedUrlCommand*)command tmpWindow = [[UIWindow alloc] initWithFrame:frame]; } UIViewController *tmpController = [[UIViewController alloc] init]; +double baseWindowLevel = [UIApplication sharedApplication].keyWindow.windowLevel; [tmpWindow setRootViewController:tmpController]; -[tmpWindow setWindowLevel:UIWindowLevelNormal]; +[tmpWindow setWindowLevel:baseWindowLevel+1]; [tmpWindow makeKeyAndVisible]; [tmpController presentViewController:nav animated:YES completion:nil]; This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > iOS Magnifying glass is showing wrong content in iFrame > --- > > Key: CB-12875 > URL: https://issues.apache.org/jira/browse/CB-12875 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-inappbrowser >Affects Versions: cordova@7.0.0 >Reporter: Thom Eijken >Priority: Major > Attachments: IMG_5791.jpg, IMG_5792.jpg > > > Our app is opening certain third party web pages using the inAppbrowser and > some of those pages (unfortunately) contain content in iFrames. > The issue occurs on iOS when you push and hold the screen to select text or > use the magnifying glass to set the cursor in an input/textarea field. What > happens is that the magnifying glass doesn't actually show the content within > the iFrame, but it shows the content underneath the in-appbrowser (the page > that launched the in-appbrowser). > I've created a very simple example to reproduce this. Just load test.html in > the in-appbrowser and use the magnifying glass inside the iframe. > File: test.html > > > > > > File: iframe.html > > > vhutriwbhrobh jbiortjtboirtw j bjrowijb iorwtj boirjgwobj org brw > jborjgiobj rojb org iob roi jboirtjwbiojrtowbj orjw bojrtobj rtj borjwiob > jrwio biorw b > vhreiuvhuierf hviu ehv oueh vo qv > o > > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12875) iOS Magnifying glass is showing wrong content in iFrame
[ https://issues.apache.org/jira/browse/CB-12875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16586869#comment-16586869 ] ASF GitHub Bot commented on CB-12875: - shazron edited a comment on issue #284: CB-12875: (iOS) Pushes the inappbrowser window to a higher UI level then the existing… URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/284#issuecomment-414536525 I see a failed build for MS Edge on Travis CI. I've tried multiple times restarting it, but it still fails. Looking at other PRs there seems to be general flakiness with browser builds. Besides that, the PR LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > iOS Magnifying glass is showing wrong content in iFrame > --- > > Key: CB-12875 > URL: https://issues.apache.org/jira/browse/CB-12875 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-inappbrowser >Affects Versions: cordova@7.0.0 >Reporter: Thom Eijken >Priority: Major > Attachments: IMG_5791.jpg, IMG_5792.jpg > > > Our app is opening certain third party web pages using the inAppbrowser and > some of those pages (unfortunately) contain content in iFrames. > The issue occurs on iOS when you push and hold the screen to select text or > use the magnifying glass to set the cursor in an input/textarea field. What > happens is that the magnifying glass doesn't actually show the content within > the iFrame, but it shows the content underneath the in-appbrowser (the page > that launched the in-appbrowser). > I've created a very simple example to reproduce this. Just load test.html in > the in-appbrowser and use the magnifying glass inside the iframe. > File: test.html > > > > > > File: iframe.html > > > vhutriwbhrobh jbiortjtboirtw j bjrowijb iorwtj boirjgwobj org brw > jborjgiobj rojb org iob roi jboirtjwbiojrtowbj orjw bojrtobj rtj borjwiob > jrwio biorw b > vhreiuvhuierf hviu ehv oueh vo qv > o > > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12875) iOS Magnifying glass is showing wrong content in iFrame
[ https://issues.apache.org/jira/browse/CB-12875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16586868#comment-16586868 ] ASF GitHub Bot commented on CB-12875: - shazron commented on issue #284: CB-12875: (iOS) Pushes the inappbrowser window to a higher UI level then the existing… URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/284#issuecomment-414536525 I see a failed build for MS Edge on Travis CI. I've tried multiple times restarting it, but it still fails. Looking at other PRs there seems to be general flakiness with browser builds. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > iOS Magnifying glass is showing wrong content in iFrame > --- > > Key: CB-12875 > URL: https://issues.apache.org/jira/browse/CB-12875 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-inappbrowser >Affects Versions: cordova@7.0.0 >Reporter: Thom Eijken >Priority: Major > Attachments: IMG_5791.jpg, IMG_5792.jpg > > > Our app is opening certain third party web pages using the inAppbrowser and > some of those pages (unfortunately) contain content in iFrames. > The issue occurs on iOS when you push and hold the screen to select text or > use the magnifying glass to set the cursor in an input/textarea field. What > happens is that the magnifying glass doesn't actually show the content within > the iFrame, but it shows the content underneath the in-appbrowser (the page > that launched the in-appbrowser). > I've created a very simple example to reproduce this. Just load test.html in > the in-appbrowser and use the magnifying glass inside the iframe. > File: test.html > > > > > > File: iframe.html > > > vhutriwbhrobh jbiortjtboirtw j bjrowijb iorwtj boirjgwobj org brw > jborjgiobj rojb org iob roi jboirtjwbiojrtowbj orjw bojrtobj rtj borjwiob > jrwio biorw b > vhreiuvhuierf hviu ehv oueh vo qv > o > > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12875) iOS Magnifying glass is showing wrong content in iFrame
[ https://issues.apache.org/jira/browse/CB-12875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16585932#comment-16585932 ] ASF GitHub Bot commented on CB-12875: - maltenorstroem commented on issue #284: CB-12875: (iOS) Pushes the inappbrowser window to a higher UI level then the existing… URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/284#issuecomment-414317876 In my opinion, this is a simple correction of the already created PR. The underlying window level is respected. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > iOS Magnifying glass is showing wrong content in iFrame > --- > > Key: CB-12875 > URL: https://issues.apache.org/jira/browse/CB-12875 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-inappbrowser >Affects Versions: cordova@7.0.0 >Reporter: Thom Eijken >Priority: Major > Attachments: IMG_5791.jpg, IMG_5792.jpg > > > Our app is opening certain third party web pages using the inAppbrowser and > some of those pages (unfortunately) contain content in iFrames. > The issue occurs on iOS when you push and hold the screen to select text or > use the magnifying glass to set the cursor in an input/textarea field. What > happens is that the magnifying glass doesn't actually show the content within > the iFrame, but it shows the content underneath the in-appbrowser (the page > that launched the in-appbrowser). > I've created a very simple example to reproduce this. Just load test.html in > the in-appbrowser and use the magnifying glass inside the iframe. > File: test.html > > > > > > File: iframe.html > > > vhutriwbhrobh jbiortjtboirtw j bjrowijb iorwtj boirjgwobj org brw > jborjgiobj rojb org iob roi jboirtjwbiojrtowbj orjw bojrtobj rtj borjwiob > jrwio biorw b > vhreiuvhuierf hviu ehv oueh vo qv > o > > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12875) iOS Magnifying glass is showing wrong content in iFrame
[ https://issues.apache.org/jira/browse/CB-12875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16585932#comment-16585932 ] ASF GitHub Bot commented on CB-12875: - maltenorstroem commented on issue #284: CB-12875: (iOS) Pushes the inappbrowser window to a higher UI level then the existing… URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/284#issuecomment-414317876 In my opinion, this is a simple correction of the already created PR. The underlying window level is respected. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > iOS Magnifying glass is showing wrong content in iFrame > --- > > Key: CB-12875 > URL: https://issues.apache.org/jira/browse/CB-12875 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-inappbrowser >Affects Versions: cordova@7.0.0 >Reporter: Thom Eijken >Priority: Major > Attachments: IMG_5791.jpg, IMG_5792.jpg > > > Our app is opening certain third party web pages using the inAppbrowser and > some of those pages (unfortunately) contain content in iFrames. > The issue occurs on iOS when you push and hold the screen to select text or > use the magnifying glass to set the cursor in an input/textarea field. What > happens is that the magnifying glass doesn't actually show the content within > the iFrame, but it shows the content underneath the in-appbrowser (the page > that launched the in-appbrowser). > I've created a very simple example to reproduce this. Just load test.html in > the in-appbrowser and use the magnifying glass inside the iframe. > File: test.html > > > > > > File: iframe.html > > > vhutriwbhrobh jbiortjtboirtw j bjrowijb iorwtj boirjgwobj org brw > jborjgiobj rojb org iob roi jboirtjwbiojrtowbj orjw bojrtobj rtj borjwiob > jrwio biorw b > vhreiuvhuierf hviu ehv oueh vo qv > o > > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12875) iOS Magnifying glass is showing wrong content in iFrame
[ https://issues.apache.org/jira/browse/CB-12875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16585925#comment-16585925 ] ASF GitHub Bot commented on CB-12875: - janpio edited a comment on issue #284: CB-12875: (iOS) Pushes the inappbrowser window to a higher UI level then the existing… URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/284#issuecomment-414315260 Are there any possible other side effects of this? Behavior someone might rely on that changes? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > iOS Magnifying glass is showing wrong content in iFrame > --- > > Key: CB-12875 > URL: https://issues.apache.org/jira/browse/CB-12875 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-inappbrowser >Affects Versions: cordova@7.0.0 >Reporter: Thom Eijken >Priority: Major > Attachments: IMG_5791.jpg, IMG_5792.jpg > > > Our app is opening certain third party web pages using the inAppbrowser and > some of those pages (unfortunately) contain content in iFrames. > The issue occurs on iOS when you push and hold the screen to select text or > use the magnifying glass to set the cursor in an input/textarea field. What > happens is that the magnifying glass doesn't actually show the content within > the iFrame, but it shows the content underneath the in-appbrowser (the page > that launched the in-appbrowser). > I've created a very simple example to reproduce this. Just load test.html in > the in-appbrowser and use the magnifying glass inside the iframe. > File: test.html > > > > > > File: iframe.html > > > vhutriwbhrobh jbiortjtboirtw j bjrowijb iorwtj boirjgwobj org brw > jborjgiobj rojb org iob roi jboirtjwbiojrtowbj orjw bojrtobj rtj borjwiob > jrwio biorw b > vhreiuvhuierf hviu ehv oueh vo qv > o > > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12875) iOS Magnifying glass is showing wrong content in iFrame
[ https://issues.apache.org/jira/browse/CB-12875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16585923#comment-16585923 ] ASF GitHub Bot commented on CB-12875: - janpio commented on issue #284: CB-12875: (iOS) Pushes the inappbrowser window to a higher UI level then the existing… URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/284#issuecomment-414315260 Any possible other side effects of this? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > iOS Magnifying glass is showing wrong content in iFrame > --- > > Key: CB-12875 > URL: https://issues.apache.org/jira/browse/CB-12875 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-inappbrowser >Affects Versions: cordova@7.0.0 >Reporter: Thom Eijken >Priority: Major > Attachments: IMG_5791.jpg, IMG_5792.jpg > > > Our app is opening certain third party web pages using the inAppbrowser and > some of those pages (unfortunately) contain content in iFrames. > The issue occurs on iOS when you push and hold the screen to select text or > use the magnifying glass to set the cursor in an input/textarea field. What > happens is that the magnifying glass doesn't actually show the content within > the iFrame, but it shows the content underneath the in-appbrowser (the page > that launched the in-appbrowser). > I've created a very simple example to reproduce this. Just load test.html in > the in-appbrowser and use the magnifying glass inside the iframe. > File: test.html > > > > > > File: iframe.html > > > vhutriwbhrobh jbiortjtboirtw j bjrowijb iorwtj boirjgwobj org brw > jborjgiobj rojb org iob roi jboirtjwbiojrtowbj orjw bojrtobj rtj borjwiob > jrwio biorw b > vhreiuvhuierf hviu ehv oueh vo qv > o > > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12875) iOS Magnifying glass is showing wrong content in iFrame
[ https://issues.apache.org/jira/browse/CB-12875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16585918#comment-16585918 ] ASF GitHub Bot commented on CB-12875: - maltenorstroem opened a new pull request #284: CB-12875: (iOS) Pushes the inappbrowser window to a higher UI level then the existing… URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/284 … app's window ### Platforms affected iOS ### What does this PR do? Pushes the inappbrowser window to a higher UI leven then the existing app's window. Fix for CB-12875: (ios) Magnifiying glass is showing wrong content with inappbrowser window #251 ### What testing has been done on this change? Tested on device (iOS 9.0, 10.2, 11.4) and simulator. ### Checklist - [x ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [x ] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [ ] Added automated test coverage as appropriate for this change. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > iOS Magnifying glass is showing wrong content in iFrame > --- > > Key: CB-12875 > URL: https://issues.apache.org/jira/browse/CB-12875 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-inappbrowser >Affects Versions: cordova@7.0.0 >Reporter: Thom Eijken >Priority: Major > Attachments: IMG_5791.jpg, IMG_5792.jpg > > > Our app is opening certain third party web pages using the inAppbrowser and > some of those pages (unfortunately) contain content in iFrames. > The issue occurs on iOS when you push and hold the screen to select text or > use the magnifying glass to set the cursor in an input/textarea field. What > happens is that the magnifying glass doesn't actually show the content within > the iFrame, but it shows the content underneath the in-appbrowser (the page > that launched the in-appbrowser). > I've created a very simple example to reproduce this. Just load test.html in > the in-appbrowser and use the magnifying glass inside the iframe. > File: test.html > > > > > > File: iframe.html > > > vhutriwbhrobh jbiortjtboirtw j bjrowijb iorwtj boirjgwobj org brw > jborjgiobj rojb org iob roi jboirtjwbiojrtowbj orjw bojrtobj rtj borjwiob > jrwio biorw b > vhreiuvhuierf hviu ehv oueh vo qv > o > > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12875) iOS Magnifying glass is showing wrong content in iFrame
[ https://issues.apache.org/jira/browse/CB-12875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16480034#comment-16480034 ] ASF GitHub Bot commented on CB-12875: - asialatsushi commented on issue #251: CB-12875: (ios) Magnifiying glass is showing wrong content with inappbrowser window URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/251#issuecomment-390074582 👍 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > iOS Magnifying glass is showing wrong content in iFrame > --- > > Key: CB-12875 > URL: https://issues.apache.org/jira/browse/CB-12875 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-inappbrowser >Affects Versions: cordova@7.0.0 >Reporter: Thom Eijken >Priority: Major > Attachments: IMG_5791.jpg, IMG_5792.jpg > > > Our app is opening certain third party web pages using the inAppbrowser and > some of those pages (unfortunately) contain content in iFrames. > The issue occurs on iOS when you push and hold the screen to select text or > use the magnifying glass to set the cursor in an input/textarea field. What > happens is that the magnifying glass doesn't actually show the content within > the iFrame, but it shows the content underneath the in-appbrowser (the page > that launched the in-appbrowser). > I've created a very simple example to reproduce this. Just load test.html in > the in-appbrowser and use the magnifying glass inside the iframe. > File: test.html > > > > > > File: iframe.html > > > vhutriwbhrobh jbiortjtboirtw j bjrowijb iorwtj boirjgwobj org brw > jborjgiobj rojb org iob roi jboirtjwbiojrtowbj orjw bojrtobj rtj borjwiob > jrwio biorw b > vhreiuvhuierf hviu ehv oueh vo qv > o > > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12875) iOS Magnifying glass is showing wrong content in iFrame
[ https://issues.apache.org/jira/browse/CB-12875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16271704#comment-16271704 ] ASF GitHub Bot commented on CB-12875: - surajpindoria opened a new pull request #251: CB-12875: (ios) Magnifiying glass is showing wrong content with inapp… URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/251 …browser window ### Platforms affected iOS ### What does this PR do? Pushes the inappbrowser window to a new UI level to fix the magnifying glass. ### What testing has been done on this change? Tested on a device and simulator. ### Checklist - [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [ ] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [ ] Added automated test coverage as appropriate for this change. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > iOS Magnifying glass is showing wrong content in iFrame > --- > > Key: CB-12875 > URL: https://issues.apache.org/jira/browse/CB-12875 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-inappbrowser >Affects Versions: cordova@7.0.0 >Reporter: Thom Eijken > Attachments: IMG_5791.jpg, IMG_5792.jpg > > > Our app is opening certain third party web pages using the inAppbrowser and > some of those pages (unfortunately) contain content in iFrames. > The issue occurs on iOS when you push and hold the screen to select text or > use the magnifying glass to set the cursor in an input/textarea field. What > happens is that the magnifying glass doesn't actually show the content within > the iFrame, but it shows the content underneath the in-appbrowser (the page > that launched the in-appbrowser). > I've created a very simple example to reproduce this. Just load test.html in > the in-appbrowser and use the magnifying glass inside the iframe. > File: test.html > > > > > > File: iframe.html > > > vhutriwbhrobh jbiortjtboirtw j bjrowijb iorwtj boirjgwobj org brw > jborjgiobj rojb org iob roi jboirtjwbiojrtowbj orjw bojrtobj rtj borjwiob > jrwio biorw b > vhreiuvhuierf hviu ehv oueh vo qv > o > > -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12875) iOS Magnifying glass is showing wrong content in iFrame
[ https://issues.apache.org/jira/browse/CB-12875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16236158#comment-16236158 ] Veniamin Craciun commented on CB-12875: --- Since my issue was marked as a duplicate and no one has figured it out. This issue has a simple solution is to change from "[tmpWindow setWindowLevel:UIWindowLevelNormal]" to "[tmpWindow setWindowLevel:UIWindowLevelNormal + 1];" this way InAppBrowser stays above. > iOS Magnifying glass is showing wrong content in iFrame > --- > > Key: CB-12875 > URL: https://issues.apache.org/jira/browse/CB-12875 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-inappbrowser >Affects Versions: cordova@7.0.0 >Reporter: Thom Eijken >Priority: Major > Attachments: IMG_5791.jpg, IMG_5792.jpg > > > Our app is opening certain third party web pages using the inAppbrowser and > some of those pages (unfortunately) contain content in iFrames. > The issue occurs on iOS when you push and hold the screen to select text or > use the magnifying glass to set the cursor in an input/textarea field. What > happens is that the magnifying glass doesn't actually show the content within > the iFrame, but it shows the content underneath the in-appbrowser (the page > that launched the in-appbrowser). > I've created a very simple example to reproduce this. Just load test.html in > the in-appbrowser and use the magnifying glass inside the iframe. > File: test.html > > > > > > File: iframe.html > > > vhutriwbhrobh jbiortjtboirtw j bjrowijb iorwtj boirjgwobj org brw > jborjgiobj rojb org iob roi jboirtjwbiojrtowbj orjw bojrtobj rtj borjwiob > jrwio biorw b > vhreiuvhuierf hviu ehv oueh vo qv > o > > -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12875) iOS Magnifying glass is showing wrong content in iFrame
[ https://issues.apache.org/jira/browse/CB-12875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16035322#comment-16035322 ] Thom Eijken commented on CB-12875: -- Just attached the screenshots in my test app. I've tested this on iOS 9.3.5 (iphone 5S) and iOS 10.2 (iphone 7). InAppBrowser plug version is 1.7.1. > iOS Magnifying glass is showing wrong content in iFrame > --- > > Key: CB-12875 > URL: https://issues.apache.org/jira/browse/CB-12875 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-inappbrowser >Affects Versions: cordova@7.0.0 >Reporter: Thom Eijken > Attachments: IMG_5791.jpg, IMG_5792.jpg > > > Our app is opening certain third party web pages using the inAppbrowser and > some of those pages (unfortunately) contain content in iFrames. > The issue occurs on iOS when you push and hold the screen to select text or > use the magnifying glass to set the cursor in an input/textarea field. What > happens is that the magnifying glass doesn't actually show the content within > the iFrame, but it shows the content underneath the in-appbrowser (the page > that launched the in-appbrowser). > I've created a very simple example to reproduce this. Just load test.html in > the in-appbrowser and use the magnifying glass inside the iframe. > File: test.html > > > > > > File: iframe.html > > > vhutriwbhrobh jbiortjtboirtw j bjrowijb iorwtj boirjgwobj org brw > jborjgiobj rojb org iob roi jboirtjwbiojrtowbj orjw bojrtobj rtj borjwiob > jrwio biorw b > vhreiuvhuierf hviu ehv oueh vo qv > o > > -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12875) iOS Magnifying glass is showing wrong content in iFrame
[ https://issues.apache.org/jira/browse/CB-12875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16035307#comment-16035307 ] Kerri Shotts commented on CB-12875: --- Also -- what version of the inappbrowser plugin are you using? > iOS Magnifying glass is showing wrong content in iFrame > --- > > Key: CB-12875 > URL: https://issues.apache.org/jira/browse/CB-12875 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-inappbrowser >Affects Versions: cordova@7.0.0 >Reporter: Thom Eijken > Attachments: IMG_5791.jpg, IMG_5792.jpg > > > Our app is opening certain third party web pages using the inAppbrowser and > some of those pages (unfortunately) contain content in iFrames. > The issue occurs on iOS when you push and hold the screen to select text or > use the magnifying glass to set the cursor in an input/textarea field. What > happens is that the magnifying glass doesn't actually show the content within > the iFrame, but it shows the content underneath the in-appbrowser (the page > that launched the in-appbrowser). > I've created a very simple example to reproduce this. Just load test.html in > the in-appbrowser and use the magnifying glass inside the iframe. > File: test.html > > > > > > File: iframe.html > > > vhutriwbhrobh jbiortjtboirtw j bjrowijb iorwtj boirjgwobj org brw > jborjgiobj rojb org iob roi jboirtjwbiojrtowbj orjw bojrtobj rtj borjwiob > jrwio biorw b > vhreiuvhuierf hviu ehv oueh vo qv > o > > -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12875) iOS Magnifying glass is showing wrong content in iFrame
[ https://issues.apache.org/jira/browse/CB-12875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16035266#comment-16035266 ] Kerri Shotts commented on CB-12875: --- Please add a screenshot so we aren't guessing at what we're supposed to see. Also indicate which version(s) of iOS and device(s) you've tried on. > iOS Magnifying glass is showing wrong content in iFrame > --- > > Key: CB-12875 > URL: https://issues.apache.org/jira/browse/CB-12875 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-inappbrowser >Affects Versions: cordova@7.0.0 >Reporter: Thom Eijken > > Our app is opening certain third party web pages using the inAppbrowser and > some of those pages (unfortunately) contain content in iFrames. > The issue occurs on iOS when you push and hold the screen to select text or > use the magnifying glass to set the cursor in an input/textarea field. What > happens is that the magnifying glass doesn't actually show the content within > the iFrame, but it shows the content underneath the in-appbrowser (the page > that launched the in-appbrowser). > I've created a very simple example to reproduce this. Just load test.html in > the in-appbrowser and use the magnifying glass inside the iframe. > File: test.html > > > > > > File: iframe.html > > > vhutriwbhrobh jbiortjtboirtw j bjrowijb iorwtj boirjgwobj org brw > jborjgiobj rojb org iob roi jboirtjwbiojrtowbj orjw bojrtobj rtj borjwiob > jrwio biorw b > vhreiuvhuierf hviu ehv oueh vo qv > o > > -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
