[jira] [Commented] (CB-13307) Accessing Google Photos on Pixel from cordova-plugin-camera

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-13307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16634485#comment-16634485
 ] 

ASF GitHub Bot commented on CB-13307:
-

janpio commented on issue #286: CB-13307: (Android) Fixed issue when unable to 
load image with mime t…
URL: 
https://github.com/apache/cordova-plugin-camera/pull/286#issuecomment-426024101
 
 
   Jippieh! I removed some unwanted changes to README that somehow made their 
way into this via merge/rebase. Now "only" waiting for review and merge.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Accessing Google Photos on Pixel from cordova-plugin-camera
> ---
>
> Key: CB-13307
> URL: https://issues.apache.org/jira/browse/CB-13307
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-camera
>Reporter: David Briglio
>Priority: Major
>
> Currently when trying to access some photos from Google Photos, it fails to 
> load. Android 8.0 on Google Pixel, cordova version 6.5.0, 
> cordova-plugin-camera version 2.4.1.
> Causes:
> 1) Only mimetypes "image/jpeg" and "image/png" are accepted, all other types 
> are considered an invalid image. The mimetype of the image I am loading gets 
> set to "image/*".
> 2) In FileHelper.java: when hitting the isGooglePhotosUri method, the uri 
> authority is compared against "com.google.android.apps.photos.content", where 
> the actual is "com.google.android.apps.photos.contentprovider". This causes 
> the logic to dismiss the image as not from Google Photos.
> After applying fixes for these two areas, I am able to successfully load all 
> of my images.
> Merge request [here|https://github.com/apache/cordova-plugin-camera/pull/286].



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13307) Accessing Google Photos on Pixel from cordova-plugin-camera

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-13307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16634475#comment-16634475
 ] 

ASF GitHub Bot commented on CB-13307:
-

DavidBriglio commented on issue #286: CB-13307: (Android) Fixed issue when 
unable to load image with mime t…
URL: 
https://github.com/apache/cordova-plugin-camera/pull/286#issuecomment-426020724
 
 
   @janpio Tests are now passing!


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Accessing Google Photos on Pixel from cordova-plugin-camera
> ---
>
> Key: CB-13307
> URL: https://issues.apache.org/jira/browse/CB-13307
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-camera
>Reporter: David Briglio
>Priority: Major
>
> Currently when trying to access some photos from Google Photos, it fails to 
> load. Android 8.0 on Google Pixel, cordova version 6.5.0, 
> cordova-plugin-camera version 2.4.1.
> Causes:
> 1) Only mimetypes "image/jpeg" and "image/png" are accepted, all other types 
> are considered an invalid image. The mimetype of the image I am loading gets 
> set to "image/*".
> 2) In FileHelper.java: when hitting the isGooglePhotosUri method, the uri 
> authority is compared against "com.google.android.apps.photos.content", where 
> the actual is "com.google.android.apps.photos.contentprovider". This causes 
> the logic to dismiss the image as not from Google Photos.
> After applying fixes for these two areas, I am able to successfully load all 
> of my images.
> Merge request [here|https://github.com/apache/cordova-plugin-camera/pull/286].



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13307) Accessing Google Photos on Pixel from cordova-plugin-camera

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-13307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16634379#comment-16634379
 ] 

ASF GitHub Bot commented on CB-13307:
-

janpio commented on issue #286: CB-13307: (Android) Fixed issue when unable to 
load image with mime t…
URL: 
https://github.com/apache/cordova-plugin-camera/pull/286#issuecomment-425996898
 
 
   And another rebase/merge from `master` to get those tests passing 
@DavidBriglio?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Accessing Google Photos on Pixel from cordova-plugin-camera
> ---
>
> Key: CB-13307
> URL: https://issues.apache.org/jira/browse/CB-13307
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-camera
>Reporter: David Briglio
>Priority: Major
>
> Currently when trying to access some photos from Google Photos, it fails to 
> load. Android 8.0 on Google Pixel, cordova version 6.5.0, 
> cordova-plugin-camera version 2.4.1.
> Causes:
> 1) Only mimetypes "image/jpeg" and "image/png" are accepted, all other types 
> are considered an invalid image. The mimetype of the image I am loading gets 
> set to "image/*".
> 2) In FileHelper.java: when hitting the isGooglePhotosUri method, the uri 
> authority is compared against "com.google.android.apps.photos.content", where 
> the actual is "com.google.android.apps.photos.contentprovider". This causes 
> the logic to dismiss the image as not from Google Photos.
> After applying fixes for these two areas, I am able to successfully load all 
> of my images.
> Merge request [here|https://github.com/apache/cordova-plugin-camera/pull/286].



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13307) Accessing Google Photos on Pixel from cordova-plugin-camera

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-13307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16633143#comment-16633143
 ] 

ASF GitHub Bot commented on CB-13307:
-

DavidBriglio opened a new pull request #286: CB-13307: (Android) Fixed issue 
when unable to load image with mime t…
URL: https://github.com/apache/cordova-plugin-camera/pull/286
 
 
   …ype "image/*", and failing to recognize new contentprovider uri authority.
   
   ### Platforms affected
   Android
   
   ### What does this PR do?
   Allows for image mimetype "image/*" to be accepted as a valid image.
   Allows for google photos uri authority ".contentprovider" to be recognized.
   
   ### What testing has been done on this change?
   When running "npm test" results in "invalid config loglevel='notice'".
   When running "npm run test-build" results in "missing script: test-build".
   Manual testing has been done on Android 8.0 Google Pixel with cordova cli 
6.5.0.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Accessing Google Photos on Pixel from cordova-plugin-camera
> ---
>
> Key: CB-13307
> URL: https://issues.apache.org/jira/browse/CB-13307
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-camera
>Reporter: David Briglio
>Priority: Major
>
> Currently when trying to access some photos from Google Photos, it fails to 
> load. Android 8.0 on Google Pixel, cordova version 6.5.0, 
> cordova-plugin-camera version 2.4.1.
> Causes:
> 1) Only mimetypes "image/jpeg" and "image/png" are accepted, all other types 
> are considered an invalid image. The mimetype of the image I am loading gets 
> set to "image/*".
> 2) In FileHelper.java: when hitting the isGooglePhotosUri method, the uri 
> authority is compared against "com.google.android.apps.photos.content", where 
> the actual is "com.google.android.apps.photos.contentprovider". This causes 
> the logic to dismiss the image as not from Google Photos.
> After applying fixes for these two areas, I am able to successfully load all 
> of my images.
> Merge request [here|https://github.com/apache/cordova-plugin-camera/pull/286].



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13307) Accessing Google Photos on Pixel from cordova-plugin-camera

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-13307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16633142#comment-16633142
 ] 

ASF GitHub Bot commented on CB-13307:
-

janpio closed pull request #286: CB-13307: (Android) Fixed issue when unable to 
load image with mime t…
URL: https://github.com/apache/cordova-plugin-camera/pull/286
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/README.md b/README.md
index 901f5d86..662d998d 100644
--- a/README.md
+++ b/README.md
@@ -21,9 +21,9 @@ description: Take pictures with the device camera.
 # under the License.
 -->
 
-|AppVeyor|Travis CI|
-|:-:|:-:|
-|[![Build 
status](https://ci.appveyor.com/api/projects/status/github/apache/cordova-plugin-camera?branch=master)](https://ci.appveyor.com/project/ApacheSoftwareFoundation/cordova-plugin-camera)|[![Build
 
Status](https://travis-ci.org/apache/cordova-plugin-camera.svg?branch=master)](https://travis-ci.org/apache/cordova-plugin-camera)|
+|Android|iOS| Windows 8.1 Store | Windows 8.1 Phone | Windows 10 Store | 
Travis CI |
+|:-:|:-:|:-:|:-:|:-:|:-:|
+|[![Build 
Status](http://cordova-ci.cloudapp.net:8080/buildStatus/icon?job=cordova-periodic-build/PLATFORM=android,PLUGIN=cordova-plugin-camera)](http://cordova-ci.cloudapp.net:8080/job/cordova-periodic-build/PLATFORM=android,PLUGIN=cordova-plugin-camera/)|[![Build
 
Status](http://cordova-ci.cloudapp.net:8080/buildStatus/icon?job=cordova-periodic-build/PLATFORM=ios,PLUGIN=cordova-plugin-camera)](http://cordova-ci.cloudapp.net:8080/job/cordova-periodic-build/PLATFORM=ios,PLUGIN=cordova-plugin-camera/)|[![Build
 
Status](http://cordova-ci.cloudapp.net:8080/buildStatus/icon?job=cordova-periodic-build/PLATFORM=windows-8.1-store,PLUGIN=cordova-plugin-camera)](http://cordova-ci.cloudapp.net:8080/job/cordova-periodic-build/PLATFORM=windows-8.1-store,PLUGIN=cordova-plugin-camera/)|[![Build
 
Status](http://cordova-ci.cloudapp.net:8080/buildStatus/icon?job=cordova-periodic-build/PLATFORM=windows-8.1-phone,PLUGIN=cordova-plugin-camera)](http://cordova-ci.cloudapp.net:8080/job/cordova-periodic-build/PLATFORM=windows-8.1-phone,PLUGIN=cordova-plugin-camera/)|[![Build
 
Status](http://cordova-ci.cloudapp.net:8080/buildStatus/icon?job=cordova-periodic-build/PLATFORM=windows-10-store,PLUGIN=cordova-plugin-camera)](http://cordova-ci.cloudapp.net:8080/job/cordova-periodic-build/PLATFORM=windows-10-store,PLUGIN=cordova-plugin-camera/)|[![Build
 
Status](https://travis-ci.org/apache/cordova-plugin-camera.svg?branch=master)](https://travis-ci.org/apache/cordova-plugin-camera)
 
 # cordova-plugin-camera
 
@@ -53,7 +53,7 @@ It is also possible to install via repo url directly ( 
unstable )
 
 ## How to Contribute
 
-Contributors are welcome! And we need your contributions to keep the project 
moving forward. You can [report 
bugs](https://issues.apache.org/jira/issues/?jql=project%20%3D%20CB%20AND%20status%20in%20(Open%2C%20%22In%20Progress%22%2C%20Reopened)%20AND%20resolution%20%3D%20Unresolved%20AND%20component%20%3D%20%22cordova-plugin-camera%22%20ORDER%20BY%20priority%20DESC%2C%20summary%20ASC%2C%20updatedDate%20DESC),
 improve the documentation, or [contribute 
code](https://github.com/apache/cordova-plugin-camera/pulls).
+Contributors are welcome! And we need your contributions to keep the project 
moving forward. You can [report 
bugs](https://issues.apache.org/jira/issues/?jql=project%20%3D%20CB%20AND%20status%20in%20(Open%2C%20%22In%20Progress%22%2C%20Reopened)%20AND%20resolution%20%3D%20Unresolved%20AND%20component%20%3D%20%22Plugin%20Camera%22%20ORDER%20BY%20priority%20DESC%2C%20summary%20ASC%2C%20updatedDate%20DESC),
 improve the documentation, or [contribute 
code](https://github.com/apache/cordova-plugin-camera/pulls).
 
 There is a specific [contributor 
workflow](http://wiki.apache.org/cordova/ContributorWorkflow) we recommend. 
Start reading there. More information is available on [our 
wiki](http://wiki.apache.org/cordova).
 
diff --git a/src/android/CameraLauncher.java b/src/android/CameraLauncher.java
index 03210828..757723d4 100644
--- a/src/android/CameraLauncher.java
+++ b/src/android/CameraLauncher.java
@@ -710,7 +710,7 @@ private void processResultFromGallery(int destType, Intent 
intent) {
 this.callbackContext.success(uriString);
 } else {
 // If we don't have a valid image so quit.
-if (!(JPEG_MIME_TYPE.equalsIgnoreCase(mimeType) || 
PNG_MIME_TYPE.equalsIgnoreCase(mimeType))) {
+if (!(JPEG_MIME_TYPE.equalsIgnoreCase(mimeType) || 
PNG_MIME_TYPE.equalsIgnoreCase(mimeType) || 
"image/*".equalsIgnoreCase(mimeType))) {
 LOG.d(LOG_TAG, "I either have a null image 

[jira] [Commented] (CB-13307) Accessing Google Photos on Pixel from cordova-plugin-camera

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-13307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16616826#comment-16616826
 ] 

ASF GitHub Bot commented on CB-13307:
-

janpio commented on issue #286: CB-13307: (Android) Fixed issue when unable to 
load image with mime t…
URL: 
https://github.com/apache/cordova-plugin-camera/pull/286#issuecomment-421804726
 
 
   Hey @DavidBriglio , there seems to be a merge conflict now. Could you maybe 
fix this? Thanks.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Accessing Google Photos on Pixel from cordova-plugin-camera
> ---
>
> Key: CB-13307
> URL: https://issues.apache.org/jira/browse/CB-13307
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-camera
>Reporter: David Briglio
>Priority: Major
>
> Currently when trying to access some photos from Google Photos, it fails to 
> load. Android 8.0 on Google Pixel, cordova version 6.5.0, 
> cordova-plugin-camera version 2.4.1.
> Causes:
> 1) Only mimetypes "image/jpeg" and "image/png" are accepted, all other types 
> are considered an invalid image. The mimetype of the image I am loading gets 
> set to "image/*".
> 2) In FileHelper.java: when hitting the isGooglePhotosUri method, the uri 
> authority is compared against "com.google.android.apps.photos.content", where 
> the actual is "com.google.android.apps.photos.contentprovider". This causes 
> the logic to dismiss the image as not from Google Photos.
> After applying fixes for these two areas, I am able to successfully load all 
> of my images.
> Merge request [here|https://github.com/apache/cordova-plugin-camera/pull/286].



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13307) Accessing Google Photos on Pixel from cordova-plugin-camera

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-13307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16406426#comment-16406426
 ] 

ASF GitHub Bot commented on CB-13307:
-

DavidBriglio commented on issue #286: CB-13307: (Android) Fixed issue when 
unable to load image with mime t…
URL: 
https://github.com/apache/cordova-plugin-camera/pull/286#issuecomment-374623368
 
 
   I have not done any testing on Android P, and do not have access to it.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Accessing Google Photos on Pixel from cordova-plugin-camera
> ---
>
> Key: CB-13307
> URL: https://issues.apache.org/jira/browse/CB-13307
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-camera
>Reporter: David Briglio
>Priority: Major
>
> Currently when trying to access some photos from Google Photos, it fails to 
> load. Android 8.0 on Google Pixel, cordova version 6.5.0, 
> cordova-plugin-camera version 2.4.1.
> Causes:
> 1) Only mimetypes "image/jpeg" and "image/png" are accepted, all other types 
> are considered an invalid image. The mimetype of the image I am loading gets 
> set to "image/*".
> 2) In FileHelper.java: when hitting the isGooglePhotosUri method, the uri 
> authority is compared against "com.google.android.apps.photos.content", where 
> the actual is "com.google.android.apps.photos.contentprovider". This causes 
> the logic to dismiss the image as not from Google Photos.
> After applying fixes for these two areas, I am able to successfully load all 
> of my images.
> Merge request [here|https://github.com/apache/cordova-plugin-camera/pull/286].



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13307) Accessing Google Photos on Pixel from cordova-plugin-camera

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-13307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16406424#comment-16406424
 ] 

ASF GitHub Bot commented on CB-13307:
-

DavidBriglio commented on issue #286: CB-13307: (Android) Fixed issue when 
unable to load image with mime t…
URL: 
https://github.com/apache/cordova-plugin-camera/pull/286#issuecomment-374623368
 
 
   I have not done any testing on Android P, and no not have access to it.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Accessing Google Photos on Pixel from cordova-plugin-camera
> ---
>
> Key: CB-13307
> URL: https://issues.apache.org/jira/browse/CB-13307
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-camera
>Reporter: David Briglio
>Priority: Major
>
> Currently when trying to access some photos from Google Photos, it fails to 
> load. Android 8.0 on Google Pixel, cordova version 6.5.0, 
> cordova-plugin-camera version 2.4.1.
> Causes:
> 1) Only mimetypes "image/jpeg" and "image/png" are accepted, all other types 
> are considered an invalid image. The mimetype of the image I am loading gets 
> set to "image/*".
> 2) In FileHelper.java: when hitting the isGooglePhotosUri method, the uri 
> authority is compared against "com.google.android.apps.photos.content", where 
> the actual is "com.google.android.apps.photos.contentprovider". This causes 
> the logic to dismiss the image as not from Google Photos.
> After applying fixes for these two areas, I am able to successfully load all 
> of my images.
> Merge request [here|https://github.com/apache/cordova-plugin-camera/pull/286].



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13307) Accessing Google Photos on Pixel from cordova-plugin-camera

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-13307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16405433#comment-16405433
 ] 

ASF GitHub Bot commented on CB-13307:
-

infil00p commented on issue #286: CB-13307: (Android) Fixed issue when unable 
to load image with mime t…
URL: 
https://github.com/apache/cordova-plugin-camera/pull/286#issuecomment-374373421
 
 
   I'm cool with it, but I can't even test if this fixes it because I don't 
even have the ability to pull from Google Photos when I test it.  Did that 
break on Android P?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Accessing Google Photos on Pixel from cordova-plugin-camera
> ---
>
> Key: CB-13307
> URL: https://issues.apache.org/jira/browse/CB-13307
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-camera
>Reporter: David Briglio
>Priority: Major
>
> Currently when trying to access some photos from Google Photos, it fails to 
> load. Android 8.0 on Google Pixel, cordova version 6.5.0, 
> cordova-plugin-camera version 2.4.1.
> Causes:
> 1) Only mimetypes "image/jpeg" and "image/png" are accepted, all other types 
> are considered an invalid image. The mimetype of the image I am loading gets 
> set to "image/*".
> 2) In FileHelper.java: when hitting the isGooglePhotosUri method, the uri 
> authority is compared against "com.google.android.apps.photos.content", where 
> the actual is "com.google.android.apps.photos.contentprovider". This causes 
> the logic to dismiss the image as not from Google Photos.
> After applying fixes for these two areas, I am able to successfully load all 
> of my images.
> Merge request [here|https://github.com/apache/cordova-plugin-camera/pull/286].



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13307) Accessing Google Photos on Pixel from cordova-plugin-camera

[Joe Bowser (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-13307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16405430#comment-16405430
 ] 

Joe Bowser commented on CB-13307:
-

Can someone with a working Pixel that's not running Android P test this? 

> Accessing Google Photos on Pixel from cordova-plugin-camera
> ---
>
> Key: CB-13307
> URL: https://issues.apache.org/jira/browse/CB-13307
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-camera
>Reporter: David Briglio
>Priority: Major
>
> Currently when trying to access some photos from Google Photos, it fails to 
> load. Android 8.0 on Google Pixel, cordova version 6.5.0, 
> cordova-plugin-camera version 2.4.1.
> Causes:
> 1) Only mimetypes "image/jpeg" and "image/png" are accepted, all other types 
> are considered an invalid image. The mimetype of the image I am loading gets 
> set to "image/*".
> 2) In FileHelper.java: when hitting the isGooglePhotosUri method, the uri 
> authority is compared against "com.google.android.apps.photos.content", where 
> the actual is "com.google.android.apps.photos.contentprovider". This causes 
> the logic to dismiss the image as not from Google Photos.
> After applying fixes for these two areas, I am able to successfully load all 
> of my images.
> Merge request [here|https://github.com/apache/cordova-plugin-camera/pull/286].



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13307) Accessing Google Photos on Pixel from cordova-plugin-camera

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-13307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16405432#comment-16405432
 ] 

ASF GitHub Bot commented on CB-13307:
-

infil00p commented on issue #286: CB-13307: (Android) Fixed issue when unable 
to load image with mime t…
URL: 
https://github.com/apache/cordova-plugin-camera/pull/286#issuecomment-374373421
 
 
   I'm cool with it, but I can't even test if this fixes it because I don't 
even have the ability to pull from Google Photos when I test it. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Accessing Google Photos on Pixel from cordova-plugin-camera
> ---
>
> Key: CB-13307
> URL: https://issues.apache.org/jira/browse/CB-13307
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-camera
>Reporter: David Briglio
>Priority: Major
>
> Currently when trying to access some photos from Google Photos, it fails to 
> load. Android 8.0 on Google Pixel, cordova version 6.5.0, 
> cordova-plugin-camera version 2.4.1.
> Causes:
> 1) Only mimetypes "image/jpeg" and "image/png" are accepted, all other types 
> are considered an invalid image. The mimetype of the image I am loading gets 
> set to "image/*".
> 2) In FileHelper.java: when hitting the isGooglePhotosUri method, the uri 
> authority is compared against "com.google.android.apps.photos.content", where 
> the actual is "com.google.android.apps.photos.contentprovider". This causes 
> the logic to dismiss the image as not from Google Photos.
> After applying fixes for these two areas, I am able to successfully load all 
> of my images.
> Merge request [here|https://github.com/apache/cordova-plugin-camera/pull/286].



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13307) Accessing Google Photos on Pixel from cordova-plugin-camera

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-13307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16174784#comment-16174784
 ] 

ASF GitHub Bot commented on CB-13307:
-

GitHub user DavidBriglio opened a pull request:

https://github.com/apache/cordova-plugin-camera/pull/286

CB-13307: (Android) Fixed issue when unable to load image with mime t…

…ype "image/*", and failing to recognize new contentprovider uri authority.

### Platforms affected
Android

### What does this PR do?
Allows for image mimetype "image/*" to be accepted as a valid image.
Allows for google photos uri authority ".contentprovider" to be recognized.

### What testing has been done on this change?
When running "npm test" results in "invalid config loglevel='notice'".
When running "npm run test-build" results in "missing script: test-build".
Manual testing has been done on Android 8.0 Google Pixel with cordova cli 
6.5.0.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/DavidBriglio/cordova-plugin-camera 
CB-13307-cordova-plugin-camera-MimeType-ContentProvider

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-camera/pull/286.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #286


commit 0d0116a3ed0b593253d96cfdd705e849b4ebca61
Author: David Briglio 
Date:   2017-09-21T13:49:47Z

CB-13307: (Android) Fixed issue when unable to load image with mime type 
"image/*", and failing to recognize new contentprovider uri authority.




> Accessing Google Photos on Pixel from cordova-plugin-camera
> ---
>
> Key: CB-13307
> URL: https://issues.apache.org/jira/browse/CB-13307
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-camera
>Reporter: David Briglio
>
> Currently when trying to access some photos from Google Photos, it fails to 
> load. Android 8.0 on Google Pixel, cordova version 6.5.0, 
> cordova-plugin-camera version 2.4.1.
> Causes:
> 1) Only mimetypes "image/jpeg" and "image/png" are accepted, all other types 
> are considered an invalid image. The mimetype of the image I am loading gets 
> set to "image/*".
> 2) In FileHelper.java: when hitting the isGooglePhotosUri method, the uri 
> authority is compared against "com.google.android.apps.photos.content", where 
> the actual is "com.google.android.apps.photos.contentprovider". This causes 
> the logic to dismiss the image as not from Google Photos.
> After applying fixes for these two areas, I am able to successfully load all 
> of my images.
> Merge request [here|https://github.com/apache/cordova-plugin-camera/pull/285].



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13307) Accessing Google Photos on Pixel from cordova-plugin-camera

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-13307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16174772#comment-16174772
 ] 

ASF GitHub Bot commented on CB-13307:
-

Github user DavidBriglio closed the pull request at:

https://github.com/apache/cordova-plugin-camera/pull/285


> Accessing Google Photos on Pixel from cordova-plugin-camera
> ---
>
> Key: CB-13307
> URL: https://issues.apache.org/jira/browse/CB-13307
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-camera
>Reporter: David Briglio
>
> Currently when trying to access some photos from Google Photos, it fails to 
> load. Android 8.0 on Google Pixel, cordova version 6.5.0, 
> cordova-plugin-camera version 2.4.1.
> Causes:
> 1) Only mimetypes "image/jpeg" and "image/png" are accepted, all other types 
> are considered an invalid image. The mimetype of the image I am loading gets 
> set to "image/*".
> 2) In FileHelper.java: when hitting the isGooglePhotosUri method, the uri 
> authority is compared against "com.google.android.apps.photos.content", where 
> the actual is "com.google.android.apps.photos.contentprovider". This causes 
> the logic to dismiss the image as not from Google Photos.
> After applying fixes for these two areas, I am able to successfully load all 
> of my images.
> Merge request [here|https://github.com/apache/cordova-plugin-camera/pull/285].



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13307) Accessing Google Photos on Pixel from cordova-plugin-camera

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-13307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16174770#comment-16174770
 ] 

ASF GitHub Bot commented on CB-13307:
-

GitHub user DavidBriglio opened a pull request:

https://github.com/apache/cordova-plugin-camera/pull/285

CB-13307: (Android) Fixed issue when unable to load image with mime t…

…ype "image/*", and failing to recognize new contentprovider uri authority.

### Platforms affected
Android

### What does this PR do?
Allows for image mimetype "image/*" to be accepted as a valid image.
Allows for google photos uri authority ".contentprovider" to be recognized.

### What testing has been done on this change?
When running "npm test" results in "invalid config loglevel='notice'".
When running "npm run test-build" results in "missing script: test-build".
Manual testing has been done on Android 8.0 Google Pixel with cordova cli 
6.5.0.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/DavidBriglio/cordova-plugin-camera 
CB-13307-MimeType-ContentProvider

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-camera/pull/285.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #285


commit 886ada803730c045e386ff3b643b0db8f4731277
Author: David Briglio 
Date:   2017-09-21T13:38:07Z

CB-13307: (Android) Fixed issue when unable to load image with mime type 
"image/*", and failing to recognize new contentprovider uri authority.




> Accessing Google Photos on Pixel from cordova-plugin-camera
> ---
>
> Key: CB-13307
> URL: https://issues.apache.org/jira/browse/CB-13307
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-camera
>Reporter: David Briglio
>
> Currently when trying to access some photos from Google Photos, it fails to 
> load. Android 8.0 on Google Pixel, cordova version 6.5.0, 
> cordova-plugin-camera version 2.4.1.
> Causes:
> 1) Only mimetypes "image/jpeg" and "image/png" are accepted, all other types 
> are considered an invalid image. The mimetype of the image I am loading gets 
> set to "image/*".
> 2) In FileHelper.java: when hitting the isGooglePhotosUri method, the uri 
> authority is compared against "com.google.android.apps.photos.content", where 
> the actual is "com.google.android.apps.photos.contentprovider". This causes 
> the logic to dismiss the image as not from Google Photos.
> After applying fixes for these two areas, I am able to successfully load all 
> of my images.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org