[jira] [Commented] (CB-13409) Allow more additional options, for customizing toolbar in cordova/inappbrowser

2018-01-25 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-13409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16339760#comment-16339760
 ] 

ASF subversion and git services commented on CB-13409:
--

Commit c80c338e51657da600ee56af5079a125426dd00f in 
cordova-plugin-inappbrowser's branch refs/heads/2.0.x from [~bowserj]
[ 
https://gitbox.apache.org/repos/asf?p=cordova-plugin-inappbrowser.git;h=c80c338 
]

Merge pull request #246 from landsbankinn/CB-13409

Cb 13409 - Add more configurable options for toolbar in android and ios

> Allow more additional options, for customizing toolbar in cordova/inappbrowser
> --
>
> Key: CB-13409
> URL: https://issues.apache.org/jira/browse/CB-13409
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-plugin-inappbrowser
> Environment: iOS, Android
>Reporter: Steinar Ágúst Steinarsson
>Priority: Minor
>  Labels: features, newbie
> Attachments: Android - 1.png, Android - 2.png, Android - 3.png, 
> Android - 4.png, Android - 5.png, iOS - 1.PNG
>
>   Original Estimate: 0h
>  Remaining Estimate: 0h
>
> I added a couple of customizations to inappbrowser's toolbar:
> *Android*:
> - Have a custom text for a close button instead of the Default X:
> _closebuttoncaption_: "set to a string to use as the close buttons caption 
> instead of a X. Note that you need to localize this value yourself."
> - Change the close button color:
> _closebuttoncolor_: "set to a valid hex color string, for example: `#00ff00`, 
> and it will change the close button color from default, regardless of being a 
> text or default X. Only has effect if user has location set to `yes`."
> - Hide the navigation buttons that go backwards and forwards:
> _hidenavigationbuttons_: "set to `yes` to hide the navigation buttons on the 
> location toolbar, only has effect if user has location set to `yes`. The 
> default value is `no`."
> - Change navigation buttons color:
> _navigationbuttoncolor_: "set to a valid hex color string, for example: 
> `#00ff00`, and it will change the color of both navigation buttons from 
> default. Only has effect if user has location set to `yes` and not 
> hidenavigationbuttons set to `yes`."
> - Change color of toolbar:
> _toolbarcolor_: "set to a valid hex color string, for example: `#00ff00`, and 
> it will change the color the toolbar from default. Only has effect if user 
> has location set to `yes`."
> *iOS:*
> - _closebuttoncolor_ (same as above)
> - _hidenavigationbuttons_ (same as above)
> - _toolbarcolor_ (same as above)
> - Make toolbar non-translucent:
> _toolbartranslucent_: "set to `yes` or `no` to make the toolbar 
> translucent(semi-transparent)  (defaults to `yes`). Only applicable if 
> toolbar is not disabled."
> See screenshots in attachments.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-13409) Allow more additional options, for customizing toolbar in cordova/inappbrowser

2018-01-25 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-13409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16339756#comment-16339756
 ] 

ASF subversion and git services commented on CB-13409:
--

Commit 84a4644cd136df9e1311bce0d1c62cacb1969a7b in 
cordova-plugin-inappbrowser's branch refs/heads/2.0.x from [~steinaragust]
[ 
https://gitbox.apache.org/repos/asf?p=cordova-plugin-inappbrowser.git;h=84a4644 
]

Merge branch 'master' of https://github.com/apache/cordova-plugin-inappbrowser 
into CB-13409


> Allow more additional options, for customizing toolbar in cordova/inappbrowser
> --
>
> Key: CB-13409
> URL: https://issues.apache.org/jira/browse/CB-13409
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-plugin-inappbrowser
> Environment: iOS, Android
>Reporter: Steinar Ágúst Steinarsson
>Priority: Minor
>  Labels: features, newbie
> Attachments: Android - 1.png, Android - 2.png, Android - 3.png, 
> Android - 4.png, Android - 5.png, iOS - 1.PNG
>
>   Original Estimate: 0h
>  Remaining Estimate: 0h
>
> I added a couple of customizations to inappbrowser's toolbar:
> *Android*:
> - Have a custom text for a close button instead of the Default X:
> _closebuttoncaption_: "set to a string to use as the close buttons caption 
> instead of a X. Note that you need to localize this value yourself."
> - Change the close button color:
> _closebuttoncolor_: "set to a valid hex color string, for example: `#00ff00`, 
> and it will change the close button color from default, regardless of being a 
> text or default X. Only has effect if user has location set to `yes`."
> - Hide the navigation buttons that go backwards and forwards:
> _hidenavigationbuttons_: "set to `yes` to hide the navigation buttons on the 
> location toolbar, only has effect if user has location set to `yes`. The 
> default value is `no`."
> - Change navigation buttons color:
> _navigationbuttoncolor_: "set to a valid hex color string, for example: 
> `#00ff00`, and it will change the color of both navigation buttons from 
> default. Only has effect if user has location set to `yes` and not 
> hidenavigationbuttons set to `yes`."
> - Change color of toolbar:
> _toolbarcolor_: "set to a valid hex color string, for example: `#00ff00`, and 
> it will change the color the toolbar from default. Only has effect if user 
> has location set to `yes`."
> *iOS:*
> - _closebuttoncolor_ (same as above)
> - _hidenavigationbuttons_ (same as above)
> - _toolbarcolor_ (same as above)
> - Make toolbar non-translucent:
> _toolbartranslucent_: "set to `yes` or `no` to make the toolbar 
> translucent(semi-transparent)  (defaults to `yes`). Only applicable if 
> toolbar is not disabled."
> See screenshots in attachments.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-13409) Allow more additional options, for customizing toolbar in cordova/inappbrowser

2018-01-17 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-13409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16329219#comment-16329219
 ] 

ASF subversion and git services commented on CB-13409:
--

Commit 6c2a8f4576e34ab29ffce102f12efb9c494ba386 in 
cordova-plugin-inappbrowser's branch refs/heads/master from [~steinaragust]
[ 
https://gitbox.apache.org/repos/asf?p=cordova-plugin-inappbrowser.git;h=6c2a8f4 
]

CB-13409: restore gitignore to default


> Allow more additional options, for customizing toolbar in cordova/inappbrowser
> --
>
> Key: CB-13409
> URL: https://issues.apache.org/jira/browse/CB-13409
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-plugin-inappbrowser
> Environment: iOS, Android
>Reporter: Steinar Ágúst Steinarsson
>Priority: Minor
>  Labels: features, newbie
> Attachments: Android - 1.png, Android - 2.png, Android - 3.png, 
> Android - 4.png, Android - 5.png, iOS - 1.PNG
>
>   Original Estimate: 0h
>  Remaining Estimate: 0h
>
> I added a couple of customizations to inappbrowser's toolbar:
> *Android*:
> - Have a custom text for a close button instead of the Default X:
> _closebuttoncaption_: "set to a string to use as the close buttons caption 
> instead of a X. Note that you need to localize this value yourself."
> - Change the close button color:
> _closebuttoncolor_: "set to a valid hex color string, for example: `#00ff00`, 
> and it will change the close button color from default, regardless of being a 
> text or default X. Only has effect if user has location set to `yes`."
> - Hide the navigation buttons that go backwards and forwards:
> _hidenavigationbuttons_: "set to `yes` to hide the navigation buttons on the 
> location toolbar, only has effect if user has location set to `yes`. The 
> default value is `no`."
> - Change navigation buttons color:
> _navigationbuttoncolor_: "set to a valid hex color string, for example: 
> `#00ff00`, and it will change the color of both navigation buttons from 
> default. Only has effect if user has location set to `yes` and not 
> hidenavigationbuttons set to `yes`."
> - Change color of toolbar:
> _toolbarcolor_: "set to a valid hex color string, for example: `#00ff00`, and 
> it will change the color the toolbar from default. Only has effect if user 
> has location set to `yes`."
> *iOS:*
> - _closebuttoncolor_ (same as above)
> - _hidenavigationbuttons_ (same as above)
> - _toolbarcolor_ (same as above)
> - Make toolbar non-translucent:
> _toolbartranslucent_: "set to `yes` or `no` to make the toolbar 
> translucent(semi-transparent)  (defaults to `yes`). Only applicable if 
> toolbar is not disabled."
> See screenshots in attachments.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-13409) Allow more additional options, for customizing toolbar in cordova/inappbrowser

2018-01-17 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-13409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16329220#comment-16329220
 ] 

ASF subversion and git services commented on CB-13409:
--

Commit ec2f12c8728f4ed39244bd6f3ae011e124e1ddce in 
cordova-plugin-inappbrowser's branch refs/heads/master from [~steinaragust]
[ 
https://gitbox.apache.org/repos/asf?p=cordova-plugin-inappbrowser.git;h=ec2f12c 
]

CB-13409: restore gitignore to default


> Allow more additional options, for customizing toolbar in cordova/inappbrowser
> --
>
> Key: CB-13409
> URL: https://issues.apache.org/jira/browse/CB-13409
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-plugin-inappbrowser
> Environment: iOS, Android
>Reporter: Steinar Ágúst Steinarsson
>Priority: Minor
>  Labels: features, newbie
> Attachments: Android - 1.png, Android - 2.png, Android - 3.png, 
> Android - 4.png, Android - 5.png, iOS - 1.PNG
>
>   Original Estimate: 0h
>  Remaining Estimate: 0h
>
> I added a couple of customizations to inappbrowser's toolbar:
> *Android*:
> - Have a custom text for a close button instead of the Default X:
> _closebuttoncaption_: "set to a string to use as the close buttons caption 
> instead of a X. Note that you need to localize this value yourself."
> - Change the close button color:
> _closebuttoncolor_: "set to a valid hex color string, for example: `#00ff00`, 
> and it will change the close button color from default, regardless of being a 
> text or default X. Only has effect if user has location set to `yes`."
> - Hide the navigation buttons that go backwards and forwards:
> _hidenavigationbuttons_: "set to `yes` to hide the navigation buttons on the 
> location toolbar, only has effect if user has location set to `yes`. The 
> default value is `no`."
> - Change navigation buttons color:
> _navigationbuttoncolor_: "set to a valid hex color string, for example: 
> `#00ff00`, and it will change the color of both navigation buttons from 
> default. Only has effect if user has location set to `yes` and not 
> hidenavigationbuttons set to `yes`."
> - Change color of toolbar:
> _toolbarcolor_: "set to a valid hex color string, for example: `#00ff00`, and 
> it will change the color the toolbar from default. Only has effect if user 
> has location set to `yes`."
> *iOS:*
> - _closebuttoncolor_ (same as above)
> - _hidenavigationbuttons_ (same as above)
> - _toolbarcolor_ (same as above)
> - Make toolbar non-translucent:
> _toolbartranslucent_: "set to `yes` or `no` to make the toolbar 
> translucent(semi-transparent)  (defaults to `yes`). Only applicable if 
> toolbar is not disabled."
> See screenshots in attachments.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-13409) Allow more additional options, for customizing toolbar in cordova/inappbrowser

2018-01-17 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-13409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16329223#comment-16329223
 ] 

ASF subversion and git services commented on CB-13409:
--

Commit 84a4644cd136df9e1311bce0d1c62cacb1969a7b in 
cordova-plugin-inappbrowser's branch refs/heads/master from [~steinaragust]
[ 
https://gitbox.apache.org/repos/asf?p=cordova-plugin-inappbrowser.git;h=84a4644 
]

Merge branch 'master' of https://github.com/apache/cordova-plugin-inappbrowser 
into CB-13409


> Allow more additional options, for customizing toolbar in cordova/inappbrowser
> --
>
> Key: CB-13409
> URL: https://issues.apache.org/jira/browse/CB-13409
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-plugin-inappbrowser
> Environment: iOS, Android
>Reporter: Steinar Ágúst Steinarsson
>Priority: Minor
>  Labels: features, newbie
> Attachments: Android - 1.png, Android - 2.png, Android - 3.png, 
> Android - 4.png, Android - 5.png, iOS - 1.PNG
>
>   Original Estimate: 0h
>  Remaining Estimate: 0h
>
> I added a couple of customizations to inappbrowser's toolbar:
> *Android*:
> - Have a custom text for a close button instead of the Default X:
> _closebuttoncaption_: "set to a string to use as the close buttons caption 
> instead of a X. Note that you need to localize this value yourself."
> - Change the close button color:
> _closebuttoncolor_: "set to a valid hex color string, for example: `#00ff00`, 
> and it will change the close button color from default, regardless of being a 
> text or default X. Only has effect if user has location set to `yes`."
> - Hide the navigation buttons that go backwards and forwards:
> _hidenavigationbuttons_: "set to `yes` to hide the navigation buttons on the 
> location toolbar, only has effect if user has location set to `yes`. The 
> default value is `no`."
> - Change navigation buttons color:
> _navigationbuttoncolor_: "set to a valid hex color string, for example: 
> `#00ff00`, and it will change the color of both navigation buttons from 
> default. Only has effect if user has location set to `yes` and not 
> hidenavigationbuttons set to `yes`."
> - Change color of toolbar:
> _toolbarcolor_: "set to a valid hex color string, for example: `#00ff00`, and 
> it will change the color the toolbar from default. Only has effect if user 
> has location set to `yes`."
> *iOS:*
> - _closebuttoncolor_ (same as above)
> - _hidenavigationbuttons_ (same as above)
> - _toolbarcolor_ (same as above)
> - Make toolbar non-translucent:
> _toolbartranslucent_: "set to `yes` or `no` to make the toolbar 
> translucent(semi-transparent)  (defaults to `yes`). Only applicable if 
> toolbar is not disabled."
> See screenshots in attachments.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-13409) Allow more additional options, for customizing toolbar in cordova/inappbrowser

2018-01-17 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-13409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16329221#comment-16329221
 ] 

ASF subversion and git services commented on CB-13409:
--

Commit ff230d429a3975c670f16e9e8cdf21c6ef874be8 in 
cordova-plugin-inappbrowser's branch refs/heads/master from [~steinaragust]
[ 
https://gitbox.apache.org/repos/asf?p=cordova-plugin-inappbrowser.git;h=ff230d4 
]

CB-13409: restore gitignore to default


> Allow more additional options, for customizing toolbar in cordova/inappbrowser
> --
>
> Key: CB-13409
> URL: https://issues.apache.org/jira/browse/CB-13409
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-plugin-inappbrowser
> Environment: iOS, Android
>Reporter: Steinar Ágúst Steinarsson
>Priority: Minor
>  Labels: features, newbie
> Attachments: Android - 1.png, Android - 2.png, Android - 3.png, 
> Android - 4.png, Android - 5.png, iOS - 1.PNG
>
>   Original Estimate: 0h
>  Remaining Estimate: 0h
>
> I added a couple of customizations to inappbrowser's toolbar:
> *Android*:
> - Have a custom text for a close button instead of the Default X:
> _closebuttoncaption_: "set to a string to use as the close buttons caption 
> instead of a X. Note that you need to localize this value yourself."
> - Change the close button color:
> _closebuttoncolor_: "set to a valid hex color string, for example: `#00ff00`, 
> and it will change the close button color from default, regardless of being a 
> text or default X. Only has effect if user has location set to `yes`."
> - Hide the navigation buttons that go backwards and forwards:
> _hidenavigationbuttons_: "set to `yes` to hide the navigation buttons on the 
> location toolbar, only has effect if user has location set to `yes`. The 
> default value is `no`."
> - Change navigation buttons color:
> _navigationbuttoncolor_: "set to a valid hex color string, for example: 
> `#00ff00`, and it will change the color of both navigation buttons from 
> default. Only has effect if user has location set to `yes` and not 
> hidenavigationbuttons set to `yes`."
> - Change color of toolbar:
> _toolbarcolor_: "set to a valid hex color string, for example: `#00ff00`, and 
> it will change the color the toolbar from default. Only has effect if user 
> has location set to `yes`."
> *iOS:*
> - _closebuttoncolor_ (same as above)
> - _hidenavigationbuttons_ (same as above)
> - _toolbarcolor_ (same as above)
> - Make toolbar non-translucent:
> _toolbartranslucent_: "set to `yes` or `no` to make the toolbar 
> translucent(semi-transparent)  (defaults to `yes`). Only applicable if 
> toolbar is not disabled."
> See screenshots in attachments.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-13409) Allow more additional options, for customizing toolbar in cordova/inappbrowser

2018-01-17 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-13409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16329217#comment-16329217
 ] 

ASF subversion and git services commented on CB-13409:
--

Commit 4af420c5920bd779efd9ab19613e132d51040e2b in 
cordova-plugin-inappbrowser's branch refs/heads/master from [~steinaragust]
[ 
https://gitbox.apache.org/repos/asf?p=cordova-plugin-inappbrowser.git;h=4af420c 
]

CB-13409: change hidetoolbarnavigationbuttons to hidenavigationbuttons in iso


> Allow more additional options, for customizing toolbar in cordova/inappbrowser
> --
>
> Key: CB-13409
> URL: https://issues.apache.org/jira/browse/CB-13409
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-plugin-inappbrowser
> Environment: iOS, Android
>Reporter: Steinar Ágúst Steinarsson
>Priority: Minor
>  Labels: features, newbie
> Attachments: Android - 1.png, Android - 2.png, Android - 3.png, 
> Android - 4.png, Android - 5.png, iOS - 1.PNG
>
>   Original Estimate: 0h
>  Remaining Estimate: 0h
>
> I added a couple of customizations to inappbrowser's toolbar:
> *Android*:
> - Have a custom text for a close button instead of the Default X:
> _closebuttoncaption_: "set to a string to use as the close buttons caption 
> instead of a X. Note that you need to localize this value yourself."
> - Change the close button color:
> _closebuttoncolor_: "set to a valid hex color string, for example: `#00ff00`, 
> and it will change the close button color from default, regardless of being a 
> text or default X. Only has effect if user has location set to `yes`."
> - Hide the navigation buttons that go backwards and forwards:
> _hidenavigationbuttons_: "set to `yes` to hide the navigation buttons on the 
> location toolbar, only has effect if user has location set to `yes`. The 
> default value is `no`."
> - Change navigation buttons color:
> _navigationbuttoncolor_: "set to a valid hex color string, for example: 
> `#00ff00`, and it will change the color of both navigation buttons from 
> default. Only has effect if user has location set to `yes` and not 
> hidenavigationbuttons set to `yes`."
> - Change color of toolbar:
> _toolbarcolor_: "set to a valid hex color string, for example: `#00ff00`, and 
> it will change the color the toolbar from default. Only has effect if user 
> has location set to `yes`."
> *iOS:*
> - _closebuttoncolor_ (same as above)
> - _hidenavigationbuttons_ (same as above)
> - _toolbarcolor_ (same as above)
> - Make toolbar non-translucent:
> _toolbartranslucent_: "set to `yes` or `no` to make the toolbar 
> translucent(semi-transparent)  (defaults to `yes`). Only applicable if 
> toolbar is not disabled."
> See screenshots in attachments.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-13409) Allow more additional options, for customizing toolbar in cordova/inappbrowser

2018-01-17 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-13409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16329222#comment-16329222
 ] 

ASF subversion and git services commented on CB-13409:
--

Commit d46f5d45d521eef5faffe0ed71718ddc7c8dfd50 in 
cordova-plugin-inappbrowser's branch refs/heads/master from [~steinaragust]
[ 
https://gitbox.apache.org/repos/asf?p=cordova-plugin-inappbrowser.git;h=d46f5d4 
]

CB-13409: restore gitignore to default


> Allow more additional options, for customizing toolbar in cordova/inappbrowser
> --
>
> Key: CB-13409
> URL: https://issues.apache.org/jira/browse/CB-13409
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-plugin-inappbrowser
> Environment: iOS, Android
>Reporter: Steinar Ágúst Steinarsson
>Priority: Minor
>  Labels: features, newbie
> Attachments: Android - 1.png, Android - 2.png, Android - 3.png, 
> Android - 4.png, Android - 5.png, iOS - 1.PNG
>
>   Original Estimate: 0h
>  Remaining Estimate: 0h
>
> I added a couple of customizations to inappbrowser's toolbar:
> *Android*:
> - Have a custom text for a close button instead of the Default X:
> _closebuttoncaption_: "set to a string to use as the close buttons caption 
> instead of a X. Note that you need to localize this value yourself."
> - Change the close button color:
> _closebuttoncolor_: "set to a valid hex color string, for example: `#00ff00`, 
> and it will change the close button color from default, regardless of being a 
> text or default X. Only has effect if user has location set to `yes`."
> - Hide the navigation buttons that go backwards and forwards:
> _hidenavigationbuttons_: "set to `yes` to hide the navigation buttons on the 
> location toolbar, only has effect if user has location set to `yes`. The 
> default value is `no`."
> - Change navigation buttons color:
> _navigationbuttoncolor_: "set to a valid hex color string, for example: 
> `#00ff00`, and it will change the color of both navigation buttons from 
> default. Only has effect if user has location set to `yes` and not 
> hidenavigationbuttons set to `yes`."
> - Change color of toolbar:
> _toolbarcolor_: "set to a valid hex color string, for example: `#00ff00`, and 
> it will change the color the toolbar from default. Only has effect if user 
> has location set to `yes`."
> *iOS:*
> - _closebuttoncolor_ (same as above)
> - _hidenavigationbuttons_ (same as above)
> - _toolbarcolor_ (same as above)
> - Make toolbar non-translucent:
> _toolbartranslucent_: "set to `yes` or `no` to make the toolbar 
> translucent(semi-transparent)  (defaults to `yes`). Only applicable if 
> toolbar is not disabled."
> See screenshots in attachments.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-13409) Allow more additional options, for customizing toolbar in cordova/inappbrowser

2018-01-17 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-13409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16329224#comment-16329224
 ] 

ASF subversion and git services commented on CB-13409:
--

Commit c80c338e51657da600ee56af5079a125426dd00f in 
cordova-plugin-inappbrowser's branch refs/heads/master from [~bowserj]
[ 
https://gitbox.apache.org/repos/asf?p=cordova-plugin-inappbrowser.git;h=c80c338 
]

Merge pull request #246 from landsbankinn/CB-13409

Cb 13409 - Add more configurable options for toolbar in android and ios

> Allow more additional options, for customizing toolbar in cordova/inappbrowser
> --
>
> Key: CB-13409
> URL: https://issues.apache.org/jira/browse/CB-13409
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-plugin-inappbrowser
> Environment: iOS, Android
>Reporter: Steinar Ágúst Steinarsson
>Priority: Minor
>  Labels: features, newbie
> Attachments: Android - 1.png, Android - 2.png, Android - 3.png, 
> Android - 4.png, Android - 5.png, iOS - 1.PNG
>
>   Original Estimate: 0h
>  Remaining Estimate: 0h
>
> I added a couple of customizations to inappbrowser's toolbar:
> *Android*:
> - Have a custom text for a close button instead of the Default X:
> _closebuttoncaption_: "set to a string to use as the close buttons caption 
> instead of a X. Note that you need to localize this value yourself."
> - Change the close button color:
> _closebuttoncolor_: "set to a valid hex color string, for example: `#00ff00`, 
> and it will change the close button color from default, regardless of being a 
> text or default X. Only has effect if user has location set to `yes`."
> - Hide the navigation buttons that go backwards and forwards:
> _hidenavigationbuttons_: "set to `yes` to hide the navigation buttons on the 
> location toolbar, only has effect if user has location set to `yes`. The 
> default value is `no`."
> - Change navigation buttons color:
> _navigationbuttoncolor_: "set to a valid hex color string, for example: 
> `#00ff00`, and it will change the color of both navigation buttons from 
> default. Only has effect if user has location set to `yes` and not 
> hidenavigationbuttons set to `yes`."
> - Change color of toolbar:
> _toolbarcolor_: "set to a valid hex color string, for example: `#00ff00`, and 
> it will change the color the toolbar from default. Only has effect if user 
> has location set to `yes`."
> *iOS:*
> - _closebuttoncolor_ (same as above)
> - _hidenavigationbuttons_ (same as above)
> - _toolbarcolor_ (same as above)
> - Make toolbar non-translucent:
> _toolbartranslucent_: "set to `yes` or `no` to make the toolbar 
> translucent(semi-transparent)  (defaults to `yes`). Only applicable if 
> toolbar is not disabled."
> See screenshots in attachments.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-13409) Allow more additional options, for customizing toolbar in cordova/inappbrowser

2018-01-17 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-13409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16329218#comment-16329218
 ] 

ASF subversion and git services commented on CB-13409:
--

Commit 55b02285f93515c0f153b0f89366d978192dd900 in 
cordova-plugin-inappbrowser's branch refs/heads/master from [~steinaragust]
[ 
https://gitbox.apache.org/repos/asf?p=cordova-plugin-inappbrowser.git;h=55b0228 
]

CB-13409: ignore idea folder


> Allow more additional options, for customizing toolbar in cordova/inappbrowser
> --
>
> Key: CB-13409
> URL: https://issues.apache.org/jira/browse/CB-13409
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-plugin-inappbrowser
> Environment: iOS, Android
>Reporter: Steinar Ágúst Steinarsson
>Priority: Minor
>  Labels: features, newbie
> Attachments: Android - 1.png, Android - 2.png, Android - 3.png, 
> Android - 4.png, Android - 5.png, iOS - 1.PNG
>
>   Original Estimate: 0h
>  Remaining Estimate: 0h
>
> I added a couple of customizations to inappbrowser's toolbar:
> *Android*:
> - Have a custom text for a close button instead of the Default X:
> _closebuttoncaption_: "set to a string to use as the close buttons caption 
> instead of a X. Note that you need to localize this value yourself."
> - Change the close button color:
> _closebuttoncolor_: "set to a valid hex color string, for example: `#00ff00`, 
> and it will change the close button color from default, regardless of being a 
> text or default X. Only has effect if user has location set to `yes`."
> - Hide the navigation buttons that go backwards and forwards:
> _hidenavigationbuttons_: "set to `yes` to hide the navigation buttons on the 
> location toolbar, only has effect if user has location set to `yes`. The 
> default value is `no`."
> - Change navigation buttons color:
> _navigationbuttoncolor_: "set to a valid hex color string, for example: 
> `#00ff00`, and it will change the color of both navigation buttons from 
> default. Only has effect if user has location set to `yes` and not 
> hidenavigationbuttons set to `yes`."
> - Change color of toolbar:
> _toolbarcolor_: "set to a valid hex color string, for example: `#00ff00`, and 
> it will change the color the toolbar from default. Only has effect if user 
> has location set to `yes`."
> *iOS:*
> - _closebuttoncolor_ (same as above)
> - _hidenavigationbuttons_ (same as above)
> - _toolbarcolor_ (same as above)
> - Make toolbar non-translucent:
> _toolbartranslucent_: "set to `yes` or `no` to make the toolbar 
> translucent(semi-transparent)  (defaults to `yes`). Only applicable if 
> toolbar is not disabled."
> See screenshots in attachments.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-13409) Allow more additional options, for customizing toolbar in cordova/inappbrowser

2018-01-17 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-13409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16329215#comment-16329215
 ] 

ASF subversion and git services commented on CB-13409:
--

Commit 8711ee3f211bf84913ae86f81e5e0e548d1c8015 in 
cordova-plugin-inappbrowser's branch refs/heads/master from [~steinaragust]
[ 
https://gitbox.apache.org/repos/asf?p=cordova-plugin-inappbrowser.git;h=8711ee3 
]

CB-13409: Lets user adjust color of toolbar, hide navigation buttons and set 
custom text on close button


> Allow more additional options, for customizing toolbar in cordova/inappbrowser
> --
>
> Key: CB-13409
> URL: https://issues.apache.org/jira/browse/CB-13409
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-plugin-inappbrowser
> Environment: iOS, Android
>Reporter: Steinar Ágúst Steinarsson
>Priority: Minor
>  Labels: features, newbie
> Attachments: Android - 1.png, Android - 2.png, Android - 3.png, 
> Android - 4.png, Android - 5.png, iOS - 1.PNG
>
>   Original Estimate: 0h
>  Remaining Estimate: 0h
>
> I added a couple of customizations to inappbrowser's toolbar:
> *Android*:
> - Have a custom text for a close button instead of the Default X:
> _closebuttoncaption_: "set to a string to use as the close buttons caption 
> instead of a X. Note that you need to localize this value yourself."
> - Change the close button color:
> _closebuttoncolor_: "set to a valid hex color string, for example: `#00ff00`, 
> and it will change the close button color from default, regardless of being a 
> text or default X. Only has effect if user has location set to `yes`."
> - Hide the navigation buttons that go backwards and forwards:
> _hidenavigationbuttons_: "set to `yes` to hide the navigation buttons on the 
> location toolbar, only has effect if user has location set to `yes`. The 
> default value is `no`."
> - Change navigation buttons color:
> _navigationbuttoncolor_: "set to a valid hex color string, for example: 
> `#00ff00`, and it will change the color of both navigation buttons from 
> default. Only has effect if user has location set to `yes` and not 
> hidenavigationbuttons set to `yes`."
> - Change color of toolbar:
> _toolbarcolor_: "set to a valid hex color string, for example: `#00ff00`, and 
> it will change the color the toolbar from default. Only has effect if user 
> has location set to `yes`."
> *iOS:*
> - _closebuttoncolor_ (same as above)
> - _hidenavigationbuttons_ (same as above)
> - _toolbarcolor_ (same as above)
> - Make toolbar non-translucent:
> _toolbartranslucent_: "set to `yes` or `no` to make the toolbar 
> translucent(semi-transparent)  (defaults to `yes`). Only applicable if 
> toolbar is not disabled."
> See screenshots in attachments.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-13409) Allow more additional options, for customizing toolbar in cordova/inappbrowser

2018-01-17 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-13409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16329216#comment-16329216
 ] 

ASF subversion and git services commented on CB-13409:
--

Commit e691212c967fe866551c126e00f4cc7f09c6dfb9 in 
cordova-plugin-inappbrowser's branch refs/heads/master from [~steinaragust]
[ 
https://gitbox.apache.org/repos/asf?p=cordova-plugin-inappbrowser.git;h=e691212 
]

CB-13409: Android works well now, all changes are now documented


> Allow more additional options, for customizing toolbar in cordova/inappbrowser
> --
>
> Key: CB-13409
> URL: https://issues.apache.org/jira/browse/CB-13409
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-plugin-inappbrowser
> Environment: iOS, Android
>Reporter: Steinar Ágúst Steinarsson
>Priority: Minor
>  Labels: features, newbie
> Attachments: Android - 1.png, Android - 2.png, Android - 3.png, 
> Android - 4.png, Android - 5.png, iOS - 1.PNG
>
>   Original Estimate: 0h
>  Remaining Estimate: 0h
>
> I added a couple of customizations to inappbrowser's toolbar:
> *Android*:
> - Have a custom text for a close button instead of the Default X:
> _closebuttoncaption_: "set to a string to use as the close buttons caption 
> instead of a X. Note that you need to localize this value yourself."
> - Change the close button color:
> _closebuttoncolor_: "set to a valid hex color string, for example: `#00ff00`, 
> and it will change the close button color from default, regardless of being a 
> text or default X. Only has effect if user has location set to `yes`."
> - Hide the navigation buttons that go backwards and forwards:
> _hidenavigationbuttons_: "set to `yes` to hide the navigation buttons on the 
> location toolbar, only has effect if user has location set to `yes`. The 
> default value is `no`."
> - Change navigation buttons color:
> _navigationbuttoncolor_: "set to a valid hex color string, for example: 
> `#00ff00`, and it will change the color of both navigation buttons from 
> default. Only has effect if user has location set to `yes` and not 
> hidenavigationbuttons set to `yes`."
> - Change color of toolbar:
> _toolbarcolor_: "set to a valid hex color string, for example: `#00ff00`, and 
> it will change the color the toolbar from default. Only has effect if user 
> has location set to `yes`."
> *iOS:*
> - _closebuttoncolor_ (same as above)
> - _hidenavigationbuttons_ (same as above)
> - _toolbarcolor_ (same as above)
> - Make toolbar non-translucent:
> _toolbartranslucent_: "set to `yes` or `no` to make the toolbar 
> translucent(semi-transparent)  (defaults to `yes`). Only applicable if 
> toolbar is not disabled."
> See screenshots in attachments.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-13409) Allow more additional options, for customizing toolbar in cordova/inappbrowser

2017-10-11 Thread JIRA

[ 
https://issues.apache.org/jira/browse/CB-13409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16200535#comment-16200535
 ] 

Steinar Ágúst Steinarsson commented on CB-13409:


This pull request is ready for review on github

> Allow more additional options, for customizing toolbar in cordova/inappbrowser
> --
>
> Key: CB-13409
> URL: https://issues.apache.org/jira/browse/CB-13409
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-plugin-inappbrowser
> Environment: iOS, Android
>Reporter: Steinar Ágúst Steinarsson
>Priority: Minor
>  Labels: features, newbie
> Attachments: Android - 1.png, Android - 2.png, Android - 3.png, 
> Android - 4.png, Android - 5.png, iOS - 1.PNG
>
>   Original Estimate: 0h
>  Remaining Estimate: 0h
>
> I added a couple of customizations to inappbrowser's toolbar:
> *Android*:
> - Have a custom text for a close button instead of the Default X:
> _closebuttoncaption_: "set to a string to use as the close buttons caption 
> instead of a X. Note that you need to localize this value yourself."
> - Change the close button color:
> _closebuttoncolor_: "set to a valid hex color string, for example: `#00ff00`, 
> and it will change the close button color from default, regardless of being a 
> text or default X. Only has effect if user has location set to `yes`."
> - Hide the navigation buttons that go backwards and forwards:
> _hidenavigationbuttons_: "set to `yes` to hide the navigation buttons on the 
> location toolbar, only has effect if user has location set to `yes`. The 
> default value is `no`."
> - Change navigation buttons color:
> _navigationbuttoncolor_: "set to a valid hex color string, for example: 
> `#00ff00`, and it will change the color of both navigation buttons from 
> default. Only has effect if user has location set to `yes` and not 
> hidenavigationbuttons set to `yes`."
> - Change color of toolbar:
> _toolbarcolor_: "set to a valid hex color string, for example: `#00ff00`, and 
> it will change the color the toolbar from default. Only has effect if user 
> has location set to `yes`."
> *iOS:*
> - _closebuttoncolor_ (same as above)
> - _hidenavigationbuttons_ (same as above)
> - _toolbarcolor_ (same as above)
> - Make toolbar non-translucent:
> _toolbartranslucent_: "set to `yes` or `no` to make the toolbar 
> translucent(semi-transparent)  (defaults to `yes`). Only applicable if 
> toolbar is not disabled."
> See screenshots in attachments.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-13409) Allow more additional options, for customizing toolbar in cordova/inappbrowser

2017-10-09 Thread JIRA

[ 
https://issues.apache.org/jira/browse/CB-13409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16197253#comment-16197253
 ] 

Steinar Ágúst Steinarsson commented on CB-13409:


pull request is here: https://issues.apache.org/jira/browse/CB-13409

> Allow more additional options, for customizing toolbar in cordova/inappbrowser
> --
>
> Key: CB-13409
> URL: https://issues.apache.org/jira/browse/CB-13409
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-plugin-inappbrowser
> Environment: iOS, Android
>Reporter: Steinar Ágúst Steinarsson
>Priority: Minor
>  Labels: features, newbie
> Attachments: Android - 1.png, Android - 2.png, Android - 3.png, 
> Android - 4.png, Android - 5.png, iOS - 1.PNG
>
>   Original Estimate: 8h
>  Remaining Estimate: 8h
>
> I added a couple of customizations to inappbrowser's toolbar:
> *Android*:
> -Have a custom text for a close button instead of the Default X:
> closebuttoncaption: "set to a string to use as the close buttons caption 
> instead of a X. Note that you need to localize this value yourself."
> -Change the close button color:
> closebuttoncolor: "set to a valid hex color string, for example: `#00ff00`, 
> and it will change the
> close button color from default, regardless of being a text or default X. 
> Only has effect if user has location set to `yes`."
> -Hide the navigation buttons that go backwards and forwards:
> hidenavigationbuttons: "set to `yes` to hide the navigation buttons on the 
> location toolbar, only has effect if user has location set to `yes`. The 
> default value is `no`."
> -Change navigation buttons color:
> navigationbuttoncolor: "set to a valid hex color string, for example: 
> `#00ff00`, and it will change the color of both navigation buttons from 
> default. Only has effect if user has location set to `yes` and not 
> hidenavigationbuttons set to `yes`."
> -Change color of toolbar:
> toolbarcolor: "set to a valid hex color string, for example: `#00ff00`, and 
> it will change the color the toolbar from default. Only has effect if user 
> has location set to `yes`."
> *iOS:*
> closebuttoncolor(same as above)
> hidenavigationbuttons(same as above)
> toolbarcolor(same as above)
> -Make toolbar non-translucent:
> toolbartranslucent: "set to `yes` or `no` to make the toolbar 
> translucent(semi-transparent)  (defaults to `yes`). Only applicable if 
> toolbar is not disabled."
> See screenshots in attachments.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-13409) Allow more additional options, for customizing toolbar in cordova/inappbrowser

2017-10-09 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-13409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16197239#comment-16197239
 ] 

ASF GitHub Bot commented on CB-13409:
-

GitHub user steinaragustli opened a pull request:

https://github.com/apache/cordova-plugin-inappbrowser/pull/246

Cb 13409



### Platforms affected
Android, iOS

### What does this PR do?
See https://issues.apache.org/jira/browse/CB-13409

### What testing has been done on this change?
I have tested the combinations possible with the new available 
configurations and have found them working fine, see in screenshots in the link 
on jira. These changes shouldn't break anything since they only allow new 
options.

### Checklist
- [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [ ] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [ ] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/landsbankinn/cordova-plugin-inappbrowser 
CB-13409

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-inappbrowser/pull/246.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #246


commit 8711ee3f211bf84913ae86f81e5e0e548d1c8015
Author: Landsbankinn 
Date:   2017-10-04T16:41:31Z

CB-13409: Lets user adjust color of toolbar, hide navigation buttons and 
set custom text on close button

commit e691212c967fe866551c126e00f4cc7f09c6dfb9
Author: Landsbankinn 
Date:   2017-10-06T13:05:01Z

CB-13409: Android works well now, all changes are now documented

commit 4af420c5920bd779efd9ab19613e132d51040e2b
Author: Landsbankinn 
Date:   2017-10-06T15:35:28Z

CB-13409: change hidetoolbarnavigationbuttons to hidenavigationbuttons in 
iso

commit 55b02285f93515c0f153b0f89366d978192dd900
Author: Landsbankinn 
Date:   2017-10-09T13:50:12Z

CB-13409: ignore idea folder

commit 6c2a8f4576e34ab29ffce102f12efb9c494ba386
Author: Landsbankinn 
Date:   2017-10-09T16:09:08Z

CB-13409: restore gitignore to default

commit ec2f12c8728f4ed39244bd6f3ae011e124e1ddce
Author: Landsbankinn 
Date:   2017-10-09T16:10:22Z

CB-13409: restore gitignore to default

commit ff230d429a3975c670f16e9e8cdf21c6ef874be8
Author: Landsbankinn 
Date:   2017-10-09T16:10:58Z

CB-13409: restore gitignore to default

commit d46f5d45d521eef5faffe0ed71718ddc7c8dfd50
Author: Landsbankinn 
Date:   2017-10-09T16:11:40Z

CB-13409: restore gitignore to default




> Allow more additional options, for customizing toolbar in cordova/inappbrowser
> --
>
> Key: CB-13409
> URL: https://issues.apache.org/jira/browse/CB-13409
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-plugin-inappbrowser
> Environment: iOS, Android
>Reporter: Steinar Ágúst Steinarsson
>Priority: Minor
>  Labels: features, newbie
> Attachments: Android - 1.png, Android - 2.png, Android - 3.png, 
> Android - 4.png, Android - 5.png, iOS - 1.PNG
>
>   Original Estimate: 8h
>  Remaining Estimate: 8h
>
> I added a couple of customizations to inappbrowser's toolbar:
> *Android*:
> -Have a custom text for a close button instead of the Default X:
> closebuttoncaption: "set to a string to use as the close buttons caption 
> instead of a X. Note that you need to localize this value yourself."
> -Change the close button color:
> closebuttoncolor: "set to a valid hex color string, for example: `#00ff00`, 
> and it will change the
> close button color from default, regardless of being a text or default X. 
> Only has effect if user has location set to `yes`."
> -Hide the navigation buttons that go backwards and forwards:
> hidenavigationbuttons: "set to `yes` to hide the navigation buttons on the 
> location toolbar, only has effect if user has location set to `yes`. The 
> default value is `no`."
> -Change navigation buttons color:
> navigationbuttoncolor: "set to a valid hex color string, for example: 
> `#00ff00`, and it will change the color of both navigation buttons from 
> default. Only has effect if user has location set to `yes` and not 
> 

[jira] [Commented] (CB-13409) Allow more additional options, for customizing toolbar in cordova/inappbrowser

2017-10-09 Thread Jan Piotrowski (Sujan) (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-13409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16196792#comment-16196792
 ] 

Jan Piotrowski (Sujan) commented on CB-13409:
-

Ah, awesome. Was confused by the "I added ..." - take your time and just leave 
a comment when it is done.

> Allow more additional options, for customizing toolbar in cordova/inappbrowser
> --
>
> Key: CB-13409
> URL: https://issues.apache.org/jira/browse/CB-13409
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-plugin-inappbrowser
> Environment: iOS, Android
>Reporter: Steinar Ágúst Steinarsson
>Priority: Minor
>  Labels: features, newbie
>   Original Estimate: 8h
>  Remaining Estimate: 8h
>
> I added a couple of customizations to inappbrowser's toolbar:
> *Android*:
> -Have a custom text for a close button instead of the Default X:
> closebuttoncaption: "set to a string to use as the close buttons caption 
> instead of a X. Note that you need to localize this value yourself."
> -Change the close button color:
> closebuttoncolor: "set to a valid hex color string, for example: `#00ff00`, 
> and it will change the
> close button color from default, regardless of being a text or default X. 
> Only has effect if user has location set to `yes`."
> -Hide the navigation buttons that go backwards and forwards:
> hidenavigationbuttons: "set to `yes` to hide the navigation buttons on the 
> location toolbar, only has effect if user has location set to `yes`. The 
> default value is `no`."
> -Change navigation buttons color:
> navigationbuttoncolor: "set to a valid hex color string, for example: 
> `#00ff00`, and it will change the color of both navigation buttons from 
> default. Only has effect if user has location set to `yes` and not 
> hidenavigationbuttons set to `yes`."
> -Change color of toolbar:
> toolbarcolor: "set to a valid hex color string, for example: `#00ff00`, and 
> it will change the color the toolbar from default. Only has effect if user 
> has location set to `yes`."
> *iOS:*
> closebuttoncolor(same as above)
> hidenavigationbuttons(same as above)
> toolbarcolor(same as above)
> -Make toolbar non-translucent:
> toolbartranslucent: "set to `yes` or `no` to make the toolbar 
> translucent(semi-transparent)  (defaults to `yes`). Only applicable if 
> toolbar is not disabled."



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-13409) Allow more additional options, for customizing toolbar in cordova/inappbrowser

2017-10-09 Thread JIRA

[ 
https://issues.apache.org/jira/browse/CB-13409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16196765#comment-16196765
 ] 

Steinar Ágúst Steinarsson commented on CB-13409:


Yes, its coming soon.

> Allow more additional options, for customizing toolbar in cordova/inappbrowser
> --
>
> Key: CB-13409
> URL: https://issues.apache.org/jira/browse/CB-13409
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-plugin-inappbrowser
> Environment: iOS, Android
>Reporter: Steinar Ágúst Steinarsson
>Priority: Minor
>  Labels: features, newbie
>   Original Estimate: 8h
>  Remaining Estimate: 8h
>
> I added a couple of customizations to inappbrowser's toolbar:
> *Android*:
> -Have a custom text for a close button instead of the Default X:
> closebuttoncaption: "set to a string to use as the close buttons caption 
> instead of a X. Note that you need to localize this value yourself."
> -Change the close button color:
> closebuttoncolor: "set to a valid hex color string, for example: `#00ff00`, 
> and it will change the
> close button color from default, regardless of being a text or default X. 
> Only has effect if user has location set to `yes`."
> -Hide the navigation buttons that go backwards and forwards:
> hidenavigationbuttons: "set to `yes` to hide the navigation buttons on the 
> location toolbar, only has effect if user has location set to `yes`. The 
> default value is `no`."
> -Change navigation buttons color:
> navigationbuttoncolor: "set to a valid hex color string, for example: 
> `#00ff00`, and it will change the color of both navigation buttons from 
> default. Only has effect if user has location set to `yes` and not 
> hidenavigationbuttons set to `yes`."
> -Change color of toolbar:
> toolbarcolor: "set to a valid hex color string, for example: `#00ff00`, and 
> it will change the color the toolbar from default. Only has effect if user 
> has location set to `yes`."
> *iOS:*
> closebuttoncolor(same as above)
> hidenavigationbuttons(same as above)
> toolbarcolor(same as above)
> -Make toolbar non-translucent:
> toolbartranslucent: "set to `yes` or `no` to make the toolbar 
> translucent(semi-transparent)  (defaults to `yes`). Only applicable if 
> toolbar is not disabled."



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-13409) Allow more additional options, for customizing toolbar in cordova/inappbrowser

2017-10-06 Thread Jan Piotrowski (Sujan) (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-13409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16195453#comment-16195453
 ] 

Jan Piotrowski (Sujan) commented on CB-13409:
-

Nice! Is there a PR for that?

> Allow more additional options, for customizing toolbar in cordova/inappbrowser
> --
>
> Key: CB-13409
> URL: https://issues.apache.org/jira/browse/CB-13409
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-plugin-inappbrowser
> Environment: iOS, Android
>Reporter: Steinar Ágúst Steinarsson
>Priority: Minor
>  Labels: features, newbie
>   Original Estimate: 8h
>  Remaining Estimate: 8h
>
> I added a couple of customizations to inappbrowser's toolbar:
> *Android*:
> -Have a custom text for a close button instead of the Default X:
> closebuttoncaption: "set to a string to use as the close buttons caption 
> instead of a X. Note that you need to localize this value yourself."
> -Change the close button color:
> closebuttoncolor: "set to a valid hex color string, for example: `#00ff00`, 
> and it will change the
> close button color from default, regardless of being a text or default X. 
> Only has effect if user has location set to `yes`."
> -Hide the navigation buttons that go backwards and forwards:
> hidenavigationbuttons: "set to `yes` to hide the navigation buttons on the 
> location toolbar, only has effect if user has location set to `yes`. The 
> default value is `no`."
> -Change navigation buttons color:
> navigationbuttoncolor: "set to a valid hex color string, for example: 
> `#00ff00`, and it will change the color of both navigation buttons from 
> default. Only has effect if user has location set to `yes` and not 
> hidenavigationbuttons set to `yes`."
> -Change color of toolbar:
> toolbarcolor: "set to a valid hex color string, for example: `#00ff00`, and 
> it will change the color the toolbar from default. Only has effect if user 
> has location set to `yes`."
> *iOS:*
> closebuttoncolor(same as above)
> hidenavigationbuttons(same as above)
> toolbarcolor(same as above)
> -Make toolbar non-translucent:
> toolbartranslucent: "set to `yes` or `no` to make the toolbar 
> translucent(semi-transparent)  (defaults to `yes`). Only applicable if 
> toolbar is not disabled."



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org