[jira] [Commented] (CB-13969) Allow close button and navigation buttons positions to be swapped - Cordova/inappbrowser
[ https://issues.apache.org/jira/browse/CB-13969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16785290#comment-16785290 ] ASF subversion and git services commented on CB-13969: -- Commit 3c0a42e2aedd19a06115e58ac56c3f3ea4a61dc5 in cordova-plugin-inappbrowser's branch refs/heads/master from steinaragustli [ https://gitbox.apache.org/repos/asf?p=cordova-plugin-inappbrowser.git;h=3c0a42e ] CB-13969 fix inappbrowser.css to be unmodified > Allow close button and navigation buttons positions to be swapped - > Cordova/inappbrowser > > > Key: CB-13969 > URL: https://issues.apache.org/jira/browse/CB-13969 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-plugin-inappbrowser > Environment: iOS and Android >Reporter: Steinar Ágúst Steinarsson >Priority: Minor > Labels: inappbrowser > Attachments: IMG_0003.jpg, IMG_0004.PNG, > Screenshot_20180313-105154.png, Screenshot_20180313-110504.png > > Original Estimate: 0h > Remaining Estimate: 0h > > Allow the user to swap positions for the close button and navigation buttons. > I added a new property 'lefttoright' which does this. > Screenshots: > iOS(the default for the close button is being on the left): > 'lefttoright' is set: > !IMG_0004.PNG! > default(not set): > !IMG_0003.jpg! > > Android(default is for close button being on the right): > 'lefttoright' is set: > !Screenshot_20180313-110504.png! > default(not set): > !Screenshot_20180313-105154.png! -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13969) Allow close button and navigation buttons positions to be swapped - Cordova/inappbrowser
[ https://issues.apache.org/jira/browse/CB-13969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16785288#comment-16785288 ] ASF subversion and git services commented on CB-13969: -- Commit c7931faa7e7a3f4dbe8def504609f5421b5130ff in cordova-plugin-inappbrowser's branch refs/heads/master from Steinar Ágúst [ https://gitbox.apache.org/repos/asf?p=cordova-plugin-inappbrowser.git;h=c7931fa ] CB-13969 adding newline at end of inappbrowser.cs > Allow close button and navigation buttons positions to be swapped - > Cordova/inappbrowser > > > Key: CB-13969 > URL: https://issues.apache.org/jira/browse/CB-13969 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-plugin-inappbrowser > Environment: iOS and Android >Reporter: Steinar Ágúst Steinarsson >Priority: Minor > Labels: inappbrowser > Attachments: IMG_0003.jpg, IMG_0004.PNG, > Screenshot_20180313-105154.png, Screenshot_20180313-110504.png > > Original Estimate: 0h > Remaining Estimate: 0h > > Allow the user to swap positions for the close button and navigation buttons. > I added a new property 'lefttoright' which does this. > Screenshots: > iOS(the default for the close button is being on the left): > 'lefttoright' is set: > !IMG_0004.PNG! > default(not set): > !IMG_0003.jpg! > > Android(default is for close button being on the right): > 'lefttoright' is set: > !Screenshot_20180313-110504.png! > default(not set): > !Screenshot_20180313-105154.png! -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13969) Allow close button and navigation buttons positions to be swapped - Cordova/inappbrowser
[ https://issues.apache.org/jira/browse/CB-13969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16396860#comment-16396860 ] Steinar Ágúst Steinarsson commented on CB-13969: PR is here: https://github.com/apache/cordova-plugin-inappbrowser/pull/262 > Allow close button and navigation buttons positions to be swapped - > Cordova/inappbrowser > > > Key: CB-13969 > URL: https://issues.apache.org/jira/browse/CB-13969 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-plugin-inappbrowser > Environment: iOS and Android >Reporter: Steinar Ágúst Steinarsson >Priority: Minor > Labels: inappbrowser > Attachments: IMG_0003.jpg, IMG_0004.PNG, > Screenshot_20180313-105154.png, Screenshot_20180313-110504.png > > Original Estimate: 0h > Remaining Estimate: 0h > > Allow the user to swap positions for the close button and navigation buttons. > I added a new property 'lefttoright' which does this. > Screenshots: > iOS(the default for the close button is being on the left): > 'lefttoright' is set: > !IMG_0004.PNG! > default(not set): > !IMG_0003.jpg! > > Android(default is for close button being on the right): > 'lefttoright' is set: > !Screenshot_20180313-110504.png! > default(not set): > !Screenshot_20180313-105154.png! > I also fixed a bug in iOS which was hiding the navigation buttons, even > though 'hidenavigationbuttons' is false. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
