[jira] [Commented] (CB-14083) Travis doesn't actually test docs on PR
[
https://issues.apache.org/jira/browse/CB-14083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16479123#comment-16479123
]
ASF GitHub Bot commented on CB-14083:
-
dpogue closed pull request #815: CB-14083: run build on PR
URL: https://github.com/apache/cordova-docs/pull/815
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/buildAndDeploy.sh b/buildAndDeploy.sh
index 76358f25c..66f16f9e6 100755
--- a/buildAndDeploy.sh
+++ b/buildAndDeploy.sh
@@ -13,6 +13,6 @@ then
cd ../cordova-docs || return;
npm test;
else
-echo "### test only: (branch = $BRANCH)"
-npm test;
+echo "### Build: (branch = $BRANCH)"
+npm run build;
fi
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Travis doesn't actually test docs on PR
> ---
>
> Key: CB-14083
> URL: https://issues.apache.org/jira/browse/CB-14083
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-docs
>Reporter: Dmitry Blotsky
>Priority: Major
> Labels: docs, travis
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> Right now the per-PR Travis task runs {{npm test}}, which doesn't actually
> build the site; it only tests code that isn't used anymore.
> Instead, it should run {{npm run-script build}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14083) Travis doesn't actually test docs on PR
[
https://issues.apache.org/jira/browse/CB-14083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16479124#comment-16479124
]
ASF subversion and git services commented on CB-14083:
--
Commit 8bdb662750d087fcb3e88a5707dda4757b5998e2 in cordova-docs's branch
refs/heads/master from [~wtrocki]
[ https://gitbox.apache.org/repos/asf?p=cordova-docs.git;h=8bdb662 ]
CB-14083: run build on PR
> Travis doesn't actually test docs on PR
> ---
>
> Key: CB-14083
> URL: https://issues.apache.org/jira/browse/CB-14083
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-docs
>Reporter: Dmitry Blotsky
>Priority: Major
> Labels: docs, travis
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> Right now the per-PR Travis task runs {{npm test}}, which doesn't actually
> build the site; it only tests code that isn't used anymore.
> Instead, it should run {{npm run-script build}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14083) Travis doesn't actually test docs on PR
[
https://issues.apache.org/jira/browse/CB-14083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16468556#comment-16468556
]
ASF GitHub Bot commented on CB-14083:
-
wtrocki opened a new pull request #815: CB-14083: run build on PR
URL: https://github.com/apache/cordova-docs/pull/815
## Motivation
https://issues.apache.org/jira/browse/CB-14083?filter=12343692
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Travis doesn't actually test docs on PR
> ---
>
> Key: CB-14083
> URL: https://issues.apache.org/jira/browse/CB-14083
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-docs
>Reporter: Dmitry Blotsky
>Priority: Major
> Labels: docs, travis
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> Right now the per-PR Travis task runs {{npm test}}, which doesn't actually
> build the site; it only tests code that isn't used anymore.
> Instead, it should run {{npm run-script build}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14083) Travis doesn't actually test docs on PR
[
https://issues.apache.org/jira/browse/CB-14083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16468498#comment-16468498
]
Wojciech Trocki commented on CB-14083:
--
Taking a look
> Travis doesn't actually test docs on PR
> ---
>
> Key: CB-14083
> URL: https://issues.apache.org/jira/browse/CB-14083
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-docs
>Reporter: Dmitry Blotsky
>Priority: Major
> Labels: docs, travis
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> Right now the per-PR Travis task runs {{npm test}}, which doesn't actually
> build the site; it only tests code that isn't used anymore.
> Instead, it should run {{npm run-script build}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
