[jira] [Updated] (CB-11394) backbutton eventlistener should be able to let cordova execute the default native behaviour
[ https://issues.apache.org/jira/browse/CB-11394?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Bowser updated CB-11394: Priority: Minor (was: Major) Making this a minor issue, since the current behaviour is documented. I do not see an easy way to change this, and make it actually work predictably, since the default behaviour of the back button is to close the document or the application. > backbutton eventlistener should be able to let cordova execute the default > native behaviour > --- > > Key: CB-11394 > URL: https://issues.apache.org/jira/browse/CB-11394 > Project: Apache Cordova > Issue Type: Bug > Components: Android >Reporter: Philipp Kursawe >Priority: Minor > > When we override the "backbutton" with a custom handler, cordova completly > skips handling of the native behaviour (as written in the docs). > It does this even though the events `defaultPrevented` property is set to > `false`. A proper implementation of event handling would look into this > property and act accordingly. > Not sure how this could be introduced now without breaking old code. > Probably old code never returns a value from the event handler. So a patch > could check if the return value is `===true` then it should perform the > default native behaviour of that button. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-11394) backbutton eventlistener should be able to let cordova execute the default native behaviour
[ https://issues.apache.org/jira/browse/CB-11394?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Philipp Kursawe updated CB-11394: - Issue Type: Improvement (was: Bug) > backbutton eventlistener should be able to let cordova execute the default > native behaviour > --- > > Key: CB-11394 > URL: https://issues.apache.org/jira/browse/CB-11394 > Project: Apache Cordova > Issue Type: Improvement > Components: Android >Reporter: Philipp Kursawe > > When we override the "backbutton" with a custom handler, cordova completly > skips handling of the native behaviour (as written in the docs). > It does this even though the events `defaultPrevented` property is set to > `false`. A proper implementation of event handling would look into this > property and act accordingly. > Not sure how this could be introduced now without breaking old code. > Probably old code never returns a value from the event handler. So a patch > could check if the return value is `===true` then it should perform the > default native behaviour of that button. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-11394) backbutton eventlistener should be able to let cordova execute the default native behaviour
[ https://issues.apache.org/jira/browse/CB-11394?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Philipp Kursawe updated CB-11394: - Issue Type: Bug (was: Improvement) > backbutton eventlistener should be able to let cordova execute the default > native behaviour > --- > > Key: CB-11394 > URL: https://issues.apache.org/jira/browse/CB-11394 > Project: Apache Cordova > Issue Type: Bug > Components: Android >Reporter: Philipp Kursawe > > When we override the "backbutton" with a custom handler, cordova completly > skips handling of the native behaviour (as written in the docs). > It does this even though the events `defaultPrevented` property is set to > `false`. A proper implementation of event handling would look into this > property and act accordingly. > Not sure how this could be introduced now without breaking old code. > Probably old code never returns a value from the event handler. So a patch > could check if the return value is `===true` then it should perform the > default native behaviour of that button. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-11394) backbutton eventlistener should be able to let cordova execute the default native behaviour
[ https://issues.apache.org/jira/browse/CB-11394?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Philipp Kursawe updated CB-11394: - Description: When we override the "backbutton" with a custom handler, cordova completly skips handling of the native behaviour (as written in the docs). It does this even though the events `defaultPrevented` property is set to `false`. A proper implementation of event handling would look into this property and act accordingly. Not sure how this could be introduced now without breaking old code. Probably old code never returns a value from the event handler. So a patch could check if the return value is `===true` then it should perform the default native behaviour of that button. was: When we override the "menubutton" with a custom handler, cordova completly skips handling of the native behaviour (as written in the docs). It does this even though the events `defaultPrevented` property is set to `false`. A proper implementation of event handling would look into this property and act accordingly. Not sure how this could be introduced now without breaking old code. Probably old code never returns a value from the event handler. So a patch could check if the return value is `===true` then it should perform the default native behaviour of that button. > backbutton eventlistener should be able to let cordova execute the default > native behaviour > --- > > Key: CB-11394 > URL: https://issues.apache.org/jira/browse/CB-11394 > Project: Apache Cordova > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Android >Reporter: Philipp Kursawe > > When we override the "backbutton" with a custom handler, cordova completly > skips handling of the native behaviour (as written in the docs). > It does this even though the events `defaultPrevented` property is set to > `false`. A proper implementation of event handling would look into this > property and act accordingly. > Not sure how this could be introduced now without breaking old code. > Probably old code never returns a value from the event handler. So a patch > could check if the return value is `===true` then it should perform the > default native behaviour of that button. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-11394) backbutton eventlistener should be able to let cordova execute the default native behaviour
[ https://issues.apache.org/jira/browse/CB-11394?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Philipp Kursawe updated CB-11394: - Component/s: (was: AllPlatforms) Android > backbutton eventlistener should be able to let cordova execute the default > native behaviour > --- > > Key: CB-11394 > URL: https://issues.apache.org/jira/browse/CB-11394 > Project: Apache Cordova > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Android >Reporter: Philipp Kursawe > > When we override the "menubutton" with a custom handler, cordova completly > skips handling of the native behaviour (as written in the docs). > It does this even though the events `defaultPrevented` property is set to > `false`. A proper implementation of event handling would look into this > property and act accordingly. > Not sure how this could be introduced now without breaking old code. > Probably old code never returns a value from the event handler. So a patch > could check if the return value is `===true` then it should perform the > default native behaviour of that button. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-11394) backbutton eventlistener should be able to let cordova execute the default native behaviour
[ https://issues.apache.org/jira/browse/CB-11394?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Philipp Kursawe updated CB-11394: - Summary: backbutton eventlistener should be able to let cordova execute the default native behaviour (was: backbutton eventlistener does not respect event.defaultPrevented) > backbutton eventlistener should be able to let cordova execute the default > native behaviour > --- > > Key: CB-11394 > URL: https://issues.apache.org/jira/browse/CB-11394 > Project: Apache Cordova > Issue Type: Bug > Components: AllPlatforms >Reporter: Philipp Kursawe > > When we override the "menubutton" with a custom handler, cordova completly > skips handling of the native behaviour (as written in the docs). > It does this even though the events `defaultPrevented` property is set to > `false`. A proper implementation of event handling would look into this > property and act accordingly. > Not sure how this could be introduced now without breaking old code. > Probably old code never returns a value from the event handler. So a patch > could check if the return value is `===true` then it should perform the > default native behaviour of that button. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
