[jira] [Commented] (DRILL-5305) Query Profile must display Query ID
[
https://issues.apache.org/jira/browse/DRILL-5305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16481078#comment-16481078
]
ASF GitHub Bot commented on DRILL-5305:
---
kkhatua commented on a change in pull request #1265: DRILL-5305: Query Profile
must display Query ID
URL: https://github.com/apache/drill/pull/1265#discussion_r189368967
##
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/ProfileWrapper.java
##
@@ -63,7 +63,7 @@
public ProfileWrapper(final QueryProfile profile, DrillConfig drillConfig) {
this.profile = profile;
-this.id = QueryIdHelper.getQueryId(profile.getId());
+this.id = profile.getId().hasText() ? profile.getId().getText() :
QueryIdHelper.getQueryId(profile.getId());
Review comment:
The JIRA's goal is to embed the query ID text within the profile. Since it
is within the profile, it would be more efficient to use that value versus
decoding repeatedly. Hence, it is an optional part of the QueryID (see proto
file), so that we can fall back to the decoding approach.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Query Profile must display Query ID
> ---
>
> Key: DRILL-5305
> URL: https://issues.apache.org/jira/browse/DRILL-5305
> Project: Apache Drill
> Issue Type: Improvement
> Components: Client - HTTP, Web Server
>Affects Versions: 1.10.0
>Reporter: Abhishek Girish
>Assignee: Kunal Khatua
>Priority: Minor
> Labels: newbie
> Fix For: 1.14.0
>
>
> It would be good to have the query ID, profile ID listed as part of the
> profile itself. Currently there is no easy way to map a profile with the
> query.
> I understand that the profile ID in the URL can be used, but often when we
> have profile dumps shared for analysis, they may not contain the query IDs.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (DRILL-5305) Query Profile must display Query ID
[
https://issues.apache.org/jira/browse/DRILL-5305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16480992#comment-16480992
]
ASF GitHub Bot commented on DRILL-5305:
---
ppadma commented on a change in pull request #1265: DRILL-5305: Query Profile
must display Query ID
URL: https://github.com/apache/drill/pull/1265#discussion_r189349466
##
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/ProfileWrapper.java
##
@@ -63,7 +63,7 @@
public ProfileWrapper(final QueryProfile profile, DrillConfig drillConfig) {
this.profile = profile;
-this.id = QueryIdHelper.getQueryId(profile.getId());
+this.id = profile.getId().hasText() ? profile.getId().getText() :
QueryIdHelper.getQueryId(profile.getId());
Review comment:
why not decode always instead of doing the check ? It is not a big deal
either way.
LGTM +1.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Query Profile must display Query ID
> ---
>
> Key: DRILL-5305
> URL: https://issues.apache.org/jira/browse/DRILL-5305
> Project: Apache Drill
> Issue Type: Improvement
> Components: Client - HTTP, Web Server
>Affects Versions: 1.10.0
>Reporter: Abhishek Girish
>Assignee: Kunal Khatua
>Priority: Minor
> Labels: newbie
> Fix For: 1.14.0
>
>
> It would be good to have the query ID, profile ID listed as part of the
> profile itself. Currently there is no easy way to map a profile with the
> query.
> I understand that the profile ID in the URL can be used, but often when we
> have profile dumps shared for analysis, they may not contain the query IDs.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (DRILL-5305) Query Profile must display Query ID
[
https://issues.apache.org/jira/browse/DRILL-5305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16480930#comment-16480930
]
ASF GitHub Bot commented on DRILL-5305:
---
kkhatua commented on a change in pull request #1265: DRILL-5305: Query Profile
must display Query ID
URL: https://github.com/apache/drill/pull/1265#discussion_r189334169
##
File path: exec/java-exec/src/main/resources/rest/profile/profile.ftl
##
@@ -165,7 +165,7 @@ table.sortable thead .sorting_desc { background-image:
url("/static/img/black-de
<#assign queued = queueName != "" && queueName != "-" />
- Query Profile
+ Query Profile : ${model.getQueryId()}
Review comment:
Yes. The backing ProfileWrapper returns the queryID as a text.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Query Profile must display Query ID
> ---
>
> Key: DRILL-5305
> URL: https://issues.apache.org/jira/browse/DRILL-5305
> Project: Apache Drill
> Issue Type: Improvement
> Components: Client - HTTP, Web Server
>Affects Versions: 1.10.0
>Reporter: Abhishek Girish
>Assignee: Kunal Khatua
>Priority: Minor
> Labels: newbie
> Fix For: 1.14.0
>
>
> It would be good to have the query ID, profile ID listed as part of the
> profile itself. Currently there is no easy way to map a profile with the
> query.
> I understand that the profile ID in the URL can be used, but often when we
> have profile dumps shared for analysis, they may not contain the query IDs.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (DRILL-5305) Query Profile must display Query ID
[
https://issues.apache.org/jira/browse/DRILL-5305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16480929#comment-16480929
]
ASF GitHub Bot commented on DRILL-5305:
---
kkhatua commented on a change in pull request #1265: DRILL-5305: Query Profile
must display Query ID
URL: https://github.com/apache/drill/pull/1265#discussion_r189333907
##
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/ProfileWrapper.java
##
@@ -63,7 +63,7 @@
public ProfileWrapper(final QueryProfile profile, DrillConfig drillConfig) {
this.profile = profile;
-this.id = QueryIdHelper.getQueryId(profile.getId());
+this.id = profile.getId().hasText() ? profile.getId().getText() :
QueryIdHelper.getQueryId(profile.getId());
Review comment:
Yes. But if the profile is of an older format, ``hasText()` will ensure that
the query ID text is decoded from the ID components: part1 & part2.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Query Profile must display Query ID
> ---
>
> Key: DRILL-5305
> URL: https://issues.apache.org/jira/browse/DRILL-5305
> Project: Apache Drill
> Issue Type: Improvement
> Components: Client - HTTP, Web Server
>Affects Versions: 1.10.0
>Reporter: Abhishek Girish
>Assignee: Kunal Khatua
>Priority: Minor
> Labels: newbie
> Fix For: 1.14.0
>
>
> It would be good to have the query ID, profile ID listed as part of the
> profile itself. Currently there is no easy way to map a profile with the
> query.
> I understand that the profile ID in the URL can be used, but often when we
> have profile dumps shared for analysis, they may not contain the query IDs.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (DRILL-5305) Query Profile must display Query ID
[
https://issues.apache.org/jira/browse/DRILL-5305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16479691#comment-16479691
]
ASF GitHub Bot commented on DRILL-5305:
---
ppadma commented on a change in pull request #1265: DRILL-5305: Query Profile
must display Query ID
URL: https://github.com/apache/drill/pull/1265#discussion_r189097009
##
File path: exec/java-exec/src/main/resources/rest/profile/profile.ftl
##
@@ -165,7 +165,7 @@ table.sortable thead .sorting_desc { background-image:
url("/static/img/black-de
<#assign queued = queueName != "" && queueName != "-" />
- Query Profile
+ Query Profile : ${model.getQueryId()}
Review comment:
what does this return ? text ?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Query Profile must display Query ID
> ---
>
> Key: DRILL-5305
> URL: https://issues.apache.org/jira/browse/DRILL-5305
> Project: Apache Drill
> Issue Type: Improvement
> Components: Client - HTTP, Web Server
>Affects Versions: 1.10.0
>Reporter: Abhishek Girish
>Assignee: Kunal Khatua
>Priority: Minor
> Labels: newbie
> Fix For: 1.14.0
>
>
> It would be good to have the query ID, profile ID listed as part of the
> profile itself. Currently there is no easy way to map a profile with the
> query.
> I understand that the profile ID in the URL can be used, but often when we
> have profile dumps shared for analysis, they may not contain the query IDs.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (DRILL-5305) Query Profile must display Query ID
[
https://issues.apache.org/jira/browse/DRILL-5305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16479690#comment-16479690
]
ASF GitHub Bot commented on DRILL-5305:
---
ppadma commented on a change in pull request #1265: DRILL-5305: Query Profile
must display Query ID
URL: https://github.com/apache/drill/pull/1265#discussion_r189095960
##
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/ProfileWrapper.java
##
@@ -63,7 +63,7 @@
public ProfileWrapper(final QueryProfile profile, DrillConfig drillConfig) {
this.profile = profile;
-this.id = QueryIdHelper.getQueryId(profile.getId());
+this.id = profile.getId().hasText() ? profile.getId().getText() :
QueryIdHelper.getQueryId(profile.getId());
Review comment:
both of them should return the same value. isn't it ?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Query Profile must display Query ID
> ---
>
> Key: DRILL-5305
> URL: https://issues.apache.org/jira/browse/DRILL-5305
> Project: Apache Drill
> Issue Type: Improvement
> Components: Client - HTTP, Web Server
>Affects Versions: 1.10.0
>Reporter: Abhishek Girish
>Assignee: Kunal Khatua
>Priority: Minor
> Labels: newbie
> Fix For: 1.14.0
>
>
> It would be good to have the query ID, profile ID listed as part of the
> profile itself. Currently there is no easy way to map a profile with the
> query.
> I understand that the profile ID in the URL can be used, but often when we
> have profile dumps shared for analysis, they may not contain the query IDs.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (DRILL-5305) Query Profile must display Query ID
[ https://issues.apache.org/jira/browse/DRILL-5305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1641#comment-1641 ] ASF GitHub Bot commented on DRILL-5305: --- kkhatua opened a new pull request #1265: DRILL-5305: Query Profile must display Query ID URL: https://github.com/apache/drill/pull/1265 Introduced change to the Protobuf to inject the text-equivalent of the QueryID into the profile. This way, the profile's file name can be changed, but restored back based on this new field. The Profile UI also shows the Query ID, though this is not inferred from this new field, for sake of backward compatibility with older profiles. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Query Profile must display Query ID > --- > > Key: DRILL-5305 > URL: https://issues.apache.org/jira/browse/DRILL-5305 > Project: Apache Drill > Issue Type: Improvement > Components: Client - HTTP, Web Server >Affects Versions: 1.10.0 >Reporter: Abhishek Girish >Assignee: Padma Penumarthy >Priority: Minor > Labels: newbie > Fix For: 1.14.0 > > > It would be good to have the query ID, profile ID listed as part of the > profile itself. Currently there is no easy way to map a profile with the > query. > I understand that the profile ID in the URL can be used, but often when we > have profile dumps shared for analysis, they may not contain the query IDs. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (DRILL-5305) Query Profile must display Query ID
[ https://issues.apache.org/jira/browse/DRILL-5305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16446360#comment-16446360 ] Kunal Khatua commented on DRILL-5305: - [~ppenumarthy] can this be done within the April sprint?? > Query Profile must display Query ID > --- > > Key: DRILL-5305 > URL: https://issues.apache.org/jira/browse/DRILL-5305 > Project: Apache Drill > Issue Type: Improvement > Components: Client - HTTP, Web Server >Affects Versions: 1.10.0 >Reporter: Abhishek Girish >Assignee: Padma Penumarthy >Priority: Minor > Labels: newbie > Fix For: 1.14.0 > > > It would be good to have the query ID, profile ID listed as part of the > profile itself. Currently there is no easy way to map a profile with the > query. > I understand that the profile ID in the URL can be used, but often when we > have profile dumps shared for analysis, they may not contain the query IDs. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (DRILL-5305) Query Profile must display Query ID
[ https://issues.apache.org/jira/browse/DRILL-5305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16201459#comment-16201459 ] Kunal Khatua commented on DRILL-5305: - This requires a change in the UserSharedBit protobuf, but should not break anything. It's a minor change not requiring less than a day's worth of effort. So, I'm marking this for 1.12.0. > Query Profile must display Query ID > --- > > Key: DRILL-5305 > URL: https://issues.apache.org/jira/browse/DRILL-5305 > Project: Apache Drill > Issue Type: Improvement > Components: Client - HTTP, Web Server >Affects Versions: 1.10.0 >Reporter: Abhishek Girish >Assignee: Padma Penumarthy >Priority: Minor > Fix For: 1.12.0 > > > It would be good to have the query ID, profile ID listed as part of the > profile itself. Currently there is no easy way to map a profile with the > query. > I understand that the profile ID in the URL can be used, but often when we > have profile dumps shared for analysis, they may not contain the query IDs. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
