[jira] [Commented] (DRILL-5698) Drill should start in embedded mode using java 1.8.0_144
[ https://issues.apache.org/jira/browse/DRILL-5698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16127229#comment-16127229 ] ASF GitHub Bot commented on DRILL-5698: --- Github user asfgit closed the pull request at: https://github.com/apache/drill/pull/890 > Drill should start in embedded mode using java 1.8.0_144 > > > Key: DRILL-5698 > URL: https://issues.apache.org/jira/browse/DRILL-5698 > Project: Apache Drill > Issue Type: Bug >Reporter: Darren > Labels: ready-to-commit > Fix For: 1.12.0 > > > Currently the start up script > distribution/src/resources/drill-config.sh > prevents drill from starting as the regex incorrectly captures the 144 > portion of the version code > this is because the regex isn't escaped > -"$JAVA" -version 2>&1 | grep "version" | egrep -e "1.4|1.5|1.6" > /dev/null > +"$JAVA" -version 2>&1 | grep "version" | egrep -e "1\.4|1\.5|1\.6" > > /dev/null -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (DRILL-5698) Drill should start in embedded mode using java 1.8.0_144
[ https://issues.apache.org/jira/browse/DRILL-5698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16120635#comment-16120635 ] ASF GitHub Bot commented on DRILL-5698: --- Github user darrenbrien closed the pull request at: https://github.com/apache/drill/pull/899 > Drill should start in embedded mode using java 1.8.0_144 > > > Key: DRILL-5698 > URL: https://issues.apache.org/jira/browse/DRILL-5698 > Project: Apache Drill > Issue Type: Bug >Reporter: Darren > Labels: ready-to-commit > Fix For: 1.12.0 > > > Currently the start up script > distribution/src/resources/drill-config.sh > prevents drill from starting as the regex incorrectly captures the 144 > portion of the version code > this is because the regex isn't escaped > -"$JAVA" -version 2>&1 | grep "version" | egrep -e "1.4|1.5|1.6" > /dev/null > +"$JAVA" -version 2>&1 | grep "version" | egrep -e "1\.4|1\.5|1\.6" > > /dev/null -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (DRILL-5698) Drill should start in embedded mode using java 1.8.0_144
[ https://issues.apache.org/jira/browse/DRILL-5698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16119969#comment-16119969 ] ASF GitHub Bot commented on DRILL-5698: --- Github user arina-ielchiieva commented on the issue: https://github.com/apache/drill/pull/899 @darrenbrien please close this PR. > Drill should start in embedded mode using java 1.8.0_144 > > > Key: DRILL-5698 > URL: https://issues.apache.org/jira/browse/DRILL-5698 > Project: Apache Drill > Issue Type: Bug >Reporter: Darren > Labels: ready-to-commit > Fix For: 1.12.0 > > > Currently the start up script > distribution/src/resources/drill-config.sh > prevents drill from starting as the regex incorrectly captures the 144 > portion of the version code > this is because the regex isn't escaped > -"$JAVA" -version 2>&1 | grep "version" | egrep -e "1.4|1.5|1.6" > /dev/null > +"$JAVA" -version 2>&1 | grep "version" | egrep -e "1\.4|1\.5|1\.6" > > /dev/null -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (DRILL-5698) Drill should start in embedded mode using java 1.8.0_144
[ https://issues.apache.org/jira/browse/DRILL-5698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16119690#comment-16119690 ] ASF GitHub Bot commented on DRILL-5698: --- Github user arina-ielchiieva commented on the issue: https://github.com/apache/drill/pull/890 There was not need to create new PR. You could just amend your commit message and use `git push -f`. > Drill should start in embedded mode using java 1.8.0_144 > > > Key: DRILL-5698 > URL: https://issues.apache.org/jira/browse/DRILL-5698 > Project: Apache Drill > Issue Type: Bug >Reporter: Darren > Labels: ready-to-commit > Fix For: 1.12.0 > > > Currently the start up script > distribution/src/resources/drill-config.sh > prevents drill from starting as the regex incorrectly captures the 144 > portion of the version code > this is because the regex isn't escaped > -"$JAVA" -version 2>&1 | grep "version" | egrep -e "1.4|1.5|1.6" > /dev/null > +"$JAVA" -version 2>&1 | grep "version" | egrep -e "1\.4|1\.5|1\.6" > > /dev/null -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (DRILL-5698) Drill should start in embedded mode using java 1.8.0_144
[ https://issues.apache.org/jira/browse/DRILL-5698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16119685#comment-16119685 ] ASF GitHub Bot commented on DRILL-5698: --- Github user darrenbrien commented on the issue: https://github.com/apache/drill/pull/890 see https://github.com/apache/drill/pull/899 > Drill should start in embedded mode using java 1.8.0_144 > > > Key: DRILL-5698 > URL: https://issues.apache.org/jira/browse/DRILL-5698 > Project: Apache Drill > Issue Type: Bug >Reporter: Darren > Labels: ready-to-commit > Fix For: 1.12.0 > > > Currently the start up script > distribution/src/resources/drill-config.sh > prevents drill from starting as the regex incorrectly captures the 144 > portion of the version code > this is because the regex isn't escaped > -"$JAVA" -version 2>&1 | grep "version" | egrep -e "1.4|1.5|1.6" > /dev/null > +"$JAVA" -version 2>&1 | grep "version" | egrep -e "1\.4|1\.5|1\.6" > > /dev/null -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (DRILL-5698) Drill should start in embedded mode using java 1.8.0_144
[ https://issues.apache.org/jira/browse/DRILL-5698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16119678#comment-16119678 ] ASF GitHub Bot commented on DRILL-5698: --- GitHub user darrenbrien opened a pull request: https://github.com/apache/drill/pull/899 DRILL-5698: Escape version number period separator, this captures ver… …sion numbers with 4 5 or 6 in them, like 1.8.0_144 You can merge this pull request into a Git repository by running: $ git pull https://github.com/darrenbrien/drill Drill-5698 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/drill/pull/899.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #899 > Drill should start in embedded mode using java 1.8.0_144 > > > Key: DRILL-5698 > URL: https://issues.apache.org/jira/browse/DRILL-5698 > Project: Apache Drill > Issue Type: Bug >Reporter: Darren > Labels: ready-to-commit > Fix For: 1.12.0 > > > Currently the start up script > distribution/src/resources/drill-config.sh > prevents drill from starting as the regex incorrectly captures the 144 > portion of the version code > this is because the regex isn't escaped > -"$JAVA" -version 2>&1 | grep "version" | egrep -e "1.4|1.5|1.6" > /dev/null > +"$JAVA" -version 2>&1 | grep "version" | egrep -e "1\.4|1\.5|1\.6" > > /dev/null -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (DRILL-5698) Drill should start in embedded mode using java 1.8.0_144
[ https://issues.apache.org/jira/browse/DRILL-5698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16119624#comment-16119624 ] ASF GitHub Bot commented on DRILL-5698: --- Github user arina-ielchiieva commented on the issue: https://github.com/apache/drill/pull/890 @darrenbrien Can you please also rename the commit message as well, as Paul have mentioned there is a convention here to have Jira number at the beginning: `DRILL-5698: Escape version number period separator, this captures version numbers` > Drill should start in embedded mode using java 1.8.0_144 > > > Key: DRILL-5698 > URL: https://issues.apache.org/jira/browse/DRILL-5698 > Project: Apache Drill > Issue Type: Bug >Reporter: Darren > Labels: ready-to-commit > Fix For: 1.12.0 > > > Currently the start up script > distribution/src/resources/drill-config.sh > prevents drill from starting as the regex incorrectly captures the 144 > portion of the version code > this is because the regex isn't escaped > -"$JAVA" -version 2>&1 | grep "version" | egrep -e "1.4|1.5|1.6" > /dev/null > +"$JAVA" -version 2>&1 | grep "version" | egrep -e "1\.4|1\.5|1\.6" > > /dev/null -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (DRILL-5698) Drill should start in embedded mode using java 1.8.0_144
[ https://issues.apache.org/jira/browse/DRILL-5698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16117207#comment-16117207 ] ASF GitHub Bot commented on DRILL-5698: --- Github user paul-rogers commented on the issue: https://github.com/apache/drill/pull/890 Please put the JIRA ticket number in the title so that the system will automagically send comments & close notices to the JIRA ticket. Example: DRILL-5698: Escape version number period separator, this captures version numbers > Drill should start in embedded mode using java 1.8.0_144 > > > Key: DRILL-5698 > URL: https://issues.apache.org/jira/browse/DRILL-5698 > Project: Apache Drill > Issue Type: Bug >Reporter: Darren > Labels: ready-to-commit > Fix For: 1.12.0 > > > Currently the start up script > distribution/src/resources/drill-config.sh > prevents drill from starting as the regex incorrectly captures the 144 > portion of the version code > this is because the regex isn't escaped > -"$JAVA" -version 2>&1 | grep "version" | egrep -e "1.4|1.5|1.6" > /dev/null > +"$JAVA" -version 2>&1 | grep "version" | egrep -e "1\.4|1\.5|1\.6" > > /dev/null -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (DRILL-5698) Drill should start in embedded mode using java 1.8.0_144
[ https://issues.apache.org/jira/browse/DRILL-5698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16112159#comment-16112159 ] Jose Flores commented on DRILL-5698: I have the same issue and got here when I was about to create an issue. It's can also be reproduced this way: - Current behaviour bash-3.2# echo "version 1.8.0_66" | grep "version" | egrep -e "1.4|1.5|1.6" (no output) bash-3.2# echo "version 1.8.0_144" | grep "version" | egrep -e "1.4|1.5|1.6" version 1.8.0_144 - With the proposal fix bash-3.2# echo "version 1.8.0_144" | grep "version" | egrep -e "1\.4|1\.5|1\.6" (no output) bash-3.2# echo "version 1.6" | grep "version" | egrep -e "1\.4|1\.5|1\.6" version 1.6 Workaround (for now): install java version not containing 14, 15 16 in the version (revision) > Drill should start in embedded mode using java 1.8.0_144 > > > Key: DRILL-5698 > URL: https://issues.apache.org/jira/browse/DRILL-5698 > Project: Apache Drill > Issue Type: Bug >Reporter: Darren > Labels: ready-to-commit > Fix For: 1.12.0 > > > Currently the start up script > distribution/src/resources/drill-config.sh > prevents drill from starting as the regex incorrectly captures the 144 > portion of the version code > this is because the regex isn't escaped > -"$JAVA" -version 2>&1 | grep "version" | egrep -e "1.4|1.5|1.6" > /dev/null > +"$JAVA" -version 2>&1 | grep "version" | egrep -e "1\.4|1\.5|1\.6" > > /dev/null -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (DRILL-5698) Drill should start in embedded mode using java 1.8.0_144
[ https://issues.apache.org/jira/browse/DRILL-5698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16109449#comment-16109449 ] ASF GitHub Bot commented on DRILL-5698: --- Github user darrenbrien commented on the issue: https://github.com/apache/drill/pull/890 Jira https://issues.apache.org/jira/browse/DRILL-5698 created > Drill should start in embedded mode using java 1.8.0_144 > > > Key: DRILL-5698 > URL: https://issues.apache.org/jira/browse/DRILL-5698 > Project: Apache Drill > Issue Type: Bug >Reporter: Darren > > Currently the start up script > distribution/src/resources/drill-config.sh > prevents drill from starting as the regex incorrectly captures the 144 > portion of the version code > this is because the regex isn't escaped > -"$JAVA" -version 2>&1 | grep "version" | egrep -e "1.4|1.5|1.6" > /dev/null > +"$JAVA" -version 2>&1 | grep "version" | egrep -e "1\.4|1\.5|1\.6" > > /dev/null -- This message was sent by Atlassian JIRA (v6.4.14#64029)
