[jira] [Commented] (DRILL-6793) FragmentExecutor cannot send its final state for the case when RootExec root wasn't initialized

2018-10-19 Thread ASF GitHub Bot (JIRA) 


[ 
https://issues.apache.org/jira/browse/DRILL-6793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16656766#comment-16656766
 ] 

ASF GitHub Bot commented on DRILL-6793:
---

asfgit closed pull request #1506: DRILL-6793: FragmentExecutor cannot send its 
final state for the case…
URL: https://github.com/apache/drill/pull/1506
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git 
a/contrib/format-maprdb/src/main/java/org/apache/drill/exec/store/mapr/db/json/MaprDBJsonRecordReader.java
 
b/contrib/format-maprdb/src/main/java/org/apache/drill/exec/store/mapr/db/json/MaprDBJsonRecordReader.java
index b68f574036a..628a98621a0 100644
--- 
a/contrib/format-maprdb/src/main/java/org/apache/drill/exec/store/mapr/db/json/MaprDBJsonRecordReader.java
+++ 
b/contrib/format-maprdb/src/main/java/org/apache/drill/exec/store/mapr/db/json/MaprDBJsonRecordReader.java
@@ -531,7 +531,7 @@ public void close() {
   @Override
   public String toString() {
 StringBuilder sb = new StringBuilder("MaprDBJsonRecordReader[Table=")
-.append(table.getPath());
+.append(table != null ? table.getPath() : null);
 if (reader != null) {
   sb.append(", Document ID=")
   .append(IdCodec.asString(reader.getId()));
diff --git 
a/contrib/storage-hive/core/src/main/java/org/apache/drill/exec/store/hive/readers/HiveAbstractReader.java
 
b/contrib/storage-hive/core/src/main/java/org/apache/drill/exec/store/hive/readers/HiveAbstractReader.java
index 5ed6c3bb7ee..cc774d97502 100644
--- 
a/contrib/storage-hive/core/src/main/java/org/apache/drill/exec/store/hive/readers/HiveAbstractReader.java
+++ 
b/contrib/storage-hive/core/src/main/java/org/apache/drill/exec/store/hive/readers/HiveAbstractReader.java
@@ -429,7 +429,7 @@ public String toString() {
 position = reader.getPos();
   }
 } catch (IOException e) {
-  logger.trace("Unable to obtain reader position: " + e.getMessage());
+  logger.trace("Unable to obtain reader position.", e);
 }
 return getClass().getSimpleName() + "[Database=" + table.getDbName()
 + ", Table=" + table.getTableName()
diff --git 
a/exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/BaseRootExec.java
 
b/exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/BaseRootExec.java
index 9142a2aded8..95a1235017a 100644
--- 
a/exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/BaseRootExec.java
+++ 
b/exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/BaseRootExec.java
@@ -126,6 +126,10 @@ public void receivingFragmentFinished(final FragmentHandle 
handle) {
 
   @Override
   public void dumpBatches() {
+if (operators == null) {
+  return;
+}
+
 final int numberOfBatchesToDump = 2;
 logger.error("Batch dump started: dumping last {} failed batches", 
numberOfBatchesToDump);
 // As batches are stored in a 'flat' List there is a need to filter out 
the failed batch
diff --git 
a/exec/java-exec/src/main/java/org/apache/drill/exec/store/avro/AvroRecordReader.java
 
b/exec/java-exec/src/main/java/org/apache/drill/exec/store/avro/AvroRecordReader.java
index 7668130068e..1d7226ad155 100644
--- 
a/exec/java-exec/src/main/java/org/apache/drill/exec/store/avro/AvroRecordReader.java
+++ 
b/exec/java-exec/src/main/java/org/apache/drill/exec/store/avro/AvroRecordReader.java
@@ -403,9 +403,11 @@ public void close() {
   public String toString() {
 long currentPosition = -1L;
 try {
-  currentPosition = reader.tell();
+  if (reader != null) {
+currentPosition = reader.tell();
+  }
 } catch (IOException e) {
-  logger.trace("Unable to obtain reader position: " + e.getMessage());
+  logger.trace("Unable to obtain reader position.", e);
 }
 return "AvroRecordReader[File=" + hadoop
 + ", Position=" + currentPosition
diff --git 
a/exec/java-exec/src/main/java/org/apache/drill/exec/store/easy/sequencefile/SequenceFileRecordReader.java
 
b/exec/java-exec/src/main/java/org/apache/drill/exec/store/easy/sequencefile/SequenceFileRecordReader.java
index 549df82773a..7f9b993fe92 100644
--- 
a/exec/java-exec/src/main/java/org/apache/drill/exec/store/easy/sequencefile/SequenceFileRecordReader.java
+++ 
b/exec/java-exec/src/main/java/org/apache/drill/exec/store/easy/sequencefile/SequenceFileRecordReader.java
@@ -172,7 +172,7 @@ public String toString() {
 position = reader.getPos();
   }
 } catch (IOException e) {
-  logger.trace("Unable to obtain reader position: " + e.getMessage());
+  logger.trace("Unable to obtain reader position.", e);
 }
 return "SequenceFileRecordReader[File=" + split.getPath()
 + ", Position=" + position

[jira] [Commented] (DRILL-6793) FragmentExecutor cannot send its final state for the case when RootExec root wasn't initialized

2018-10-17 Thread ASF GitHub Bot (JIRA) 


[ 
https://issues.apache.org/jira/browse/DRILL-6793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16653307#comment-16653307
 ] 

ASF GitHub Bot commented on DRILL-6793:
---

KazydubB commented on a change in pull request #1506: DRILL-6793: 
FragmentExecutor cannot send its final state for the case…
URL: https://github.com/apache/drill/pull/1506#discussion_r225861055
 
 

 ##
 File path: 
contrib/format-maprdb/src/main/java/org/apache/drill/exec/store/mapr/db/json/MaprDBJsonRecordReader.java
 ##
 @@ -530,8 +530,10 @@ public void close() {
 
   @Override
   public String toString() {
-StringBuilder sb = new StringBuilder("MaprDBJsonRecordReader[Table=")
-.append(table.getPath());
+StringBuilder sb = new StringBuilder("MaprDBJsonRecordReader[Table=");
+if (table != null) {
 
 Review comment:
   Thanks for pointing it out, done.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> FragmentExecutor cannot send its final state for the case when RootExec root 
> wasn't initialized
> ---
>
> Key: DRILL-6793
> URL: https://issues.apache.org/jira/browse/DRILL-6793
> Project: Apache Drill
>  Issue Type: Bug
>Affects Versions: 1.15.0
>Reporter: Volodymyr Vysotskyi
>Assignee: Bohdan Kazydub
>Priority: Major
> Fix For: 1.15.0
>
>
> *Problem description*
> For the case when the exception was thrown during [initializing {{RootExec 
> root}}|https://github.com/apache/drill/blob/master/exec/java-exec/src/main/java/org/apache/drill/exec/work/fragment/FragmentExecutor.java#L264],
>  after that {{root.dumpBatches()}} is called in 
> {{FragmentExecutor.cleanup()}} method, so NPE will be thrown before releasing 
> the resources and sending the final state.
> {noformat}
> 20:11:22.910 [243f2a45-cd8a-b3f8-3d5d-36fdbe8fb446:frag:0:0] ERROR 
> o.a.d.exec.server.BootStrapContext - 
> org.apache.drill.exec.work.WorkManager$WorkerBee$2.run() leaked an exception.
> Exception in thread "243f2a45-cd8a-b3f8-3d5d-36fdbe8fb446:frag:0:0" 
> java.lang.NullPointerException
>   at 
> org.apache.drill.exec.work.fragment.FragmentExecutor.cleanup(FragmentExecutor.java:211)
>   at 
> org.apache.drill.exec.work.fragment.FragmentExecutor.run(FragmentExecutor.java:330)
>   at 
> org.apache.drill.common.SelfCleaningRunnable.run(SelfCleaningRunnable.java:38)
>   at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
>   at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
>   at java.lang.Thread.run(Thread.java:748)
> java.lang.NullPointerException: null
>   at 
> org.apache.drill.exec.work.fragment.FragmentExecutor.cleanup(FragmentExecutor.java:211)
>  ~[classes/:na]
>   at 
> org.apache.drill.exec.work.fragment.FragmentExecutor.run(FragmentExecutor.java:330)
>  ~[classes/:na]
>   at 
> org.apache.drill.common.SelfCleaningRunnable.run(SelfCleaningRunnable.java:38)
>  ~[classes/:na]
>   at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
>  ~[na:1.8.0_181]
>   at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
>  [na:1.8.0_181]
>   at java.lang.Thread.run(Thread.java:748) [na:1.8.0_181]
> {noformat}
> *Simple reproduce*
> Throw the exception in the constructor of {{ParquetRecordReader}} and run any 
> parquet test, for example 
> {{TestParquetMetadataCache.testPartitionPruningWithMetadataCache_1()}}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (DRILL-6793) FragmentExecutor cannot send its final state for the case when RootExec root wasn't initialized

2018-10-17 Thread ASF GitHub Bot (JIRA) 


[ 
https://issues.apache.org/jira/browse/DRILL-6793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16653309#comment-16653309
 ] 

ASF GitHub Bot commented on DRILL-6793:
---

KazydubB commented on a change in pull request #1506: DRILL-6793: 
FragmentExecutor cannot send its final state for the case…
URL: https://github.com/apache/drill/pull/1506#discussion_r225861548
 
 

 ##
 File path: 
exec/java-exec/src/main/java/org/apache/drill/exec/store/avro/AvroRecordReader.java
 ##
 @@ -403,7 +403,9 @@ public void close() {
   public String toString() {
 long currentPosition = -1L;
 try {
-  currentPosition = reader.tell();
+  if (reader != null) {
+currentPosition = reader.tell();
+  }
 } catch (IOException e) {
   logger.trace("Unable to obtain reader position: " + e.getMessage());
 
 Review comment:
   Done.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> FragmentExecutor cannot send its final state for the case when RootExec root 
> wasn't initialized
> ---
>
> Key: DRILL-6793
> URL: https://issues.apache.org/jira/browse/DRILL-6793
> Project: Apache Drill
>  Issue Type: Bug
>Affects Versions: 1.15.0
>Reporter: Volodymyr Vysotskyi
>Assignee: Bohdan Kazydub
>Priority: Major
> Fix For: 1.15.0
>
>
> *Problem description*
> For the case when the exception was thrown during [initializing {{RootExec 
> root}}|https://github.com/apache/drill/blob/master/exec/java-exec/src/main/java/org/apache/drill/exec/work/fragment/FragmentExecutor.java#L264],
>  after that {{root.dumpBatches()}} is called in 
> {{FragmentExecutor.cleanup()}} method, so NPE will be thrown before releasing 
> the resources and sending the final state.
> {noformat}
> 20:11:22.910 [243f2a45-cd8a-b3f8-3d5d-36fdbe8fb446:frag:0:0] ERROR 
> o.a.d.exec.server.BootStrapContext - 
> org.apache.drill.exec.work.WorkManager$WorkerBee$2.run() leaked an exception.
> Exception in thread "243f2a45-cd8a-b3f8-3d5d-36fdbe8fb446:frag:0:0" 
> java.lang.NullPointerException
>   at 
> org.apache.drill.exec.work.fragment.FragmentExecutor.cleanup(FragmentExecutor.java:211)
>   at 
> org.apache.drill.exec.work.fragment.FragmentExecutor.run(FragmentExecutor.java:330)
>   at 
> org.apache.drill.common.SelfCleaningRunnable.run(SelfCleaningRunnable.java:38)
>   at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
>   at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
>   at java.lang.Thread.run(Thread.java:748)
> java.lang.NullPointerException: null
>   at 
> org.apache.drill.exec.work.fragment.FragmentExecutor.cleanup(FragmentExecutor.java:211)
>  ~[classes/:na]
>   at 
> org.apache.drill.exec.work.fragment.FragmentExecutor.run(FragmentExecutor.java:330)
>  ~[classes/:na]
>   at 
> org.apache.drill.common.SelfCleaningRunnable.run(SelfCleaningRunnable.java:38)
>  ~[classes/:na]
>   at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
>  ~[na:1.8.0_181]
>   at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
>  [na:1.8.0_181]
>   at java.lang.Thread.run(Thread.java:748) [na:1.8.0_181]
> {noformat}
> *Simple reproduce*
> Throw the exception in the constructor of {{ParquetRecordReader}} and run any 
> parquet test, for example 
> {{TestParquetMetadataCache.testPartitionPruningWithMetadataCache_1()}}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (DRILL-6793) FragmentExecutor cannot send its final state for the case when RootExec root wasn't initialized

2018-10-17 Thread ASF GitHub Bot (JIRA) 


[ 
https://issues.apache.org/jira/browse/DRILL-6793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16653308#comment-16653308
 ] 

ASF GitHub Bot commented on DRILL-6793:
---

KazydubB commented on a change in pull request #1506: DRILL-6793: 
FragmentExecutor cannot send its final state for the case…
URL: https://github.com/apache/drill/pull/1506#discussion_r225861490
 
 

 ##
 File path: 
contrib/format-maprdb/src/main/java/org/apache/drill/exec/store/mapr/db/json/MaprDBJsonRecordReader.java
 ##
 @@ -530,8 +530,10 @@ public void close() {
 
   @Override
   public String toString() {
-StringBuilder sb = new StringBuilder("MaprDBJsonRecordReader[Table=")
-.append(table.getPath());
+StringBuilder sb = new StringBuilder("MaprDBJsonRecordReader[Table=");
+if (table != null) {
+  sb.append(table.getPath());
+}
 if (reader != null) {
   sb.append(", Document ID=")
 
 Review comment:
   Made previous field to be present in any case. It seems there is no need in 
doing so.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> FragmentExecutor cannot send its final state for the case when RootExec root 
> wasn't initialized
> ---
>
> Key: DRILL-6793
> URL: https://issues.apache.org/jira/browse/DRILL-6793
> Project: Apache Drill
>  Issue Type: Bug
>Affects Versions: 1.15.0
>Reporter: Volodymyr Vysotskyi
>Assignee: Bohdan Kazydub
>Priority: Major
> Fix For: 1.15.0
>
>
> *Problem description*
> For the case when the exception was thrown during [initializing {{RootExec 
> root}}|https://github.com/apache/drill/blob/master/exec/java-exec/src/main/java/org/apache/drill/exec/work/fragment/FragmentExecutor.java#L264],
>  after that {{root.dumpBatches()}} is called in 
> {{FragmentExecutor.cleanup()}} method, so NPE will be thrown before releasing 
> the resources and sending the final state.
> {noformat}
> 20:11:22.910 [243f2a45-cd8a-b3f8-3d5d-36fdbe8fb446:frag:0:0] ERROR 
> o.a.d.exec.server.BootStrapContext - 
> org.apache.drill.exec.work.WorkManager$WorkerBee$2.run() leaked an exception.
> Exception in thread "243f2a45-cd8a-b3f8-3d5d-36fdbe8fb446:frag:0:0" 
> java.lang.NullPointerException
>   at 
> org.apache.drill.exec.work.fragment.FragmentExecutor.cleanup(FragmentExecutor.java:211)
>   at 
> org.apache.drill.exec.work.fragment.FragmentExecutor.run(FragmentExecutor.java:330)
>   at 
> org.apache.drill.common.SelfCleaningRunnable.run(SelfCleaningRunnable.java:38)
>   at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
>   at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
>   at java.lang.Thread.run(Thread.java:748)
> java.lang.NullPointerException: null
>   at 
> org.apache.drill.exec.work.fragment.FragmentExecutor.cleanup(FragmentExecutor.java:211)
>  ~[classes/:na]
>   at 
> org.apache.drill.exec.work.fragment.FragmentExecutor.run(FragmentExecutor.java:330)
>  ~[classes/:na]
>   at 
> org.apache.drill.common.SelfCleaningRunnable.run(SelfCleaningRunnable.java:38)
>  ~[classes/:na]
>   at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
>  ~[na:1.8.0_181]
>   at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
>  [na:1.8.0_181]
>   at java.lang.Thread.run(Thread.java:748) [na:1.8.0_181]
> {noformat}
> *Simple reproduce*
> Throw the exception in the constructor of {{ParquetRecordReader}} and run any 
> parquet test, for example 
> {{TestParquetMetadataCache.testPartitionPruningWithMetadataCache_1()}}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (DRILL-6793) FragmentExecutor cannot send its final state for the case when RootExec root wasn't initialized

2018-10-17 Thread ASF GitHub Bot (JIRA) 


[ 
https://issues.apache.org/jira/browse/DRILL-6793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16653271#comment-16653271
 ] 

ASF GitHub Bot commented on DRILL-6793:
---

vvysotskyi commented on a change in pull request #1506: DRILL-6793: 
FragmentExecutor cannot send its final state for the case…
URL: https://github.com/apache/drill/pull/1506#discussion_r225851956
 
 

 ##
 File path: 
contrib/format-maprdb/src/main/java/org/apache/drill/exec/store/mapr/db/json/MaprDBJsonRecordReader.java
 ##
 @@ -530,8 +530,10 @@ public void close() {
 
   @Override
   public String toString() {
-StringBuilder sb = new StringBuilder("MaprDBJsonRecordReader[Table=")
-.append(table.getPath());
+StringBuilder sb = new StringBuilder("MaprDBJsonRecordReader[Table=");
+if (table != null) {
 
 Review comment:
   For the case when `table` is null, the string will be formed incorrectly - 
`Table=` should be appended only if `table != null`


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> FragmentExecutor cannot send its final state for the case when RootExec root 
> wasn't initialized
> ---
>
> Key: DRILL-6793
> URL: https://issues.apache.org/jira/browse/DRILL-6793
> Project: Apache Drill
>  Issue Type: Bug
>Affects Versions: 1.15.0
>Reporter: Volodymyr Vysotskyi
>Assignee: Bohdan Kazydub
>Priority: Major
> Fix For: 1.15.0
>
>
> *Problem description*
> For the case when the exception was thrown during [initializing {{RootExec 
> root}}|https://github.com/apache/drill/blob/master/exec/java-exec/src/main/java/org/apache/drill/exec/work/fragment/FragmentExecutor.java#L264],
>  after that {{root.dumpBatches()}} is called in 
> {{FragmentExecutor.cleanup()}} method, so NPE will be thrown before releasing 
> the resources and sending the final state.
> {noformat}
> 20:11:22.910 [243f2a45-cd8a-b3f8-3d5d-36fdbe8fb446:frag:0:0] ERROR 
> o.a.d.exec.server.BootStrapContext - 
> org.apache.drill.exec.work.WorkManager$WorkerBee$2.run() leaked an exception.
> Exception in thread "243f2a45-cd8a-b3f8-3d5d-36fdbe8fb446:frag:0:0" 
> java.lang.NullPointerException
>   at 
> org.apache.drill.exec.work.fragment.FragmentExecutor.cleanup(FragmentExecutor.java:211)
>   at 
> org.apache.drill.exec.work.fragment.FragmentExecutor.run(FragmentExecutor.java:330)
>   at 
> org.apache.drill.common.SelfCleaningRunnable.run(SelfCleaningRunnable.java:38)
>   at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
>   at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
>   at java.lang.Thread.run(Thread.java:748)
> java.lang.NullPointerException: null
>   at 
> org.apache.drill.exec.work.fragment.FragmentExecutor.cleanup(FragmentExecutor.java:211)
>  ~[classes/:na]
>   at 
> org.apache.drill.exec.work.fragment.FragmentExecutor.run(FragmentExecutor.java:330)
>  ~[classes/:na]
>   at 
> org.apache.drill.common.SelfCleaningRunnable.run(SelfCleaningRunnable.java:38)
>  ~[classes/:na]
>   at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
>  ~[na:1.8.0_181]
>   at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
>  [na:1.8.0_181]
>   at java.lang.Thread.run(Thread.java:748) [na:1.8.0_181]
> {noformat}
> *Simple reproduce*
> Throw the exception in the constructor of {{ParquetRecordReader}} and run any 
> parquet test, for example 
> {{TestParquetMetadataCache.testPartitionPruningWithMetadataCache_1()}}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (DRILL-6793) FragmentExecutor cannot send its final state for the case when RootExec root wasn't initialized

2018-10-17 Thread ASF GitHub Bot (JIRA) 


[ 
https://issues.apache.org/jira/browse/DRILL-6793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16653273#comment-16653273
 ] 

ASF GitHub Bot commented on DRILL-6793:
---

vvysotskyi commented on a change in pull request #1506: DRILL-6793: 
FragmentExecutor cannot send its final state for the case…
URL: https://github.com/apache/drill/pull/1506#discussion_r225853187
 
 

 ##
 File path: 
exec/java-exec/src/main/java/org/apache/drill/exec/store/avro/AvroRecordReader.java
 ##
 @@ -403,7 +403,9 @@ public void close() {
   public String toString() {
 long currentPosition = -1L;
 try {
-  currentPosition = reader.tell();
+  if (reader != null) {
+currentPosition = reader.tell();
+  }
 } catch (IOException e) {
   logger.trace("Unable to obtain reader position: " + e.getMessage());
 
 Review comment:
   Please log the stack trace of the exception.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> FragmentExecutor cannot send its final state for the case when RootExec root 
> wasn't initialized
> ---
>
> Key: DRILL-6793
> URL: https://issues.apache.org/jira/browse/DRILL-6793
> Project: Apache Drill
>  Issue Type: Bug
>Affects Versions: 1.15.0
>Reporter: Volodymyr Vysotskyi
>Assignee: Bohdan Kazydub
>Priority: Major
> Fix For: 1.15.0
>
>
> *Problem description*
> For the case when the exception was thrown during [initializing {{RootExec 
> root}}|https://github.com/apache/drill/blob/master/exec/java-exec/src/main/java/org/apache/drill/exec/work/fragment/FragmentExecutor.java#L264],
>  after that {{root.dumpBatches()}} is called in 
> {{FragmentExecutor.cleanup()}} method, so NPE will be thrown before releasing 
> the resources and sending the final state.
> {noformat}
> 20:11:22.910 [243f2a45-cd8a-b3f8-3d5d-36fdbe8fb446:frag:0:0] ERROR 
> o.a.d.exec.server.BootStrapContext - 
> org.apache.drill.exec.work.WorkManager$WorkerBee$2.run() leaked an exception.
> Exception in thread "243f2a45-cd8a-b3f8-3d5d-36fdbe8fb446:frag:0:0" 
> java.lang.NullPointerException
>   at 
> org.apache.drill.exec.work.fragment.FragmentExecutor.cleanup(FragmentExecutor.java:211)
>   at 
> org.apache.drill.exec.work.fragment.FragmentExecutor.run(FragmentExecutor.java:330)
>   at 
> org.apache.drill.common.SelfCleaningRunnable.run(SelfCleaningRunnable.java:38)
>   at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
>   at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
>   at java.lang.Thread.run(Thread.java:748)
> java.lang.NullPointerException: null
>   at 
> org.apache.drill.exec.work.fragment.FragmentExecutor.cleanup(FragmentExecutor.java:211)
>  ~[classes/:na]
>   at 
> org.apache.drill.exec.work.fragment.FragmentExecutor.run(FragmentExecutor.java:330)
>  ~[classes/:na]
>   at 
> org.apache.drill.common.SelfCleaningRunnable.run(SelfCleaningRunnable.java:38)
>  ~[classes/:na]
>   at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
>  ~[na:1.8.0_181]
>   at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
>  [na:1.8.0_181]
>   at java.lang.Thread.run(Thread.java:748) [na:1.8.0_181]
> {noformat}
> *Simple reproduce*
> Throw the exception in the constructor of {{ParquetRecordReader}} and run any 
> parquet test, for example 
> {{TestParquetMetadataCache.testPartitionPruningWithMetadataCache_1()}}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (DRILL-6793) FragmentExecutor cannot send its final state for the case when RootExec root wasn't initialized

2018-10-17 Thread ASF GitHub Bot (JIRA) 


[ 
https://issues.apache.org/jira/browse/DRILL-6793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16653272#comment-16653272
 ] 

ASF GitHub Bot commented on DRILL-6793:
---

vvysotskyi commented on a change in pull request #1506: DRILL-6793: 
FragmentExecutor cannot send its final state for the case…
URL: https://github.com/apache/drill/pull/1506#discussion_r225852711
 
 

 ##
 File path: 
contrib/format-maprdb/src/main/java/org/apache/drill/exec/store/mapr/db/json/MaprDBJsonRecordReader.java
 ##
 @@ -530,8 +530,10 @@ public void close() {
 
   @Override
   public String toString() {
-StringBuilder sb = new StringBuilder("MaprDBJsonRecordReader[Table=")
-.append(table.getPath());
+StringBuilder sb = new StringBuilder("MaprDBJsonRecordReader[Table=");
+if (table != null) {
+  sb.append(table.getPath());
+}
 if (reader != null) {
   sb.append(", Document ID=")
 
 Review comment:
   Also, please move `, `string here and below to the previous appenders.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> FragmentExecutor cannot send its final state for the case when RootExec root 
> wasn't initialized
> ---
>
> Key: DRILL-6793
> URL: https://issues.apache.org/jira/browse/DRILL-6793
> Project: Apache Drill
>  Issue Type: Bug
>Affects Versions: 1.15.0
>Reporter: Volodymyr Vysotskyi
>Assignee: Bohdan Kazydub
>Priority: Major
> Fix For: 1.15.0
>
>
> *Problem description*
> For the case when the exception was thrown during [initializing {{RootExec 
> root}}|https://github.com/apache/drill/blob/master/exec/java-exec/src/main/java/org/apache/drill/exec/work/fragment/FragmentExecutor.java#L264],
>  after that {{root.dumpBatches()}} is called in 
> {{FragmentExecutor.cleanup()}} method, so NPE will be thrown before releasing 
> the resources and sending the final state.
> {noformat}
> 20:11:22.910 [243f2a45-cd8a-b3f8-3d5d-36fdbe8fb446:frag:0:0] ERROR 
> o.a.d.exec.server.BootStrapContext - 
> org.apache.drill.exec.work.WorkManager$WorkerBee$2.run() leaked an exception.
> Exception in thread "243f2a45-cd8a-b3f8-3d5d-36fdbe8fb446:frag:0:0" 
> java.lang.NullPointerException
>   at 
> org.apache.drill.exec.work.fragment.FragmentExecutor.cleanup(FragmentExecutor.java:211)
>   at 
> org.apache.drill.exec.work.fragment.FragmentExecutor.run(FragmentExecutor.java:330)
>   at 
> org.apache.drill.common.SelfCleaningRunnable.run(SelfCleaningRunnable.java:38)
>   at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
>   at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
>   at java.lang.Thread.run(Thread.java:748)
> java.lang.NullPointerException: null
>   at 
> org.apache.drill.exec.work.fragment.FragmentExecutor.cleanup(FragmentExecutor.java:211)
>  ~[classes/:na]
>   at 
> org.apache.drill.exec.work.fragment.FragmentExecutor.run(FragmentExecutor.java:330)
>  ~[classes/:na]
>   at 
> org.apache.drill.common.SelfCleaningRunnable.run(SelfCleaningRunnable.java:38)
>  ~[classes/:na]
>   at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
>  ~[na:1.8.0_181]
>   at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
>  [na:1.8.0_181]
>   at java.lang.Thread.run(Thread.java:748) [na:1.8.0_181]
> {noformat}
> *Simple reproduce*
> Throw the exception in the constructor of {{ParquetRecordReader}} and run any 
> parquet test, for example 
> {{TestParquetMetadataCache.testPartitionPruningWithMetadataCache_1()}}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (DRILL-6793) FragmentExecutor cannot send its final state for the case when RootExec root wasn't initialized

2018-10-17 Thread ASF GitHub Bot (JIRA) 


[ 
https://issues.apache.org/jira/browse/DRILL-6793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16653207#comment-16653207
 ] 

ASF GitHub Bot commented on DRILL-6793:
---

KazydubB opened a new pull request #1506: DRILL-6793: FragmentExecutor cannot 
send its final state for the case…
URL: https://github.com/apache/drill/pull/1506
 
 
   … when RootExec root wasn't initialized


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> FragmentExecutor cannot send its final state for the case when RootExec root 
> wasn't initialized
> ---
>
> Key: DRILL-6793
> URL: https://issues.apache.org/jira/browse/DRILL-6793
> Project: Apache Drill
>  Issue Type: Bug
>Affects Versions: 1.15.0
>Reporter: Volodymyr Vysotskyi
>Assignee: Bohdan Kazydub
>Priority: Major
> Fix For: 1.15.0
>
>
> *Problem description*
> For the case when the exception was thrown during [initializing {{RootExec 
> root}}|https://github.com/apache/drill/blob/master/exec/java-exec/src/main/java/org/apache/drill/exec/work/fragment/FragmentExecutor.java#L264],
>  after that {{root.dumpBatches()}} is called in 
> {{FragmentExecutor.cleanup()}} method, so NPE will be thrown before releasing 
> the resources and sending the final state.
> {noformat}
> 20:11:22.910 [243f2a45-cd8a-b3f8-3d5d-36fdbe8fb446:frag:0:0] ERROR 
> o.a.d.exec.server.BootStrapContext - 
> org.apache.drill.exec.work.WorkManager$WorkerBee$2.run() leaked an exception.
> Exception in thread "243f2a45-cd8a-b3f8-3d5d-36fdbe8fb446:frag:0:0" 
> java.lang.NullPointerException
>   at 
> org.apache.drill.exec.work.fragment.FragmentExecutor.cleanup(FragmentExecutor.java:211)
>   at 
> org.apache.drill.exec.work.fragment.FragmentExecutor.run(FragmentExecutor.java:330)
>   at 
> org.apache.drill.common.SelfCleaningRunnable.run(SelfCleaningRunnable.java:38)
>   at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
>   at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
>   at java.lang.Thread.run(Thread.java:748)
> java.lang.NullPointerException: null
>   at 
> org.apache.drill.exec.work.fragment.FragmentExecutor.cleanup(FragmentExecutor.java:211)
>  ~[classes/:na]
>   at 
> org.apache.drill.exec.work.fragment.FragmentExecutor.run(FragmentExecutor.java:330)
>  ~[classes/:na]
>   at 
> org.apache.drill.common.SelfCleaningRunnable.run(SelfCleaningRunnable.java:38)
>  ~[classes/:na]
>   at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
>  ~[na:1.8.0_181]
>   at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
>  [na:1.8.0_181]
>   at java.lang.Thread.run(Thread.java:748) [na:1.8.0_181]
> {noformat}
> *Simple reproduce*
> Throw the exception in the constructor of {{ParquetRecordReader}} and run any 
> parquet test, for example 
> {{TestParquetMetadataCache.testPartitionPruningWithMetadataCache_1()}}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)