[jira] [Commented] (DRILL-6867) WebUI Query editor cursor position
[
https://issues.apache.org/jira/browse/DRILL-6867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16703754#comment-16703754
]
ASF GitHub Bot commented on DRILL-6867:
---
asfgit closed pull request #1551: DRILL-6867: WebUI Query editor cursor position
URL: https://github.com/apache/drill/pull/1551
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/exec/java-exec/src/main/resources/rest/query/query.ftl
b/exec/java-exec/src/main/resources/rest/query/query.ftl
index 00fdd9e6fe4..fd3e8bd6dd3 100644
--- a/exec/java-exec/src/main/resources/rest/query/query.ftl
+++ b/exec/java-exec/src/main/resources/rest/query/query.ftl
@@ -103,7 +103,7 @@
editor.$blockScrolling = "Infinity";
//CSS Formatting
document.getElementById('query-editor-format').style.fontSize='13px';
-document.getElementById('query-editor-format').style.fontFamily='courier';
+
document.getElementById('query-editor-format').style.fontFamily='courier,monospace';
document.getElementById('query-editor-format').style.lineHeight='1.5';
document.getElementById('query-editor-format').style.width='98%';
document.getElementById('query-editor-format').style.margin='auto';
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> WebUI Query editor cursor position
> --
>
> Key: DRILL-6867
> URL: https://issues.apache.org/jira/browse/DRILL-6867
> Project: Apache Drill
> Issue Type: Bug
>Affects Versions: 1.14.0
>Reporter: Oleg Zinoviev
>Assignee: Oleg Zinoviev
>Priority: Minor
> Labels: ready-to-commit
> Fix For: 1.15.0
>
> Attachments: query.png
>
>
> In Firefox (at least on Ununtu 18.10), the position of the cursor does not
> match the text when editing the SQL-query
> !query.png!
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (DRILL-6867) WebUI Query editor cursor position
[ https://issues.apache.org/jira/browse/DRILL-6867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16702401#comment-16702401 ] ASF GitHub Bot commented on DRILL-6867: --- kkhatua removed a comment on issue #1551: DRILL-6867: WebUI Query editor cursor position URL: https://github.com/apache/drill/pull/1551#issuecomment-442611104 Thanks for making the change to `monospace'` A default monospace font on the Linux platform should address the issue of the missing `courier` font and we need not include any other special font. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > WebUI Query editor cursor position > -- > > Key: DRILL-6867 > URL: https://issues.apache.org/jira/browse/DRILL-6867 > Project: Apache Drill > Issue Type: Bug >Affects Versions: 1.14.0 >Reporter: Oleg Zinoviev >Assignee: Oleg Zinoviev >Priority: Minor > Labels: ready-to-commit > Fix For: 1.15.0 > > Attachments: query.png > > > In Firefox (at least on Ununtu 18.10), the position of the cursor does not > match the text when editing the SQL-query > !query.png! -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (DRILL-6867) WebUI Query editor cursor position
[ https://issues.apache.org/jira/browse/DRILL-6867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16702398#comment-16702398 ] ASF GitHub Bot commented on DRILL-6867: --- kkhatua commented on issue #1551: DRILL-6867: WebUI Query editor cursor position URL: https://github.com/apache/drill/pull/1551#issuecomment-442611104 Thanks for making the change to `monospace'` A default monospace font on the Linux platform should address the issue of the missing `courier` font and we need not include any other special font. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > WebUI Query editor cursor position > -- > > Key: DRILL-6867 > URL: https://issues.apache.org/jira/browse/DRILL-6867 > Project: Apache Drill > Issue Type: Bug >Affects Versions: 1.14.0 >Reporter: Oleg Zinoviev >Assignee: Oleg Zinoviev >Priority: Minor > Fix For: 1.15.0 > > Attachments: query.png > > > In Firefox (at least on Ununtu 18.10), the position of the cursor does not > match the text when editing the SQL-query > !query.png! -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (DRILL-6867) WebUI Query editor cursor position
[ https://issues.apache.org/jira/browse/DRILL-6867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16702108#comment-16702108 ] ASF GitHub Bot commented on DRILL-6867: --- oleg-zinovev edited a comment on issue #1551: DRILL-6867: WebUI Query editor cursor position URL: https://github.com/apache/drill/pull/1551#issuecomment-442509671 @vdiravka , @kkhatua 1) Ace editor requires monospace font. Here (http://web.mit.edu/jmorzins/www/fonts.html) I can find only two `common monospace fonts`: `courier` and `courier new`. Both of them missing in Ubuntu 18.10. 2) Firefox on Ubuntu with monospace font:  P.S. I remove Ubuntu Mono (too small) and Consolas (missing in Ubuntu as well). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > WebUI Query editor cursor position > -- > > Key: DRILL-6867 > URL: https://issues.apache.org/jira/browse/DRILL-6867 > Project: Apache Drill > Issue Type: Bug >Affects Versions: 1.14.0 >Reporter: Oleg Zinoviev >Assignee: Oleg Zinoviev >Priority: Minor > Fix For: 1.15.0 > > Attachments: query.png > > > In Firefox (at least on Ununtu 18.10), the position of the cursor does not > match the text when editing the SQL-query > !query.png! -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (DRILL-6867) WebUI Query editor cursor position
[ https://issues.apache.org/jira/browse/DRILL-6867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16702104#comment-16702104 ] ASF GitHub Bot commented on DRILL-6867: --- oleg-zinovev edited a comment on issue #1551: DRILL-6867: WebUI Query editor cursor position URL: https://github.com/apache/drill/pull/1551#issuecomment-442509671 @vdiravka , @kkhatua 1) Ace editor requires monospace font. Both 'courier' and 'courier new' missing in Ubuntu 18.10. 2) Firefox on Ubuntu with monospace font:  P.S. I remove Ubuntu Mono (too small) and Consolas (missing in Ubuntu as well). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > WebUI Query editor cursor position > -- > > Key: DRILL-6867 > URL: https://issues.apache.org/jira/browse/DRILL-6867 > Project: Apache Drill > Issue Type: Bug >Affects Versions: 1.14.0 >Reporter: Oleg Zinoviev >Assignee: Oleg Zinoviev >Priority: Minor > Fix For: 1.15.0 > > Attachments: query.png > > > In Firefox (at least on Ununtu 18.10), the position of the cursor does not > match the text when editing the SQL-query > !query.png! -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (DRILL-6867) WebUI Query editor cursor position
[ https://issues.apache.org/jira/browse/DRILL-6867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16702102#comment-16702102 ] ASF GitHub Bot commented on DRILL-6867: --- oleg-zinovev edited a comment on issue #1551: DRILL-6867: WebUI Query editor cursor position URL: https://github.com/apache/drill/pull/1551#issuecomment-442509671 @vdiravka , @kkhatua 1) Ace editor requires monospace font. Both 'courier' and 'courier new' missing in Ubuntu 18.10. 2) Firefox on Ubuntu with monospace font:  P.S. I remove Ubuntu Mono (was too small) and Consolas (missing in Ubuntu as well). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > WebUI Query editor cursor position > -- > > Key: DRILL-6867 > URL: https://issues.apache.org/jira/browse/DRILL-6867 > Project: Apache Drill > Issue Type: Bug >Affects Versions: 1.14.0 >Reporter: Oleg Zinoviev >Assignee: Oleg Zinoviev >Priority: Minor > Fix For: 1.15.0 > > Attachments: query.png > > > In Firefox (at least on Ununtu 18.10), the position of the cursor does not > match the text when editing the SQL-query > !query.png! -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (DRILL-6867) WebUI Query editor cursor position
[ https://issues.apache.org/jira/browse/DRILL-6867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16702100#comment-16702100 ] ASF GitHub Bot commented on DRILL-6867: --- oleg-zinovev commented on issue #1551: DRILL-6867: WebUI Query editor cursor position URL: https://github.com/apache/drill/pull/1551#issuecomment-442509671 @vdiravka , @kkhatua 1) Ace editor requires monospace font. Both 'courier' and 'courier new' missing in Ubuntu 18.10. 2) Firefox on Ubuntu with monospace font:  This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > WebUI Query editor cursor position > -- > > Key: DRILL-6867 > URL: https://issues.apache.org/jira/browse/DRILL-6867 > Project: Apache Drill > Issue Type: Bug >Affects Versions: 1.14.0 >Reporter: Oleg Zinoviev >Assignee: Oleg Zinoviev >Priority: Minor > Fix For: 1.15.0 > > Attachments: query.png > > > In Firefox (at least on Ununtu 18.10), the position of the cursor does not > match the text when editing the SQL-query > !query.png! -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (DRILL-6867) WebUI Query editor cursor position
[ https://issues.apache.org/jira/browse/DRILL-6867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16699518#comment-16699518 ] ASF GitHub Bot commented on DRILL-6867: --- oleg-zinovev edited a comment on issue #1551: DRILL-6867: WebUI Query editor cursor position URL: https://github.com/apache/drill/pull/1551#issuecomment-441782880 @vdiravka , Unfortunately, I can check this only on wednesday or Thursday. Is this ok? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > WebUI Query editor cursor position > -- > > Key: DRILL-6867 > URL: https://issues.apache.org/jira/browse/DRILL-6867 > Project: Apache Drill > Issue Type: Bug >Affects Versions: 1.14.0 >Reporter: Oleg Zinoviev >Assignee: Oleg Zinoviev >Priority: Minor > Fix For: 1.15.0 > > Attachments: query.png > > > In Firefox (at least on Ununtu 18.10), the position of the cursor does not > match the text when editing the SQL-query > !query.png! -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (DRILL-6867) WebUI Query editor cursor position
[ https://issues.apache.org/jira/browse/DRILL-6867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16699517#comment-16699517 ] ASF GitHub Bot commented on DRILL-6867: --- oleg-zinovev commented on issue #1551: DRILL-6867: WebUI Query editor cursor position URL: https://github.com/apache/drill/pull/1551#issuecomment-441782880 Unfortunately, I can check this only on wednesday or Thursday. Is this ok? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > WebUI Query editor cursor position > -- > > Key: DRILL-6867 > URL: https://issues.apache.org/jira/browse/DRILL-6867 > Project: Apache Drill > Issue Type: Bug >Affects Versions: 1.14.0 >Reporter: Oleg Zinoviev >Assignee: Oleg Zinoviev >Priority: Minor > Fix For: 1.15.0 > > Attachments: query.png > > > In Firefox (at least on Ununtu 18.10), the position of the cursor does not > match the text when editing the SQL-query > !query.png! -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (DRILL-6867) WebUI Query editor cursor position
[ https://issues.apache.org/jira/browse/DRILL-6867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16699332#comment-16699332 ] ASF GitHub Bot commented on DRILL-6867: --- vdiravka commented on issue #1551: DRILL-6867: WebUI Query editor cursor position URL: https://github.com/apache/drill/pull/1551#issuecomment-441724693 @oleg-zinovev Could you check the fonts list? If so it can be included to 1.15 release then. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > WebUI Query editor cursor position > -- > > Key: DRILL-6867 > URL: https://issues.apache.org/jira/browse/DRILL-6867 > Project: Apache Drill > Issue Type: Bug >Affects Versions: 1.14.0 >Reporter: Oleg Zinoviev >Assignee: Oleg Zinoviev >Priority: Minor > Fix For: 1.15.0 > > Attachments: query.png > > > In Firefox (at least on Ununtu 18.10), the position of the cursor does not > match the text when editing the SQL-query > !query.png! -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (DRILL-6867) WebUI Query editor cursor position
[ https://issues.apache.org/jira/browse/DRILL-6867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16697355#comment-16697355 ] ASF GitHub Bot commented on DRILL-6867: --- arina-ielchiieva commented on issue #1551: DRILL-6867: WebUI Query editor cursor position URL: https://github.com/apache/drill/pull/1551#issuecomment-441283700 @kkhatua could you please review? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > WebUI Query editor cursor position > -- > > Key: DRILL-6867 > URL: https://issues.apache.org/jira/browse/DRILL-6867 > Project: Apache Drill > Issue Type: Bug >Affects Versions: 1.14.0 >Reporter: Oleg Zinoviev >Assignee: Oleg Zinoviev >Priority: Minor > Fix For: 1.15.0 > > Attachments: query.png > > > In Firefox (at least on Ununtu 18.10), the position of the cursor does not > match the text when editing the SQL-query > !query.png! -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (DRILL-6867) WebUI Query editor cursor position
[ https://issues.apache.org/jira/browse/DRILL-6867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16696597#comment-16696597 ] ASF GitHub Bot commented on DRILL-6867: --- oleg-zinovev opened a new pull request #1551: DRILL-6867: WebUI Query editor cursor position URL: https://github.com/apache/drill/pull/1551 Few additional font families added for `query-editor-format` element This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > WebUI Query editor cursor position > -- > > Key: DRILL-6867 > URL: https://issues.apache.org/jira/browse/DRILL-6867 > Project: Apache Drill > Issue Type: Bug >Affects Versions: 1.14.0 >Reporter: Oleg Zinoviev >Priority: Minor > Attachments: query.png > > > In Firefox (at least on Ununtu 18.10), the position of the cursor does not > match the text when editing the SQL-query > !query.png! -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (DRILL-6867) WebUI Query editor cursor position
[ https://issues.apache.org/jira/browse/DRILL-6867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16696568#comment-16696568 ] Oleg Zinoviev commented on DRILL-6867: -- Reason: Courier font is missing in Ubuntu 18.10 Possible fix: Add few additional font families to query-editor-format > WebUI Query editor cursor position > -- > > Key: DRILL-6867 > URL: https://issues.apache.org/jira/browse/DRILL-6867 > Project: Apache Drill > Issue Type: Bug >Affects Versions: 1.14.0 >Reporter: Oleg Zinoviev >Priority: Major > Attachments: query.png > > > In Firefox (at least on Ununtu 18.10), the position of the cursor does not > match the text when editing the SQL-query > !query.png! -- This message was sent by Atlassian JIRA (v7.6.3#76005)
