[jira] [Comment Edited] (FINERACT-1221) Fineract Client Java SDK API has broken methods
[
https://issues.apache.org/jira/browse/FINERACT-1221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17901024#comment-17901024
]
Henrique Paes edited comment on FINERACT-1221 at 11/25/24 9:19 PM:
---
Hello! This issue was solved by this
[PR|[https://github.com/apache/fineract/pull/4078]]. It can be marked as solved
so it doesn't appear on Open Issues section
was (Author: JIRAUSER307093):
Hello! This issue was solved by this
[PR|[https://github.com/apache/fineract/pull/4078]]. It can be marked as solved
so it doesn't appear on Open Issues section
> Fineract Client Java SDK API has broken methods
> ---
>
> Key: FINERACT-1221
> URL: https://issues.apache.org/jira/browse/FINERACT-1221
> Project: Apache Fineract
> Issue Type: Bug
> Components: SDK
>Affects Versions: 1.8.0
>Reporter: Michael Vorburger
>Priority: Blocker
> Fix For: 1.11.0
>
>
> Our brand new "Fineract Client Java SDK API" emerging from
> https://github.com/apache/fineract/pull/1428/ for FINERACT-1216 contains at
> least some annotated Java methods which are invalid for Retrofit.
> When enabling {{apiClient.getAdapterBuilder().validateEagerly(true);}}, I'm
> seeing e.g.
> {noformat}java.lang.IllegalArgumentException: Non-body HTTP method cannot
> contain @Body.
> for method ClientApi.delete9
> at retrofit2.Utils.methodError(Utils.java:54)
> at retrofit2.Utils.methodError(Utils.java:43)
> at retrofit2.RequestFactory$Builder.build(RequestFactory.java:213)
> at retrofit2.RequestFactory.parseAnnotations(RequestFactory.java:67)
> at retrofit2.ServiceMethod.parseAnnotations(ServiceMethod.java:26)
> at retrofit2.Retrofit.loadServiceMethod(Retrofit.java:202)
> at retrofit2.Retrofit.validateServiceInterface(Retrofit.java:189)
> at retrofit2.Retrofit.create(Retrofit.java:141)
> at
> org.apache.fineract.client.ApiClient.createService(ApiClient.java:127)
> at
> org.apache.fineract.client.util.FineractClient.createService(FineractClient.java:42)
> at
> org.apache.fineract.client.test.FineractClientTest.testRetrieveAllClients(FineractClientTest.java:41){noformat}
> As a first step to eventually fixing this (and having non-regression for it),
> I'll write an automated test about it (but keep it ignored, for now).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Comment Edited] (FINERACT-1221) Fineract Client Java SDK API has broken methods
[
https://issues.apache.org/jira/browse/FINERACT-1221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17901024#comment-17901024
]
Henrique Paes edited comment on FINERACT-1221 at 11/25/24 9:19 PM:
---
Hello! This issue was solved by this
[PR|[https://github.com/apache/fineract/pull/4078]]. It can be marked as solved
so it doesn't appear on Open Issues section
was (Author: JIRAUSER307093):
Hello! This issue was solved by this
[PR|[https://github.com/apache/fineract/pull/4078]]. It can be marked as solved
so it doesn't appear on Open Issues section
> Fineract Client Java SDK API has broken methods
> ---
>
> Key: FINERACT-1221
> URL: https://issues.apache.org/jira/browse/FINERACT-1221
> Project: Apache Fineract
> Issue Type: Bug
> Components: SDK
>Affects Versions: 1.8.0
>Reporter: Michael Vorburger
>Priority: Blocker
> Fix For: 1.11.0
>
>
> Our brand new "Fineract Client Java SDK API" emerging from
> https://github.com/apache/fineract/pull/1428/ for FINERACT-1216 contains at
> least some annotated Java methods which are invalid for Retrofit.
> When enabling {{apiClient.getAdapterBuilder().validateEagerly(true);}}, I'm
> seeing e.g.
> {noformat}java.lang.IllegalArgumentException: Non-body HTTP method cannot
> contain @Body.
> for method ClientApi.delete9
> at retrofit2.Utils.methodError(Utils.java:54)
> at retrofit2.Utils.methodError(Utils.java:43)
> at retrofit2.RequestFactory$Builder.build(RequestFactory.java:213)
> at retrofit2.RequestFactory.parseAnnotations(RequestFactory.java:67)
> at retrofit2.ServiceMethod.parseAnnotations(ServiceMethod.java:26)
> at retrofit2.Retrofit.loadServiceMethod(Retrofit.java:202)
> at retrofit2.Retrofit.validateServiceInterface(Retrofit.java:189)
> at retrofit2.Retrofit.create(Retrofit.java:141)
> at
> org.apache.fineract.client.ApiClient.createService(ApiClient.java:127)
> at
> org.apache.fineract.client.util.FineractClient.createService(FineractClient.java:42)
> at
> org.apache.fineract.client.test.FineractClientTest.testRetrieveAllClients(FineractClientTest.java:41){noformat}
> As a first step to eventually fixing this (and having non-regression for it),
> I'll write an automated test about it (but keep it ignored, for now).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Comment Edited] (FINERACT-1221) Fineract Client Java SDK API has broken methods
[
https://issues.apache.org/jira/browse/FINERACT-1221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17901024#comment-17901024
]
Henrique Paes edited comment on FINERACT-1221 at 11/25/24 9:18 PM:
---
Hello! This issue was solved by this
[PR|[https://github.com/apache/fineract/pull/4078]]. It can be marked as solved
so it doesn't appear on Open Issues section
was (Author: JIRAUSER307093):
Hello! This issue was solved by this
[PR|[[https://github.com/apache/fineract/pull/4078|https://github.com/apache/fineract/pull/4078]].
It can be marked as solved so it doesn't appear on Open Issues section
> Fineract Client Java SDK API has broken methods
> ---
>
> Key: FINERACT-1221
> URL: https://issues.apache.org/jira/browse/FINERACT-1221
> Project: Apache Fineract
> Issue Type: Bug
> Components: SDK
>Affects Versions: 1.8.0
>Reporter: Michael Vorburger
>Priority: Blocker
> Fix For: 1.11.0
>
>
> Our brand new "Fineract Client Java SDK API" emerging from
> https://github.com/apache/fineract/pull/1428/ for FINERACT-1216 contains at
> least some annotated Java methods which are invalid for Retrofit.
> When enabling {{apiClient.getAdapterBuilder().validateEagerly(true);}}, I'm
> seeing e.g.
> {noformat}java.lang.IllegalArgumentException: Non-body HTTP method cannot
> contain @Body.
> for method ClientApi.delete9
> at retrofit2.Utils.methodError(Utils.java:54)
> at retrofit2.Utils.methodError(Utils.java:43)
> at retrofit2.RequestFactory$Builder.build(RequestFactory.java:213)
> at retrofit2.RequestFactory.parseAnnotations(RequestFactory.java:67)
> at retrofit2.ServiceMethod.parseAnnotations(ServiceMethod.java:26)
> at retrofit2.Retrofit.loadServiceMethod(Retrofit.java:202)
> at retrofit2.Retrofit.validateServiceInterface(Retrofit.java:189)
> at retrofit2.Retrofit.create(Retrofit.java:141)
> at
> org.apache.fineract.client.ApiClient.createService(ApiClient.java:127)
> at
> org.apache.fineract.client.util.FineractClient.createService(FineractClient.java:42)
> at
> org.apache.fineract.client.test.FineractClientTest.testRetrieveAllClients(FineractClientTest.java:41){noformat}
> As a first step to eventually fixing this (and having non-regression for it),
> I'll write an automated test about it (but keep it ignored, for now).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
