[GitHub] incubator-fineract issue #215: creditbureau configuration

2016-11-17 Thread nazeer1100126
Github user nazeer1100126 commented on the issue: https://github.com/apache/incubator-fineract/pull/215 Remove all commented code --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] incubator-fineract pull request #178: Added notification module

2016-11-17 Thread nazeer1100126
Github user nazeer1100126 commented on a diff in the pull request: https://github.com/apache/incubator-fineract/pull/178#discussion_r88409750 --- Diff: fineract-provider/src/main/java/org/apache/fineract/portfolio/shareproducts/api/ShareDividendApiResource.java --- @@ -113,6

[GitHub] incubator-fineract pull request #178: Added notification module

2016-11-17 Thread nazeer1100126
Github user nazeer1100126 commented on a diff in the pull request: https://github.com/apache/incubator-fineract/pull/178#discussion_r88409047 --- Diff: fineract-provider/src/main/resources/sql/migrations/core_db/V1__mifosplatform-core-ddl-latest.sql --- @@ -204,7 +204,7 @@ CREATE

[GitHub] incubator-fineract pull request #178: Added notification module

2016-11-17 Thread nazeer1100126
Github user nazeer1100126 commented on a diff in the pull request: https://github.com/apache/incubator-fineract/pull/178#discussion_r88409480 --- Diff: fineract-provider/src/main/java/org/apache/fineract/useradministration/service/PermissionReadPlatformServiceImpl.java --- @@

[GitHub] incubator-fineract pull request #178: Added notification module

2016-11-17 Thread nazeer1100126
Github user nazeer1100126 commented on a diff in the pull request: https://github.com/apache/incubator-fineract/pull/178#discussion_r88408934 --- Diff: fineract-provider/src/main/resources/sql/migrations/core_db/V254__General_Ledger_Report.sql --- @@ -39,5 +39,5 @@ INSERT INTO

[GitHub] incubator-fineract pull request #178: Added notification module

2016-11-17 Thread nazeer1100126
Github user nazeer1100126 commented on a diff in the pull request: https://github.com/apache/incubator-fineract/pull/178#discussion_r88410313 --- Diff: fineract-provider/src/main/java/org/apache/fineract/portfolio/loanproduct/api/LoanProductsApiResource.java --- @@ -18,25 +18,6

[GitHub] incubator-fineract pull request #178: Added notification module

2016-11-17 Thread nazeer1100126
Github user nazeer1100126 commented on a diff in the pull request: https://github.com/apache/incubator-fineract/pull/178#discussion_r88410440 --- Diff: fineract-provider/src/main/java/org/apache/fineract/portfolio/group/api/GroupsApiResource.java --- @@ -53,7 +53,9 @@ import

[GitHub] incubator-fineract pull request #178: Added notification module

2016-11-17 Thread nazeer1100126
Github user nazeer1100126 commented on a diff in the pull request: https://github.com/apache/incubator-fineract/pull/178#discussion_r88410473 --- Diff: fineract-provider/src/main/java/org/apache/fineract/portfolio/group/api/CentersApiResource.java --- @@ -54,7 +54,9 @@

[GitHub] incubator-fineract pull request #178: Added notification module

2016-11-17 Thread nazeer1100126
Github user nazeer1100126 commented on a diff in the pull request: https://github.com/apache/incubator-fineract/pull/178#discussion_r88410183 --- Diff: fineract-provider/src/main/java/org/apache/fineract/portfolio/savings/api/RecurringDepositAccountsApiResource.java --- @@ -51,7

[GitHub] incubator-fineract pull request #178: Added notification module

2016-11-17 Thread nazeer1100126
Github user nazeer1100126 commented on a diff in the pull request: https://github.com/apache/incubator-fineract/pull/178#discussion_r88410207 --- Diff: fineract-provider/src/main/java/org/apache/fineract/portfolio/savings/api/FixedDepositAccountsApiResource.java --- @@ -51,7

[GitHub] incubator-fineract pull request #178: Added notification module

2016-11-17 Thread nazeer1100126
Github user nazeer1100126 commented on a diff in the pull request: https://github.com/apache/incubator-fineract/pull/178#discussion_r88410510 --- Diff: fineract-provider/src/main/java/org/apache/fineract/portfolio/client/api/ClientsApiResource.java --- @@ -18,25 +18,6 @@ */

[GitHub] incubator-fineract pull request #178: Added notification module

2016-11-17 Thread nazeer1100126
Github user nazeer1100126 commented on a diff in the pull request: https://github.com/apache/incubator-fineract/pull/178#discussion_r88410274 --- Diff: fineract-provider/src/main/java/org/apache/fineract/portfolio/note/service/NoteWritePlatformServiceJpaRepositoryImpl.java --- @@

[GitHub] incubator-fineract pull request #178: Added notification module

2016-11-17 Thread nazeer1100126
Github user nazeer1100126 commented on a diff in the pull request: https://github.com/apache/incubator-fineract/pull/178#discussion_r88410550 --- Diff: fineract-provider/src/main/java/org/apache/fineract/portfolio/accounts/api/AccountsApiResource.java --- @@ -38,14 +38,18 @@

[GitHub] incubator-fineract pull request #178: Added notification module

2016-11-17 Thread nazeer1100126
Github user nazeer1100126 commented on a diff in the pull request: https://github.com/apache/incubator-fineract/pull/178#discussion_r88398383 --- Diff: fineract-provider/src/main/java/org/apache/fineract/infrastructure/security/filter/TenantAwareBasicAuthenticationFilter.java ---

[GitHub] incubator-fineract pull request #178: Added notification module

2016-11-17 Thread nazeer1100126
Github user nazeer1100126 commented on a diff in the pull request: https://github.com/apache/incubator-fineract/pull/178#discussion_r88396940 --- Diff: fineract-provider/gradle/wrapper/gradle-wrapper.properties --- @@ -1,6 +1,6 @@ -#Fri Jan 29 13:04:36 IST 2016 +#Tue Jul 19

[GitHub] incubator-fineract pull request #178: Added notification module

2016-11-17 Thread nazeer1100126
Github user nazeer1100126 commented on a diff in the pull request: https://github.com/apache/incubator-fineract/pull/178#discussion_r88409571 --- Diff: fineract-provider/src/main/java/org/apache/fineract/useradministration/service/AppUserReadPlatformServiceImpl.java --- @@ -95,10

[GitHub] incubator-fineract pull request #178: Added notification module

2016-11-17 Thread nazeer1100126
Github user nazeer1100126 commented on a diff in the pull request: https://github.com/apache/incubator-fineract/pull/178#discussion_r88398119 --- Diff: fineract-provider/src/main/java/org/apache/fineract/infrastructure/core/service/SearchParameters.java --- @@ -75,6 +75,15 @@

[GitHub] incubator-fineract pull request #178: Added notification module

2016-11-17 Thread nazeer1100126
Github user nazeer1100126 commented on a diff in the pull request: https://github.com/apache/incubator-fineract/pull/178#discussion_r88410380 --- Diff: fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/api/LoansApiResource.java --- @@ -18,29 +18,7 @@

[GitHub] incubator-fineract pull request #178: Added notification module

2016-11-17 Thread nazeer1100126
Github user nazeer1100126 commented on a diff in the pull request: https://github.com/apache/incubator-fineract/pull/178#discussion_r88409004 --- Diff: fineract-provider/src/main/resources/sql/migrations/core_db/V228__entity_to_entity_access.sql --- @@ -56,9 +56,9 @@ CREATE TABLE

[GitHub] incubator-fineract pull request #178: Added notification module

2016-11-17 Thread nazeer1100126
Github user nazeer1100126 commented on a diff in the pull request: https://github.com/apache/incubator-fineract/pull/178#discussion_r88398916 --- Diff: fineract-provider/src/main/java/org/apache/fineract/notification/api/NotificationApiResource.java --- @@ -0,0 +1,68 @@

[GitHub] incubator-fineract pull request #178: Added notification module

2016-11-17 Thread nazeer1100126
Github user nazeer1100126 commented on a diff in the pull request: https://github.com/apache/incubator-fineract/pull/178#discussion_r88408961 --- Diff: fineract-provider/src/main/resources/sql/migrations/core_db/V234__opening_balaces_setup.sql --- @@ -36,7 +36,7 @@ INSERT INTO

[GitHub] incubator-fineract issue #178: Added notification module

2016-11-17 Thread ad-os
Github user ad-os commented on the issue: https://github.com/apache/incubator-fineract/pull/178 I have used jms to publish the generated notifications to a queue(implmented via ActiveMq) and then used the jmslistener to subscribe to that queue and listen for any new notification.

[GitHub] incubator-fineract pull request #243: SMS Campaign issues fix on 16-11

2016-11-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/incubator-fineract/pull/243 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] incubator-fineract issue #231: Better E-mail for new user

2016-11-17 Thread nazeer1100126
Github user nazeer1100126 commented on the issue: https://github.com/apache/incubator-fineract/pull/231 No, You need to send new PR --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] incubator-fineract pull request #231: Better E-mail for new user

2016-11-17 Thread gkrishnan724
Github user gkrishnan724 closed the pull request at: https://github.com/apache/incubator-fineract/pull/231 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] incubator-fineract pull request #244: Fix for MIFOSX-2799

2016-11-17 Thread gkrishnan724
GitHub user gkrishnan724 opened a pull request: https://github.com/apache/incubator-fineract/pull/244 Fix for MIFOSX-2799 Issue: When a new user is created in the community-app, the E-mail received on registration was too complicated to understand Fix: Changed the

[GitHub] incubator-fineract issue #244: Fix for MIFOSX-2799

2016-11-17 Thread gkrishnan724
Github user gkrishnan724 commented on the issue: https://github.com/apache/incubator-fineract/pull/244 Yeah thats fine, I'll send new PR --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] incubator-fineract issue #231: Better E-mail for new user

2016-11-17 Thread gkrishnan724
Github user gkrishnan724 commented on the issue: https://github.com/apache/incubator-fineract/pull/231 Okay I will --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] incubator-fineract issue #178: Added notification module

2016-11-17 Thread nazeer1100126
Github user nazeer1100126 commented on the issue: https://github.com/apache/incubator-fineract/pull/178 Have a look at how business events are implemented in Fineract. I believe the same way you can do it asynchronously by listening to required events. By this approach you no need to

[GitHub] incubator-fineract issue #244: Fix for MIFOSX-2799

2016-11-17 Thread nazeer1100126
Github user nazeer1100126 commented on the issue: https://github.com/apache/incubator-fineract/pull/244 The subject line should be "New User Information" or 'Welcome to [Organization] Name'. I meant [Organization] should be replaced with Organization name. Remove [ ]. Sorry that I

[GitHub] incubator-fineract pull request #245: Fix for MIFOSX-2799

2016-11-17 Thread gkrishnan724
GitHub user gkrishnan724 opened a pull request: https://github.com/apache/incubator-fineract/pull/245 Fix for MIFOSX-2799 Issue: When a new user is created in the community-app, the E-mail received on registration was too complicated to understand Fix: Changed the

[GitHub] incubator-fineract issue #245: Fix for MIFOSX-2799

2016-11-17 Thread gkrishnan724
Github user gkrishnan724 commented on the issue: https://github.com/apache/incubator-fineract/pull/245 Hope this one is fine :-P --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] incubator-fineract pull request #246: Put gradle version in build.gradle and...

2016-11-17 Thread maddingo
GitHub user maddingo opened a pull request: https://github.com/apache/incubator-fineract/pull/246 Put gradle version in build.gradle and avoid having to download the correct gradle version prior to building You can merge this pull request into a Git repository by running: $

[GitHub] incubator-fineract issue #178: Added notification module

2016-11-17 Thread ad-os
Github user ad-os commented on the issue: https://github.com/apache/incubator-fineract/pull/178 I think I have followed the same design as the implementation of business events. > You no need to modify all API resources I have used only the publish method call from