[GitHub] incubator-fineract pull request #270: Notification Module

2017-01-13 Thread ad-os
Github user ad-os commented on a diff in the pull request: https://github.com/apache/incubator-fineract/pull/270#discussion_r96107755 --- Diff: fineract-provider/src/main/java/org/apache/fineract/notification/eventandlistener/NotificationEventListener.java --- @@ -0,0 +1,101 @@

[GitHub] incubator-fineract pull request #270: Notification Module

2017-01-13 Thread ad-os
Github user ad-os commented on a diff in the pull request: https://github.com/apache/incubator-fineract/pull/270#discussion_r96110571 --- Diff: fineract-provider/src/main/java/org/apache/fineract/notification/domain/NotificationGenerator.java --- @@ -0,0 +1,178 @@ +/** +

[GitHub] incubator-fineract pull request #274: FINERACT-352 fix showing penalties aft...

2017-01-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/incubator-fineract/pull/274 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] incubator-fineract pull request #271: Fineract-265:addressModuleNullPointerF...

2017-01-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/incubator-fineract/pull/271 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] incubator-fineract issue #274: FINERACT-352 fix showing penalties after last...

2017-01-13 Thread nazeer1100126
Github user nazeer1100126 commented on the issue: https://github.com/apache/incubator-fineract/pull/274 @lionelraymundi Changes Looks OK. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] incubator-fineract pull request #270: Notification Module

2017-01-13 Thread ad-os
Github user ad-os commented on a diff in the pull request: https://github.com/apache/incubator-fineract/pull/270#discussion_r95986979 --- Diff: fineract-provider/src/main/java/org/apache/fineract/notification/domain/NotificationMapper.java --- @@ -0,0 +1,121 @@ +/** + *

[GitHub] incubator-fineract pull request #270: Notification Module

2017-01-13 Thread ad-os
Github user ad-os commented on a diff in the pull request: https://github.com/apache/incubator-fineract/pull/270#discussion_r96020577 --- Diff: fineract-provider/src/main/java/org/apache/fineract/notification/domain/NotificationGenerator.java --- @@ -0,0 +1,178 @@ +/** +

[GitHub] incubator-fineract pull request #270: Notification Module

2017-01-13 Thread ad-os
Github user ad-os commented on a diff in the pull request: https://github.com/apache/incubator-fineract/pull/270#discussion_r96020630 --- Diff: fineract-provider/src/main/java/org/apache/fineract/notification/domain/NotificationMapper.java --- @@ -0,0 +1,121 @@ +/** + *

[GitHub] incubator-fineract pull request #270: Notification Module

2017-01-13 Thread ad-os
Github user ad-os commented on a diff in the pull request: https://github.com/apache/incubator-fineract/pull/270#discussion_r96020429 --- Diff: fineract-provider/src/main/java/org/apache/fineract/notification/data/NotificationData.java --- @@ -0,0 +1,220 @@ +/** + *