[GitHub] incubator-fineract pull request #178: Added notification module

2016-11-17 Thread nazeer1100126
Github user nazeer1100126 commented on a diff in the pull request: https://github.com/apache/incubator-fineract/pull/178#discussion_r88410550 --- Diff: fineract-provider/src/main/java/org/apache/fineract/portfolio/accounts/api/AccountsApiResource.java --- @@ -38,14 +38,18 @@

[GitHub] incubator-fineract pull request #178: Added notification module

2016-11-17 Thread nazeer1100126
Github user nazeer1100126 commented on a diff in the pull request: https://github.com/apache/incubator-fineract/pull/178#discussion_r88398383 --- Diff: fineract-provider/src/main/java/org/apache/fineract/infrastructure/security/filter/TenantAwareBasicAuthenticationFilter.java ---

[GitHub] incubator-fineract pull request #178: Added notification module

2016-11-17 Thread nazeer1100126
Github user nazeer1100126 commented on a diff in the pull request: https://github.com/apache/incubator-fineract/pull/178#discussion_r88396940 --- Diff: fineract-provider/gradle/wrapper/gradle-wrapper.properties --- @@ -1,6 +1,6 @@ -#Fri Jan 29 13:04:36 IST 2016 +#Tue Jul 19

[GitHub] incubator-fineract pull request #178: Added notification module

2016-11-17 Thread nazeer1100126
Github user nazeer1100126 commented on a diff in the pull request: https://github.com/apache/incubator-fineract/pull/178#discussion_r88398119 --- Diff: fineract-provider/src/main/java/org/apache/fineract/infrastructure/core/service/SearchParameters.java --- @@ -75,6 +75,15 @@

[GitHub] incubator-fineract pull request #178: Added notification module

2016-11-17 Thread nazeer1100126
Github user nazeer1100126 commented on a diff in the pull request: https://github.com/apache/incubator-fineract/pull/178#discussion_r88408934 --- Diff: fineract-provider/src/main/resources/sql/migrations/core_db/V254__General_Ledger_Report.sql --- @@ -39,5 +39,5 @@ INSERT INTO

[GitHub] incubator-fineract pull request #178: Added notification module

2016-11-17 Thread nazeer1100126
Github user nazeer1100126 commented on a diff in the pull request: https://github.com/apache/incubator-fineract/pull/178#discussion_r88410313 --- Diff: fineract-provider/src/main/java/org/apache/fineract/portfolio/loanproduct/api/LoanProductsApiResource.java --- @@ -18,25 +18,6

[GitHub] incubator-fineract pull request #178: Added notification module

2016-11-17 Thread nazeer1100126
Github user nazeer1100126 commented on a diff in the pull request: https://github.com/apache/incubator-fineract/pull/178#discussion_r88410440 --- Diff: fineract-provider/src/main/java/org/apache/fineract/portfolio/group/api/GroupsApiResource.java --- @@ -53,7 +53,9 @@ import

[GitHub] incubator-fineract pull request #178: Added notification module

2016-11-17 Thread nazeer1100126
Github user nazeer1100126 commented on a diff in the pull request: https://github.com/apache/incubator-fineract/pull/178#discussion_r88409571 --- Diff: fineract-provider/src/main/java/org/apache/fineract/useradministration/service/AppUserReadPlatformServiceImpl.java --- @@ -95,10

[GitHub] incubator-fineract pull request #178: Added notification module

2016-11-17 Thread nazeer1100126
Github user nazeer1100126 commented on a diff in the pull request: https://github.com/apache/incubator-fineract/pull/178#discussion_r88410183 --- Diff: fineract-provider/src/main/java/org/apache/fineract/portfolio/savings/api/RecurringDepositAccountsApiResource.java --- @@ -51,7

[GitHub] incubator-fineract pull request #178: Added notification module

2016-11-17 Thread nazeer1100126
Github user nazeer1100126 commented on a diff in the pull request: https://github.com/apache/incubator-fineract/pull/178#discussion_r88410207 --- Diff: fineract-provider/src/main/java/org/apache/fineract/portfolio/savings/api/FixedDepositAccountsApiResource.java --- @@ -51,7

[GitHub] incubator-fineract pull request #178: Added notification module

2016-11-17 Thread nazeer1100126
Github user nazeer1100126 commented on a diff in the pull request: https://github.com/apache/incubator-fineract/pull/178#discussion_r88409480 --- Diff: fineract-provider/src/main/java/org/apache/fineract/useradministration/service/PermissionReadPlatformServiceImpl.java --- @@

[GitHub] incubator-fineract pull request #178: Added notification module

2016-11-17 Thread nazeer1100126
Github user nazeer1100126 commented on a diff in the pull request: https://github.com/apache/incubator-fineract/pull/178#discussion_r88410473 --- Diff: fineract-provider/src/main/java/org/apache/fineract/portfolio/group/api/CentersApiResource.java --- @@ -54,7 +54,9 @@

[GitHub] incubator-fineract pull request #178: Added notification module

2016-11-17 Thread nazeer1100126
Github user nazeer1100126 commented on a diff in the pull request: https://github.com/apache/incubator-fineract/pull/178#discussion_r88410510 --- Diff: fineract-provider/src/main/java/org/apache/fineract/portfolio/client/api/ClientsApiResource.java --- @@ -18,25 +18,6 @@ */

[GitHub] incubator-fineract pull request #178: Added notification module

2016-11-17 Thread nazeer1100126
Github user nazeer1100126 commented on a diff in the pull request: https://github.com/apache/incubator-fineract/pull/178#discussion_r88410274 --- Diff: fineract-provider/src/main/java/org/apache/fineract/portfolio/note/service/NoteWritePlatformServiceJpaRepositoryImpl.java --- @@

[GitHub] incubator-fineract pull request #178: Added notification module

2016-11-17 Thread nazeer1100126
Github user nazeer1100126 commented on a diff in the pull request: https://github.com/apache/incubator-fineract/pull/178#discussion_r88409750 --- Diff: fineract-provider/src/main/java/org/apache/fineract/portfolio/shareproducts/api/ShareDividendApiResource.java --- @@ -113,6

[GitHub] incubator-fineract pull request #178: Added notification module

2016-11-17 Thread nazeer1100126
Github user nazeer1100126 commented on a diff in the pull request: https://github.com/apache/incubator-fineract/pull/178#discussion_r88409047 --- Diff: fineract-provider/src/main/resources/sql/migrations/core_db/V1__mifosplatform-core-ddl-latest.sql --- @@ -204,7 +204,7 @@ CREATE

[GitHub] incubator-fineract pull request #178: Added notification module

2016-11-17 Thread nazeer1100126
Github user nazeer1100126 commented on a diff in the pull request: https://github.com/apache/incubator-fineract/pull/178#discussion_r88410380 --- Diff: fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/api/LoansApiResource.java --- @@ -18,29 +18,7 @@

[GitHub] incubator-fineract pull request #178: Added notification module

2016-11-17 Thread nazeer1100126
Github user nazeer1100126 commented on a diff in the pull request: https://github.com/apache/incubator-fineract/pull/178#discussion_r88409004 --- Diff: fineract-provider/src/main/resources/sql/migrations/core_db/V228__entity_to_entity_access.sql --- @@ -56,9 +56,9 @@ CREATE TABLE

[GitHub] incubator-fineract pull request #178: Added notification module

2016-11-17 Thread nazeer1100126
Github user nazeer1100126 commented on a diff in the pull request: https://github.com/apache/incubator-fineract/pull/178#discussion_r88398916 --- Diff: fineract-provider/src/main/java/org/apache/fineract/notification/api/NotificationApiResource.java --- @@ -0,0 +1,68 @@

[GitHub] incubator-fineract pull request #178: Added notification module

2016-11-17 Thread nazeer1100126
Github user nazeer1100126 commented on a diff in the pull request: https://github.com/apache/incubator-fineract/pull/178#discussion_r88408961 --- Diff: fineract-provider/src/main/resources/sql/migrations/core_db/V234__opening_balaces_setup.sql --- @@ -36,7 +36,7 @@ INSERT INTO