Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/692#discussion_r30779810
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/optimization/GradientDescent.scala
---
@@ -36,19 +36,20 @@ import
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/702#issuecomment-104170195
I like the idea of this, but we have to be aware that this breaks the
existing streaming API by
renaming the `writeToFile()` method.
Since `writeToFile`
[
https://issues.apache.org/jira/browse/FLINK-1992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14553820#comment-14553820
]
ASF GitHub Bot commented on FLINK-1992:
---
Github user tillrohrmann commented on a
[
https://issues.apache.org/jira/browse/FLINK-1992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14553830#comment-14553830
]
ASF GitHub Bot commented on FLINK-1992:
---
Github user tillrohrmann commented on a
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/692#discussion_r30780327
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/optimization/GradientDescent.scala
---
@@ -76,86 +77,163 @@ class
[
https://issues.apache.org/jira/browse/FLINK-2050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14553840#comment-14553840
]
Theodore Vasiloudis commented on FLINK-2050:
[~till.rohrmann] I'm going
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/692#discussion_r30781135
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/optimization/Solver.scala
---
@@ -40,6 +44,32 @@ abstract class Solver extends
[
https://issues.apache.org/jira/browse/FLINK-1992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14553851#comment-14553851
]
ASF GitHub Bot commented on FLINK-1992:
---
Github user tillrohrmann commented on a
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/692#discussion_r30781429
--- Diff:
flink-staging/flink-ml/src/test/scala/org/apache/flink/ml/optimization/GradientDescentITSuite.scala
---
@@ -205,6 +190,61 @@ class
[
https://issues.apache.org/jira/browse/FLINK-1992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14553863#comment-14553863
]
ASF GitHub Bot commented on FLINK-1992:
---
Github user tillrohrmann commented on a
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/692#discussion_r30781414
--- Diff:
flink-staging/flink-ml/src/test/scala/org/apache/flink/ml/optimization/GradientDescentITSuite.scala
---
@@ -205,6 +190,61 @@ class
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/692#issuecomment-104179672
Great work @thvasilo. I had some minor comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
[
https://issues.apache.org/jira/browse/FLINK-1992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14553874#comment-14553874
]
ASF GitHub Bot commented on FLINK-1992:
---
Github user tillrohrmann commented on the
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/682#discussion_r30782105
--- Diff:
flink-staging/flink-streaming/flink-streaming-core/src/main/java/org/apache/flink/streaming/api/graph/StreamingJobGraphGenerator.java
---
@@ -93,6
[
https://issues.apache.org/jira/browse/FLINK-2003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14553880#comment-14553880
]
ASF GitHub Bot commented on FLINK-2003:
---
Github user rmetzger commented on the pull
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/690#issuecomment-104181351
I would actually say into both, the README and the how to contribute
section.
---
If your project is set up for it, you can reply to this email and have your
reply
[
https://issues.apache.org/jira/browse/FLINK-2050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14553896#comment-14553896
]
ASF GitHub Bot commented on FLINK-2050:
---
Github user thvasilo commented on a diff in
Github user thvasilo commented on a diff in the pull request:
https://github.com/apache/flink/pull/704#discussion_r30783065
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/preprocessing/StandardScaler.scala
---
@@ -22,38 +22,47 @@ import breeze.linalg
[
https://issues.apache.org/jira/browse/FLINK-2034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14553894#comment-14553894
]
ASF GitHub Bot commented on FLINK-2034:
---
Github user rmetzger commented on a diff in
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/688#discussion_r30783024
--- Diff: docs/libs/ml/index.md ---
@@ -20,8 +20,100 @@ specific language governing permissions and limitations
under the License.
--
+The
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/692#discussion_r3078
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/optimization/GradientDescent.scala
---
@@ -76,86 +77,163 @@ class
[
https://issues.apache.org/jira/browse/FLINK-1992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14553817#comment-14553817
]
ASF GitHub Bot commented on FLINK-1992:
---
Github user tillrohrmann commented on a
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/692#discussion_r30780043
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/optimization/GradientDescent.scala
---
@@ -76,86 +77,163 @@ class
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/702#issuecomment-104171609
How about adding a `writeToFile()` method that accepts a `FileInputFormat`?
This would only break code where the method is used with a
non-FileInputFormat.
---
If
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/692#discussion_r30780392
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/optimization/GradientDescent.scala
---
@@ -76,86 +77,163 @@ class
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/692#discussion_r30780559
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/optimization/GradientDescent.scala
---
@@ -76,86 +77,163 @@ class
[
https://issues.apache.org/jira/browse/FLINK-1992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14553835#comment-14553835
]
ASF GitHub Bot commented on FLINK-1992:
---
Github user tillrohrmann commented on a
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/692#discussion_r30780625
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/optimization/GradientDescent.scala
---
@@ -76,86 +77,163 @@ class
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/692#discussion_r30780614
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/optimization/GradientDescent.scala
---
@@ -76,86 +77,163 @@ class
[
https://issues.apache.org/jira/browse/FLINK-1992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14553834#comment-14553834
]
ASF GitHub Bot commented on FLINK-1992:
---
Github user tillrohrmann commented on a
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/692#discussion_r30781162
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/optimization/Solver.scala
---
@@ -106,7 +139,7 @@ object Solver {
* See
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/692#discussion_r30781214
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/optimization/Solver.scala
---
@@ -118,6 +151,44 @@ abstract class IterativeSolver
[
https://issues.apache.org/jira/browse/FLINK-1992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14553854#comment-14553854
]
ASF GitHub Bot commented on FLINK-1992:
---
Github user tillrohrmann commented on a
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/669#issuecomment-104174485
Hey @aljoscha,
it seems this is one needed for the Gelly Scala API :-)
Shall I go ahead and merge it?
---
If your project is set up for it, you can reply to this
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/682#discussion_r30782073
--- Diff:
flink-staging/flink-streaming/flink-streaming-core/src/main/java/org/apache/flink/streaming/api/graph/StreamingJobGraphGenerator.java
---
@@ -93,6
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/682#issuecomment-104180508
I have some minor remarks which need some attention, otherwise good to
merge.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user aljoscha commented on the pull request:
https://github.com/apache/flink/pull/669#issuecomment-104182293
I didn't want to merge it without any comments. But please, go ahead.
:smile:
---
If your project is set up for it, you can reply to this email and have your
reply
[
https://issues.apache.org/jira/browse/FLINK-1992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14553811#comment-14553811
]
ASF GitHub Bot commented on FLINK-1992:
---
Github user tillrohrmann commented on a
[
https://issues.apache.org/jira/browse/FLINK-1992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14553808#comment-14553808
]
ASF GitHub Bot commented on FLINK-1992:
---
Github user tillrohrmann commented on a
Github user HilmiYildirim commented on the pull request:
https://github.com/apache/flink/pull/702#issuecomment-104171850
Good idea. I am working on it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/702#issuecomment-104171814
That is a very nice idea!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
[
https://issues.apache.org/jira/browse/FLINK-1992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14553832#comment-14553832
]
ASF GitHub Bot commented on FLINK-1992:
---
Github user tillrohrmann commented on a
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/692#discussion_r30781085
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/optimization/Regularization.scala
---
@@ -95,6 +95,7 @@ abstract class
[
https://issues.apache.org/jira/browse/FLINK-1992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14553855#comment-14553855
]
ASF GitHub Bot commented on FLINK-1992:
---
Github user tillrohrmann commented on a
[
https://issues.apache.org/jira/browse/FLINK-2050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14553879#comment-14553879
]
Till Rohrmann commented on FLINK-2050:
--
Yes of course, where do I find it?
On Thu,
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/688#issuecomment-104185370
Thank you for writing this. Finally I get a better understanding of the
overall status of the FlinkML stuff ;)
+1 to merge.
---
If your project is set up for
[
https://issues.apache.org/jira/browse/FLINK-2034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14553907#comment-14553907
]
ASF GitHub Bot commented on FLINK-2034:
---
Github user rmetzger commented on the pull
[
https://issues.apache.org/jira/browse/FLINK-2050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14553909#comment-14553909
]
ASF GitHub Bot commented on FLINK-2050:
---
Github user tillrohrmann commented on a
Github user thvasilo commented on a diff in the pull request:
https://github.com/apache/flink/pull/692#discussion_r30783908
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/optimization/GradientDescent.scala
---
@@ -76,86 +77,163 @@ class
[
https://issues.apache.org/jira/browse/FLINK-1992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14553911#comment-14553911
]
ASF GitHub Bot commented on FLINK-1992:
---
Github user thvasilo commented on a diff in
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/704#discussion_r30783847
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/preprocessing/StandardScaler.scala
---
@@ -22,38 +22,47 @@ import breeze.linalg
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/704#issuecomment-104186229
Documentation :white_check_mark:
Scaladocs :white_check_mark:
Tests :white_check_mark:
No code outside of flink-ml touched :white_check_mark:
:ship:
Github user thvasilo commented on a diff in the pull request:
https://github.com/apache/flink/pull/692#discussion_r30784142
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/optimization/GradientDescent.scala
---
@@ -36,19 +36,20 @@ import
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/688#discussion_r30784369
--- Diff: docs/libs/ml/index.md ---
@@ -20,8 +20,100 @@ specific language governing permissions and limitations
under the License.
--
[
https://issues.apache.org/jira/browse/FLINK-1992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14553945#comment-14553945
]
ASF GitHub Bot commented on FLINK-1992:
---
Github user thvasilo commented on a diff in
[
https://issues.apache.org/jira/browse/FLINK-2034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14553951#comment-14553951
]
ASF GitHub Bot commented on FLINK-2034:
---
Github user tillrohrmann commented on a
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/688#issuecomment-104193448
Really nice text @thvasilo. I think it's a great introduction.
But I also think that we should change a little bit the outline of our
starting page. IMO, it
[
https://issues.apache.org/jira/browse/FLINK-2034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14553959#comment-14553959
]
ASF GitHub Bot commented on FLINK-2034:
---
Github user tillrohrmann commented on the
Github user thvasilo commented on a diff in the pull request:
https://github.com/apache/flink/pull/692#discussion_r30785863
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/optimization/Solver.scala
---
@@ -40,6 +44,32 @@ abstract class Solver extends
[
https://issues.apache.org/jira/browse/FLINK-1992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14553963#comment-14553963
]
ASF GitHub Bot commented on FLINK-1992:
---
Github user thvasilo commented on a diff in
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/692#discussion_r30786437
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/optimization/GradientDescent.scala
---
@@ -76,86 +77,163 @@ class
[
https://issues.apache.org/jira/browse/FLINK-2034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14553976#comment-14553976
]
ASF GitHub Bot commented on FLINK-2034:
---
Github user thvasilo commented on a diff in
[
https://issues.apache.org/jira/browse/FLINK-1992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14553975#comment-14553975
]
ASF GitHub Bot commented on FLINK-1992:
---
Github user tillrohrmann commented on a
Github user thvasilo commented on a diff in the pull request:
https://github.com/apache/flink/pull/688#discussion_r30786608
--- Diff: docs/libs/ml/index.md ---
@@ -20,8 +20,100 @@ specific language governing permissions and limitations
under the License.
--
+The
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/692#discussion_r30786580
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/optimization/Solver.scala
---
@@ -40,6 +44,32 @@ abstract class Solver extends
[
https://issues.apache.org/jira/browse/FLINK-1992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14553915#comment-14553915
]
ASF GitHub Bot commented on FLINK-1992:
---
Github user thvasilo commented on a diff in
[
https://issues.apache.org/jira/browse/FLINK-2050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14553914#comment-14553914
]
ASF GitHub Bot commented on FLINK-2050:
---
Github user rmetzger commented on the pull
Github user thvasilo commented on a diff in the pull request:
https://github.com/apache/flink/pull/692#discussion_r30784001
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/optimization/GradientDescent.scala
---
@@ -76,86 +77,163 @@ class
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/688#discussion_r30784160
--- Diff: docs/libs/ml/index.md ---
@@ -20,8 +20,100 @@ specific language governing permissions and limitations
under the License.
--
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/688#discussion_r30784150
--- Diff: docs/libs/ml/index.md ---
@@ -20,8 +20,100 @@ specific language governing permissions and limitations
under the License.
--
Github user thvasilo commented on a diff in the pull request:
https://github.com/apache/flink/pull/692#discussion_r30784205
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/optimization/GradientDescent.scala
---
@@ -36,19 +36,20 @@ import
[
https://issues.apache.org/jira/browse/FLINK-1992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14553918#comment-14553918
]
ASF GitHub Bot commented on FLINK-1992:
---
Github user thvasilo commented on a diff in
[
https://issues.apache.org/jira/browse/FLINK-2034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14553919#comment-14553919
]
ASF GitHub Bot commented on FLINK-2034:
---
Github user tillrohrmann commented on a
[
https://issues.apache.org/jira/browse/FLINK-1992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14553924#comment-14553924
]
ASF GitHub Bot commented on FLINK-1992:
---
Github user thvasilo commented on a diff in
[
https://issues.apache.org/jira/browse/FLINK-2034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14553921#comment-14553921
]
ASF GitHub Bot commented on FLINK-2034:
---
Github user tillrohrmann commented on a
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/688#discussion_r30784183
--- Diff: docs/libs/ml/index.md ---
@@ -20,8 +20,100 @@ specific language governing permissions and limitations
under the License.
--
[
https://issues.apache.org/jira/browse/FLINK-2034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14553923#comment-14553923
]
ASF GitHub Bot commented on FLINK-2034:
---
Github user tillrohrmann commented on a
[
https://issues.apache.org/jira/browse/FLINK-2034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14553929#comment-14553929
]
ASF GitHub Bot commented on FLINK-2034:
---
Github user tillrohrmann commented on a
[
https://issues.apache.org/jira/browse/FLINK-2034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14553939#comment-14553939
]
ASF GitHub Bot commented on FLINK-2034:
---
Github user tillrohrmann commented on a
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/688#discussion_r30784588
--- Diff: docs/libs/ml/index.md ---
@@ -20,8 +20,100 @@ specific language governing permissions and limitations
under the License.
--
Github user thvasilo commented on a diff in the pull request:
https://github.com/apache/flink/pull/692#discussion_r30784817
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/optimization/GradientDescent.scala
---
@@ -76,86 +77,163 @@ class
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/688#discussion_r30784829
--- Diff: docs/libs/ml/index.md ---
@@ -20,8 +20,100 @@ specific language governing permissions and limitations
under the License.
--
[
https://issues.apache.org/jira/browse/FLINK-2034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14553946#comment-14553946
]
ASF GitHub Bot commented on FLINK-2034:
---
Github user tillrohrmann commented on a
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/688#discussion_r30784959
--- Diff: docs/libs/ml/index.md ---
@@ -20,8 +20,100 @@ specific language governing permissions and limitations
under the License.
--
[
https://issues.apache.org/jira/browse/FLINK-2034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14553949#comment-14553949
]
ASF GitHub Bot commented on FLINK-2034:
---
Github user tillrohrmann commented on a
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/688#discussion_r30785023
--- Diff: docs/libs/ml/index.md ---
@@ -30,7 +122,7 @@ under the License.
/dependency
{% endhighlight %}
-## Algorithms
+##
Github user thvasilo commented on a diff in the pull request:
https://github.com/apache/flink/pull/692#discussion_r30785537
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/optimization/Regularization.scala
---
@@ -95,6 +95,7 @@ abstract class
[
https://issues.apache.org/jira/browse/FLINK-1992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14553957#comment-14553957
]
ASF GitHub Bot commented on FLINK-1992:
---
Github user thvasilo commented on a diff in
[
https://issues.apache.org/jira/browse/FLINK-1992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14553974#comment-14553974
]
ASF GitHub Bot commented on FLINK-1992:
---
Github user tillrohrmann commented on a
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/692#discussion_r30786533
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/optimization/Regularization.scala
---
@@ -95,6 +95,7 @@ abstract class
[
https://issues.apache.org/jira/browse/FLINK-1992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14553971#comment-14553971
]
ASF GitHub Bot commented on FLINK-1992:
---
Github user tillrohrmann commented on a
Github user thvasilo commented on a diff in the pull request:
https://github.com/apache/flink/pull/688#discussion_r30786490
--- Diff: docs/libs/ml/index.md ---
@@ -20,8 +20,100 @@ specific language governing permissions and limitations
under the License.
--
+The
[
https://issues.apache.org/jira/browse/FLINK-2034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14553973#comment-14553973
]
ASF GitHub Bot commented on FLINK-2034:
---
Github user thvasilo commented on a diff in
Github user thvasilo commented on a diff in the pull request:
https://github.com/apache/flink/pull/688#discussion_r30786639
--- Diff: docs/libs/ml/index.md ---
@@ -20,8 +20,100 @@ specific language governing permissions and limitations
under the License.
--
+The
[
https://issues.apache.org/jira/browse/FLINK-2034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14553977#comment-14553977
]
ASF GitHub Bot commented on FLINK-2034:
---
Github user thvasilo commented on a diff in
Github user thvasilo commented on a diff in the pull request:
https://github.com/apache/flink/pull/688#discussion_r30786723
--- Diff: docs/libs/ml/index.md ---
@@ -30,7 +122,7 @@ under the License.
/dependency
{% endhighlight %}
-## Algorithms
+## Algorithm
[
https://issues.apache.org/jira/browse/FLINK-1992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14553983#comment-14553983
]
ASF GitHub Bot commented on FLINK-1992:
---
Github user tillrohrmann commented on a
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/669#issuecomment-104204248
It would be good to share a bit of information beyond `Some fixes for Scala
type analysis` about what is actually changed. Then others could think about
possible
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/692#discussion_r30786949
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/optimization/GradientDescent.scala
---
@@ -36,19 +36,20 @@ import
[
https://issues.apache.org/jira/browse/FLINK-1992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14553989#comment-14553989
]
ASF GitHub Bot commented on FLINK-1992:
---
Github user tillrohrmann commented on a
1 - 100 of 216 matches
Mail list logo
