Github user zentol commented on the pull request:
https://github.com/apache/flink/pull/1376#issuecomment-158015146
@tillrohrmann I've changed the type deduction test to a) no longer produce
any output and b) actually fail with an exception f things go wrong.
---
If your project is
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/1376#issuecomment-158016205
Great @zentol. Good to merge then.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
[
https://issues.apache.org/jira/browse/FLINK-1945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15013292#comment-15013292
]
ASF GitHub Bot commented on FLINK-1945:
---
Github user tillrohrmann commented on the pull request:
[
https://issues.apache.org/jira/browse/FLINK-3020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15013311#comment-15013311
]
ASF GitHub Bot commented on FLINK-3020:
---
Github user mxm commented on the pull request:
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/1360#issuecomment-158020011
I would also be in favor of changing the local execution to always use the
maximum specified parallelism as the number of task slots. IMHO the current
behavior is not
[
https://issues.apache.org/jira/browse/FLINK-1994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15013142#comment-15013142
]
Till Rohrmann commented on FLINK-1994:
--
Hi Trevor,
would be great to add tests and docs, otherwise
Github user aljoscha commented on the pull request:
https://github.com/apache/flink/pull/1318#issuecomment-157998634
Thanks for adding this. :+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
[
https://issues.apache.org/jira/browse/FLINK-2955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15013205#comment-15013205
]
ASF GitHub Bot commented on FLINK-2955:
---
Github user aljoscha commented on the pull request:
[
https://issues.apache.org/jira/browse/FLINK-2955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15013212#comment-15013212
]
ASF GitHub Bot commented on FLINK-2955:
---
Github user aljoscha commented on the pull request:
Github user aljoscha commented on the pull request:
https://github.com/apache/flink/pull/1318#issuecomment-157999295
Github seems to not want to close this. @ChengXiangLi Could you please do
it?
---
If your project is set up for it, you can reply to this email and have your
reply
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/1371#issuecomment-158003742
Thanks! Updated. I'll open a JIRA for integrating it into the TypeExtractor.
---
If your project is set up for it, you can reply to this email and have your
reply appear
[
https://issues.apache.org/jira/browse/FLINK-3002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15013228#comment-15013228
]
ASF GitHub Bot commented on FLINK-3002:
---
Github user vasia commented on the pull request:
Vasia Kalavri created FLINK-3046:
Summary: Integrate the Either Java type with the TypeExtractor
Key: FLINK-3046
URL: https://issues.apache.org/jira/browse/FLINK-3046
Project: Flink
Issue
[
https://issues.apache.org/jira/browse/FLINK-2115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15013254#comment-15013254
]
ASF GitHub Bot commented on FLINK-2115:
---
Github user ChengXiangLi commented on the pull request:
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/1360#issuecomment-158009498
True. That's how it is handled on the batch side. Not sure about this
behavior though. If a user sets a default parallelism but uses operators with
`parallelism >
[
https://issues.apache.org/jira/browse/FLINK-3020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15013266#comment-15013266
]
ASF GitHub Bot commented on FLINK-3020:
---
Github user mxm commented on the pull request:
[
https://issues.apache.org/jira/browse/FLINK-2249?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Maximilian Michels closed FLINK-2249.
-
Resolution: Won't Fix
> ExecutionEnvironment: Ignore calls to execute() if no data sinks
Robert Metzger created FLINK-3045:
-
Summary: Properly expose the key of a kafka message
Key: FLINK-3045
URL: https://issues.apache.org/jira/browse/FLINK-3045
Project: Flink
Issue Type:
[
https://issues.apache.org/jira/browse/FLINK-2978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15013215#comment-15013215
]
ASF GitHub Bot commented on FLINK-2978:
---
Github user sachingoel0101 commented on a diff in the pull
Github user sachingoel0101 commented on a diff in the pull request:
https://github.com/apache/flink/pull/1338#discussion_r45317406
--- Diff:
flink-core/src/main/java/org/apache/flink/configuration/ConfigConstants.java ---
@@ -635,8 +644,18 @@
* The default number of
[
https://issues.apache.org/jira/browse/FLINK-3040?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stephan Ewen resolved FLINK-3040.
-
Resolution: Fixed
Fixed in
- 0.10.1 in db456a761480679f54136743237999049cb7476b
- 1.0.0 in
[
https://issues.apache.org/jira/browse/FLINK-3040?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stephan Ewen closed FLINK-3040.
---
> Add docs describing how to configure State Backends
>
[
https://issues.apache.org/jira/browse/FLINK-2249?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Maximilian Michels reopened FLINK-2249:
---
> ExecutionEnvironment: Ignore calls to execute() if no data sinks defined
>
[
https://issues.apache.org/jira/browse/FLINK-2115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15013200#comment-15013200
]
ASF GitHub Bot commented on FLINK-2115:
---
Github user aljoscha commented on the pull request:
Github user aljoscha commented on the pull request:
https://github.com/apache/flink/pull/1377#issuecomment-157997049
OK, I see your point. We can go with the MySQL way then. Thanks for
explaining it. :smile:
Could you please update the documentation with a small paragraph
Github user aljoscha commented on the pull request:
https://github.com/apache/flink/pull/1318#issuecomment-157998150
I'm merging
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
[
https://issues.apache.org/jira/browse/FLINK-2955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15013208#comment-15013208
]
ASF GitHub Bot commented on FLINK-2955:
---
Github user aljoscha commented on the pull request:
[
https://issues.apache.org/jira/browse/FLINK-2955?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aljoscha Krettek resolved FLINK-2955.
-
Resolution: Fixed
Fix Version/s: 1.0.0
Resolved in
Github user ChengXiangLi closed the pull request at:
https://github.com/apache/flink/pull/1318
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
[
https://issues.apache.org/jira/browse/FLINK-2955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15013234#comment-15013234
]
ASF GitHub Bot commented on FLINK-2955:
---
Github user ChengXiangLi closed the pull request at:
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/1345
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
[
https://issues.apache.org/jira/browse/FLINK-3001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15013511#comment-15013511
]
Hubert Czerpak edited comment on FLINK-3001 at 11/19/15 5:50 PM:
-
Github user gyfora commented on a diff in the pull request:
https://github.com/apache/flink/pull/1305#discussion_r45377370
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/StateBackend.java ---
@@ -64,33 +64,35 @@
/**
* Closes the state
[
https://issues.apache.org/jira/browse/FLINK-3009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15014891#comment-15014891
]
ASF GitHub Bot commented on FLINK-3009:
---
Github user hsaputra commented on the pull request:
Github user hsaputra commented on the pull request:
https://github.com/apache/flink/pull/1363#issuecomment-158245010
LGTM
+1
Will commit end of day if no one beats me
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
[
https://issues.apache.org/jira/browse/FLINK-3032?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Metzger resolved FLINK-3032.
---
Resolution: Fixed
Fix Version/s: 0.10.1
1.0.0
Fixed for 0.10
Github user mliesenberg commented on the pull request:
https://github.com/apache/flink/pull/1097#issuecomment-158164663
Oha. yes. Found the problem causing the exception, will fix it and make the
tests more specific as to which exceptions they need to catch.
While I am at it,
[
https://issues.apache.org/jira/browse/FLINK-2017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15014198#comment-15014198
]
ASF GitHub Bot commented on FLINK-2017:
---
Github user mliesenberg commented on the pull request:
[
https://issues.apache.org/jira/browse/FLINK-3009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15014482#comment-15014482
]
ASF GitHub Bot commented on FLINK-3009:
---
Github user jaoki commented on the pull request:
Github user jaoki commented on the pull request:
https://github.com/apache/flink/pull/1363#issuecomment-158213589
Does anyone want to commit this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
[
https://issues.apache.org/jira/browse/FLINK-3020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15013342#comment-15013342
]
ASF GitHub Bot commented on FLINK-3020:
---
Github user mxm commented on the pull request:
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1360#discussion_r45327211
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/environment/LocalStreamEnvironment.java
---
@@ -91,7 +91,11 @@ public
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/1360#issuecomment-158024467
Alright. I will push the original pull request version again which uses the
max parallelism of all operators. Further, I will open a separate JIRA for the
batch side
[
https://issues.apache.org/jira/browse/FLINK-3020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15013341#comment-15013341
]
ASF GitHub Bot commented on FLINK-3020:
---
Github user tillrohrmann commented on a diff in the pull
[
https://issues.apache.org/jira/browse/FLINK-3044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15013362#comment-15013362
]
Stephan Ewen commented on FLINK-3044:
-
Can you elaborate? Why is it not respected, do the TaskManagers
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1371#issuecomment-158027623
Looks good, +1 to merge this
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
[
https://issues.apache.org/jira/browse/FLINK-3002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15013380#comment-15013380
]
ASF GitHub Bot commented on FLINK-3002:
---
Github user StephanEwen commented on the pull request:
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/1379#issuecomment-158044491
LGTM. Will merge this PR. Thanks for your work @smarthi.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
[
https://issues.apache.org/jira/browse/FLINK-3043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15013457#comment-15013457
]
ASF GitHub Bot commented on FLINK-3043:
---
Github user tillrohrmann commented on the pull request:
[
https://issues.apache.org/jira/browse/FLINK-3041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15013461#comment-15013461
]
ASF GitHub Bot commented on FLINK-3041:
---
Github user asfgit closed the pull request at:
[
https://issues.apache.org/jira/browse/FLINK-3041?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Till Rohrmann resolved FLINK-3041.
--
Resolution: Fixed
Added via dc61c7a955f0192ca8c86470cd3e22eb1f5dc2dd
> Twitter Streaming
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/1379
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user uce commented on the pull request:
https://github.com/apache/flink/pull/1369#issuecomment-158047558
I've updated the PR as you suggested and rebased on the current master.
Waiting for Travis. After that I, think it is ready to be merged to
`release-0.10` and `master`.
[
https://issues.apache.org/jira/browse/FLINK-3011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15013474#comment-15013474
]
ASF GitHub Bot commented on FLINK-3011:
---
Github user uce commented on the pull request:
[
https://issues.apache.org/jira/browse/FLINK-3020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15013477#comment-15013477
]
ASF GitHub Bot commented on FLINK-3020:
---
Github user tillrohrmann commented on the pull request:
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/1360#issuecomment-158047994
But this is only true if the `taskManagerNumSlots` in `LocalExecutor` are
left untouched. Currently, this is the case but this is not enforced.
---
If your
Github user alexeyegorov commented on the pull request:
https://github.com/apache/flink/commit/bf29de981c2bcd5cb5d33c68b158c95c8820f43d#commitcomment-14496327
@tillrohrmann @mxm thank you both. It's good know where I can find binaries
I build on my own (was looking for them in my
[
https://issues.apache.org/jira/browse/FLINK-3020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15013328#comment-15013328
]
ASF GitHub Bot commented on FLINK-3020:
---
Github user StephanEwen commented on a diff in the pull
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/1360#discussion_r45326391
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/environment/LocalStreamEnvironment.java
---
@@ -91,7 +91,11 @@ public
[
https://issues.apache.org/jira/browse/FLINK-3044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15013395#comment-15013395
]
Stephan Ewen commented on FLINK-3044:
-
Let's verify that. Would be surprising, as other config flags
[
https://issues.apache.org/jira/browse/FLINK-3047?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Maximilian Michels closed FLINK-3047.
-
Resolution: Not A Problem
> Local batch execution: set number of task manager slots to
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/1360#issuecomment-158032582
Just checked. The batch side always uses the maximum parallelism as the
number of task slots (if they are not set explicitly). Till and me actually
thought differently. So
[
https://issues.apache.org/jira/browse/FLINK-3020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15013400#comment-15013400
]
ASF GitHub Bot commented on FLINK-3020:
---
Github user mxm commented on the pull request:
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/1376
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
[
https://issues.apache.org/jira/browse/FLINK-1945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15013439#comment-15013439
]
ASF GitHub Bot commented on FLINK-1945:
---
Github user asfgit closed the pull request at:
[
https://issues.apache.org/jira/browse/FLINK-1945?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chesnay Schepler closed FLINK-1945.
---
Resolution: Fixed
> Make python tests less verbose
> --
>
>
[
https://issues.apache.org/jira/browse/FLINK-2440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15013447#comment-15013447
]
ASF GitHub Bot commented on FLINK-2440:
---
GitHub user zentol opened a pull request:
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/1380#issuecomment-158045723
LGTM. Maybe we can also update the documentation for 0.10 if the changes
apply to this version as well.
---
If your project is set up for it, you can reply to
Github user twalthr commented on the pull request:
https://github.com/apache/flink/pull/1371#issuecomment-158048821
@vasia I can implement the TypeExtractor support.
@StephanEwen Custom type integration interfaces sound very good. I can open
an issue for that.
---
If your
[
https://issues.apache.org/jira/browse/FLINK-3002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15013480#comment-15013480
]
ASF GitHub Bot commented on FLINK-3002:
---
Github user twalthr commented on the pull request:
[
https://issues.apache.org/jira/browse/FLINK-2115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15013350#comment-15013350
]
ASF GitHub Bot commented on FLINK-2115:
---
Github user tillrohrmann commented on the pull request:
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/1377#issuecomment-158025348
@Li Chengxiang, you can always pull changes directly from the ASF git
repository: https://git-wip-us.apache.org/repos/asf/flink.git. Then you
don't have to
[
https://issues.apache.org/jira/browse/FLINK-3044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15013381#comment-15013381
]
Aljoscha Krettek commented on FLINK-3044:
-
I recently ran a Job on GCE to test the state backend.
[
https://issues.apache.org/jira/browse/FLINK-2732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15013411#comment-15013411
]
Martin Liesenberg commented on FLINK-2732:
--
I have two questions concerning the display and
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/1371#issuecomment-158042526
Thanks. I'll squash the commits and merge later today.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
[
https://issues.apache.org/jira/browse/FLINK-3002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15013429#comment-15013429
]
ASF GitHub Bot commented on FLINK-3002:
---
Github user vasia commented on the pull request:
[
https://issues.apache.org/jira/browse/FLINK-1945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15013432#comment-15013432
]
ASF GitHub Bot commented on FLINK-1945:
---
Github user zentol commented on the pull request:
[
https://issues.apache.org/jira/browse/FLINK-2318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15013431#comment-15013431
]
Chesnay Schepler commented on FLINK-2318:
-
I think i may have a fix for this issue, can be found
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/1383
[FLINK-2440][py] Expand Environment feature coverage
Small PR that
* renames setDegreeOfParallelism() to setParallelism()
* adds getDegreeOfParallelism(), set-/getNumberOfExecutionRetries()
[
https://issues.apache.org/jira/browse/FLINK-3041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15013445#comment-15013445
]
ASF GitHub Bot commented on FLINK-3041:
---
Github user tillrohrmann commented on the pull request:
Maximilian Michels created FLINK-3047:
-
Summary: Local batch execution: set number of task manager slots
to the maximum parallelism
Key: FLINK-3047
URL: https://issues.apache.org/jira/browse/FLINK-3047
[
https://issues.apache.org/jira/browse/FLINK-3047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15013402#comment-15013402
]
Maximilian Michels commented on FLINK-3047:
---
This has already been fixed for batch execution.
>
Github user zentol commented on the pull request:
https://github.com/apache/flink/pull/1376#issuecomment-158042693
Merging this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
[
https://issues.apache.org/jira/browse/FLINK-3043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15013453#comment-15013453
]
ASF GitHub Bot commented on FLINK-3043:
---
Github user tillrohrmann commented on a diff in the pull
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1380#discussion_r45335152
--- Diff: docs/apis/streaming_guide.md ---
@@ -3448,15 +3417,14 @@ Then, import the connector in your maven project:
Note that the streaming
[
https://issues.apache.org/jira/browse/FLINK-3020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15013309#comment-15013309
]
ASF GitHub Bot commented on FLINK-3020:
---
Github user tillrohrmann commented on the pull request:
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/1360#issuecomment-158019230
Yes, in such a case it would fail. Thinking about it, you're right that it
would give a better user experience if the maximum degree of the job is taken
instead of
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/1305#discussion_r45351298
--- Diff:
flink-contrib/flink-streaming-contrib/src/main/java/org/apache/flink/contrib/streaming/state/DbBackendConfig.java
---
@@ -0,0 +1,406 @@
Github user gyfora commented on a diff in the pull request:
https://github.com/apache/flink/pull/1305#discussion_r45351896
--- Diff:
flink-contrib/flink-streaming-contrib/src/main/java/org/apache/flink/contrib/streaming/state/DbBackendConfig.java
---
@@ -0,0 +1,406 @@
+/*
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1360#issuecomment-158022328
+1 for taking the max parallelism of all operators
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
[
https://issues.apache.org/jira/browse/FLINK-3020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15013327#comment-15013327
]
ASF GitHub Bot commented on FLINK-3020:
---
Github user StephanEwen commented on the pull request:
[
https://issues.apache.org/jira/browse/FLINK-2978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15013761#comment-15013761
]
ASF GitHub Bot commented on FLINK-2978:
---
Github user rmetzger commented on a diff in the pull
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/1353
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
[
https://issues.apache.org/jira/browse/FLINK-2913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15013767#comment-15013767
]
ASF GitHub Bot commented on FLINK-2913:
---
Github user asfgit closed the pull request at:
[
https://issues.apache.org/jira/browse/FLINK-3048?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stephan Ewen closed FLINK-3048.
---
> DataSinkTaskTest.testCancelDataSinkTask
> ---
>
>
[
https://issues.apache.org/jira/browse/FLINK-3048?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stephan Ewen resolved FLINK-3048.
-
Resolution: Fixed
Fix Version/s: 1.0.0
Fixed via 93622001e499fa04bb5c4a63b1b3ed09b270f5b9
[
https://issues.apache.org/jira/browse/FLINK-2913?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stephan Ewen resolved FLINK-2913.
-
Resolution: Fixed
Assignee: Ted Yu
Fix Version/s: 1.0.0
Fixed via
[
https://issues.apache.org/jira/browse/FLINK-2913?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stephan Ewen closed FLINK-2913.
---
> Close of ObjectOutputStream should be enclosed in finally block in
> FsStateBackend
>
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/1305#discussion_r45362408
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/StateBackend.java ---
@@ -64,33 +64,35 @@
/**
* Closes the state
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1305#issuecomment-158107515
I have a final comment inline. Otherwise, I think this is good to merge.
---
If your project is set up for it, you can reply to this email and have your
reply
1 - 100 of 190 matches
Mail list logo
