[jira] [Commented] (FLINK-4355) Implement TaskManager side of registration at ResourceManager

2016-08-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15423229#comment-15423229 ] ASF GitHub Bot commented on FLINK-4355: --- Github user StephanEwen commented on the issue:

[jira] [Commented] (FLINK-3298) Streaming connector for ActiveMQ

2016-08-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15423313#comment-15423313 ] ASF GitHub Bot commented on FLINK-3298: --- Github user mushketyk commented on a diff in the pull

[GitHub] flink pull request #2314: [FLINK-3298] Implement ActiveMQ streaming connecto...

2016-08-16 Thread mushketyk
Github user mushketyk commented on a diff in the pull request: https://github.com/apache/flink/pull/2314#discussion_r75010803 --- Diff: flink-streaming-connectors/flink-connector-activemq/pom.xml --- @@ -0,0 +1,104 @@ + + +http://maven.apache.org/POM/4.0.0; +

[GitHub] flink pull request #2314: [FLINK-3298] Implement ActiveMQ streaming connecto...

2016-08-16 Thread mushketyk
Github user mushketyk commented on a diff in the pull request: https://github.com/apache/flink/pull/2314#discussion_r75010826 --- Diff: flink-streaming-connectors/flink-connector-activemq/pom.xml --- @@ -0,0 +1,104 @@ + + +http://maven.apache.org/POM/4.0.0; +

[GitHub] flink pull request #2359: [FLINK-4198] Replace org.apache.flink.streaming.ap...

2016-08-16 Thread kishorekgarg
Github user kishorekgarg closed the pull request at: https://github.com/apache/flink/pull/2359 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] flink issue #2359: [FLINK-4198] Replace org.apache.flink.streaming.api.windo...

2016-08-16 Thread kishorekgarg
Github user kishorekgarg commented on the issue: https://github.com/apache/flink/pull/2359 Sure. I will close it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] flink issue #2353: [FLINK-4355] [cluster management] Implement TaskManager s...

2016-08-16 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/2353 I addressed the comments by @tillrohrmann and @wenlong88 - turning the registration object into a reusable utility that can also be used for the JobMaster registration - I made the

[jira] [Commented] (FLINK-3298) Streaming connector for ActiveMQ

2016-08-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15423312#comment-15423312 ] ASF GitHub Bot commented on FLINK-3298: --- Github user mushketyk commented on a diff in the pull

[jira] [Updated] (FLINK-4381) Refactor State to Prepare For Key-Group State Backends

2016-08-16 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4381?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aljoscha Krettek updated FLINK-4381: Assignee: Stefan Richter > Refactor State to Prepare For Key-Group State Backends >

[jira] [Assigned] (FLINK-4380) Introduce KeyGroupAssigner and Max-Parallelism Parameter

2016-08-16 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4380?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aljoscha Krettek reassigned FLINK-4380: --- Assignee: Aljoscha Krettek > Introduce KeyGroupAssigner and Max-Parallelism

[jira] [Updated] (FLINK-4380) Introduce KeyGroupAssigner and Max-Parallelism Parameter

2016-08-16 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4380?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aljoscha Krettek updated FLINK-4380: Assignee: Stefan Richter (was: Aljoscha Krettek) > Introduce KeyGroupAssigner and

[GitHub] flink pull request #2288: Feature/s3 a fix

2016-08-16 Thread cresny
Github user cresny commented on a diff in the pull request: https://github.com/apache/flink/pull/2288#discussion_r74982416 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/util/HDFSCopyFromLocal.java --- @@ -62,4 +64,34 @@ public void run() {

[GitHub] flink pull request #2314: [FLINK-3298] Implement ActiveMQ streaming connecto...

2016-08-16 Thread mushketyk
Github user mushketyk commented on a diff in the pull request: https://github.com/apache/flink/pull/2314#discussion_r75011140 --- Diff: flink-streaming-connectors/flink-connector-activemq/src/main/java/org/apache/flink/streaming/connectors/activemq/AMQSink.java --- @@ -0,0 +1,155

[jira] [Commented] (FLINK-3298) Streaming connector for ActiveMQ

2016-08-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15423315#comment-15423315 ] ASF GitHub Bot commented on FLINK-3298: --- Github user mushketyk commented on a diff in the pull

[jira] [Created] (FLINK-4403) RPC proxy classloading should use Flink class' classloader

2016-08-16 Thread Stephan Ewen (JIRA)
Stephan Ewen created FLINK-4403: --- Summary: RPC proxy classloading should use Flink class' classloader Key: FLINK-4403 URL: https://issues.apache.org/jira/browse/FLINK-4403 Project: Flink Issue

[jira] [Commented] (FLINK-4402) Wrong metrics parameter names in documentation

2016-08-16 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15423241#comment-15423241 ] Chesnay Schepler commented on FLINK-4402: - the documentation should be adjusted. > Wrong metrics

[jira] [Commented] (FLINK-4198) Replace org.apache.flink.streaming.api.windowing.time.Time with org.apache.flink.api.common.time.Time

2016-08-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15423168#comment-15423168 ] ASF GitHub Bot commented on FLINK-4198: --- Github user kishorekgarg commented on the issue:

[jira] [Commented] (FLINK-4198) Replace org.apache.flink.streaming.api.windowing.time.Time with org.apache.flink.api.common.time.Time

2016-08-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15423169#comment-15423169 ] ASF GitHub Bot commented on FLINK-4198: --- Github user kishorekgarg closed the pull request at:

[GitHub] flink pull request #2314: [FLINK-3298] Implement ActiveMQ streaming connecto...

2016-08-16 Thread mushketyk
Github user mushketyk commented on a diff in the pull request: https://github.com/apache/flink/pull/2314#discussion_r75011407 --- Diff: flink-streaming-connectors/flink-connector-activemq/src/main/java/org/apache/flink/streaming/connectors/activemq/AMQSink.java --- @@ -0,0 +1,155

[GitHub] flink issue #2353: [FLINK-4355] [cluster management] Implement TaskManager s...

2016-08-16 Thread tillrohrmann
Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/2353 Really good code @StephanEwen :-) I like it a lot that you've pulled out the registration logic from the `TaskExecutor`. This makes it much cleaner and easier to test. I'm actually

[jira] [Commented] (FLINK-4355) Implement TaskManager side of registration at ResourceManager

2016-08-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15422302#comment-15422302 ] ASF GitHub Bot commented on FLINK-4355: --- Github user tillrohrmann commented on the issue:

[jira] [Commented] (FLINK-3950) Add Meter Metric Type

2016-08-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15422355#comment-15422355 ] ASF GitHub Bot commented on FLINK-3950: --- Github user zentol commented on the issue:

[GitHub] flink issue #2374: [FLINK-3950] Add Meter Metric Type

2016-08-16 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/2374 I will look at this in more detail later today; but i couldn't find any mistakes skimming over it. However, a small update to the Metrics documentation would be neat (which i forgot to list on my

[GitHub] flink pull request #2332: [FLINK-2055] Implement Streaming HBaseSink

2016-08-16 Thread delding
Github user delding commented on a diff in the pull request: https://github.com/apache/flink/pull/2332#discussion_r74886606 --- Diff: flink-streaming-connectors/flink-connector-hbase/src/main/java/org/apache/flink/streaming/connectors/hbase/MutationActionList.java --- @@ -0,0

[jira] [Commented] (FLINK-4393) Failed to serialize accumulators for task

2016-08-16 Thread Robert Metzger (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15422367#comment-15422367 ] Robert Metzger commented on FLINK-4393: --- 3.6 GB are too much data to transfer using collect(). I

[GitHub] flink issue #2371: [FLINK-4309] Potential null pointer dereference in Delega...

2016-08-16 Thread uce
Github user uce commented on the issue: https://github.com/apache/flink/pull/2371 Changes look good all in all. Could you also add a `org.apache.flink.util.Preconditions.checkNotNull` check for the backing config in the constructor? --- If your project is set up for it, you can

[jira] [Created] (FLINK-4401) Add docs about ordering in streams

2016-08-16 Thread Ufuk Celebi (JIRA)
Ufuk Celebi created FLINK-4401: -- Summary: Add docs about ordering in streams Key: FLINK-4401 URL: https://issues.apache.org/jira/browse/FLINK-4401 Project: Flink Issue Type: Improvement

[jira] [Commented] (FLINK-4309) Potential null pointer dereference in DelegatingConfiguration#keySet()

2016-08-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15422399#comment-15422399 ] ASF GitHub Bot commented on FLINK-4309: --- Github user uce commented on the issue:

[GitHub] flink pull request #2371: [FLINK-4309] Potential null pointer dereference in...

2016-08-16 Thread uce
Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/2371#discussion_r74894098 --- Diff: flink-core/src/main/java/org/apache/flink/configuration/DelegatingConfiguration.java --- @@ -178,14 +178,19 @@ public String toString() {

[jira] [Commented] (FLINK-4309) Potential null pointer dereference in DelegatingConfiguration#keySet()

2016-08-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15422400#comment-15422400 ] ASF GitHub Bot commented on FLINK-4309: --- Github user uce commented on a diff in the pull request:

[GitHub] flink issue #2371: [FLINK-4309] Potential null pointer dereference in Delega...

2016-08-16 Thread tillrohrmann
Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/2371 Thanks for your contribution @tsunny. Your changes look good. I only had a minor comment. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[jira] [Commented] (FLINK-4309) Potential null pointer dereference in DelegatingConfiguration#keySet()

2016-08-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15422393#comment-15422393 ] ASF GitHub Bot commented on FLINK-4309: --- Github user uce commented on a diff in the pull request:

[GitHub] flink pull request #2371: [FLINK-4309] Potential null pointer dereference in...

2016-08-16 Thread uce
Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/2371#discussion_r74893573 --- Diff: flink-core/src/test/java/org/apache/flink/configuration/DelegatingConfigurationTest.java --- @@ -88,4 +90,49 @@ private String

[GitHub] flink pull request #2371: [FLINK-4309] Potential null pointer dereference in...

2016-08-16 Thread uce
Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/2371#discussion_r74893581 --- Diff: flink-core/src/test/java/org/apache/flink/configuration/DelegatingConfigurationTest.java --- @@ -88,4 +90,49 @@ private String

[jira] [Commented] (FLINK-4309) Potential null pointer dereference in DelegatingConfiguration#keySet()

2016-08-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15422395#comment-15422395 ] ASF GitHub Bot commented on FLINK-4309: --- Github user uce commented on a diff in the pull request:

[jira] [Commented] (FLINK-4309) Potential null pointer dereference in DelegatingConfiguration#keySet()

2016-08-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15422394#comment-15422394 ] ASF GitHub Bot commented on FLINK-4309: --- Github user uce commented on a diff in the pull request:

[GitHub] flink pull request #2371: [FLINK-4309] Potential null pointer dereference in...

2016-08-16 Thread uce
Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/2371#discussion_r74893687 --- Diff: flink-core/src/main/java/org/apache/flink/configuration/DelegatingConfiguration.java --- @@ -178,14 +178,19 @@ public String toString() {

[jira] [Resolved] (FLINK-4373) Introduce SlotID, AllocationID, ResourceProfile

2016-08-16 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4373?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann resolved FLINK-4373. -- Resolution: Done Added via 08cf860169948c93c6c92ab1e2c70cf1a4266c6f > Introduce SlotID,

[GitHub] flink pull request #2371: [FLINK-4309] Potential null pointer dereference in...

2016-08-16 Thread uce
Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/2371#discussion_r74893448 --- Diff: flink-core/src/main/java/org/apache/flink/configuration/DelegatingConfiguration.java --- @@ -178,14 +178,19 @@ public String toString() {

[jira] [Commented] (FLINK-4309) Potential null pointer dereference in DelegatingConfiguration#keySet()

2016-08-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15422392#comment-15422392 ] ASF GitHub Bot commented on FLINK-4309: --- Github user tillrohrmann commented on a diff in the pull

[GitHub] flink pull request #2371: [FLINK-4309] Potential null pointer dereference in...

2016-08-16 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/2371#discussion_r74893388 --- Diff: flink-core/src/main/java/org/apache/flink/configuration/DelegatingConfiguration.java --- @@ -178,14 +178,19 @@ public String toString() {

[jira] [Commented] (FLINK-4309) Potential null pointer dereference in DelegatingConfiguration#keySet()

2016-08-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15422396#comment-15422396 ] ASF GitHub Bot commented on FLINK-4309: --- Github user tillrohrmann commented on the issue:

[jira] [Commented] (FLINK-4253) Rename "recovery.mode" config key to "high-availability"

2016-08-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15422398#comment-15422398 ] ASF GitHub Bot commented on FLINK-4253: --- Github user ramkrish86 commented on the issue:

[jira] [Commented] (FLINK-4309) Potential null pointer dereference in DelegatingConfiguration#keySet()

2016-08-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15422397#comment-15422397 ] ASF GitHub Bot commented on FLINK-4309: --- Github user uce commented on a diff in the pull request:

[GitHub] flink issue #2342: FLINK-4253 - Rename "recovery.mode" config key to "high-a...

2016-08-16 Thread ramkrish86
Github user ramkrish86 commented on the issue: https://github.com/apache/flink/pull/2342 @uce Updated with changes so that all the configs are renamed from 'recovery' to 'high-availability'. --- If your project is set up for it, you can reply to this email and have your reply

[jira] [Commented] (FLINK-4393) Failed to serialize accumulators for task

2016-08-16 Thread Sajeev Ramakrishnan (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15422352#comment-15422352 ] Sajeev Ramakrishnan commented on FLINK-4393: My processing file size is 3.6 GB which contains

[jira] [Commented] (FLINK-4373) Introduce SlotID, AllocationID, ResourceProfile

2016-08-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15422383#comment-15422383 ] ASF GitHub Bot commented on FLINK-4373: --- Github user tillrohrmann commented on the issue:

[GitHub] flink issue #2370: [FLINK-4373] [cluster management] Introduce SlotID, Alloc...

2016-08-16 Thread tillrohrmann
Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/2370 Failing test cases are unrelated. Will merge this PR. Thanks for your contribution @KurtYoung. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] flink issue #2371: [FLINK-4309] Potential null pointer dereference in Delega...

2016-08-16 Thread tsunny
Github user tsunny commented on the issue: https://github.com/apache/flink/pull/2371 No problem. Happy to contribute. Thanks for the review comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] flink pull request #2371: [FLINK-4309] Potential null pointer dereference in...

2016-08-16 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/2371 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (FLINK-4309) Potential null pointer dereference in DelegatingConfiguration#keySet()

2016-08-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15422573#comment-15422573 ] ASF GitHub Bot commented on FLINK-4309: --- Github user asfgit closed the pull request at:

[jira] [Commented] (FLINK-3950) Add Meter Metric Type

2016-08-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15422619#comment-15422619 ] ASF GitHub Bot commented on FLINK-3950: --- Github user mushketyk commented on the issue:

[jira] [Commented] (FLINK-4253) Rename "recovery.mode" config key to "high-availability"

2016-08-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15422618#comment-15422618 ] ASF GitHub Bot commented on FLINK-4253: --- Github user uce commented on a diff in the pull request:

[GitHub] flink issue #2374: [FLINK-3950] Add Meter Metric Type

2016-08-16 Thread mushketyk
Github user mushketyk commented on the issue: https://github.com/apache/flink/pull/2374 Hi @zentol Thank you for your prompt review. Sorry, I was not aware that there is Metrics documentation. I'll update the PR today. --- If your project is set up for it, you can reply to

[jira] [Commented] (FLINK-4309) Potential null pointer dereference in DelegatingConfiguration#keySet()

2016-08-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15422473#comment-15422473 ] ASF GitHub Bot commented on FLINK-4309: --- Github user uce commented on a diff in the pull request:

[GitHub] flink pull request #2371: [FLINK-4309] Potential null pointer dereference in...

2016-08-16 Thread uce
Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/2371#discussion_r74901158 --- Diff: flink-core/src/main/java/org/apache/flink/configuration/DelegatingConfiguration.java --- @@ -56,6 +57,7 @@ public DelegatingConfiguration() {

[jira] [Commented] (FLINK-4309) Potential null pointer dereference in DelegatingConfiguration#keySet()

2016-08-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15422474#comment-15422474 ] ASF GitHub Bot commented on FLINK-4309: --- Github user uce commented on the issue:

[GitHub] flink issue #2371: [FLINK-4309] Potential null pointer dereference in Delega...

2016-08-16 Thread uce
Github user uce commented on the issue: https://github.com/apache/flink/pull/2371 Thanks for addressing our comments! I'm going to merge this later today. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[jira] [Commented] (FLINK-4309) Potential null pointer dereference in DelegatingConfiguration#keySet()

2016-08-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15422489#comment-15422489 ] ASF GitHub Bot commented on FLINK-4309: --- Github user tsunny commented on the issue:

[GitHub] flink pull request #2342: FLINK-4253 - Rename "recovery.mode" config key to ...

2016-08-16 Thread uce
Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/2342#discussion_r74918068 --- Diff: docs/setup/config.md --- @@ -285,7 +285,7 @@ of the JobManager, because the same ActorSystem is used. Its not possible to use ## High

[jira] [Closed] (FLINK-4309) Potential null pointer dereference in DelegatingConfiguration#keySet()

2016-08-16 Thread Ufuk Celebi (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4309?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ufuk Celebi closed FLINK-4309. -- Resolution: Fixed Fix Version/s: 1.1.2 1.2.0 Fixed in ad34540 (master),

[jira] [Commented] (FLINK-4253) Rename "recovery.mode" config key to "high-availability"

2016-08-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15422617#comment-15422617 ] ASF GitHub Bot commented on FLINK-4253: --- Github user uce commented on a diff in the pull request:

[GitHub] flink pull request #2342: FLINK-4253 - Rename "recovery.mode" config key to ...

2016-08-16 Thread uce
Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/2342#discussion_r74918209 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/blob/BlobServer.java --- @@ -77,7 +77,7 @@ /** * Shutdown hook thread to

[jira] [Commented] (FLINK-3950) Add Meter Metric Type

2016-08-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15423358#comment-15423358 ] ASF GitHub Bot commented on FLINK-3950: --- Github user zentol commented on a diff in the pull request:

[GitHub] flink pull request #2374: [FLINK-3950] Add Meter Metric Type

2016-08-16 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/2374#discussion_r75017658 --- Diff: flink-metrics/flink-metrics-jmx/src/test/java/org/apache/flink/metrics/jmx/JMXReporterTest.java --- @@ -245,6 +246,50 @@ public void

[jira] [Commented] (FLINK-4402) Wrong metrics parameter names in documentation

2016-08-16 Thread Neelesh Srinivas Salian (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15423395#comment-15423395 ] Neelesh Srinivas Salian commented on FLINK-4402: If you don't mind, shall I work on this

[GitHub] flink pull request #2314: [FLINK-3298] Implement ActiveMQ streaming connecto...

2016-08-16 Thread mushketyk
Github user mushketyk commented on a diff in the pull request: https://github.com/apache/flink/pull/2314#discussion_r75024557 --- Diff: flink-streaming-connectors/flink-connector-activemq/src/main/java/org/apache/flink/streaming/connectors/activemq/AMQSink.java --- @@ -0,0 +1,155

[jira] [Commented] (FLINK-3950) Add Meter Metric Type

2016-08-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15423463#comment-15423463 ] ASF GitHub Bot commented on FLINK-3950: --- Github user mushketyk commented on the issue:

[jira] [Commented] (FLINK-3298) Streaming connector for ActiveMQ

2016-08-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15423318#comment-15423318 ] ASF GitHub Bot commented on FLINK-3298: --- Github user mushketyk commented on a diff in the pull

[jira] [Commented] (FLINK-3298) Streaming connector for ActiveMQ

2016-08-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15423319#comment-15423319 ] ASF GitHub Bot commented on FLINK-3298: --- Github user mushketyk commented on a diff in the pull

[jira] [Assigned] (FLINK-3761) Introduce key group state backend

2016-08-16 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3761?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aljoscha Krettek reassigned FLINK-3761: --- Assignee: Aljoscha Krettek (was: Till Rohrmann) > Introduce key group state backend

[GitHub] flink pull request #2374: [FLINK-3950] Add Meter Metric Type

2016-08-16 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/2374#discussion_r75018225 --- Diff: flink-metrics/flink-metrics-statsd/src/test/java/org/apache/flink/metrics/statsd/StatsDReporterTest.java --- @@ -261,6 +327,40 @@ public long

[jira] [Commented] (FLINK-3950) Add Meter Metric Type

2016-08-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15423364#comment-15423364 ] ASF GitHub Bot commented on FLINK-3950: --- Github user zentol commented on a diff in the pull request:

[GitHub] flink pull request #2374: [FLINK-3950] Add Meter Metric Type

2016-08-16 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/2374#discussion_r75018180 --- Diff: flink-metrics/flink-metrics-jmx/src/test/java/org/apache/flink/metrics/jmx/JMXReporterTest.java --- @@ -297,4 +342,42 @@ public long getMin() {

[jira] [Commented] (FLINK-3298) Streaming connector for ActiveMQ

2016-08-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15423325#comment-15423325 ] ASF GitHub Bot commented on FLINK-3298: --- Github user mushketyk commented on a diff in the pull

[jira] [Commented] (FLINK-3298) Streaming connector for ActiveMQ

2016-08-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15423327#comment-15423327 ] ASF GitHub Bot commented on FLINK-3298: --- Github user mushketyk commented on a diff in the pull

[jira] [Commented] (FLINK-3950) Add Meter Metric Type

2016-08-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15423365#comment-15423365 ] ASF GitHub Bot commented on FLINK-3950: --- Github user zentol commented on a diff in the pull request:

[jira] [Commented] (FLINK-3298) Streaming connector for ActiveMQ

2016-08-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15423415#comment-15423415 ] ASF GitHub Bot commented on FLINK-3298: --- Github user mushketyk commented on a diff in the pull

[jira] [Commented] (FLINK-3298) Streaming connector for ActiveMQ

2016-08-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15423417#comment-15423417 ] ASF GitHub Bot commented on FLINK-3298: --- Github user mushketyk commented on the issue:

[GitHub] flink issue #2314: [FLINK-3298] Implement ActiveMQ streaming connector

2016-08-16 Thread mushketyk
Github user mushketyk commented on the issue: https://github.com/apache/flink/pull/2314 @rmetzger I've updated the PR according to your review. Could you please take another look? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] flink issue #2374: [FLINK-3950] Add Meter Metric Type

2016-08-16 Thread mushketyk
Github user mushketyk commented on the issue: https://github.com/apache/flink/pull/2374 @zentol Thank you for reviewing my PR! I'll fix these issues as soon as I can. On the metrics interface. Could you please elaborate why do you think exponentially weighted rate and 15

[jira] [Commented] (FLINK-4373) Introduce SlotID, AllocationID, ResourceProfile

2016-08-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15422656#comment-15422656 ] ASF GitHub Bot commented on FLINK-4373: --- Github user tillrohrmann commented on the issue:

[GitHub] flink issue #2370: [FLINK-4373] [cluster management] Introduce SlotID, Alloc...

2016-08-16 Thread tillrohrmann
Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/2370 Not automatically closed by the asfgit bot. @KurtYoung could you close this PR manually? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[jira] [Commented] (FLINK-4399) Add support for oversized messages

2016-08-16 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15422667#comment-15422667 ] Till Rohrmann commented on FLINK-4399: -- Hi Felix, both issues have the same idea. However, this

[GitHub] flink issue #2369: [FLINK-4035] Add a streaming connector for Apache Kafka 0...

2016-08-16 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/2369 Just looked over this briefly. What struck me first is that this again uses the dirty trick of adding a dependency to "Flink Kafka 0.9" and then transitively excluding "Kafka 0.9". Is there

[jira] [Commented] (FLINK-1984) Integrate Flink with Apache Mesos

2016-08-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15422810#comment-15422810 ] ASF GitHub Bot commented on FLINK-1984: --- Github user tillrohrmann commented on a diff in the pull

[GitHub] flink pull request #2315: [FLINK-1984] Integrate Flink with Apache Mesos (T1...

2016-08-16 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/2315#discussion_r74947651 --- Diff: flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/MesosApplicationMasterRunner.java --- @@ -0,0 +1,618 @@ +/*

[jira] [Commented] (FLINK-1984) Integrate Flink with Apache Mesos

2016-08-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15422814#comment-15422814 ] ASF GitHub Bot commented on FLINK-1984: --- Github user tillrohrmann commented on a diff in the pull

[jira] [Commented] (FLINK-1984) Integrate Flink with Apache Mesos

2016-08-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15422823#comment-15422823 ] ASF GitHub Bot commented on FLINK-1984: --- Github user tillrohrmann commented on a diff in the pull

[GitHub] flink pull request #2315: [FLINK-1984] Integrate Flink with Apache Mesos (T1...

2016-08-16 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/2315#discussion_r74949669 --- Diff: flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/MesosApplicationMasterRunner.java --- @@ -0,0 +1,618 @@ +/*

[GitHub] flink pull request #2315: [FLINK-1984] Integrate Flink with Apache Mesos (T1...

2016-08-16 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/2315#discussion_r74948145 --- Diff: flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/MesosApplicationMasterRunner.java --- @@ -0,0 +1,618 @@ +/*

[GitHub] flink pull request #2315: [FLINK-1984] Integrate Flink with Apache Mesos (T1...

2016-08-16 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/2315#discussion_r74950002 --- Diff: flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/MesosApplicationMasterRunner.java --- @@ -0,0 +1,618 @@ +/*

[jira] [Commented] (FLINK-1984) Integrate Flink with Apache Mesos

2016-08-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15422833#comment-15422833 ] ASF GitHub Bot commented on FLINK-1984: --- Github user tillrohrmann commented on a diff in the pull

[GitHub] flink pull request #2315: [FLINK-1984] Integrate Flink with Apache Mesos (T1...

2016-08-16 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/2315#discussion_r74950095 --- Diff: flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/MesosApplicationMasterRunner.java --- @@ -0,0 +1,618 @@ +/*

[jira] [Created] (FLINK-4400) Leadership Election among JobManagers

2016-08-16 Thread Xiaogang Shi (JIRA)
Xiaogang Shi created FLINK-4400: --- Summary: Leadership Election among JobManagers Key: FLINK-4400 URL: https://issues.apache.org/jira/browse/FLINK-4400 Project: Flink Issue Type: Sub-task

[jira] [Commented] (FLINK-2055) Implement Streaming HBaseSink

2016-08-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15422341#comment-15422341 ] ASF GitHub Bot commented on FLINK-2055: --- Github user delding commented on a diff in the pull

[jira] [Commented] (FLINK-4035) Bump Kafka producer in Kafka sink to Kafka 0.10.0.0

2016-08-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15422807#comment-15422807 ] ASF GitHub Bot commented on FLINK-4035: --- Github user StephanEwen commented on the issue:

[jira] [Commented] (FLINK-1984) Integrate Flink with Apache Mesos

2016-08-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15422811#comment-15422811 ] ASF GitHub Bot commented on FLINK-1984: --- Github user tillrohrmann commented on a diff in the pull

[jira] [Commented] (FLINK-1984) Integrate Flink with Apache Mesos

2016-08-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15422820#comment-15422820 ] ASF GitHub Bot commented on FLINK-1984: --- Github user tillrohrmann commented on a diff in the pull

[GitHub] flink pull request #2315: [FLINK-1984] Integrate Flink with Apache Mesos (T1...

2016-08-16 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/2315#discussion_r74948792 --- Diff: flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/MesosApplicationMasterRunner.java --- @@ -0,0 +1,618 @@ +/*

  1   2   >