[
https://issues.apache.org/jira/browse/FLINK-4743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15616101#comment-15616101
]
ASF GitHub Bot commented on FLINK-4743:
---
GitHub user tonycox reopened a pull request:
GitHub user tonycox reopened a pull request:
https://github.com/apache/flink/pull/2686
[FLINK-4743] The sqrt/power function not accept the real data types.
Add supporting of variety types on "power" function. Add casting for Float
and BigDecimal.
You can merge this pull request
Github user tonycox closed the pull request at:
https://github.com/apache/flink/pull/2686
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
[
https://issues.apache.org/jira/browse/FLINK-4743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15616097#comment-15616097
]
ASF GitHub Bot commented on FLINK-4743:
---
Github user tonycox closed the pull request at:
[
https://issues.apache.org/jira/browse/FLINK-4963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15616195#comment-15616195
]
ASF GitHub Bot commented on FLINK-4963:
---
GitHub user greghogan opened a pull request:
GitHub user greghogan opened a pull request:
https://github.com/apache/flink/pull/2725
[FLINK-4963] [gelly] Tabulate edge direction for directed VertexMetrics
The current implementation simply counts edges. We can do one better and
tabulate unidirectional (u:v but no v:u) and
[
https://issues.apache.org/jira/browse/FLINK-4743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15615807#comment-15615807
]
ASF GitHub Bot commented on FLINK-4743:
---
Github user wuchong commented on the issue:
Github user wuchong commented on the issue:
https://github.com/apache/flink/pull/2686
Hi @fhueske @tonycox , the PR is really good.
But I think the true reason of this issue is because the
`BuiltInMethods.POWER_DEC` is bound to a wrong method, which should be
`power(double,
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/2699
Thanks for the review @StephanEwen. You're right that I should have tested
the changes on a cluster to make sure that things are actually working. I'll
address your comments and then run jobs
[
https://issues.apache.org/jira/browse/FLINK-4887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15615868#comment-15615868
]
ASF GitHub Bot commented on FLINK-4887:
---
Github user tillrohrmann commented on a diff in the pull
[
https://issues.apache.org/jira/browse/FLINK-4887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15615871#comment-15615871
]
ASF GitHub Bot commented on FLINK-4887:
---
Github user tillrohrmann commented on the issue:
[
https://issues.apache.org/jira/browse/FLINK-4887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15615867#comment-15615867
]
ASF GitHub Bot commented on FLINK-4887:
---
Github user tillrohrmann commented on a diff in the pull
[
https://issues.apache.org/jira/browse/FLINK-4962?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jark Wu updated FLINK-4962:
---
Summary: Improve exception information about operand type inference failure
during UDF SQL validation (was:
[
https://issues.apache.org/jira/browse/FLINK-4604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15615730#comment-15615730
]
Fabian Hueske commented on FLINK-4604:
--
Hi [~anmu], thanks for digging into this.
Regarding the
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2699#discussion_r85562718
--- Diff: flink-tests/src/test/resources/log4j-test.properties ---
@@ -18,7 +18,7 @@
# Set root logger level to OFF to not flood build logs
Github user wuchong commented on the issue:
https://github.com/apache/flink/pull/2686
According to the question mentioned in the dev mailing. I prefer to
approach 2). POWER only works on double. And `power(double, BigDecimal)` is
only used to support `SQRT(double)` which is actually
[
https://issues.apache.org/jira/browse/FLINK-4887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15615835#comment-15615835
]
ASF GitHub Bot commented on FLINK-4887:
---
Github user tillrohrmann commented on a diff in the pull
Greg Hogan created FLINK-4963:
-
Summary: Tabulate edge direction for directed VertexMetrics
Key: FLINK-4963
URL: https://issues.apache.org/jira/browse/FLINK-4963
Project: Flink
Issue Type:
GitHub user rmetzger opened a pull request:
https://github.com/apache/flink/pull/2724
[FLINK-4221] Show metrics in WebFrontend + general improvements
Other included changes:
- Removed Properties tab
- Renamed plan to overview
- Added parallelism to task list
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2691#discussion_r85570641
--- Diff:
flink-core/src/main/java/org/apache/flink/core/fs/SafetyNetCloseableRegistry.java
---
@@ -0,0 +1,181 @@
+/*
+ * Licensed to the
[
https://issues.apache.org/jira/browse/FLINK-4910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15615957#comment-15615957
]
ASF GitHub Bot commented on FLINK-4910:
---
Github user tillrohrmann commented on a diff in the pull
[
https://issues.apache.org/jira/browse/FLINK-4469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15615695#comment-15615695
]
Fabian Hueske commented on FLINK-4469:
--
Thanks [~jark], this is great news!
How do we continue with
[
https://issues.apache.org/jira/browse/FLINK-4221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15615958#comment-15615958
]
ASF GitHub Bot commented on FLINK-4221:
---
GitHub user rmetzger opened a pull request:
[
https://issues.apache.org/jira/browse/FLINK-4743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15615980#comment-15615980
]
ASF GitHub Bot commented on FLINK-4743:
---
Github user tonycox commented on the issue:
Github user tonycox commented on the issue:
https://github.com/apache/flink/pull/2686
Hi @wuchong
I agree that users can cast types manually. And that
BuiltInMethods.POWER_DEC should be bound power(double, BigDecimal), but it's
trouble of Calcite
[
https://issues.apache.org/jira/browse/FLINK-4743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15615842#comment-15615842
]
ASF GitHub Bot commented on FLINK-4743:
---
Github user wuchong commented on the issue:
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2699#discussion_r85564343
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/messages/StackTraceSampleResponse.java
---
@@ -0,0 +1,57 @@
+/*
+ * Licensed to
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2699#discussion_r85564373
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/messages/StackTrace.java
---
@@ -0,0 +1,41 @@
+/*
+ * Licensed to the Apache
[
https://issues.apache.org/jira/browse/FLINK-4221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15616494#comment-15616494
]
ASF GitHub Bot commented on FLINK-4221:
---
Github user zentol commented on a diff in the pull request:
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2724#discussion_r85606565
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/graph/StreamingJobGraphGenerator.java
---
@@ -383,25 +384,28 @@ private void
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2724#discussion_r85604825
--- Diff: flink-runtime-web/web-dashboard/app/scripts/index.coffee ---
@@ -39,6 +39,8 @@ angular.module('flinkApp', ['ui.router', 'angularMoment'])
.run
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2724#discussion_r85604628
--- Diff:
flink-examples/flink-examples-streaming/src/main/java/org/apache/flink/streaming/examples/socket/SocketWindowWordCount.java
---
@@ -30,7 +30,7 @@
[
https://issues.apache.org/jira/browse/FLINK-4221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15616493#comment-15616493
]
ASF GitHub Bot commented on FLINK-4221:
---
Github user zentol commented on a diff in the pull request:
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2718#discussion_r85523016
--- Diff:
flink-tests/src/test/java/org/apache/flink/test/checkpointing/TimestampedFileInputSplitTest.java
---
@@ -90,4 +112,60 @@ public void
Aljoscha Krettek created FLINK-4959:
---
Summary: Write Documentation for Timely FlatMap Functions
Key: FLINK-4959
URL: https://issues.apache.org/jira/browse/FLINK-4959
Project: Flink
Issue
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/2715
@manuzhang I added some more fixes because I realised some more stuff is
missing. If you want to have a look. (You don't have to, just FYI.)
---
If your project is set up for it, you can reply to
Github user kl0u commented on the issue:
https://github.com/apache/flink/pull/2718
@mxm I agree and I am planning to do it as soon as we fix some other design
issues with the ContinuousFileReadOperator that concern rescaling. Thanks for
the review.
---
If your project is set up for
[
https://issues.apache.org/jira/browse/FLINK-4713?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gábor Hermann reassigned FLINK-4713:
Assignee: Gábor Hermann
> Implementing ranking evaluation scores for recommender systems
>
[
https://issues.apache.org/jira/browse/FLINK-4621?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jark Wu updated FLINK-4621:
---
Assignee: (was: Jark Wu)
> Improve decimal literals of SQL API
> ---
>
>
[
https://issues.apache.org/jira/browse/FLINK-4886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15614709#comment-15614709
]
ASF GitHub Bot commented on FLINK-4886:
---
Github user thvasilo commented on the issue:
[
https://issues.apache.org/jira/browse/FLINK-4469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15614425#comment-15614425
]
Jark Wu commented on FLINK-4469:
Hi all,
I have proposed CROSS/OUTER APPLY syntax to Calcite community.
Manu Zhang created FLINK-4953:
-
Summary: Allow querying time in window functions
Key: FLINK-4953
URL: https://issues.apache.org/jira/browse/FLINK-4953
Project: Flink
Issue Type: Improvement
[
https://issues.apache.org/jira/browse/FLINK-4850?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Theodore Vasiloudis updated FLINK-4850:
---
Priority: Minor (was: Major)
> FlinkML - SVM predict Operation for Vector and not
[
https://issues.apache.org/jira/browse/FLINK-4378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15614834#comment-15614834
]
ASF GitHub Bot commented on FLINK-4378:
---
Github user aljoscha commented on the issue:
[
https://issues.apache.org/jira/browse/FLINK-4787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15614843#comment-15614843
]
ASF GitHub Bot commented on FLINK-4787:
---
Github user asfgit closed the pull request at:
[
https://issues.apache.org/jira/browse/FLINK-4378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15614845#comment-15614845
]
ASF GitHub Bot commented on FLINK-4378:
---
Github user wenlong88 closed the pull request at:
[
https://issues.apache.org/jira/browse/FLINK-4787?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ufuk Celebi closed FLINK-4787.
--
Resolution: Implemented
Fix Version/s: 1.2.0
Implemented in 3bc9cad (master).
> Add REST API
[
https://issues.apache.org/jira/browse/FLINK-4552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15614926#comment-15614926
]
ASF GitHub Bot commented on FLINK-4552:
---
Github user aljoscha commented on a diff in the pull
Github user StefanRRichter commented on the issue:
https://github.com/apache/flink/pull/2572
My idea would be to introduce an adapter that abstracts advancing of time,
where two concrete implementations exist that forward to advanceWatermark or on
onProcessingTime. Or am I missing
[
https://issues.apache.org/jira/browse/FLINK-4932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15614981#comment-15614981
]
ASF GitHub Bot commented on FLINK-4932:
---
GitHub user tillrohrmann opened a pull request:
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/2572
No, it's more or less that but there is more stuff that needs to be in that
adapter, for example in `testOnProcessingTimeFire()`, I'm highlighting the
places that need changing:
```
GitHub user tillrohrmann opened a pull request:
https://github.com/apache/flink/pull/2711
[backport] [FLINK-4932] [exec graph] Failing in state RESTARTING only fails
the EG if no more restarts are possible
This PR is a backport of #2710 for the release-1.1 branch.
If in
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/2572
Yeah, alright, I'm just lazy. ð
I'll whip something up.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
[
https://issues.apache.org/jira/browse/FLINK-4469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15615002#comment-15615002
]
Shaoxuan Wang commented on FLINK-4469:
--
Hi Jark,
Sounds good to me. Can you please update the Jira
[
https://issues.apache.org/jira/browse/FLINK-4733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15614772#comment-15614772
]
ASF GitHub Bot commented on FLINK-4733:
---
Github user zentol commented on the issue:
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/2616
The `CoordinatorShutdownTest` can't be fixed with a cast. This test assumes
that the actual ExecutionGraph is still available when a job is finished since
it tries to access the CheckpointCoordinator
[
https://issues.apache.org/jira/browse/FLINK-4925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15614862#comment-15614862
]
ASF GitHub Bot commented on FLINK-4925:
---
Github user asfgit closed the pull request at:
[
https://issues.apache.org/jira/browse/FLINK-4552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15614891#comment-15614891
]
ASF GitHub Bot commented on FLINK-4552:
---
Github user aljoscha commented on a diff in the pull
[
https://issues.apache.org/jira/browse/FLINK-4552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15614896#comment-15614896
]
ASF GitHub Bot commented on FLINK-4552:
---
Github user aljoscha commented on a diff in the pull
Github user wenlong88 closed the pull request at:
https://github.com/apache/flink/pull/2356
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/2626
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
[
https://issues.apache.org/jira/browse/FLINK-4552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15614940#comment-15614940
]
ASF GitHub Bot commented on FLINK-4552:
---
Github user StefanRRichter commented on the issue:
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/2709
+1 to merge
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/2572#discussion_r85500578
--- Diff:
flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/operators/windowing/PurgingTriggerTest.java
---
@@ -0,0 +1,149 @@
+/*
Github user StefanRRichter commented on the issue:
https://github.com/apache/flink/pull/2572
Yes, I was aware that some configuration/mocking also depends on the time
domain. However what those calls do is essentially equivalent, just for
different time domain. So I assume an adapter
Github user StefanRRichter commented on the issue:
https://github.com/apache/flink/pull/2572
Yeah, I know the pain ;-) but next times when we need to fix only half the
amount of tests on a change it will quickly pay off (hopefully)
---
If your project is set up for it, you can reply
[
https://issues.apache.org/jira/browse/FLINK-4733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15614739#comment-15614739
]
ASF GitHub Bot commented on FLINK-4733:
---
Github user zentol commented on the issue:
Github user thvasilo commented on the issue:
https://github.com/apache/flink/pull/2682
Thank you @ch33hau I'll also mark the issue as a duplicate!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
[
https://issues.apache.org/jira/browse/FLINK-4378?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aljoscha Krettek resolved FLINK-4378.
-
Resolution: Fixed
Fix Version/s: 1.2.0
Implemented in
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/2616
Both issues should be fixed now, but I'll let travis take another stab at
it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
[
https://issues.apache.org/jira/browse/FLINK-4733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15614841#comment-15614841
]
ASF GitHub Bot commented on FLINK-4733:
---
Github user zentol commented on the issue:
[
https://issues.apache.org/jira/browse/FLINK-4925?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chesnay Schepler closed FLINK-4925.
---
Resolution: Fixed
Implemented in a582882dae125da2c4cef249428371c37fd64c53
> Integrate meters
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/2694
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/2572#discussion_r85497817
--- Diff:
flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/operators/windowing/CountTriggerTest.java
---
@@ -0,0 +1,123 @@
+/*
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/2572#discussion_r85499215
--- Diff:
flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/operators/windowing/EventTimeSessionWindowsWindowsTest.java
---
@@ -0,0
[
https://issues.apache.org/jira/browse/FLINK-4552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15614932#comment-15614932
]
ASF GitHub Bot commented on FLINK-4552:
---
Github user StefanRRichter commented on a diff in the pull
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/2572#discussion_r85500759
--- Diff:
flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/operators/windowing/TriggerTestHarness.java
---
@@ -0,0 +1,369 @@
+/*
[
https://issues.apache.org/jira/browse/FLINK-4552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15614930#comment-15614930
]
ASF GitHub Bot commented on FLINK-4552:
---
Github user aljoscha commented on the issue:
GitHub user chermenin opened a pull request:
https://github.com/apache/flink/pull/2709
[FLINK-4631] Avoided NPE in OneInputStreamTask.
Added additional condition to check possible NPE. This PR solve
[FLINK-4631](https://issues.apache.org/jira/browse/FLINK-4631).
You can merge this
[
https://issues.apache.org/jira/browse/FLINK-4631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15614952#comment-15614952
]
ASF GitHub Bot commented on FLINK-4631:
---
Github user zentol commented on the issue:
[
https://issues.apache.org/jira/browse/FLINK-4552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15614968#comment-15614968
]
ASF GitHub Bot commented on FLINK-4552:
---
Github user aljoscha commented on the issue:
[
https://issues.apache.org/jira/browse/FLINK-4932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15614985#comment-15614985
]
ASF GitHub Bot commented on FLINK-4932:
---
GitHub user tillrohrmann opened a pull request:
GitHub user tillrohrmann opened a pull request:
https://github.com/apache/flink/pull/2710
[FLINK-4932] [exec graph] Failing in state RESTARTING only fails the EG if
no more restarts are possible
If in state RESTARTING a failure occurs (`ExecutionGraph.fail` is called),
then a new
[
https://issues.apache.org/jira/browse/FLINK-4552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15614993#comment-15614993
]
ASF GitHub Bot commented on FLINK-4552:
---
Github user aljoscha commented on the issue:
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/2616
I just found another bug related to forked-chains. Right now only the
output of a single operator is used as the task output counter, where as we
should actually use both of them. Will fix it while
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/2356
I merged it. ð Could you please close this PR?
I changed `setHDFSConfig()` to `setFSConfig` to reflect the fact that a
`FileSystem` is not necessarily used only for HDFS, I hope that's
[
https://issues.apache.org/jira/browse/FLINK-4378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15614852#comment-15614852
]
ASF GitHub Bot commented on FLINK-4378:
---
Github user wenlong88 commented on the issue:
[
https://issues.apache.org/jira/browse/FLINK-4552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15614881#comment-15614881
]
ASF GitHub Bot commented on FLINK-4552:
---
Github user aljoscha commented on a diff in the pull
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/2572#discussion_r85498801
--- Diff:
flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/operators/windowing/CountTriggerTest.java
---
@@ -0,0 +1,123 @@
+/*
[
https://issues.apache.org/jira/browse/FLINK-4552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15614919#comment-15614919
]
ASF GitHub Bot commented on FLINK-4552:
---
Github user aljoscha commented on a diff in the pull
[
https://issues.apache.org/jira/browse/FLINK-4552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15614917#comment-15614917
]
ASF GitHub Bot commented on FLINK-4552:
---
Github user aljoscha commented on a diff in the pull
[
https://issues.apache.org/jira/browse/FLINK-4631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15614920#comment-15614920
]
ASF GitHub Bot commented on FLINK-4631:
---
GitHub user chermenin opened a pull request:
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/2572#discussion_r85500442
--- Diff:
flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/operators/windowing/EventTimeTriggerTest.java
---
@@ -0,0 +1,153 @@
+/*
[
https://issues.apache.org/jira/browse/FLINK-4552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15614973#comment-15614973
]
ASF GitHub Bot commented on FLINK-4552:
---
Github user StefanRRichter commented on the issue:
[
https://issues.apache.org/jira/browse/FLINK-4552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15615000#comment-15615000
]
ASF GitHub Bot commented on FLINK-4552:
---
Github user StefanRRichter commented on the issue:
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/2572#discussion_r85501090
--- Diff:
flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/operators/windowing/TriggerTestHarness.java
---
@@ -0,0 +1,369 @@
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/2572
Thanks for your review, @StefanRRichter! You found some areas where this
can be improved.
I'm not yet sure whether parameterisation for processing-time/event-time
can be done without
[
https://issues.apache.org/jira/browse/FLINK-4958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15615382#comment-15615382
]
ASF GitHub Bot commented on FLINK-4958:
---
GitHub user tillrohrmann opened a pull request:
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2650#discussion_r85533745
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/metrics/groups/AbstractMetricGroup.java
---
@@ -85,9 +86,12 @@
* For example
[
https://issues.apache.org/jira/browse/FLINK-4563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15615479#comment-15615479
]
ASF GitHub Bot commented on FLINK-4563:
---
Github user zentol commented on the issue:
1 - 100 of 180 matches
Mail list logo
