[jira] [Commented] (FLINK-5801) Queryable State from Scala job/client fails with key of type Long

2017-02-15 Thread Ufuk Celebi (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15867418#comment-15867418 ] Ufuk Celebi commented on FLINK-5801: Thanks for reporting this. I will look into this

[jira] [Assigned] (FLINK-5801) Queryable State from Scala job/client fails with key of type Long

2017-02-15 Thread Ufuk Celebi (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5801?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ufuk Celebi reassigned FLINK-5801: -- Assignee: Ufuk Celebi > Queryable State from Scala job/client fails with key of type Long > ---

[GitHub] flink issue #3315: Release 1.2.0 rc3

2017-02-15 Thread uce
Github user uce commented on the issue: https://github.com/apache/flink/pull/3315 I think this PR was a mistake? If so, could you please close it? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[jira] [Commented] (FLINK-5796) broken links in the docs

2017-02-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15867422#comment-15867422 ] ASF GitHub Bot commented on FLINK-5796: --- Github user uce commented on the issue:

[GitHub] flink issue #3308: [FLINK-5796] fix some broken links in the docs

2017-02-15 Thread uce
Github user uce commented on the issue: https://github.com/apache/flink/pull/3308 Thanks for the PR, I'll merge this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[jira] [Closed] (FLINK-5036) Perform the grouping of keys in restoring instead of checkpointing

2017-02-15 Thread Xiaogang Shi (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5036?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xiaogang Shi closed FLINK-5036. --- Resolution: Invalid > Perform the grouping of keys in restoring instead of checkpointing > ---

[GitHub] flink pull request #3315: Release 1.2.0 rc3

2017-02-15 Thread xiaorui123
Github user xiaorui123 closed the pull request at: https://github.com/apache/flink/pull/3315 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (FLINK-5802) Flink SQL calling Hive User-Defined Functions

2017-02-15 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15867437#comment-15867437 ] Fabian Hueske commented on FLINK-5802: -- Thanks for opening this issue [~clarkyzl]. I

[GitHub] flink pull request #3316: [FLINK-5771] [core] Fix multi-char delimiter detec...

2017-02-15 Thread fhueske
GitHub user fhueske opened a pull request: https://github.com/apache/flink/pull/3316 [FLINK-5771] [core] Fix multi-char delimiter detection in DelimitedInputFormat Fix multi-char delimiter detection in DelimitedInputFormat. - Add a test case to validate correct delimiter de

[jira] [Commented] (FLINK-5771) DelimitedInputFormat does not correctly handle multi-byte delimiters

2017-02-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15867454#comment-15867454 ] ASF GitHub Bot commented on FLINK-5771: --- GitHub user fhueske opened a pull request:

[GitHub] flink pull request #2509: [FLINK-4280][kafka-connector] Explicit start posit...

2017-02-15 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/2509#discussion_r101231413 --- Diff: flink-connectors/flink-connector-kafka-base/src/test/java/org/apache/flink/streaming/connectors/kafka/KafkaConsumerTestBase.java --- @@ -633,7 +6

[jira] [Commented] (FLINK-4280) New Flink-specific option to set starting position of Kafka consumer without respecting external offsets in ZK / Broker

2017-02-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15867506#comment-15867506 ] ASF GitHub Bot commented on FLINK-4280: --- Github user rmetzger commented on a diff in

[GitHub] flink issue #3308: [FLINK-5796] fix some broken links in the docs

2017-02-15 Thread rmetzger
Github user rmetzger commented on the issue: https://github.com/apache/flink/pull/3308 Nice, thank you! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[jira] [Commented] (FLINK-5796) broken links in the docs

2017-02-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15867509#comment-15867509 ] ASF GitHub Bot commented on FLINK-5796: --- Github user rmetzger commented on the issue

[jira] [Commented] (FLINK-4280) New Flink-specific option to set starting position of Kafka consumer without respecting external offsets in ZK / Broker

2017-02-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15867521#comment-15867521 ] ASF GitHub Bot commented on FLINK-4280: --- Github user tzulitai commented on a diff in

[GitHub] flink pull request #2509: [FLINK-4280][kafka-connector] Explicit start posit...

2017-02-15 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/2509#discussion_r101233499 --- Diff: flink-connectors/flink-connector-kafka-base/src/test/java/org/apache/flink/streaming/connectors/kafka/KafkaConsumerTestBase.java --- @@ -633,7 +6

[GitHub] flink pull request #3273: [FLINK-5714] [table] Use a builder pattern for cre...

2017-02-15 Thread KurtYoung
Github user KurtYoung commented on a diff in the pull request: https://github.com/apache/flink/pull/3273#discussion_r101234016 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/sources/CsvTableSource.scala --- @@ -266,11 +266,16 @@ object CsvTableSource {

[jira] [Commented] (FLINK-5714) Use a builder pattern for creating CsvTableSource

2017-02-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15867526#comment-15867526 ] ASF GitHub Bot commented on FLINK-5714: --- Github user KurtYoung commented on a diff i

[jira] [Assigned] (FLINK-5070) Unable to use Scala's BeanProperty with classes

2017-02-15 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5070?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timo Walther reassigned FLINK-5070: --- Assignee: Timo Walther > Unable to use Scala's BeanProperty with classes > --

[jira] [Commented] (FLINK-5657) Add processing time OVER RANGE BETWEEN UNBOUNDED PRECEDING aggregation to SQL

2017-02-15 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15867541#comment-15867541 ] Fabian Hueske commented on FLINK-5657: -- Unfortunately, JIRA does not support nested s

[GitHub] flink pull request #3149: FLINK-2168 Add HBaseTableSource

2017-02-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/3149 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[jira] [Commented] (FLINK-2168) Add HBaseTableSource

2017-02-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15867546#comment-15867546 ] ASF GitHub Bot commented on FLINK-2168: --- Github user asfgit closed the pull request

[jira] [Closed] (FLINK-2168) Add HBaseTableSource

2017-02-15 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2168?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fabian Hueske closed FLINK-2168. Resolution: Implemented Fix Version/s: 1.3.0 Thanks for implementing this features [~ram_kris

[jira] [Created] (FLINK-5805) improve docs for ProcessFunction

2017-02-15 Thread David Anderson (JIRA)
David Anderson created FLINK-5805: - Summary: improve docs for ProcessFunction Key: FLINK-5805 URL: https://issues.apache.org/jira/browse/FLINK-5805 Project: Flink Issue Type: Improvement

[jira] [Assigned] (FLINK-5805) improve docs for ProcessFunction

2017-02-15 Thread David Anderson (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5805?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Anderson reassigned FLINK-5805: - Assignee: David Anderson > improve docs for ProcessFunction > ---

[GitHub] flink issue #3305: [FLINK-5790][StateBackend] Use list types when ListStateD...

2017-02-15 Thread tillrohrmann
Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/3305 Given our current usage where the `TypeInformation` is no longer a sole API concept and we already keep most of the type informations in `flink-core`, I think it is a good idea to add `ListTypeI

[jira] [Commented] (FLINK-5790) Use list types when ListStateDescriptor extends StateDescriptor

2017-02-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15867570#comment-15867570 ] ASF GitHub Bot commented on FLINK-5790: --- Github user tillrohrmann commented on the i

[jira] [Commented] (FLINK-5802) Flink SQL calling Hive User-Defined Functions

2017-02-15 Thread Zhuoluo Yang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15867574#comment-15867574 ] Zhuoluo Yang commented on FLINK-5802: - Hi [~fhueske]. Thank you for your comment. I ag

[GitHub] flink issue #3305: [FLINK-5790][StateBackend] Use list types when ListStateD...

2017-02-15 Thread shixiaogang
Github user shixiaogang commented on the issue: https://github.com/apache/flink/pull/3305 @tillrohrmann Both `org.apache.flink.api.common.typeutils.base` and `"org.apache.flink.api.common.typeinfo` are in the module `flink-core`. --- If your project is set up for it, you can reply t

[jira] [Updated] (FLINK-5773) Cannot cast scala.util.Failure to org.apache.flink.runtime.messages.Acknowledge

2017-02-15 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5773?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann updated FLINK-5773: - Component/s: (was: DataStream API) Distributed Coordination > Cannot cast sca

[jira] [Updated] (FLINK-5773) Cannot cast scala.util.Failure to org.apache.flink.runtime.messages.Acknowledge

2017-02-15 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5773?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann updated FLINK-5773: - Affects Version/s: 1.3.0 > Cannot cast scala.util.Failure to > org.apache.flink.runtime.messages.

[jira] [Commented] (FLINK-5790) Use list types when ListStateDescriptor extends StateDescriptor

2017-02-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15867575#comment-15867575 ] ASF GitHub Bot commented on FLINK-5790: --- Github user shixiaogang commented on the is

[jira] [Updated] (FLINK-5773) Cannot cast scala.util.Failure to org.apache.flink.runtime.messages.Acknowledge

2017-02-15 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5773?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann updated FLINK-5773: - Fix Version/s: 1.3.0 > Cannot cast scala.util.Failure to > org.apache.flink.runtime.messages.Ackn

[GitHub] flink issue #2509: [FLINK-4280][kafka-connector] Explicit start position con...

2017-02-15 Thread tzulitai
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/2509 Last commit addresses consolidating the deserliazer settings for `KafkaOffsetHandlerImpl`. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[jira] [Commented] (FLINK-4280) New Flink-specific option to set starting position of Kafka consumer without respecting external offsets in ZK / Broker

2017-02-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15867580#comment-15867580 ] ASF GitHub Bot commented on FLINK-4280: --- Github user tzulitai commented on the issue

[GitHub] flink pull request #3317: [FLINK-5805] improvements to docs for ProcessFunct...

2017-02-15 Thread alpinegizmo
GitHub user alpinegizmo opened a pull request: https://github.com/apache/flink/pull/3317 [FLINK-5805] improvements to docs for ProcessFunction I added a paragraph to hopefully clarify why ProcessFunction is relevant to joins. I also tried to clean up a few places where the English w

[jira] [Commented] (FLINK-5805) improve docs for ProcessFunction

2017-02-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15867578#comment-15867578 ] ASF GitHub Bot commented on FLINK-5805: --- GitHub user alpinegizmo opened a pull reque

[GitHub] flink pull request #3318: [FLINK-5070] [types] Unable to use Scala's BeanPro...

2017-02-15 Thread twalthr
GitHub user twalthr opened a pull request: https://github.com/apache/flink/pull/3318 [FLINK-5070] [types] Unable to use Scala's BeanProperty with classes This PR fixes issues with `@BeanProperty` annotation. The problem is that `var` generates Scala-style getters/setters and the ann

[jira] [Commented] (FLINK-5070) Unable to use Scala's BeanProperty with classes

2017-02-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15867581#comment-15867581 ] ASF GitHub Bot commented on FLINK-5070: --- GitHub user twalthr opened a pull request:

[jira] [Assigned] (FLINK-5802) Flink SQL calling Hive User-Defined Functions

2017-02-15 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5802?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fabian Hueske reassigned FLINK-5802: Assignee: Zhuoluo Yang > Flink SQL calling Hive User-Defined Functions > --

[jira] [Commented] (FLINK-5802) Flink SQL calling Hive User-Defined Functions

2017-02-15 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15867592#comment-15867592 ] Fabian Hueske commented on FLINK-5802: -- Hi [~clarkyzl], sure. I gave you contributor

[jira] [Closed] (FLINK-5745) Set uncaught exception handler for Netty threads

2017-02-15 Thread Ufuk Celebi (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5745?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ufuk Celebi closed FLINK-5745. -- Resolution: Fixed Fix Version/s: 1.3.0 Fixed in 9b4cd34 (release-1.2). > Set uncaught exception

[GitHub] flink pull request #3293: [FLINK-5745] set an uncaught exception handler for...

2017-02-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/3293 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[jira] [Commented] (FLINK-5745) Set uncaught exception handler for Netty threads

2017-02-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15867609#comment-15867609 ] ASF GitHub Bot commented on FLINK-5745: --- Github user asfgit closed the pull request

[GitHub] flink pull request #3308: [FLINK-5796] fix some broken links in the docs

2017-02-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/3308 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[jira] [Commented] (FLINK-5796) broken links in the docs

2017-02-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15867612#comment-15867612 ] ASF GitHub Bot commented on FLINK-5796: --- Github user asfgit closed the pull request

[jira] [Commented] (FLINK-5802) Flink SQL calling Hive User-Defined Functions

2017-02-15 Thread Zhuoluo Yang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15867625#comment-15867625 ] Zhuoluo Yang commented on FLINK-5802: - Sure. [~fhueske]. Thank you so much. I also wou

[jira] [Closed] (FLINK-5796) broken links in the docs

2017-02-15 Thread Ufuk Celebi (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5796?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ufuk Celebi closed FLINK-5796. -- Resolution: Fixed Fix Version/s: 1.2.0 1.3.0 Fixed 8368681 (release-1.2), ded7

[jira] [Commented] (FLINK-5624) Support tumbling window on streaming tables in the SQL API

2017-02-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15867643#comment-15867643 ] ASF GitHub Bot commented on FLINK-5624: --- Github user fhueske commented on a diff in

[GitHub] flink pull request #3252: [FLINK-5624] Support tumbling window on streaming ...

2017-02-15 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3252#discussion_r101248097 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/rules/datastream/LogicalWindowAggregateRule.scala --- @@ -0,0 +1,139 @@

[GitHub] flink pull request #3252: [FLINK-5624] Support tumbling window on streaming ...

2017-02-15 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3252#discussion_r101239149 --- Diff: flink-libraries/flink-table/src/test/java/org/apache/flink/table/api/java/stream/sql/WindowAggregateITCase.java --- @@ -0,0 +1,135 @@ +/*

[jira] [Commented] (FLINK-5624) Support tumbling window on streaming tables in the SQL API

2017-02-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15867642#comment-15867642 ] ASF GitHub Bot commented on FLINK-5624: --- Github user fhueske commented on a diff in

[GitHub] flink pull request #3305: [FLINK-5790][StateBackend] Use list types when Lis...

2017-02-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/3305 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[jira] [Commented] (FLINK-5790) Use list types when ListStateDescriptor extends StateDescriptor

2017-02-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15867724#comment-15867724 ] ASF GitHub Bot commented on FLINK-5790: --- Github user asfgit closed the pull request

[jira] [Created] (FLINK-5806) TaskExecutionState toString format have wrong key

2017-02-15 Thread shijinkui (JIRA)
shijinkui created FLINK-5806: Summary: TaskExecutionState toString format have wrong key Key: FLINK-5806 URL: https://issues.apache.org/jira/browse/FLINK-5806 Project: Flink Issue Type: Bug

[GitHub] flink pull request #3319: [FLINK-5806] TaskExecutionState toString format ha...

2017-02-15 Thread shijinkui
GitHub user shijinkui opened a pull request: https://github.com/apache/flink/pull/3319 [FLINK-5806] TaskExecutionState toString format have wrong key The key of jobID should be executionId in the string format. - [X] General - The pull request references the related JI

[jira] [Commented] (FLINK-5806) TaskExecutionState toString format have wrong key

2017-02-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15867748#comment-15867748 ] ASF GitHub Bot commented on FLINK-5806: --- GitHub user shijinkui opened a pull request

[GitHub] flink pull request #3176: [FLINK-5571] [table] add open and close methods fo...

2017-02-15 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/3176#discussion_r101247688 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/CodeGenerator.scala --- @@ -220,56 +247,105 @@ class CodeGenerator(

[GitHub] flink pull request #3176: [FLINK-5571] [table] add open and close methods fo...

2017-02-15 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/3176#discussion_r101246957 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/CodeGenerator.scala --- @@ -122,6 +123,18 @@ class CodeGenerator(

[GitHub] flink pull request #3176: [FLINK-5571] [table] add open and close methods fo...

2017-02-15 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/3176#discussion_r101265088 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/UDFContext.scala --- @@ -0,0 +1,53 @@ +/* + * Licensed to the

[GitHub] flink pull request #3176: [FLINK-5571] [table] add open and close methods fo...

2017-02-15 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/3176#discussion_r101249809 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/UDFContext.scala --- @@ -0,0 +1,53 @@ +/* + * Licensed to the

[GitHub] flink pull request #3176: [FLINK-5571] [table] add open and close methods fo...

2017-02-15 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/3176#discussion_r101265531 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/UserDefinedFunction.scala --- @@ -24,4 +24,19 @@ package org.apache.fl

[GitHub] flink pull request #3176: [FLINK-5571] [table] add open and close methods fo...

2017-02-15 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/3176#discussion_r101248702 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/UDFContext.scala --- @@ -0,0 +1,53 @@ +/* + * Licensed to the

[jira] [Commented] (FLINK-5571) add open and close methods for UserDefinedFunction in TableAPI & SQL

2017-02-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15867769#comment-15867769 ] ASF GitHub Bot commented on FLINK-5571: --- Github user twalthr commented on a diff in

[jira] [Commented] (FLINK-5571) add open and close methods for UserDefinedFunction in TableAPI & SQL

2017-02-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15867766#comment-15867766 ] ASF GitHub Bot commented on FLINK-5571: --- Github user twalthr commented on a diff in

[jira] [Created] (FLINK-5807) improved wording for doc home page

2017-02-15 Thread David Anderson (JIRA)
David Anderson created FLINK-5807: - Summary: improved wording for doc home page Key: FLINK-5807 URL: https://issues.apache.org/jira/browse/FLINK-5807 Project: Flink Issue Type: Improvement

[jira] [Commented] (FLINK-5571) add open and close methods for UserDefinedFunction in TableAPI & SQL

2017-02-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15867767#comment-15867767 ] ASF GitHub Bot commented on FLINK-5571: --- Github user twalthr commented on a diff in

[jira] [Commented] (FLINK-5571) add open and close methods for UserDefinedFunction in TableAPI & SQL

2017-02-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15867768#comment-15867768 ] ASF GitHub Bot commented on FLINK-5571: --- Github user twalthr commented on a diff in

[jira] [Commented] (FLINK-5571) add open and close methods for UserDefinedFunction in TableAPI & SQL

2017-02-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15867770#comment-15867770 ] ASF GitHub Bot commented on FLINK-5571: --- Github user twalthr commented on a diff in

[jira] [Commented] (FLINK-5571) add open and close methods for UserDefinedFunction in TableAPI & SQL

2017-02-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15867771#comment-15867771 ] ASF GitHub Bot commented on FLINK-5571: --- Github user twalthr commented on a diff in

[jira] [Commented] (FLINK-5571) add open and close methods for UserDefinedFunction in TableAPI & SQL

2017-02-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15867772#comment-15867772 ] ASF GitHub Bot commented on FLINK-5571: --- Github user twalthr commented on a diff in

[GitHub] flink pull request #3176: [FLINK-5571] [table] add open and close methods fo...

2017-02-15 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/3176#discussion_r101269209 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/FlatMapRunner.scala --- @@ -43,10 +44,16 @@ class FlatMapRunner[IN, OUT]

[GitHub] flink pull request #3320: [FLINK-5807] improved wording for doc home page

2017-02-15 Thread alpinegizmo
GitHub user alpinegizmo opened a pull request: https://github.com/apache/flink/pull/3320 [FLINK-5807] improved wording for doc home page There is currently some awkwardness in the wording of the Migration Guide section of the home page of the docs. You can merge this pull request

[jira] [Commented] (FLINK-5807) improved wording for doc home page

2017-02-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15867776#comment-15867776 ] ASF GitHub Bot commented on FLINK-5807: --- GitHub user alpinegizmo opened a pull reque

[GitHub] flink pull request #3320: [FLINK-5807] improved wording for doc home page

2017-02-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/3320 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[jira] [Commented] (FLINK-5807) improved wording for doc home page

2017-02-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15867781#comment-15867781 ] ASF GitHub Bot commented on FLINK-5807: --- Github user asfgit closed the pull request

[jira] [Closed] (FLINK-5806) TaskExecutionState toString format have wrong key

2017-02-15 Thread Ufuk Celebi (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5806?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ufuk Celebi closed FLINK-5806. -- Resolution: Fixed Fix Version/s: 1.2.1 1.3.0 Fixed in b065226 (master), 1037ac

[GitHub] flink pull request #3319: [FLINK-5806] TaskExecutionState toString format ha...

2017-02-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/3319 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[jira] [Closed] (FLINK-5807) improved wording for doc home page

2017-02-15 Thread Ufuk Celebi (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5807?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ufuk Celebi closed FLINK-5807. -- Resolution: Fixed Fixed in d1b415b (release-1.2), 5ae9195 (master). > improved wording for doc home pag

[jira] [Commented] (FLINK-5806) TaskExecutionState toString format have wrong key

2017-02-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15867784#comment-15867784 ] ASF GitHub Bot commented on FLINK-5806: --- Github user asfgit closed the pull request

[GitHub] flink pull request #3312: [FLINK-5800] [checkpointing] Create CheckpointStea...

2017-02-15 Thread uce
Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/3312#discussion_r101271401 --- Diff: flink-streaming-java/src/test/java/org/apache/flink/streaming/util/AbstractStreamOperatorTestHarness.java --- @@ -513,7 +509,9 @@ public void notifyOf

[jira] [Commented] (FLINK-5800) Make sure that the CheckpointStreamFactory is instantiated once per operator only

2017-02-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15867791#comment-15867791 ] ASF GitHub Bot commented on FLINK-5800: --- Github user uce commented on a diff in the

[GitHub] flink pull request #3278: [FLINK-5701] [kafka] FlinkKafkaProducer should che...

2017-02-15 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/3278#discussion_r101273261 --- Diff: flink-connectors/flink-connector-kafka-base/src/test/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaProducerBaseTest.java --- @@ -88,

[jira] [Commented] (FLINK-5701) FlinkKafkaProducer should check asyncException on checkpoints

2017-02-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15867807#comment-15867807 ] ASF GitHub Bot commented on FLINK-5701: --- Github user tzulitai commented on a diff in

[GitHub] flink pull request #3278: [FLINK-5701] [kafka] FlinkKafkaProducer should che...

2017-02-15 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/3278#discussion_r101273458 --- Diff: flink-connectors/flink-connector-kafka-base/src/test/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaProducerBaseTest.java --- @@ -88,

[jira] [Commented] (FLINK-5701) FlinkKafkaProducer should check asyncException on checkpoints

2017-02-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15867809#comment-15867809 ] ASF GitHub Bot commented on FLINK-5701: --- Github user tzulitai commented on a diff in

[GitHub] flink pull request #3321: [FLINK-5773] Use akka.actor.Status.Failure class t...

2017-02-15 Thread tillrohrmann
GitHub user tillrohrmann opened a pull request: https://github.com/apache/flink/pull/3321 [FLINK-5773] Use akka.actor.Status.Failure class to send failures via AskSupport Akka's AskSupport trait requires that failures are wrapped in a akka.actor.Status.Failure to be recognized.

[jira] [Commented] (FLINK-5773) Cannot cast scala.util.Failure to org.apache.flink.runtime.messages.Acknowledge

2017-02-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15867818#comment-15867818 ] ASF GitHub Bot commented on FLINK-5773: --- GitHub user tillrohrmann opened a pull requ

[jira] [Commented] (FLINK-5701) FlinkKafkaProducer should check asyncException on checkpoints

2017-02-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15867827#comment-15867827 ] ASF GitHub Bot commented on FLINK-5701: --- Github user tzulitai commented on a diff in

[GitHub] flink pull request #3278: [FLINK-5701] [kafka] FlinkKafkaProducer should che...

2017-02-15 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/3278#discussion_r101275048 --- Diff: flink-connectors/flink-connector-kafka-base/src/test/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaProducerBaseTest.java --- @@ -88,

[jira] [Assigned] (FLINK-4813) Having flink-test-utils as a dependency outside Flink fails the build

2017-02-15 Thread Nico Kruber (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4813?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nico Kruber reassigned FLINK-4813: -- Assignee: Nico Kruber > Having flink-test-utils as a dependency outside Flink fails the build >

[jira] [Commented] (FLINK-5701) FlinkKafkaProducer should check asyncException on checkpoints

2017-02-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15867860#comment-15867860 ] ASF GitHub Bot commented on FLINK-5701: --- Github user tzulitai commented on the issue

[GitHub] flink issue #3278: [FLINK-5701] [kafka] FlinkKafkaProducer should check asyn...

2017-02-15 Thread tzulitai
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/3278 @tillrohrmann thanks for your second-pass review, the tips you mentioned were helpful. I've incoporated all of your comments except: > Maybe you could override the DummyFlinkKafkaProducer#fl

[GitHub] flink issue #3273: [FLINK-5714] [table] Use a builder pattern for creating C...

2017-02-15 Thread twalthr
Github user twalthr commented on the issue: https://github.com/apache/flink/pull/3273 Looks good to merge. Merging... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[jira] [Commented] (FLINK-5714) Use a builder pattern for creating CsvTableSource

2017-02-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15867868#comment-15867868 ] ASF GitHub Bot commented on FLINK-5714: --- Github user twalthr commented on the issue:

[GitHub] flink issue #3321: [FLINK-5773] Use akka.actor.Status.Failure class to send ...

2017-02-15 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/3321 Good fix, +1 to merge this --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and w

[jira] [Commented] (FLINK-5773) Cannot cast scala.util.Failure to org.apache.flink.runtime.messages.Acknowledge

2017-02-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15867873#comment-15867873 ] ASF GitHub Bot commented on FLINK-5773: --- Github user StephanEwen commented on the is

[GitHub] flink issue #3306: [FLINK-5793] [runtime] fix running slot may not be add to...

2017-02-15 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/3306 Thanks looks good! Merging this... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feat

[jira] [Commented] (FLINK-5793) Running slot may not be add to AllocatedMap in SlotPool

2017-02-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15867874#comment-15867874 ] ASF GitHub Bot commented on FLINK-5793: --- Github user StephanEwen commented on the is

[GitHub] flink pull request #3318: [FLINK-5070] [types] Unable to use Scala's BeanPro...

2017-02-15 Thread StephanEwen
Github user StephanEwen commented on a diff in the pull request: https://github.com/apache/flink/pull/3318#discussion_r101282565 --- Diff: flink-core/src/main/java/org/apache/flink/api/java/typeutils/TypeExtractor.java --- @@ -1723,20 +1720,17 @@ private boolean isValidPojoField(F

  1   2   3   4   >