[GitHub] flink issue #3523: [FLINK-5985] Report no task states for stateless tasks in...

2017-03-14 Thread gyfora
Github user gyfora commented on the issue: https://github.com/apache/flink/pull/3523 Hm, doesnt seem to work for the first try. What I did is I updated the client with the new jar based on your backport branch. Redeployed the job with a savepoint (to get the new Flink version), took

[jira] [Commented] (FLINK-5985) Flink treats every task as stateful (making topology changes impossible)

2017-03-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15924869#comment-15924869 ] ASF GitHub Bot commented on FLINK-5985: --- Github user gyfora commented on the issue:

[jira] [Commented] (FLINK-3930) Implement Service-Level Authorization

2017-03-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15924834#comment-15924834 ] ASF GitHub Bot commented on FLINK-3930: --- Github user EronWright commented on the issue:

[GitHub] flink issue #2425: FLINK-3930 Added shared secret based authorization for Fl...

2017-03-14 Thread EronWright
Github user EronWright commented on the issue: https://github.com/apache/flink/pull/2425 @StephanEwen keep in mind that Flink's current SSL support in Flink doesn't achieve _mutual authentication_ - there's no client certificate there.With SSL enabled, an untrusted client can

[jira] [Created] (FLINK-6052) Potential null access in ZooKeeperCompletedCheckpointStore#getLatestCheckpoint()

2017-03-14 Thread Ted Yu (JIRA)
Ted Yu created FLINK-6052: - Summary: Potential null access in ZooKeeperCompletedCheckpointStore#getLatestCheckpoint() Key: FLINK-6052 URL: https://issues.apache.org/jira/browse/FLINK-6052 Project: Flink

[jira] [Commented] (FLINK-6000) Can not start HA cluster with start-cluster.sh

2017-03-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15924751#comment-15924751 ] ASF GitHub Bot commented on FLINK-6000: --- Github user dawidwys commented on the issue:

[GitHub] flink issue #3506: [FLINK-6000] Fix starting HA cluster with start-cluster.s...

2017-03-14 Thread dawidwys
Github user dawidwys commented on the issue: https://github.com/apache/flink/pull/3506 @uce You replied to my message on mailing-list than maybe you could have a look at this PR ;) Recently another user reported it at SO:

[jira] [Created] (FLINK-6053) Gauge should only take subclasses of Number, rather than everything

2017-03-14 Thread Bowen Li (JIRA)
Bowen Li created FLINK-6053: --- Summary: Gauge should only take subclasses of Number, rather than everything Key: FLINK-6053 URL: https://issues.apache.org/jira/browse/FLINK-6053 Project: Flink

[GitHub] flink issue #3523: [FLINK-5985] Report no task states for stateless tasks in...

2017-03-14 Thread gyfora
Github user gyfora commented on the issue: https://github.com/apache/flink/pull/3523 It also doesnt seem to work starting from a clean state and then savepoint redeploy with changed topology so maybe I am really screwing up something --- If your project is set up for it, you can

[jira] [Updated] (FLINK-6053) Gauge should only take subclasses of Number, rather than everything

2017-03-14 Thread Bowen Li (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6053?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bowen Li updated FLINK-6053: Description: Currently, Flink's Gauge is defined as ```java public interface Gauge extends Metric {

[jira] [Updated] (FLINK-6053) Gauge should only take subclasses of Number, rather than everything

2017-03-14 Thread Bowen Li (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6053?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bowen Li updated FLINK-6053: Description: Currently, Flink's Gauge is defined as ```java /** * A Gauge is a {@link Metric} that

[jira] [Commented] (FLINK-5985) Flink treats every task as stateful (making topology changes impossible)

2017-03-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15924934#comment-15924934 ] ASF GitHub Bot commented on FLINK-5985: --- Github user gyfora commented on the issue:

[jira] [Commented] (FLINK-5808) Missing verification for setParallelism and setMaxParallelism

2017-03-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15925127#comment-15925127 ] ASF GitHub Bot commented on FLINK-5808: --- Github user aljoscha commented on a diff in the pull

[GitHub] flink pull request #3509: [FLINK-5808] Fix Missing verification for setParal...

2017-03-14 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/3509#discussion_r106040063 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/environment/StreamContextEnvironment.java --- @@ -38,14 +38,10 @@

[jira] [Closed] (FLINK-6040) DataStreamUserDefinedFunctionITCase occasionally fails

2017-03-14 Thread Kurt Young (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6040?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kurt Young closed FLINK-6040. - Resolution: Fixed > DataStreamUserDefinedFunctionITCase occasionally fails >

[jira] [Commented] (FLINK-5756) When there are many values under the same key in ListState, RocksDBStateBackend performances poor

2017-03-14 Thread Syinchwun Leo (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15925393#comment-15925393 ] Syinchwun Leo commented on FLINK-5756: -- Is it possible that avoiding using merge() operation. I

[jira] [Commented] (FLINK-5981) SSL version and ciper suites cannot be constrained as configured

2017-03-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15925423#comment-15925423 ] ASF GitHub Bot commented on FLINK-5981: --- Github user WangTaoTheTonic commented on the issue:

[jira] [Commented] (FLINK-3849) Add FilterableTableSource interface and translation rule

2017-03-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15925441#comment-15925441 ] ASF GitHub Bot commented on FLINK-3849: --- Github user godfreyhe commented on a diff in the pull

[jira] [Commented] (FLINK-3849) Add FilterableTableSource interface and translation rule

2017-03-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15925442#comment-15925442 ] ASF GitHub Bot commented on FLINK-3849: --- Github user godfreyhe commented on a diff in the pull

[GitHub] flink pull request #3520: [FLINK-3849] [table] Add FilterableTableSource int...

2017-03-14 Thread godfreyhe
Github user godfreyhe commented on a diff in the pull request: https://github.com/apache/flink/pull/3520#discussion_r106073030 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/util/RexProgramExtractor.scala --- @@ -0,0 +1,184 @@ +/* + *

[GitHub] flink pull request #3520: [FLINK-3849] [table] Add FilterableTableSource int...

2017-03-14 Thread godfreyhe
Github user godfreyhe commented on a diff in the pull request: https://github.com/apache/flink/pull/3520#discussion_r106072764 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/util/RexProgramExtractor.scala --- @@ -0,0 +1,184 @@ +/* + *

[GitHub] flink issue #3486: [FLINK-5981][SECURITY]make ssl version and cipher suites ...

2017-03-14 Thread WangTaoTheTonic
Github user WangTaoTheTonic commented on the issue: https://github.com/apache/flink/pull/3486 @vijikarthi I've checked the [JDK doc](http://docs.oracle.com/javase/8/docs/technotes/guides/security/StandardNames.html#ciphersuites) and not found any notes about combination of ssl

[jira] [Commented] (FLINK-6040) DataStreamUserDefinedFunctionITCase occasionally fails

2017-03-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6040?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15925359#comment-15925359 ] ASF GitHub Bot commented on FLINK-6040: --- Github user KurtYoung commented on the issue:

[GitHub] flink issue #3530: [FLINK-6040] [table] DataStreamUserDefinedFunctionITCase ...

2017-03-14 Thread KurtYoung
Github user KurtYoung commented on the issue: https://github.com/apache/flink/pull/3530 looks good, merging --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[jira] [Commented] (FLINK-5756) When there are many values under the same key in ListState, RocksDBStateBackend performances poor

2017-03-14 Thread Syinchwun Leo (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15925364#comment-15925364 ] Syinchwun Leo commented on FLINK-5756: -- OK, this problem is not only influence the performance of UDF

[GitHub] flink pull request #3535: [FLINK-5713] Protect against NPE in WindowOperator...

2017-03-14 Thread sunjincheng121
Github user sunjincheng121 commented on a diff in the pull request: https://github.com/apache/flink/pull/3535#discussion_r106065855 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/operators/windowing/WindowOperator.java --- @@ -354,22 +354,27 @@

[jira] [Commented] (FLINK-5713) Protect against NPE in WindowOperator window cleanup

2017-03-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15925371#comment-15925371 ] ASF GitHub Bot commented on FLINK-5713: --- Github user sunjincheng121 commented on a diff in the pull

[jira] [Comment Edited] (FLINK-5756) When there are many values under the same key in ListState, RocksDBStateBackend performances poor

2017-03-14 Thread Syinchwun Leo (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15925393#comment-15925393 ] Syinchwun Leo edited comment on FLINK-5756 at 3/15/17 1:43 AM: --- Is it

[jira] [Updated] (FLINK-6036) Let catalog support partition

2017-03-14 Thread jingzhang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6036?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] jingzhang updated FLINK-6036: - Description: Now catalog only support CRUD at database and table level. But in some kind of catalog, for

[jira] [Updated] (FLINK-6039) Row of TableFunction should support flexible number of fields

2017-03-14 Thread Kurt Young (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6039?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kurt Young updated FLINK-6039: -- Component/s: Table API & SQL > Row of TableFunction should support flexible number of fields >

[jira] [Commented] (FLINK-6040) DataStreamUserDefinedFunctionITCase occasionally fails

2017-03-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6040?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15925373#comment-15925373 ] ASF GitHub Bot commented on FLINK-6040: --- Github user asfgit closed the pull request at:

[GitHub] flink pull request #3530: [FLINK-6040] [table] DataStreamUserDefinedFunction...

2017-03-14 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/3530 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Updated] (FLINK-6036) Let catalog support partition

2017-03-14 Thread jingzhang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6036?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] jingzhang updated FLINK-6036: - Description: Now catalog only support CRUD at database and table level. But in some kind of catalog, for

[jira] [Assigned] (FLINK-6036) Let catalog support partition

2017-03-14 Thread jingzhang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6036?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] jingzhang reassigned FLINK-6036: Assignee: jingzhang > Let catalog support partition > - > >

[jira] [Created] (FLINK-6055) Supported setting timers on a Non-Keyed Stream

2017-03-14 Thread sunjincheng (JIRA)
sunjincheng created FLINK-6055: -- Summary: Supported setting timers on a Non-Keyed Stream Key: FLINK-6055 URL: https://issues.apache.org/jira/browse/FLINK-6055 Project: Flink Issue Type: New

[jira] [Created] (FLINK-6054) Add new state backend that dynamically stores data in memory and external storage

2017-03-14 Thread Sergio Esteves (JIRA)
Sergio Esteves created FLINK-6054: - Summary: Add new state backend that dynamically stores data in memory and external storage Key: FLINK-6054 URL: https://issues.apache.org/jira/browse/FLINK-6054

[jira] [Commented] (FLINK-6053) Gauge should only take subclasses of Number, rather than everything

2017-03-14 Thread Bowen Li (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15925257#comment-15925257 ] Bowen Li commented on FLINK-6053: - hm I found in Flink's Gauge class is used like this in

[jira] [Commented] (FLINK-6055) Supported setting timers on a Non-Keyed Stream

2017-03-14 Thread Xiaogang Shi (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15925575#comment-15925575 ] Xiaogang Shi commented on FLINK-6055: - I think it's very challenging because the storing and restoring

[jira] [Commented] (FLINK-6039) Row of TableFunction should support flexible number of fields

2017-03-14 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15923836#comment-15923836 ] Fabian Hueske commented on FLINK-6039: -- Can you explain the semantics if the returned rows are too

[jira] [Commented] (FLINK-6035) The method name(String) is undefined for the type UnsortedGrouping

2017-03-14 Thread Luke Hutchison (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15923849#comment-15923849 ] Luke Hutchison commented on FLINK-6035: --- The name parameter shouldn't be required, just as calling

[jira] [Updated] (FLINK-6035) Sinks need optional name parameter: .collect(name), .count(name)

2017-03-14 Thread Luke Hutchison (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6035?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Hutchison updated FLINK-6035: -- Summary: Sinks need optional name parameter: .collect(name), .count(name) (was: The method

[jira] [Comment Edited] (FLINK-6035) Sinks need optional name parameter: .collect(name), .count(name)

2017-03-14 Thread Luke Hutchison (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15923849#comment-15923849 ] Luke Hutchison edited comment on FLINK-6035 at 3/14/17 9:19 AM: The name

[jira] [Commented] (FLINK-6039) Row of TableFunction should support flexible number of fields

2017-03-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15923859#comment-15923859 ] ASF GitHub Bot commented on FLINK-6039: --- Github user fhueske commented on a diff in the pull

[GitHub] flink pull request #3529: [FLINK-6039] [core] Row of TableFunction should su...

2017-03-14 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3529#discussion_r105856276 --- Diff: flink-core/src/main/java/org/apache/flink/types/Row.java --- @@ -66,10 +66,11 @@ public int getArity() { * Gets the field at the specified

[jira] [Commented] (FLINK-6039) Row of TableFunction should support flexible number of fields

2017-03-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15923882#comment-15923882 ] ASF GitHub Bot commented on FLINK-6039: --- Github user clarkyzl commented on a diff in the pull

[jira] [Commented] (FLINK-6039) Row of TableFunction should support flexible number of fields

2017-03-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15923887#comment-15923887 ] ASF GitHub Bot commented on FLINK-6039: --- Github user fhueske commented on a diff in the pull

[GitHub] flink pull request #3529: [FLINK-6039] [core] Row of TableFunction should su...

2017-03-14 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3529#discussion_r105862926 --- Diff: flink-core/src/main/java/org/apache/flink/types/Row.java --- @@ -66,10 +66,11 @@ public int getArity() { * Gets the field at the specified

[jira] [Commented] (FLINK-6039) Row of TableFunction should support flexible number of fields

2017-03-14 Thread Zhuoluo Yang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15923886#comment-15923886 ] Zhuoluo Yang commented on FLINK-6039: - Hi [~fhueske] Thank you for your comments. I'm not sure whether

[jira] [Updated] (FLINK-6040) DataStreamUserDefinedFunctionITCase occasionally fails

2017-03-14 Thread Zhuoluo Yang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6040?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhuoluo Yang updated FLINK-6040: Labels: test (was: ) > DataStreamUserDefinedFunctionITCase occasionally fails >

[jira] [Commented] (FLINK-6040) DataStreamUserDefinedFunctionITCase occasionally fails

2017-03-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6040?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15923923#comment-15923923 ] ASF GitHub Bot commented on FLINK-6040: --- GitHub user clarkyzl opened a pull request:

[GitHub] flink issue #3518: [backport-1.2] [FLINK-6025] [core] Add Flink's own JavaSe...

2017-03-14 Thread rmetzger
Github user rmetzger commented on the issue: https://github.com/apache/flink/pull/3518 @tzulitai The merge didn't close the PR :) I think the "this closes #xxx" thing only works for commits to `master`. --- If your project is set up for it, you can reply to this email and have your

[jira] [Commented] (FLINK-6040) DataStreamUserDefinedFunctionITCase occasionally fails

2017-03-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6040?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15923932#comment-15923932 ] ASF GitHub Bot commented on FLINK-6040: --- Github user KurtYoung commented on a diff in the pull

[GitHub] flink pull request #3530: [FLINK-6040] [table] DataStreamUserDefinedFunction...

2017-03-14 Thread KurtYoung
Github user KurtYoung commented on a diff in the pull request: https://github.com/apache/flink/pull/3530#discussion_r105869656 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/datastream/DataStreamUserDefinedFunctionITCase.scala --- @@ -85,6

[jira] [Commented] (FLINK-6025) User code ClassLoader not used when KryoSerializer fallbacks to serialization for copying

2017-03-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15923931#comment-15923931 ] ASF GitHub Bot commented on FLINK-6025: --- Github user rmetzger commented on the issue:

[jira] [Commented] (FLINK-6039) Row of TableFunction should support flexible number of fields

2017-03-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15923831#comment-15923831 ] ASF GitHub Bot commented on FLINK-6039: --- Github user clarkyzl commented on the issue:

[GitHub] flink pull request #3477: [Flink-3318][cep] Add support for quantifiers to C...

2017-03-14 Thread dawidwys
Github user dawidwys commented on a diff in the pull request: https://github.com/apache/flink/pull/3477#discussion_r105851855 --- Diff: flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/ComputationState.java --- @@ -52,14 +57,35 @@ public ComputationState(

[GitHub] flink pull request #3477: [Flink-3318][cep] Add support for quantifiers to C...

2017-03-14 Thread dawidwys
Github user dawidwys commented on a diff in the pull request: https://github.com/apache/flink/pull/3477#discussion_r105856821 --- Diff: flink-libraries/flink-cep/src/test/java/org/apache/flink/cep/nfa/NFAITCase.java --- @@ -272,37 +372,42 @@ public void testBranchingPattern() {

[GitHub] flink pull request #3477: [Flink-3318][cep] Add support for quantifiers to C...

2017-03-14 Thread dawidwys
Github user dawidwys commented on a diff in the pull request: https://github.com/apache/flink/pull/3477#discussion_r105854765 --- Diff: flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/NFA.java --- @@ -247,27 +275,148 @@ public int compare(final StateTransition o1,

[GitHub] flink pull request #3477: [Flink-3318][cep] Add support for quantifiers to C...

2017-03-14 Thread dawidwys
Github user dawidwys commented on a diff in the pull request: https://github.com/apache/flink/pull/3477#discussion_r105853157 --- Diff: flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/NFA.java --- @@ -71,19 +70,16 @@ private final

[GitHub] flink pull request #3477: [Flink-3318][cep] Add support for quantifiers to C...

2017-03-14 Thread dawidwys
Github user dawidwys commented on a diff in the pull request: https://github.com/apache/flink/pull/3477#discussion_r105855825 --- Diff: flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/StateTransition.java --- @@ -55,6 +65,7 @@ public boolean equals(Object obj) {

[GitHub] flink pull request #3477: [Flink-3318][cep] Add support for quantifiers to C...

2017-03-14 Thread dawidwys
Github user dawidwys commented on a diff in the pull request: https://github.com/apache/flink/pull/3477#discussion_r105854576 --- Diff: flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/NFA.java --- @@ -247,27 +275,148 @@ public int compare(final StateTransition o1,

[GitHub] flink pull request #3477: [Flink-3318][cep] Add support for quantifiers to C...

2017-03-14 Thread dawidwys
Github user dawidwys commented on a diff in the pull request: https://github.com/apache/flink/pull/3477#discussion_r105857677 --- Diff: flink-libraries/flink-cep/src/test/java/org/apache/flink/cep/nfa/NFAITCase.java --- @@ -272,37 +372,42 @@ public void testBranchingPattern() {

[GitHub] flink pull request #3477: [Flink-3318][cep] Add support for quantifiers to C...

2017-03-14 Thread dawidwys
Github user dawidwys commented on a diff in the pull request: https://github.com/apache/flink/pull/3477#discussion_r105857530 --- Diff: flink-libraries/flink-cep/src/test/java/org/apache/flink/cep/nfa/compiler/NFACompilerTest.java --- @@ -18,9 +18,13 @@ package

[GitHub] flink pull request #3477: [Flink-3318][cep] Add support for quantifiers to C...

2017-03-14 Thread dawidwys
Github user dawidwys commented on a diff in the pull request: https://github.com/apache/flink/pull/3477#discussion_r105854241 --- Diff: flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/NFA.java --- @@ -209,33 +204,66 @@ public boolean equals(Object obj) {

[GitHub] flink pull request #3477: [Flink-3318][cep] Add support for quantifiers to C...

2017-03-14 Thread dawidwys
Github user dawidwys commented on a diff in the pull request: https://github.com/apache/flink/pull/3477#discussion_r105854452 --- Diff: flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/NFA.java --- @@ -247,27 +275,148 @@ public int compare(final StateTransition o1,

[GitHub] flink pull request #3477: [Flink-3318][cep] Add support for quantifiers to C...

2017-03-14 Thread dawidwys
Github user dawidwys commented on a diff in the pull request: https://github.com/apache/flink/pull/3477#discussion_r105851817 --- Diff: flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/NFA.java --- @@ -71,19 +70,16 @@ private final

[GitHub] flink pull request #3477: [Flink-3318][cep] Add support for quantifiers to C...

2017-03-14 Thread dawidwys
Github user dawidwys commented on a diff in the pull request: https://github.com/apache/flink/pull/3477#discussion_r105851882 --- Diff: flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/ComputationState.java --- @@ -41,8 +43,11 @@ // Timestamp of the first

[GitHub] flink pull request #3477: [Flink-3318][cep] Add support for quantifiers to C...

2017-03-14 Thread dawidwys
Github user dawidwys commented on a diff in the pull request: https://github.com/apache/flink/pull/3477#discussion_r105857618 --- Diff: flink-libraries/flink-cep/src/test/java/org/apache/flink/cep/nfa/NFAITCase.java --- @@ -272,37 +372,42 @@ public void testBranchingPattern() {

[GitHub] flink pull request #3477: [Flink-3318][cep] Add support for quantifiers to C...

2017-03-14 Thread dawidwys
Github user dawidwys commented on a diff in the pull request: https://github.com/apache/flink/pull/3477#discussion_r105857595 --- Diff: flink-libraries/flink-cep/src/test/java/org/apache/flink/cep/nfa/NFAITCase.java --- @@ -272,37 +372,42 @@ public void testBranchingPattern() {

[jira] [Created] (FLINK-6040) DataStreamUserDefinedFunctionITCase occasionally fails

2017-03-14 Thread Zhuoluo Yang (JIRA)
Zhuoluo Yang created FLINK-6040: --- Summary: DataStreamUserDefinedFunctionITCase occasionally fails Key: FLINK-6040 URL: https://issues.apache.org/jira/browse/FLINK-6040 Project: Flink Issue

[GitHub] flink pull request #3530: [FLINK-6040] [table] DataStreamUserDefinedFunction...

2017-03-14 Thread clarkyzl
GitHub user clarkyzl opened a pull request: https://github.com/apache/flink/pull/3530 [FLINK-6040] [table] DataStreamUserDefinedFunctionITCase occasionally fails Type: Bug Priority: Major Components: table, test Problem Definition: DataStreamUserDefinedFunctionITCase

[GitHub] flink issue #3445: [FLINK-5846] [cep] Make the CEP operators backwards compa...

2017-03-14 Thread kl0u
Github user kl0u commented on the issue: https://github.com/apache/flink/pull/3445 Thanks for the comments @aljoscha . I integrated them and I updated https://issues.apache.org/jira/browse/FLINK-5969 to keep track. --- If your project is set up for it, you can reply to this email

[jira] [Commented] (FLINK-5846) CEP: make the operators backwards compatible.

2017-03-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15923940#comment-15923940 ] ASF GitHub Bot commented on FLINK-5846: --- Github user kl0u commented on the issue:

[jira] [Commented] (FLINK-3026) Publish the flink docker container to the docker registry

2017-03-14 Thread Patrick Lucas (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15923956#comment-15923956 ] Patrick Lucas commented on FLINK-3026: -- Personally I like the idea of having as little code as

[jira] [Commented] (FLINK-6025) User code ClassLoader not used when KryoSerializer fallbacks to serialization for copying

2017-03-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15923964#comment-15923964 ] ASF GitHub Bot commented on FLINK-6025: --- Github user tzulitai commented on the issue:

[GitHub] flink issue #3518: [backport-1.2] [FLINK-6025] [core] Add Flink's own JavaSe...

2017-03-14 Thread tzulitai
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/3518 Thanks for the reminder :-D --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[jira] [Commented] (FLINK-6025) User code ClassLoader not used when KryoSerializer fallbacks to serialization for copying

2017-03-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15923966#comment-15923966 ] ASF GitHub Bot commented on FLINK-6025: --- Github user tzulitai closed the pull request at:

[jira] [Commented] (FLINK-6025) User code ClassLoader not used when KryoSerializer fallbacks to serialization for copying

2017-03-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15923965#comment-15923965 ] ASF GitHub Bot commented on FLINK-6025: --- Github user tzulitai closed the pull request at:

[GitHub] flink pull request #3518: [backport-1.2] [FLINK-6025] [core] Add Flink's own...

2017-03-14 Thread tzulitai
Github user tzulitai closed the pull request at: https://github.com/apache/flink/pull/3518 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] flink issue #3529: [FLINK-6039] [core] Row of TableFunction should support f...

2017-03-14 Thread clarkyzl
Github user clarkyzl commented on the issue: https://github.com/apache/flink/pull/3529 I didn't change the behavior of `org.apache.flink.types.Record`. I think we can open another issue if necessary. --- If your project is set up for it, you can reply to this email and have your

[GitHub] flink pull request #3477: [Flink-3318][cep] Add support for quantifiers to C...

2017-03-14 Thread dawidwys
Github user dawidwys commented on a diff in the pull request: https://github.com/apache/flink/pull/3477#discussion_r105856015 --- Diff: flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/pattern/Quantifier.java --- @@ -0,0 +1,28 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request #3477: [Flink-3318][cep] Add support for quantifiers to C...

2017-03-14 Thread dawidwys
Github user dawidwys commented on a diff in the pull request: https://github.com/apache/flink/pull/3477#discussion_r105854116 --- Diff: flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/NFA.java --- @@ -209,33 +204,66 @@ public boolean equals(Object obj) {

[GitHub] flink pull request #3477: [Flink-3318][cep] Add support for quantifiers to C...

2017-03-14 Thread dawidwys
Github user dawidwys commented on a diff in the pull request: https://github.com/apache/flink/pull/3477#discussion_r105854967 --- Diff: flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/NFA.java --- @@ -247,27 +275,148 @@ public int compare(final StateTransition o1,

[GitHub] flink pull request #3477: [Flink-3318][cep] Add support for quantifiers to C...

2017-03-14 Thread dawidwys
Github user dawidwys commented on a diff in the pull request: https://github.com/apache/flink/pull/3477#discussion_r105855625 --- Diff: flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/SharedBuffer.java --- @@ -217,23 +217,22 @@ public void prune(long

[GitHub] flink pull request #3477: [Flink-3318][cep] Add support for quantifiers to C...

2017-03-14 Thread dawidwys
Github user dawidwys commented on a diff in the pull request: https://github.com/apache/flink/pull/3477#discussion_r105854471 --- Diff: flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/NFA.java --- @@ -247,27 +275,148 @@ public int compare(final StateTransition o1,

[GitHub] flink pull request #3477: [Flink-3318][cep] Add support for quantifiers to C...

2017-03-14 Thread dawidwys
Github user dawidwys commented on a diff in the pull request: https://github.com/apache/flink/pull/3477#discussion_r105855949 --- Diff: flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/pattern/InvalidPatternException.java --- @@ -0,0 +1,28 @@ +/* + * Licensed

[GitHub] flink pull request #3477: [Flink-3318][cep] Add support for quantifiers to C...

2017-03-14 Thread dawidwys
Github user dawidwys commented on a diff in the pull request: https://github.com/apache/flink/pull/3477#discussion_r105855001 --- Diff: flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/NFA.java --- @@ -247,27 +275,148 @@ public int compare(final StateTransition o1,

[GitHub] flink issue #3477: [Flink-3318][cep] Add support for quantifiers to CEP's pa...

2017-03-14 Thread kl0u
Github user kl0u commented on the issue: https://github.com/apache/flink/pull/3477 Thanks @dawidwys I will have a look now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[jira] [Updated] (FLINK-5969) Add savepoint backwards compatibility tests from 1.2 to 1.3

2017-03-14 Thread Kostas Kloudas (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5969?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kostas Kloudas updated FLINK-5969: -- Description: We currently only have tests that test migration from 1.1 to 1.3, because we

[GitHub] flink pull request #3519: [backport-1.1] [FLINK-6025] [core] Add Flink's own...

2017-03-14 Thread tzulitai
Github user tzulitai closed the pull request at: https://github.com/apache/flink/pull/3519 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] flink issue #3477: [Flink-3318][cep] Add support for quantifiers to CEP's pa...

2017-03-14 Thread kl0u
Github user kl0u commented on the issue: https://github.com/apache/flink/pull/3477 Hi @dawidwys , the following produces no output, which should not be the case. The same holds if you change the pattern to `oneOrMore`. ``` public void testZeroOrMore() {

[jira] [Commented] (FLINK-6006) Kafka Consumer can lose state if queried partition list is incomplete on restore

2017-03-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15923872#comment-15923872 ] ASF GitHub Bot commented on FLINK-6006: --- Github user tzulitai commented on a diff in the pull

[GitHub] flink pull request #3505: [backport-1.2] [FLINK-6006] [kafka] Always use com...

2017-03-14 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/3505#discussion_r105860440 --- Diff: flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaConsumerBase.java --- @@ -489,16

[jira] [Commented] (FLINK-6006) Kafka Consumer can lose state if queried partition list is incomplete on restore

2017-03-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15923874#comment-15923874 ] ASF GitHub Bot commented on FLINK-6006: --- Github user tzulitai commented on a diff in the pull

[GitHub] flink pull request #3505: [backport-1.2] [FLINK-6006] [kafka] Always use com...

2017-03-14 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/3505#discussion_r105860279 --- Diff: flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/internals/AbstractFetcher.java --- @@

[GitHub] flink pull request #3529: [FLINK-6039] [core] Row of TableFunction should su...

2017-03-14 Thread clarkyzl
Github user clarkyzl commented on a diff in the pull request: https://github.com/apache/flink/pull/3529#discussion_r105861507 --- Diff: flink-core/src/main/java/org/apache/flink/types/Row.java --- @@ -66,10 +66,11 @@ public int getArity() { * Gets the field at the

[GitHub] flink issue #3477: [Flink-3318][cep] Add support for quantifiers to CEP's pa...

2017-03-14 Thread dawidwys
Github user dawidwys commented on the issue: https://github.com/apache/flink/pull/3477 Thanks @kl0u for your comments, I've changed all code style specific. Some comments were addressing a behaviour that one `Pattern` can be translated into multiple "equivalent" `States`

[jira] [Updated] (FLINK-6040) DataStreamUserDefinedFunctionITCase occasionally fails

2017-03-14 Thread Zhuoluo Yang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6040?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhuoluo Yang updated FLINK-6040: Affects Version/s: 1.3.0 > DataStreamUserDefinedFunctionITCase occasionally fails >

[jira] [Updated] (FLINK-6040) DataStreamUserDefinedFunctionITCase occasionally fails

2017-03-14 Thread Zhuoluo Yang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6040?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhuoluo Yang updated FLINK-6040: Fix Version/s: 1.3.0 > DataStreamUserDefinedFunctionITCase occasionally fails >

[jira] [Updated] (FLINK-6040) DataStreamUserDefinedFunctionITCase occasionally fails

2017-03-14 Thread Zhuoluo Yang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6040?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhuoluo Yang updated FLINK-6040: Component/s: Tests > DataStreamUserDefinedFunctionITCase occasionally fails >

  1   2   3   4   >