[jira] [Comment Edited] (FLINK-6130) Consider calling resourceManager#getTerminationFuture() with lock held

2017-04-16 Thread mingleizhang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15970586#comment-15970586 ] mingleizhang edited comment on FLINK-6130 at 4/17/17 1:51 AM: -- [~tedyu] Could

[jira] [Commented] (FLINK-6130) Consider calling resourceManager#getTerminationFuture() with lock held

2017-04-16 Thread mingleizhang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15970586#comment-15970586 ] mingleizhang commented on FLINK-6130: - [~tedyu] Could you please help review the code ? How do you

[jira] [Commented] (FLINK-6130) Consider calling resourceManager#getTerminationFuture() with lock held

2017-04-16 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15970587#comment-15970587 ] Ted Yu commented on FLINK-6130: --- lgtm > Consider calling resourceManager#getTerminationFuture() with lock

[jira] [Commented] (FLINK-6130) Consider calling resourceManager#getTerminationFuture() with lock held

2017-04-16 Thread mingleizhang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15970598#comment-15970598 ] mingleizhang commented on FLINK-6130: - [~tedyu] Yep. And the code like below, how do you think of this

[jira] [Commented] (FLINK-6130) Consider calling resourceManager#getTerminationFuture() with lock held

2017-04-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15970649#comment-15970649 ] ASF GitHub Bot commented on FLINK-6130: --- Github user zhangminglei commented on the issue:

[GitHub] flink issue #3726: [FLINK-6130] [yarn] Fix Consider calling resourceManager#...

2017-04-16 Thread zhangminglei
Github user zhangminglei commented on the issue: https://github.com/apache/flink/pull/3726 @tedyu @zentol It seems there is a problem with travis-ci test if no output within 5 mins then it will print the stacktrace and then kill the watchdog , please help to review and checkout how

[jira] [Commented] (FLINK-2032) Migrate integration tests from temp output files to collect()

2017-04-16 Thread Pattarawat Chormai (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15970524#comment-15970524 ] Pattarawat Chormai commented on FLINK-2032: --- Hi all, I have searched on Github using [1] and

[jira] [Commented] (FLINK-6306) Sink for eventually consistent file systems

2017-04-16 Thread Tzu-Li (Gordon) Tai (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15970683#comment-15970683 ] Tzu-Li (Gordon) Tai commented on FLINK-6306: This definitely needs a closer look. Thanks for

[jira] [Commented] (FLINK-6130) Consider calling resourceManager#getTerminationFuture() with lock held

2017-04-16 Thread mingleizhang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15970602#comment-15970602 ] mingleizhang commented on FLINK-6130: - [~tedyu] Thanks and appreciate it again. If there is no more

[jira] [Created] (FLINK-6310) LocalExecutor#endSession() uses wrong lock for synchronization

2017-04-16 Thread Ted Yu (JIRA)
Ted Yu created FLINK-6310: - Summary: LocalExecutor#endSession() uses wrong lock for synchronization Key: FLINK-6310 URL: https://issues.apache.org/jira/browse/FLINK-6310 Project: Flink Issue Type:

[jira] [Commented] (FLINK-5752) Support push down projections for HBaseTableSource

2017-04-16 Thread ramkrishna.s.vasudevan (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15970592#comment-15970592 ] ramkrishna.s.vasudevan commented on FLINK-5752: --- I completed the patch related work but I

[GitHub] flink pull request #3726: [FLINK-6130] [yarn] Fix Consider calling resourceM...

2017-04-16 Thread zhangminglei
GitHub user zhangminglei opened a pull request: https://github.com/apache/flink/pull/3726 [FLINK-6130] [yarn] Fix Consider calling resourceManager#getTerminati… …onFuture() with lock held. Thanks for contributing to Apache Flink. Before you open your pull request,

[jira] [Commented] (FLINK-6130) Consider calling resourceManager#getTerminationFuture() with lock held

2017-04-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15970608#comment-15970608 ] ASF GitHub Bot commented on FLINK-6130: --- GitHub user zhangminglei opened a pull request:

[jira] [Commented] (FLINK-6130) Consider calling resourceManager#getTerminationFuture() with lock held

2017-04-16 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15970590#comment-15970590 ] Ted Yu commented on FLINK-6130: --- You don't need to create another synchronized (lock) block. You can use the

[jira] [Assigned] (FLINK-6309) Memory consumer weights should be calculated in job vertex level

2017-04-16 Thread Xu Pingyong (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6309?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xu Pingyong reassigned FLINK-6309: -- Assignee: Xu Pingyong > Memory consumer weights should be calculated in job vertex level >

[jira] [Created] (FLINK-6311) NPE in FlinkKinesisConsumer if source was closed before run

2017-04-16 Thread Tzu-Li (Gordon) Tai (JIRA)
Tzu-Li (Gordon) Tai created FLINK-6311: -- Summary: NPE in FlinkKinesisConsumer if source was closed before run Key: FLINK-6311 URL: https://issues.apache.org/jira/browse/FLINK-6311 Project: Flink

[jira] [Created] (FLINK-6309) Memory consumer weights should be calculated in job vertex level

2017-04-16 Thread Kurt Young (JIRA)
Kurt Young created FLINK-6309: - Summary: Memory consumer weights should be calculated in job vertex level Key: FLINK-6309 URL: https://issues.apache.org/jira/browse/FLINK-6309 Project: Flink

[jira] [Commented] (FLINK-6130) Consider calling resourceManager#getTerminationFuture() with lock held

2017-04-16 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15970599#comment-15970599 ] Ted Yu commented on FLINK-6130: --- lgtm > Consider calling resourceManager#getTerminationFuture() with lock

[jira] [Commented] (FLINK-6301) Flink KafkaConnector09 leaks memory on reading compressed messages due to a Kafka consumer bug

2017-04-16 Thread Tzu-Li (Gordon) Tai (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15970699#comment-15970699 ] Tzu-Li (Gordon) Tai commented on FLINK-6301: Thanks a lot for looking into this in detail! It

[jira] [Commented] (FLINK-6130) Consider calling resourceManager#getTerminationFuture() with lock held

2017-04-16 Thread mingleizhang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15970588#comment-15970588 ] mingleizhang commented on FLINK-6130: - [~tedyu] Thanks and appreciate it. I will give a PR to this

[jira] [Commented] (FLINK-6257) Post-pass OVER windows

2017-04-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15970303#comment-15970303 ] ASF GitHub Bot commented on FLINK-6257: --- Github user zentol commented on the issue:

[GitHub] flink issue #3697: [FLINK-6257][table]Optimize test cases

2017-04-16 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/3697 Please provide some description as to the changes that you made, it's a 2000+ line diff after all. --- If your project is set up for it, you can reply to this email and have your reply appear on

[jira] [Commented] (FLINK-5090) Expose optionally detailed metrics about network queue lengths

2017-04-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15970311#comment-15970311 ] ASF GitHub Bot commented on FLINK-5090: --- Github user zentol commented on the issue:

[jira] [Assigned] (FLINK-6130) Consider calling resourceManager#getTerminationFuture() with lock held

2017-04-16 Thread mingleizhang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6130?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] mingleizhang reassigned FLINK-6130: --- Assignee: mingleizhang > Consider calling resourceManager#getTerminationFuture() with lock

[jira] [Commented] (FLINK-6286) hbase command not found error

2017-04-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15970355#comment-15970355 ] ASF GitHub Bot commented on FLINK-6286: --- Github user greghogan commented on the issue:

[GitHub] flink issue #3711: [FLINK-6286] [script] Fix the hbase command not found err...

2017-04-16 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/3711 @lingjinjiang thanks for your contribution! Merging ... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[jira] [Commented] (FLINK-6104) Resource leak in ListViaRangeSpeedMiniBenchmark

2017-04-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15970358#comment-15970358 ] ASF GitHub Bot commented on FLINK-6104: --- GitHub user zhangminglei opened a pull request:

[jira] [Commented] (FLINK-6295) use LoadingCache instead of WeakHashMap to lower latency

2017-04-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15970302#comment-15970302 ] ASF GitHub Bot commented on FLINK-6295: --- Github user zentol commented on the issue:

[GitHub] flink issue #3709: [FLINK-6295]use LoadingCache instead of WeakHashMap to lo...

2017-04-16 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/3709 It shouldn't matter for the display in the web-frontend in which data structure the cached ExecutionGraphs are being held. We are caching the actual ExecutionGraph that the JobManager works with and

[jira] [Commented] (FLINK-6195) Move gelly-examples jar from opt to examples

2017-04-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15970305#comment-15970305 ] ASF GitHub Bot commented on FLINK-6195: --- Github user zentol commented on the issue:

[GitHub] flink issue #3691: [FLINK-6195] [build] Move gelly-examples jar from opt to ...

2017-04-16 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/3691 Changes to the build and docs look good. I would propose moving the changes to the EdgeList/AsmTestBase into a separate commit though. --- If your project is set up for it, you can reply to this

[GitHub] flink issue #3348: [FLINK-5090] [network] Add metrics for details about inbo...

2017-04-16 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/3348 Will try merging this now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] flink issue #3348: [FLINK-5090] [network] Add metrics for details about inbo...

2017-04-16 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/3348 Did @StephanEwen provide the initial implementation, or why is the first commit by him? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[jira] [Commented] (FLINK-5090) Expose optionally detailed metrics about network queue lengths

2017-04-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15970314#comment-15970314 ] ASF GitHub Bot commented on FLINK-5090: --- Github user zentol commented on the issue:

[jira] [Commented] (FLINK-6130) Consider calling resourceManager#getTerminationFuture() with lock held

2017-04-16 Thread mingleizhang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15970332#comment-15970332 ] mingleizhang commented on FLINK-6130: - [~tedyu] Thanks. I would ask how to use those return value that

[jira] [Assigned] (FLINK-6104) Resource leak in ListViaRangeSpeedMiniBenchmark

2017-04-16 Thread mingleizhang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6104?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] mingleizhang reassigned FLINK-6104: --- Assignee: mingleizhang > Resource leak in ListViaRangeSpeedMiniBenchmark >

[jira] [Commented] (FLINK-6104) Resource leak in ListViaRangeSpeedMiniBenchmark

2017-04-16 Thread mingleizhang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15970341#comment-15970341 ] mingleizhang commented on FLINK-6104: - I will give a pr to this jira soon. > Resource leak in

[GitHub] flink pull request #3725: [FLINK-6104] Fix resource leak in ListViaRangeSpee...

2017-04-16 Thread zhangminglei
GitHub user zhangminglei opened a pull request: https://github.com/apache/flink/pull/3725 [FLINK-6104] Fix resource leak in ListViaRangeSpeedMiniBenchmark. Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into

[jira] [Commented] (FLINK-6275) Unprotected access to resourceManager in YarnFlinkApplicationMasterRunner#runApplicationMaster

2017-04-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15970245#comment-15970245 ] ASF GitHub Bot commented on FLINK-6275: --- Github user zhangminglei closed the pull request at:

[GitHub] flink pull request #3707: [FLINK-6275] [yarn] Fix unprotected access to reso...

2017-04-16 Thread zhangminglei
Github user zhangminglei closed the pull request at: https://github.com/apache/flink/pull/3707 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[jira] [Commented] (FLINK-6275) Unprotected access to resourceManager in YarnFlinkApplicationMasterRunner#runApplicationMaster

2017-04-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15970251#comment-15970251 ] ASF GitHub Bot commented on FLINK-6275: --- Github user zhangminglei commented on the issue:

[GitHub] flink issue #3707: [FLINK-6275] [yarn] Fix unprotected access to resourceMan...

2017-04-16 Thread zhangminglei
Github user zhangminglei commented on the issue: https://github.com/apache/flink/pull/3707 @zentol Could you please reopen this pr again ? It seems belong to my misoperation. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[jira] [Commented] (FLINK-6275) Unprotected access to resourceManager in YarnFlinkApplicationMasterRunner#runApplicationMaster

2017-04-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15970256#comment-15970256 ] ASF GitHub Bot commented on FLINK-6275: --- GitHub user zhangminglei opened a pull request:

[GitHub] flink pull request #3724: [FLINK-6275] [yarn] Fix unprotected access to reso...

2017-04-16 Thread zhangminglei
GitHub user zhangminglei opened a pull request: https://github.com/apache/flink/pull/3724 [FLINK-6275] [yarn] Fix unprotected access to resourceManage in YarnF… …linkApplicationMasterRunner. Thanks for contributing to Apache Flink. Before you open your pull request,

[jira] [Assigned] (FLINK-5611) Add QueryableStateException type

2017-04-16 Thread mingleizhang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5611?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] mingleizhang reassigned FLINK-5611: --- Assignee: mingleizhang > Add QueryableStateException type >

[jira] [Commented] (FLINK-6130) Consider calling resourceManager#getTerminationFuture() with lock held

2017-04-16 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15970408#comment-15970408 ] Ted Yu commented on FLINK-6130: --- You can store the return value from getTerminationFuture in a variable

[jira] [Commented] (FLINK-5611) Add QueryableStateException type

2017-04-16 Thread mingleizhang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15970385#comment-15970385 ] mingleizhang commented on FLINK-5611: - [~uce]Hi, I will work on this soon. Thanks ~ > Add

[jira] [Created] (FLINK-6308) Task managers are not attaching to job manager on macos

2017-04-16 Thread Mateusz Zakarczemny (JIRA)
Mateusz Zakarczemny created FLINK-6308: -- Summary: Task managers are not attaching to job manager on macos Key: FLINK-6308 URL: https://issues.apache.org/jira/browse/FLINK-6308 Project: Flink

[jira] [Updated] (FLINK-6308) Task managers are not attaching to job manager on macos

2017-04-16 Thread Mateusz Zakarczemny (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6308?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mateusz Zakarczemny updated FLINK-6308: --- Description: I'm using flink 1.2.0. On macOS task managers were not joining cluster.

[jira] [Closed] (FLINK-4548) Refactor ContinuousFileMonitoringTest to use OneShotLatch

2017-04-16 Thread Pattarawat Chormai (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4548?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pattarawat Chormai closed FLINK-4548. - Resolution: Fixed > Refactor ContinuousFileMonitoringTest to use OneShotLatch >

[jira] [Commented] (FLINK-4548) Refactor ContinuousFileMonitoringTest to use OneShotLatch

2017-04-16 Thread Pattarawat Chormai (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15970516#comment-15970516 ] Pattarawat Chormai commented on FLINK-4548: --- The test was removed already by