[GitHub] flink pull request #4560: Flink 7077

2017-08-18 Thread EronWright
Github user EronWright commented on a diff in the pull request: https://github.com/apache/flink/pull/4560#discussion_r134003593 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/ResourceManager.java --- @@ -960,12 +965,26 @@ public void

[jira] [Commented] (FLINK-6988) Add Apache Kafka 0.11 connector

2017-08-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16133557#comment-16133557 ] ASF GitHub Bot commented on FLINK-6988: --- Github user rangadi commented on a diff in the pull

[GitHub] flink pull request #4239: [FLINK-6988] flink-connector-kafka-0.11 with exact...

2017-08-18 Thread rangadi
Github user rangadi commented on a diff in the pull request: https://github.com/apache/flink/pull/4239#discussion_r134044031 --- Diff: flink-connectors/flink-connector-kafka-0.11/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaProducer011.java --- @@ -0,0

[GitHub] flink pull request #4560: Flink 7077

2017-08-18 Thread EronWright
Github user EronWright commented on a diff in the pull request: https://github.com/apache/flink/pull/4560#discussion_r134004745 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/slotmanager/TaskManagerRegistration.java --- @@ -68,7 +68,9 @@ public

[jira] [Commented] (FLINK-7479) Support to retrieve the past event by physical offset

2017-08-18 Thread Dian Fu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16133888#comment-16133888 ] Dian Fu commented on FLINK-7479: Hi [~kkl0u], {quote} Before opening a PR for a feature, we first have to

[jira] [Comment Edited] (FLINK-7479) Support to retrieve the past event by physical offset

2017-08-18 Thread Dian Fu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16133888#comment-16133888 ] Dian Fu edited comment on FLINK-7479 at 8/19/17 2:27 AM: - Hi [~kkl0u], Thanks a

[GitHub] flink issue #4560: Flink 7077

2017-08-18 Thread EronWright
Github user EronWright commented on the issue: https://github.com/apache/flink/pull/4560 @tillrohrmann fixed the test issue and other noted issues. Once #4555 is in, this is good to go. The test issue was a race in RM acquiring leadership vs RPC call. Added some code to

[jira] [Comment Edited] (FLINK-7129) Dynamically changing patterns

2017-08-18 Thread Dian Fu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16131782#comment-16131782 ] Dian Fu edited comment on FLINK-7129 at 8/18/17 6:22 AM: - Hi [~dawidwys], Thanks a

[jira] [Created] (FLINK-7475) ListState support update

2017-08-18 Thread yf (JIRA)
yf created FLINK-7475: - Summary: ListState support update Key: FLINK-7475 URL: https://issues.apache.org/jira/browse/FLINK-7475 Project: Flink Issue Type: Improvement Components: Core

[jira] [Commented] (FLINK-7442) Add option for using a child-first classloader for loading user code

2017-08-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16131779#comment-16131779 ] ASF GitHub Bot commented on FLINK-7442: --- Github user aljoscha commented on the issue:

[GitHub] flink issue #4554: [FLINK-7442] Add option for using child-first classloader...

2017-08-18 Thread aljoscha
Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/4554 This is the exception I got with the class loader from

[jira] [Commented] (FLINK-7129) Dynamically changing patterns

2017-08-18 Thread Dian Fu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16131782#comment-16131782 ] Dian Fu commented on FLINK-7129: Hi [~dawidwys], Thanks a lot for your work here. I'm very interested in

[jira] [Commented] (FLINK-7479) Support to retrieve the past event by physical offset

2017-08-18 Thread Kostas Kloudas (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16133628#comment-16133628 ] Kostas Kloudas commented on FLINK-7479: --- Hi [~dian.fu], Before opening a PR for a feature, we

[jira] [Commented] (FLINK-7245) Enhance the operators to support holding back watermarks

2017-08-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16131812#comment-16131812 ] ASF GitHub Bot commented on FLINK-7245: --- Github user fhueske commented on the issue:

[GitHub] flink issue #4530: [FLINK-7245] [stream] Support holding back watermarks wit...

2017-08-18 Thread fhueske
Github user fhueske commented on the issue: https://github.com/apache/flink/pull/4530 I see, didn't consider the private timeServiceManager. Maybe this is the best approach then. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[jira] [Commented] (FLINK-7057) move BLOB ref-counting from LibraryCacheManager to BlobCache

2017-08-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16131858#comment-16131858 ] ASF GitHub Bot commented on FLINK-7057: --- Github user asfgit closed the pull request at:

[jira] [Commented] (FLINK-7068) change BlobService sub-classes for permanent and transient BLOBs

2017-08-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16131859#comment-16131859 ] ASF GitHub Bot commented on FLINK-7068: --- Github user tillrohrmann commented on the issue:

[GitHub] flink pull request #4558: [FLINK-7056][tests][hotfix] make sure the client a...

2017-08-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/4558 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] flink pull request #4238: [FLINK-7057][blob] move BLOB ref-counting from Lib...

2017-08-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/4238 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (FLINK-7056) add API to allow job-related BLOBs to be stored

2017-08-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16131857#comment-16131857 ] ASF GitHub Bot commented on FLINK-7056: --- Github user asfgit closed the pull request at:

[GitHub] flink issue #4358: [FLINK-7068][blob] change BlobService sub-classes for per...

2017-08-18 Thread tillrohrmann
Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/4358 I've merged #4238. Could you please rebase onto the latest master? Moreover, I've noticed that `JobManagerCleanupITCase.testBlobServerCleanupCancelledJob` failed in one of the Travis runs. Not

[jira] [Updated] (FLINK-7347) "removeAll" is extremely inefficient in MessageAcknowledgingSourceBase.notifyCheckpointComplete

2017-08-18 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7347?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aljoscha Krettek updated FLINK-7347: Fix Version/s: 1.4.0 > "removeAll" is extremely inefficient in >

[jira] [Commented] (FLINK-7057) move BLOB ref-counting from LibraryCacheManager to BlobCache

2017-08-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16131846#comment-16131846 ] ASF GitHub Bot commented on FLINK-7057: --- Github user tillrohrmann commented on the issue:

[GitHub] flink issue #4238: [FLINK-7057][blob] move BLOB ref-counting from LibraryCac...

2017-08-18 Thread tillrohrmann
Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/4238 Thanks for addressing the review comments @NicoK. Travis passed. Will merge this PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[jira] [Commented] (FLINK-3089) State API Should Support Data Expiration (State TTL)

2017-08-18 Thread Sihua Zhou (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16131864#comment-16131864 ] Sihua Zhou commented on FLINK-3089: --- [~richtesn] I'm not sure if I understand the problem you said

[GitHub] flink issue #4554: [FLINK-7442] Add option for using child-first classloader...

2017-08-18 Thread aljoscha
Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/4554 Probably, yes. I also don't know what other stuff this could break, though. For example, I don't know if queryable state, which starts netty (and Akka) stuff will still work with this.

[jira] [Commented] (FLINK-7442) Add option for using a child-first classloader for loading user code

2017-08-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16131926#comment-16131926 ] ASF GitHub Bot commented on FLINK-7442: --- Github user aljoscha commented on the issue:

[GitHub] flink pull request #4562: [FLINK-7402] Fix ineffective null check in NettyMe...

2017-08-18 Thread zjureel
GitHub user zjureel opened a pull request: https://github.com/apache/flink/pull/4562 [FLINK-7402] Fix ineffective null check in NettyMessage#write() ## What is the purpose of the change Fix ineffective null check in NettyMessage#write() ## Brief change log

[jira] [Assigned] (FLINK-7347) "removeAll" is extremely inefficient in MessageAcknowledgingSourceBase.notifyCheckpointComplete

2017-08-18 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7347?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aljoscha Krettek reassigned FLINK-7347: --- Assignee: Yonatan Most > "removeAll" is extremely inefficient in >

[jira] [Commented] (FLINK-7446) Support to define an existing field as the rowtime field for TableSource

2017-08-18 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16131805#comment-16131805 ] Fabian Hueske commented on FLINK-7446: -- That's in fact a good question. In principle we could avoid

[GitHub] flink issue #4554: [FLINK-7442] Add option for using child-first classloader...

2017-08-18 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/4554 Ah, I see - that is probably related to reading resources from a jar file (like the config), methods like `getResourceAsStream()`. I can see that the "delegate to parent after child" lookup

[GitHub] flink issue #4239: [FLINK-6988] flink-connector-kafka-0.11 with exactly-once...

2017-08-18 Thread pnowojski
Github user pnowojski commented on the issue: https://github.com/apache/flink/pull/4239 Implemented fixed size pool of producers, please check last commit. If we run out of producers in the pool, exception is being thrown aborting ongoing snapshot. --- If your project is

[jira] [Commented] (FLINK-6988) Add Apache Kafka 0.11 connector

2017-08-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16131913#comment-16131913 ] ASF GitHub Bot commented on FLINK-6988: --- Github user pnowojski commented on the issue:

[GitHub] flink issue #4560: Flink 7077

2017-08-18 Thread tillrohrmann
Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/4560 Thanks for you contribution @EronWright. `MesosResourceManagerTest` seems to fail on Travis. --- If your project is set up for it, you can reply to this email and have your reply appear on

[jira] [Reopened] (FLINK-7300) End-to-end tests are instable on Travis

2017-08-18 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7300?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann reopened FLINK-7300: -- The issue appeared again: https://travis-ci.org/apache/flink/jobs/265362414 I think the reason for

[jira] [Commented] (FLINK-3089) State API Should Support Data Expiration (State TTL)

2017-08-18 Thread Sihua Zhou (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16131845#comment-16131845 ] Sihua Zhou commented on FLINK-3089: --- [~stefanrichte...@gmail.com] i think ttl is also fine for

[jira] [Resolved] (FLINK-7057) move BLOB ref-counting from LibraryCacheManager to BlobCache

2017-08-18 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7057?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann resolved FLINK-7057. -- Resolution: Fixed Fix Version/s: 1.4.0 Fixed via

[jira] [Commented] (FLINK-7056) add API to allow job-related BLOBs to be stored

2017-08-18 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16131862#comment-16131862 ] Till Rohrmann commented on FLINK-7056: -- Hotfix applied for test stability via

[jira] [Created] (FLINK-7476) Try to recover from failure in TwoPhaseCommitSinkFunction.beginTransaction

2017-08-18 Thread Piotr Nowojski (JIRA)
Piotr Nowojski created FLINK-7476: - Summary: Try to recover from failure in TwoPhaseCommitSinkFunction.beginTransaction Key: FLINK-7476 URL: https://issues.apache.org/jira/browse/FLINK-7476 Project:

[jira] [Commented] (FLINK-7442) Add option for using a child-first classloader for loading user code

2017-08-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16131889#comment-16131889 ] ASF GitHub Bot commented on FLINK-7442: --- Github user StephanEwen commented on the issue:

[jira] [Updated] (FLINK-7476) Try to recover from failure in TwoPhaseCommitSinkFunction.beginTransaction

2017-08-18 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7476?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler updated FLINK-7476: Fix Version/s: 1.4.0 > Try to recover from failure in

[jira] [Updated] (FLINK-7476) Try to recover from failure in TwoPhaseCommitSinkFunction.beginTransaction

2017-08-18 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7476?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler updated FLINK-7476: Affects Version/s: 1.4.0 > Try to recover from failure in

[GitHub] flink pull request #4561: [FLINK-7476][streaming] Continue using previous tr...

2017-08-18 Thread pnowojski
GitHub user pnowojski opened a pull request: https://github.com/apache/flink/pull/4561 [FLINK-7476][streaming] Continue using previous transaction on failures First commit comes from #4557. Previously when using TwoPhaseCommitSinkFunction, if there was some intermittent

[jira] [Commented] (FLINK-7476) Try to recover from failure in TwoPhaseCommitSinkFunction.beginTransaction

2017-08-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16131907#comment-16131907 ] ASF GitHub Bot commented on FLINK-7476: --- GitHub user pnowojski opened a pull request:

[jira] [Commented] (FLINK-7465) Add build-in BloomFilterCount on TableAPI

2017-08-18 Thread Jark Wu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16131948#comment-16131948 ] Jark Wu commented on FLINK-7465: I think the problem is how to design the state. Even if it is a bitarray

[jira] [Commented] (FLINK-7402) Ineffective null check in NettyMessage#write()

2017-08-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16131944#comment-16131944 ] ASF GitHub Bot commented on FLINK-7402: --- GitHub user zjureel opened a pull request:

[jira] [Commented] (FLINK-7347) "removeAll" is extremely inefficient in MessageAcknowledgingSourceBase.notifyCheckpointComplete

2017-08-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16131967#comment-16131967 ] ASF GitHub Bot commented on FLINK-7347: --- Github user aljoscha commented on the issue:

[jira] [Created] (FLINK-7477) Use "hadoop classpath" to augment classpath when available

2017-08-18 Thread Aljoscha Krettek (JIRA)
Aljoscha Krettek created FLINK-7477: --- Summary: Use "hadoop classpath" to augment classpath when available Key: FLINK-7477 URL: https://issues.apache.org/jira/browse/FLINK-7477 Project: Flink

[jira] [Commented] (FLINK-7423) Always reuse an instance to get elements from the inputFormat

2017-08-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16131993#comment-16131993 ] ASF GitHub Bot commented on FLINK-7423: --- Github user StephanEwen commented on the issue:

[GitHub] flink issue #4525: [FLINK-7423] Always reuse an instance to get elements fro...

2017-08-18 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/4525 The logic is currently not correct with the contract of the input formats. A return value of null is not an "end of split" indicator. Also, the description mentions that this adds a

[jira] [Commented] (FLINK-7206) Implementation of DataView to support state access for UDAGG

2017-08-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16132010#comment-16132010 ] ASF GitHub Bot commented on FLINK-7206: --- Github user kaibozhou commented on a diff in the pull

[GitHub] flink pull request #4355: [FLINK-7206] [table] Implementation of DataView to...

2017-08-18 Thread kaibozhou
Github user kaibozhou commented on a diff in the pull request: https://github.com/apache/flink/pull/4355#discussion_r133924725 --- Diff: flink-libraries/flink-table/src/test/java/org/apache/flink/table/runtime/utils/JavaUserDefinedAggFunctions.java --- @@ -135,4 +138,172 @@

[jira] [Commented] (FLINK-7068) change BlobService sub-classes for permanent and transient BLOBs

2017-08-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16132041#comment-16132041 ] ASF GitHub Bot commented on FLINK-7068: --- Github user NicoK commented on the issue:

[jira] [Commented] (FLINK-7206) Implementation of DataView to support state access for UDAGG

2017-08-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16132042#comment-16132042 ] ASF GitHub Bot commented on FLINK-7206: --- Github user kaibozhou commented on the issue:

[GitHub] flink issue #4534: [FLINK-7358][table]Add implicitly converts support for Us...

2017-08-18 Thread sunjincheng121
Github user sunjincheng121 commented on the issue: https://github.com/apache/flink/pull/4534 Hi, @fhueske Thank you for reminding me :-). I updated the description. and feel free to tell me if there is any inappropriate description. Thanks, jincheng --- If your project is

[jira] [Commented] (FLINK-7358) Add implicitly converts support for User-defined function

2017-08-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16132056#comment-16132056 ] ASF GitHub Bot commented on FLINK-7358: --- Github user sunjincheng121 commented on the issue:

[GitHub] flink issue #4525: [FLINK-7423] Always reuse an instance to get elements fro...

2017-08-18 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/4525 @StephanEwen why are `null` values permitted if not in the contract of the input formats? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[jira] [Commented] (FLINK-7423) Always reuse an instance to get elements from the inputFormat

2017-08-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16132062#comment-16132062 ] ASF GitHub Bot commented on FLINK-7423: --- Github user greghogan commented on the issue:

[jira] [Commented] (FLINK-6442) Extend TableAPI Support Sink Table Registration and ‘insert into’ Clause in SQL

2017-08-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16131996#comment-16131996 ] ASF GitHub Bot commented on FLINK-6442: --- Github user lincoln-lil commented on a diff in the pull

[GitHub] flink pull request #3829: [FLINK-6442] [table] Extend TableAPI Support Sink ...

2017-08-18 Thread lincoln-lil
Github user lincoln-lil commented on a diff in the pull request: https://github.com/apache/flink/pull/3829#discussion_r133920847 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/queryConfig.scala --- @@ -19,9 +19,21 @@ package

[GitHub] flink pull request #3829: [FLINK-6442] [table] Extend TableAPI Support Sink ...

2017-08-18 Thread lincoln-lil
Github user lincoln-lil commented on a diff in the pull request: https://github.com/apache/flink/pull/3829#discussion_r133921697 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/TableEnvironment.scala --- @@ -502,26 +513,140 @@ abstract class

[GitHub] flink pull request #4355: [FLINK-7206] [table] Implementation of DataView to...

2017-08-18 Thread kaibozhou
Github user kaibozhou commented on a diff in the pull request: https://github.com/apache/flink/pull/4355#discussion_r133925097 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/AggregationCodeGenerator.scala --- @@ -405,6 +481,17 @@ class

[jira] [Commented] (FLINK-7206) Implementation of DataView to support state access for UDAGG

2017-08-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16132017#comment-16132017 ] ASF GitHub Bot commented on FLINK-7206: --- Github user kaibozhou commented on a diff in the pull

[GitHub] flink issue #4454: [hotfix][docs] Add section in docs about writing unit/int...

2017-08-18 Thread pnowojski
Github user pnowojski commented on the issue: https://github.com/apache/flink/pull/4454 @twalthr, kindly reminder :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] flink issue #4468: [FLINK-7347] [streaming] Keep ids for current checkpoint ...

2017-08-18 Thread aljoscha
Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/4468 Thanks a lot for contributing this fix, @ymost! 👍 I merged into master, could you please close this PR? --- If your project is set up for it, you can reply to this email and have your

[jira] [Closed] (FLINK-7347) "removeAll" is extremely inefficient in MessageAcknowledgingSourceBase.notifyCheckpointComplete

2017-08-18 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7347?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aljoscha Krettek closed FLINK-7347. --- Resolution: Fixed Implemented in 76f1022884fe7b291fe81028a29896fb5b5ca5c9 on master. >

[jira] [Updated] (FLINK-7475) ListState support update

2017-08-18 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7475?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aljoscha Krettek updated FLINK-7475: Component/s: DataStream API > ListState support update > > >

[jira] [Commented] (FLINK-6442) Extend TableAPI Support Sink Table Registration and ‘insert into’ Clause in SQL

2017-08-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16131995#comment-16131995 ] ASF GitHub Bot commented on FLINK-6442: --- Github user lincoln-lil commented on a diff in the pull

[GitHub] flink issue #4554: [FLINK-7442] Add option for using child-first classloader...

2017-08-18 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/4554 I think what you mentioned is one more reason to not use this in too many places for now, but only inside the TaskManager / Tasks. Let's introduce that as a tool that users can use to resolve

[jira] [Commented] (FLINK-7442) Add option for using a child-first classloader for loading user code

2017-08-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16131997#comment-16131997 ] ASF GitHub Bot commented on FLINK-7442: --- Github user StephanEwen commented on the issue:

[jira] [Created] (FLINK-7478) Update documentation for sql insert and api change in TableAPI & SQL

2017-08-18 Thread lincoln.lee (JIRA)
lincoln.lee created FLINK-7478: -- Summary: Update documentation for sql insert and api change in TableAPI & SQL Key: FLINK-7478 URL: https://issues.apache.org/jira/browse/FLINK-7478 Project: Flink

[GitHub] flink pull request #4355: [FLINK-7206] [table] Implementation of DataView to...

2017-08-18 Thread kaibozhou
Github user kaibozhou commented on a diff in the pull request: https://github.com/apache/flink/pull/4355#discussion_r133925176 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/AggregationCodeGenerator.scala --- @@ -179,13 +214,19 @@ class

[jira] [Commented] (FLINK-7206) Implementation of DataView to support state access for UDAGG

2017-08-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16132016#comment-16132016 ] ASF GitHub Bot commented on FLINK-7206: --- Github user kaibozhou commented on a diff in the pull

[GitHub] flink issue #4358: [FLINK-7068][blob] change BlobService sub-classes for per...

2017-08-18 Thread NicoK
Github user NicoK commented on the issue: https://github.com/apache/flink/pull/4358 Rebased onto `master`, but had to drag in #4402 early to fix the end-to-end tests failing due to spurious warnings. The test failure you observed was actually a test instability introduced with #4238

[GitHub] flink issue #4355: [FLINK-7206] [table] Implementation of DataView to suppor...

2017-08-18 Thread kaibozhou
Github user kaibozhou commented on the issue: https://github.com/apache/flink/pull/4355 1. Use HeapMapView/HeapListView as default implementation 2. add initialize and cleanUp interface to GeneratedAggregations --- If your project is set up for it, you can reply to this email and

[jira] [Commented] (FLINK-7479) Support to retrieve the past event by an offset

2017-08-18 Thread Dian Fu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16133007#comment-16133007 ] Dian Fu commented on FLINK-7479: This is to support the {{PREV}} clause in {{MATCH_RECOGNIZE}}. As

[jira] [Updated] (FLINK-7479) Support to retrieve the past event by physical offset

2017-08-18 Thread Dian Fu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7479?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dian Fu updated FLINK-7479: --- Summary: Support to retrieve the past event by physical offset (was: Support to retrieve the past event by

[jira] [Commented] (FLINK-7471) Improve bounded OVER support non-retract method AGG

2017-08-18 Thread Jark Wu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16133031#comment-16133031 ] Jark Wu commented on FLINK-7471: Hi [~fhueske], I think [~sunjincheng121] mean that retraction for over

[jira] [Commented] (FLINK-7477) Use "hadoop classpath" to augment classpath when available

2017-08-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16133044#comment-16133044 ] ASF GitHub Bot commented on FLINK-7477: --- GitHub user aljoscha opened a pull request:

[GitHub] flink pull request #4566: [FLINK-7477] [FLINK-7480] Various improvements to ...

2017-08-18 Thread aljoscha
GitHub user aljoscha opened a pull request: https://github.com/apache/flink/pull/4566 [FLINK-7477] [FLINK-7480] Various improvements to Flink scripts You can merge this pull request into a Git repository by running: $ git pull https://github.com/aljoscha/flink

[jira] [Commented] (FLINK-6630) Implement FLIP-6 MesosAppMasterRunner

2017-08-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16133056#comment-16133056 ] ASF GitHub Bot commented on FLINK-6630: --- Github user tillrohrmann commented on a diff in the pull

[GitHub] flink pull request #4555: [FLINK-6630] [Mesos] Implement FLIP-6 MesosAppMast...

2017-08-18 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/4555#discussion_r133974899 --- Diff: flink-mesos/src/main/java/org/apache/flink/mesos/entrypoint/MesosJobClusterEntrypoint.java --- @@ -0,0 +1,207 @@ +/* + * Licensed to

[jira] [Commented] (FLINK-6630) Implement FLIP-6 MesosAppMasterRunner

2017-08-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16133058#comment-16133058 ] ASF GitHub Bot commented on FLINK-6630: --- Github user tillrohrmann commented on a diff in the pull

[jira] [Commented] (FLINK-6630) Implement FLIP-6 MesosAppMasterRunner

2017-08-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16133057#comment-16133057 ] ASF GitHub Bot commented on FLINK-6630: --- Github user tillrohrmann commented on a diff in the pull

[jira] [Commented] (FLINK-7402) Ineffective null check in NettyMessage#write()

2017-08-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16133081#comment-16133081 ] ASF GitHub Bot commented on FLINK-7402: --- Github user tedyu commented on a diff in the pull request:

[GitHub] flink pull request #4562: [FLINK-7402] Fix ineffective null check in NettyMe...

2017-08-18 Thread tedyu
Github user tedyu commented on a diff in the pull request: https://github.com/apache/flink/pull/4562#discussion_r133980441 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/NettyMessage.java --- @@ -220,6 +220,10 @@ void releaseBuffer() {

[GitHub] flink pull request #4560: Flink 7077

2017-08-18 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/4560#discussion_r133980216 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/ResourceManager.java --- @@ -960,12 +965,26 @@ public void

[jira] [Commented] (FLINK-7245) Enhance the operators to support holding back watermarks

2017-08-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16133027#comment-16133027 ] ASF GitHub Bot commented on FLINK-7245: --- Github user xccui commented on the issue:

[GitHub] flink issue #4530: [FLINK-7245] [stream] Support holding back watermarks wit...

2017-08-18 Thread xccui
Github user xccui commented on the issue: https://github.com/apache/flink/pull/4530 Thanks for the comment, @aljoscha. IMO, making the `timeServiceManager` protected indeed will minimise the impact on `AbstractStreamOperator`, while that may introduce duplicated codes in the

[jira] [Created] (FLINK-7480) Set HADOOP_CONF_DIR to sane default if not set

2017-08-18 Thread Aljoscha Krettek (JIRA)
Aljoscha Krettek created FLINK-7480: --- Summary: Set HADOOP_CONF_DIR to sane default if not set Key: FLINK-7480 URL: https://issues.apache.org/jira/browse/FLINK-7480 Project: Flink Issue

[jira] [Updated] (FLINK-7477) Use "hadoop classpath" to augment classpath when available

2017-08-18 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7477?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aljoscha Krettek updated FLINK-7477: Fix Version/s: 1.4.0 > Use "hadoop classpath" to augment classpath when available >

[jira] [Commented] (FLINK-7446) Support to define an existing field as the rowtime field for TableSource

2017-08-18 Thread Xingcan Cui (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16133050#comment-16133050 ] Xingcan Cui commented on FLINK-7446: Thanks for the response, [~fhueske]. From my perspective, I

[jira] [Commented] (FLINK-6630) Implement FLIP-6 MesosAppMasterRunner

2017-08-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16133055#comment-16133055 ] ASF GitHub Bot commented on FLINK-6630: --- Github user tillrohrmann commented on a diff in the pull

[GitHub] flink pull request #4555: [FLINK-6630] [Mesos] Implement FLIP-6 MesosAppMast...

2017-08-18 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/4555#discussion_r133974223 --- Diff: flink-mesos/src/main/java/org/apache/flink/mesos/entrypoint/MesosEntrypointUtils.java --- @@ -0,0 +1,175 @@ +/* + * Licensed to the

[GitHub] flink pull request #4555: [FLINK-6630] [Mesos] Implement FLIP-6 MesosAppMast...

2017-08-18 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/4555#discussion_r133975661 --- Diff: flink-mesos/src/main/java/org/apache/flink/mesos/entrypoint/MesosTaskExecutorRunner.java --- @@ -0,0 +1,140 @@ +/* + * Licensed to

[GitHub] flink pull request #4555: [FLINK-6630] [Mesos] Implement FLIP-6 MesosAppMast...

2017-08-18 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/4555#discussion_r133975100 --- Diff: flink-mesos/src/main/java/org/apache/flink/mesos/entrypoint/MesosJobClusterEntrypoint.java --- @@ -0,0 +1,207 @@ +/* + * Licensed to

[jira] [Commented] (FLINK-7300) End-to-end tests are instable on Travis

2017-08-18 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16133053#comment-16133053 ] Aljoscha Krettek commented on FLINK-7300: - The reason this time is an {{AskTimeoutException}}. The

[GitHub] flink pull request #4560: Flink 7077

2017-08-18 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/4560#discussion_r133980386 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/slotmanager/TaskManagerRegistration.java --- @@ -68,7 +68,9 @@ public

[GitHub] flink pull request #4564: [FLINK-7442] Add option for using child-first clas...

2017-08-18 Thread aljoscha
GitHub user aljoscha opened a pull request: https://github.com/apache/flink/pull/4564 [FLINK-7442] Add option for using child-first classloader for loading user code This is an alternative to #4554 that does not make the client class loader configurable. ## What is the

[jira] [Commented] (FLINK-7442) Add option for using a child-first classloader for loading user code

2017-08-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16132168#comment-16132168 ] ASF GitHub Bot commented on FLINK-7442: --- GitHub user aljoscha opened a pull request:

  1   2   >