[GitHub] flink issue #5463: [FLINK-8475][config][docs] Integrate YARN options

2018-02-13 Thread aljoscha
Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/5463 Ok, please go ahead, then. 👍 ---

[jira] [Commented] (FLINK-8475) Move remaining sections to generated tables

2018-02-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16362137#comment-16362137 ] ASF GitHub Bot commented on FLINK-8475: --- Github user aljoscha commented on the issue:

[GitHub] flink issue #5462: [FLINK-8475][config][docs] Integrate HA-ZK options

2018-02-13 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/5462 merging. ---

[GitHub] flink issue #5463: [FLINK-8475][config][docs] Integrate YARN options

2018-02-13 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/5463 merging. ---

[jira] [Commented] (FLINK-8475) Move remaining sections to generated tables

2018-02-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16362171#comment-16362171 ] ASF GitHub Bot commented on FLINK-8475: --- Github user zentol commented on the issue:

[GitHub] flink pull request #5467: [FLINK-8475][config][docs] Integrate HA options

2018-02-13 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/5467#discussion_r167838921 --- Diff: docs/_includes/generated/high_availability_configuration.html --- @@ -0,0 +1,36 @@ + + + +Key +

[GitHub] flink pull request #5431: [FLINK-8608] [flip6] Implement MiniDispatcher for ...

2018-02-13 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/5431#discussion_r167850253 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/Dispatcher.java --- @@ -671,13 +674,68 @@ public void jobFinishedByOther() {

[jira] [Commented] (FLINK-8475) Move remaining sections to generated tables

2018-02-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16362261#comment-16362261 ] ASF GitHub Bot commented on FLINK-8475: --- Github user zentol commented on a diff in the pull request:

[jira] [Commented] (FLINK-8608) Add MiniDispatcher for job mode

2018-02-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16362263#comment-16362263 ] ASF GitHub Bot commented on FLINK-8608: --- Github user tillrohrmann commented on the issue:

[GitHub] flink pull request #5471: [FLINK-8475][config][docs] Integrate TM options

2018-02-13 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/5471#discussion_r167855709 --- Diff: docs/ops/config.md --- @@ -268,59 +268,7 @@ These parameters configure the default HDFS used by Flink. Setups that do not sp ###

[GitHub] flink issue #5431: [FLINK-8608] [flip6] Implement MiniDispatcher for job mod...

2018-02-13 Thread tillrohrmann
Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/5431 Thanks for your review @GJL. I've addressed your comments with cb3fca3 and rebased onto the latest master. ---

[GitHub] flink pull request #5471: [FLINK-8475][config][docs] Integrate TM options

2018-02-13 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/5471#discussion_r167856770 --- Diff: docs/ops/config.md --- @@ -268,59 +268,7 @@ These parameters configure the default HDFS used by Flink. Setups that do not sp ###

[GitHub] flink pull request #5471: [FLINK-8475][config][docs] Integrate TM options

2018-02-13 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/5471#discussion_r167856613 --- Diff: docs/ops/config.md --- @@ -268,59 +268,7 @@ These parameters configure the default HDFS used by Flink. Setups that do not sp ###

[jira] [Commented] (FLINK-8475) Move remaining sections to generated tables

2018-02-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16362271#comment-16362271 ] ASF GitHub Bot commented on FLINK-8475: --- Github user zentol commented on a diff in the pull request:

[jira] [Commented] (FLINK-8475) Move remaining sections to generated tables

2018-02-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16362267#comment-16362267 ] ASF GitHub Bot commented on FLINK-8475: --- Github user zentol commented on a diff in the pull request:

[jira] [Commented] (FLINK-8644) Shut down AkkaRpcActors with PoisonPill

2018-02-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16362322#comment-16362322 ] ASF GitHub Bot commented on FLINK-8644: --- GitHub user tillrohrmann opened a pull request:

[jira] [Created] (FLINK-8644) Shut down AkkaRpcActors with PoisonPill

2018-02-13 Thread Till Rohrmann (JIRA)
Till Rohrmann created FLINK-8644: Summary: Shut down AkkaRpcActors with PoisonPill Key: FLINK-8644 URL: https://issues.apache.org/jira/browse/FLINK-8644 Project: Flink Issue Type: Sub-task

[GitHub] flink pull request #5476: [FLINK-8644] [flip6] Shut down AkkaRpcActors with ...

2018-02-13 Thread tillrohrmann
GitHub user tillrohrmann opened a pull request: https://github.com/apache/flink/pull/5476 [FLINK-8644] [flip6] Shut down AkkaRpcActors with PoisonPill ## What is the purpose of the change Shutting AkkaRpcActors down with Kill can result in uncompleted futures, if the

[jira] [Comment Edited] (FLINK-8520) CassandraConnectorITCase.testCassandraTableSink unstable on Travis

2018-02-13 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16362144#comment-16362144 ] Chesnay Schepler edited comment on FLINK-8520 at 2/13/18 11:09 AM: ---

[jira] [Commented] (FLINK-8475) Move remaining sections to generated tables

2018-02-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16362145#comment-16362145 ] ASF GitHub Bot commented on FLINK-8475: --- Github user aljoscha commented on a diff in the pull

[GitHub] flink pull request #5468: [FLINK-8475][config][docs] Integrate Environment o...

2018-02-13 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/5468#discussion_r167831861 --- Diff: docs/_includes/generated/environment_configuration.html --- @@ -0,0 +1,41 @@ + + + +Key +

[jira] [Commented] (FLINK-8520) CassandraConnectorITCase.testCassandraTableSink unstable on Travis

2018-02-13 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16362144#comment-16362144 ] Chesnay Schepler commented on FLINK-8520: - There's a race condition between the callback

[jira] [Commented] (FLINK-8475) Move remaining sections to generated tables

2018-02-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16362166#comment-16362166 ] ASF GitHub Bot commented on FLINK-8475: --- Github user zentol commented on the issue:

[jira] [Commented] (FLINK-8608) Add MiniDispatcher for job mode

2018-02-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16362241#comment-16362241 ] ASF GitHub Bot commented on FLINK-8608: --- Github user tillrohrmann commented on a diff in the pull

[jira] [Commented] (FLINK-8475) Move remaining sections to generated tables

2018-02-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16362253#comment-16362253 ] ASF GitHub Bot commented on FLINK-8475: --- Github user aljoscha commented on a diff in the pull

[jira] [Commented] (FLINK-8475) Move remaining sections to generated tables

2018-02-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16362256#comment-16362256 ] ASF GitHub Bot commented on FLINK-8475: --- Github user aljoscha commented on a diff in the pull

[jira] [Commented] (FLINK-8475) Move remaining sections to generated tables

2018-02-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16362252#comment-16362252 ] ASF GitHub Bot commented on FLINK-8475: --- Github user aljoscha commented on a diff in the pull

[jira] [Commented] (FLINK-8475) Move remaining sections to generated tables

2018-02-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16362254#comment-16362254 ] ASF GitHub Bot commented on FLINK-8475: --- Github user aljoscha commented on a diff in the pull

[jira] [Commented] (FLINK-8475) Move remaining sections to generated tables

2018-02-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16362250#comment-16362250 ] ASF GitHub Bot commented on FLINK-8475: --- Github user aljoscha commented on a diff in the pull

[jira] [Commented] (FLINK-8475) Move remaining sections to generated tables

2018-02-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16362260#comment-16362260 ] ASF GitHub Bot commented on FLINK-8475: --- Github user aljoscha commented on a diff in the pull

[jira] [Commented] (FLINK-8475) Move remaining sections to generated tables

2018-02-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16362251#comment-16362251 ] ASF GitHub Bot commented on FLINK-8475: --- Github user aljoscha commented on a diff in the pull

[jira] [Commented] (FLINK-8475) Move remaining sections to generated tables

2018-02-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16362258#comment-16362258 ] ASF GitHub Bot commented on FLINK-8475: --- Github user aljoscha commented on a diff in the pull

[jira] [Commented] (FLINK-8475) Move remaining sections to generated tables

2018-02-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16362257#comment-16362257 ] ASF GitHub Bot commented on FLINK-8475: --- Github user aljoscha commented on a diff in the pull

[jira] [Commented] (FLINK-8475) Move remaining sections to generated tables

2018-02-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16362249#comment-16362249 ] ASF GitHub Bot commented on FLINK-8475: --- Github user aljoscha commented on a diff in the pull

[GitHub] flink pull request #5471: [FLINK-8475][config][docs] Integrate TM options

2018-02-13 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/5471#discussion_r167836313 --- Diff: docs/ops/config.md --- @@ -268,59 +268,7 @@ These parameters configure the default HDFS used by Flink. Setups that do not sp ###

[GitHub] flink pull request #5471: [FLINK-8475][config][docs] Integrate TM options

2018-02-13 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/5471#discussion_r167853972 --- Diff: docs/ops/config.md --- @@ -268,59 +268,7 @@ These parameters configure the default HDFS used by Flink. Setups that do not sp ###

[jira] [Commented] (FLINK-8547) Implement CheckpointBarrierHandler not to spill data for exactly-once based on credit-based flow control

2018-02-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16362335#comment-16362335 ] ASF GitHub Bot commented on FLINK-8547: --- Github user zhijiangW commented on the issue:

[GitHub] flink issue #5400: [FLINK-8547][network] Implement CheckpointBarrierHandler ...

2018-02-13 Thread zhijiangW
Github user zhijiangW commented on the issue: https://github.com/apache/flink/pull/5400 Thanks for rebasing the conflicts. Yes, the default value can be changed to true after the credit-based is totally merged. If need any changes on my side after all, pls let me know. :)

[jira] [Created] (FLINK-8646) Move docs directory to flink-docs

2018-02-13 Thread Chesnay Schepler (JIRA)
Chesnay Schepler created FLINK-8646: --- Summary: Move docs directory to flink-docs Key: FLINK-8646 URL: https://issues.apache.org/jira/browse/FLINK-8646 Project: Flink Issue Type:

[jira] [Commented] (FLINK-8475) Move remaining sections to generated tables

2018-02-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16362158#comment-16362158 ] ASF GitHub Bot commented on FLINK-8475: --- Github user zentol commented on a diff in the pull request:

[GitHub] flink pull request #5468: [FLINK-8475][config][docs] Integrate Environment o...

2018-02-13 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/5468#discussion_r167833518 --- Diff: docs/_includes/generated/environment_configuration.html --- @@ -0,0 +1,41 @@ + + + +Key +

[GitHub] flink pull request #5462: [FLINK-8475][config][docs] Integrate HA-ZK options

2018-02-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/5462 ---

[GitHub] flink pull request #5463: [FLINK-8475][config][docs] Integrate YARN options

2018-02-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/5463 ---

[jira] [Commented] (FLINK-8475) Move remaining sections to generated tables

2018-02-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16362185#comment-16362185 ] ASF GitHub Bot commented on FLINK-8475: --- Github user zentol commented on a diff in the pull request:

[jira] [Commented] (FLINK-8475) Move remaining sections to generated tables

2018-02-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16362187#comment-16362187 ] ASF GitHub Bot commented on FLINK-8475: --- Github user asfgit closed the pull request at:

[jira] [Commented] (FLINK-8475) Move remaining sections to generated tables

2018-02-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16362186#comment-16362186 ] ASF GitHub Bot commented on FLINK-8475: --- Github user asfgit closed the pull request at:

[GitHub] flink pull request #5415: [FLINK-3655] [core] Support multiple paths in File...

2018-02-13 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/5415#discussion_r167850694 --- Diff: flink-core/src/test/java/org/apache/flink/api/common/io/DelimitedInputFormatTest.java --- @@ -428,6 +431,78 @@ public void

[GitHub] flink pull request #5471: [FLINK-8475][config][docs] Integrate TM options

2018-02-13 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/5471#discussion_r167861535 --- Diff: docs/ops/config.md --- @@ -268,59 +268,7 @@ These parameters configure the default HDFS used by Flink. Setups that do not sp ###

[jira] [Commented] (FLINK-8642) Initialize descriptors before use at getBroadcastState().

2018-02-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16362326#comment-16362326 ] ASF GitHub Bot commented on FLINK-8642: --- GitHub user kl0u opened a pull request:

[GitHub] flink pull request #5477: [FLINK-8642] Initialize descriptors before use at ...

2018-02-13 Thread kl0u
GitHub user kl0u opened a pull request: https://github.com/apache/flink/pull/5477 [FLINK-8642] Initialize descriptors before use at getBroadcastState(). ## What is the purpose of the change As the name implies, this PR fixes a bug that could lead to `NPEs` when trying to

[GitHub] flink pull request #5443: [FLINK-8626] Introduce BackPressureStatsTracker in...

2018-02-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/5443 ---

[jira] [Closed] (FLINK-8626) Introduce BackPressureStatsTracker interface

2018-02-13 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8626?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann closed FLINK-8626. Resolution: Fixed Fixed via f719befaa1c00997ef34809e121f6192f44f7164 > Introduce

[jira] [Commented] (FLINK-8626) Introduce BackPressureStatsTracker interface

2018-02-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16361941#comment-16361941 ] ASF GitHub Bot commented on FLINK-8626: --- Github user asfgit closed the pull request at:

[jira] [Closed] (FLINK-8020) Deadlock found in Async I/O operator

2018-02-13 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8020?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler closed FLINK-8020. --- Resolution: Not A Problem Fix Version/s: (was: 1.4.2) (was:

[jira] [Commented] (FLINK-8475) Move remaining sections to generated tables

2018-02-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16362172#comment-16362172 ] ASF GitHub Bot commented on FLINK-8475: --- Github user zentol commented on the issue:

[GitHub] flink pull request #5470: [FLINK-8475][config][docs] Integrate RM options

2018-02-13 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/5470#discussion_r167839893 --- Diff: docs/_includes/generated/resource_manager_configuration.html --- @@ -0,0 +1,36 @@ + + + +Key +

[jira] [Commented] (FLINK-8608) Add MiniDispatcher for job mode

2018-02-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16362225#comment-16362225 ] ASF GitHub Bot commented on FLINK-8608: --- Github user tillrohrmann commented on a diff in the pull

[GitHub] flink pull request #5431: [FLINK-8608] [flip6] Implement MiniDispatcher for ...

2018-02-13 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/5431#discussion_r167850583 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/dispatcher/MiniDispatcherTest.java --- @@ -0,0 +1,208 @@ +/* + * Licensed to

[jira] [Commented] (FLINK-8608) Add MiniDispatcher for job mode

2018-02-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16362238#comment-16362238 ] ASF GitHub Bot commented on FLINK-8608: --- Github user tillrohrmann commented on a diff in the pull

[GitHub] flink pull request #5431: [FLINK-8608] [flip6] Implement MiniDispatcher for ...

2018-02-13 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/5431#discussion_r167853004 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/entrypoint/ClusterEntrypoint.java --- @@ -300,4 +587,12 @@ protected static

[GitHub] flink pull request #5431: [FLINK-8608] [flip6] Implement MiniDispatcher for ...

2018-02-13 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/5431#discussion_r167852786 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/entrypoint/ClusterEntrypoint.java --- @@ -63,6 +89,10 @@ */ public abstract

[GitHub] flink pull request #5471: [FLINK-8475][config][docs] Integrate TM options

2018-02-13 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/5471#discussion_r167856324 --- Diff: docs/ops/config.md --- @@ -268,59 +268,7 @@ These parameters configure the default HDFS used by Flink. Setups that do not sp ###

[jira] [Commented] (FLINK-8475) Move remaining sections to generated tables

2018-02-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16362265#comment-16362265 ] ASF GitHub Bot commented on FLINK-8475: --- Github user zentol commented on a diff in the pull request:

[GitHub] flink pull request #5471: [FLINK-8475][config][docs] Integrate TM options

2018-02-13 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/5471#discussion_r167856138 --- Diff: docs/ops/config.md --- @@ -268,59 +268,7 @@ These parameters configure the default HDFS used by Flink. Setups that do not sp ###

[GitHub] flink pull request #5415: [FLINK-3655] [core] Support multiple paths in File...

2018-02-13 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/5415#discussion_r167849176 --- Diff: flink-core/src/test/java/org/apache/flink/api/common/io/BinaryInputFormatTest.java --- @@ -40,8 +41,12 @@ protected Record

[GitHub] flink pull request #5415: [FLINK-3655] [core] Support multiple paths in File...

2018-02-13 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/5415#discussion_r167853159 --- Diff: flink-core/src/test/java/org/apache/flink/api/common/io/FileInputFormatTest.java --- @@ -203,7 +390,104 @@ public void

[GitHub] flink pull request #5415: [FLINK-3655] [core] Support multiple paths in File...

2018-02-13 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/5415#discussion_r167850774 --- Diff: flink-core/src/test/java/org/apache/flink/api/common/io/DelimitedInputFormatTest.java --- @@ -428,6 +431,78 @@ public void

[jira] [Commented] (FLINK-3655) Allow comma-separated or multiple directories to be specified for FileInputFormat

2018-02-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16362277#comment-16362277 ] ASF GitHub Bot commented on FLINK-3655: --- Github user zentol commented on a diff in the pull request:

[jira] [Commented] (FLINK-3655) Allow comma-separated or multiple directories to be specified for FileInputFormat

2018-02-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16362279#comment-16362279 ] ASF GitHub Bot commented on FLINK-3655: --- Github user zentol commented on a diff in the pull request:

[GitHub] flink pull request #5415: [FLINK-3655] [core] Support multiple paths in File...

2018-02-13 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/5415#discussion_r167848724 --- Diff: flink-core/src/main/java/org/apache/flink/api/common/io/FileInputFormat.java --- @@ -404,9 +486,39 @@ public FileBaseStatistics

[jira] [Commented] (FLINK-8475) Move remaining sections to generated tables

2018-02-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16362332#comment-16362332 ] ASF GitHub Bot commented on FLINK-8475: --- Github user zentol commented on the issue:

[jira] [Updated] (FLINK-8645) Support convenient extension of parent-first ClassLoader patterns

2018-02-13 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8645?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler updated FLINK-8645: Fix Version/s: (was: 1.5.0) > Support convenient extension of parent-first ClassLoader

[jira] [Commented] (FLINK-8475) Move remaining sections to generated tables

2018-02-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16362141#comment-16362141 ] ASF GitHub Bot commented on FLINK-8475: --- Github user aljoscha commented on a diff in the pull

[GitHub] flink pull request #5459: [FLINK-8475][config][docs] Integrate FS options

2018-02-13 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/5459#discussion_r167831341 --- Diff: flink-core/src/main/java/org/apache/flink/configuration/CoreOptions.java --- @@ -127,7 +130,30 @@ */ public static final

[jira] [Commented] (FLINK-8475) Move remaining sections to generated tables

2018-02-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16362142#comment-16362142 ] ASF GitHub Bot commented on FLINK-8475: --- Github user zentol commented on a diff in the pull request:

[jira] [Commented] (FLINK-8475) Move remaining sections to generated tables

2018-02-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16362152#comment-16362152 ] ASF GitHub Bot commented on FLINK-8475: --- Github user aljoscha commented on the issue:

[GitHub] flink pull request #5470: [FLINK-8475][config][docs] Integrate RM options

2018-02-13 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/5470#discussion_r167833506 --- Diff: docs/_includes/generated/resource_manager_configuration.html --- @@ -0,0 +1,36 @@ + + + +Key +

[jira] [Commented] (FLINK-8475) Move remaining sections to generated tables

2018-02-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16362157#comment-16362157 ] ASF GitHub Bot commented on FLINK-8475: --- Github user aljoscha commented on a diff in the pull

[GitHub] flink pull request #5474: [FLINK-8529][cassandra] Fix race condition

2018-02-13 Thread zentol
GitHub user zentol opened a pull request: https://github.com/apache/flink/pull/5474 [FLINK-8529][cassandra] Fix race condition ## What is the purpose of the change This PR fixes a deadlock that could happen if a callback is executed during

[GitHub] flink pull request #5431: [FLINK-8608] [flip6] Implement MiniDispatcher for ...

2018-02-13 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/5431#discussion_r167853480 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/entrypoint/ClusterEntrypoint.java --- @@ -262,32 +430,151 @@ protected void

[GitHub] flink pull request #5471: [FLINK-8475][config][docs] Integrate TM options

2018-02-13 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/5471#discussion_r167856481 --- Diff: docs/ops/config.md --- @@ -268,59 +268,7 @@ These parameters configure the default HDFS used by Flink. Setups that do not sp ###

[jira] [Commented] (FLINK-8475) Move remaining sections to generated tables

2018-02-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16362266#comment-16362266 ] ASF GitHub Bot commented on FLINK-8475: --- Github user zentol commented on a diff in the pull request:

[jira] [Commented] (FLINK-8475) Move remaining sections to generated tables

2018-02-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16362304#comment-16362304 ] ASF GitHub Bot commented on FLINK-8475: --- Github user zentol commented on a diff in the pull request:

[GitHub] flink pull request #5471: [FLINK-8475][config][docs] Integrate TM options

2018-02-13 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/5471#discussion_r167863017 --- Diff: docs/ops/config.md --- @@ -268,59 +268,7 @@ These parameters configure the default HDFS used by Flink. Setups that do not sp ###

[GitHub] flink pull request #5467: [FLINK-8475][config][docs] Integrate HA options

2018-02-13 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/5467#discussion_r167831138 --- Diff: docs/_includes/generated/high_availability_configuration.html --- @@ -0,0 +1,36 @@ + + + +Key +

[GitHub] flink issue #5469: [FLINK-8475][config][docs] Integrate Core options

2018-02-13 Thread aljoscha
Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/5469 Couldn't these be called "Classloader options" and have their own group? That way you don't have to manually mess with the generated table. ---

[GitHub] flink issue #5469: [FLINK-8475][config][docs] Integrate Core options

2018-02-13 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/5469 I only did that for the sake of this PR to avoid merge conflicts; this won't be necessary in the future. ---

[jira] [Commented] (FLINK-8475) Move remaining sections to generated tables

2018-02-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16362178#comment-16362178 ] ASF GitHub Bot commented on FLINK-8475: --- Github user zentol commented on a diff in the pull request:

[jira] [Created] (FLINK-8643) Use JobManagerOptions#SLOT_REQUEST_TIMEOUT in ExecutionGraph

2018-02-13 Thread Till Rohrmann (JIRA)
Till Rohrmann created FLINK-8643: Summary: Use JobManagerOptions#SLOT_REQUEST_TIMEOUT in ExecutionGraph Key: FLINK-8643 URL: https://issues.apache.org/jira/browse/FLINK-8643 Project: Flink

[jira] [Commented] (FLINK-8608) Add MiniDispatcher for job mode

2018-02-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16362228#comment-16362228 ] ASF GitHub Bot commented on FLINK-8608: --- Github user tillrohrmann commented on a diff in the pull

[jira] [Commented] (FLINK-8475) Move remaining sections to generated tables

2018-02-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16362272#comment-16362272 ] ASF GitHub Bot commented on FLINK-8475: --- Github user zentol commented on the issue:

[jira] [Commented] (FLINK-8475) Move remaining sections to generated tables

2018-02-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16362270#comment-16362270 ] ASF GitHub Bot commented on FLINK-8475: --- Github user zentol commented on a diff in the pull request:

[GitHub] flink issue #5471: [FLINK-8475][config][docs] Integrate TM options

2018-02-13 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/5471 man these long descriptions are gonna wreck the table... ---

[jira] [Commented] (FLINK-8475) Move remaining sections to generated tables

2018-02-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16362303#comment-16362303 ] ASF GitHub Bot commented on FLINK-8475: --- Github user zentol commented on a diff in the pull request:

[jira] [Commented] (FLINK-8475) Move remaining sections to generated tables

2018-02-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16362314#comment-16362314 ] ASF GitHub Bot commented on FLINK-8475: --- Github user zentol commented on a diff in the pull request:

[jira] [Commented] (FLINK-8529) Let Yarn entry points use YarnConfigOptions#APPLICATION_MASTER_PORT

2018-02-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16362169#comment-16362169 ] ASF GitHub Bot commented on FLINK-8529: --- GitHub user zentol opened a pull request:

[jira] [Created] (FLINK-8642) Initialize descriptors before use at getBroadcastState().

2018-02-13 Thread Kostas Kloudas (JIRA)
Kostas Kloudas created FLINK-8642: - Summary: Initialize descriptors before use at getBroadcastState(). Key: FLINK-8642 URL: https://issues.apache.org/jira/browse/FLINK-8642 Project: Flink

[jira] [Commented] (FLINK-8643) Use JobManagerOptions#SLOT_REQUEST_TIMEOUT in ExecutionGraph

2018-02-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16362219#comment-16362219 ] ASF GitHub Bot commented on FLINK-8643: --- GitHub user tillrohrmann opened a pull request:

[GitHub] flink pull request #5475: [FLINK-8643] [flip6] Use JobManagerOptions#SLOT_RE...

2018-02-13 Thread tillrohrmann
GitHub user tillrohrmann opened a pull request: https://github.com/apache/flink/pull/5475 [FLINK-8643] [flip6] Use JobManagerOptions#SLOT_REQUEST_TIMEOUT in ExecutionGraph ## What is the purpose of the change This commit changes the initialization of the ExecutionGraph to

[GitHub] flink pull request #5431: [FLINK-8608] [flip6] Implement MiniDispatcher for ...

2018-02-13 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/5431#discussion_r167851271 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/dispatcher/MiniDispatcherTest.java --- @@ -0,0 +1,208 @@ +/* + * Licensed to

  1   2   3   4   >